Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(113 errors, 10 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/naas/backup/moodle2/backup_naas_activity_task.class.php
(#33) Opening brace must not be followed by a blank line
mod/naas/backup/moodle2/backup_naas_stepslib.php
(#24) Opening brace must not be followed by a blank line
mod/naas/backup/moodle2/restore_naas_activity_task.class.php
(#33) Opening brace must not be followed by a blank line
mod/naas/backup/moodle2/restore_naas_stepslib.php
(#23) Opening brace must not be followed by a blank line
mod/naas/classes/completion/custom_completion.php
(#35) Opening brace must not be followed by a blank line
mod/naas/classes/event/course_module_viewed.php
(#30) Opening brace must not be followed by a blank line
mod/naas/classes/external/proxy_naas_api.php
(#40) Expected 1 space before "external_api"; 2 found
(#40) Opening brace must not be followed by a blank line
(#370) Only one argument is allowed per line in a multi-line function call
(#405) Function closing brace must go on the next line following the body; found 1 blank lines before brace
mod/naas/classes/external/xapi.php
(#39) Opening brace must not be followed by a blank line
(#89) Expected at least 1 space before "."; 0 found
(#89) Expected at least 1 space after "."; 0 found
(#89) Expected at least 1 space before "."; 0 found
(#89) Expected at least 1 space after "."; 0 found
mod/naas/classes/mod_util.php
(#35) Opening brace must not be followed by a blank line
(#84) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#102) Expected at least 1 space before "."; 0 found
(#102) Expected at least 1 space after "."; 0 found
(#102) Expected at least 1 space before "."; 0 found
(#102) Expected at least 1 space after "."; 0 found
(#127) The closing brace for the class must go on the next line after the body
mod/naas/classes/naas_client.php
(#30) Opening brace must not be followed by a blank line
(#62) Expected at least 1 space before "."; 0 found
(#62) Expected at least 1 space after "."; 0 found
(#66) Expected at least 1 space before "."; 0 found
(#66) Expected at least 1 space after "."; 0 found
(#210) Expected at least 1 space before "."; 0 found
(#210) Expected at least 1 space after "."; 0 found
(#246) Incorrect spacing between argument "$structureid" and equals sign; expected 1 but found 0
(#246) Incorrect spacing between default value and equals sign for argument "$structureid"; expected 1 but found 0
(#252) Expected at least 1 space before "."; 0 found
(#252) Expected at least 1 space after "."; 0 found
(#252) Expected at least 1 space before "."; 0 found
(#252) Expected at least 1 space after "."; 0 found
(#264) Expected at least 1 space before "."; 0 found
(#264) Expected at least 1 space after "."; 0 found
(#264) Expected at least 1 space before "."; 0 found
(#264) Expected at least 1 space after "."; 0 found
mod/naas/classes/naas_lti.php
(#31) Opening brace must not be followed by a blank line
(#40) Incorrect spacing between argument "$language" and equals sign; expected 1 but found 0
(#40) Incorrect spacing between default value and equals sign for argument "$language"; expected 1 but found 0
(#55) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#58) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#124) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#125) Multi-line function call not indented correctly; expected 20 spaces but found 24
(#126) Multi-line function call not indented correctly; expected 20 spaces but found 24
(#126) Expected at least 1 space before "."; 0 found
(#126) Expected at least 1 space after "."; 0 found
(#126) Expected at least 1 space before "."; 0 found
(#126) Expected at least 1 space after "."; 0 found
(#127) Multi-line function call not indented correctly; expected 20 spaces but found 24
(#128) Multi-line function call not indented correctly; expected 20 spaces but found 24
(#153) Expected at least 1 space before "."; 0 found
(#159) Expected at least 1 space before "."; 0 found
(#159) Expected at least 1 space before "."; 0 found
(#159) Expected at least 1 space after "."; 0 found
mod/naas/classes/privacy/provider.php
(#35) The interface names in a "class implements" statement should be ordered alphabetically. Expected: \core_privacy\local\metadata\provider, \core_privacy\local\request\core_userlist_provider, \core_privacy\local\request\plugin\provider; Found: \core_privacy\local\request\core_userlist_provider, \core_privacy\local\metadata\provider, \core_privacy\local\request\plugin\provider
(#35) The first item in a multi-line implements list must be on the line following the implements keyword
(#37) Opening brace must not be followed by a blank line
(#148) Expected 1 space between the comma and "'activity_id'". Found: 3 spaces
(#254) Blank line found at start of control structure
(#276) Long list syntax is not allowed
mod/naas/index.php
(#101) Expected at least 1 space before "."; 0 found
(#101) Expected at least 1 space after "."; 0 found
mod/naas/lang/en/naas.php
(#53) The string key "error:naas_api:bad_request" is not in the correct order, it should be before "error:unsupported_grade_method"
(#59) The string key "connection_test_success" is not in the correct order, it should be before "error:proxy_naas_api:curl"
(#60) The string key "connection_test_failed" is not in the correct order, it should be before "connection_test_success"
(#91) The string key "moduleintro" is not in the correct order, it should be before "naas:view"
(#97) The string key "naas_server_unauthorized" is not in the correct order, it should be before "naas_server_unexpected"
(#101) The string key "naas_server_unauthorized" is duplicated
(#102) The string key "naas_server_unauthorized_help" is not in the correct order, it should be before "naas_server_unavailable_title"
(#104) Unexpected string end, it should be a line feed after a semicolon
(#104) Each PHP statement must be on a line by itself
(#134) The string key "no_nugget" is not in the correct order, it should be before "nonewmodules"
(#177) The string key "privacy:metadata:naas_xapi" is not in the correct order, it should be before "privacy:metadata:naastable:timemodified"
(#179) The string key "privacy:metadata:naas_xapi:email" is not in the correct order, it should be before "privacy:metadata:naas_xapi:name"
(#183) The string key "privacy:metadata:naas_xapi:body" is not in the correct order, it should be before "privacy:metadata:naas_xapi:version_id"
mod/naas/launch.php
(#38) Expected 1 blank line at end of file; 2 found
mod/naas/lib.php
(#41) Expected 1 space after comma in argument list; 2 found
(#41) Expected 1 space between the comma and "'4'". Found: 2 spaces
(#84) Expected 1 space after SWITCH keyword; 0 found
(#391) Opening parenthesis of a multi-line function call must be the last content on the line
(#393) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Only one argument is allowed per line in a multi-line function call
(#393) Closing parenthesis of a multi-line function call must be on a line by itself
(#406) Expected at least 1 space before "."; 0 found
(#406) Expected at least 1 space after "."; 0 found
(#438) Incorrect spacing between argument "$userid" and equals sign; expected 1 but found 0
(#438) Incorrect spacing between default value and equals sign for argument "$userid"; expected 1 but found 0
(#438) Incorrect spacing between argument "$nullifnone" and equals sign; expected 1 but found 0
(#438) Incorrect spacing between default value and equals sign for argument "$nullifnone"; expected 1 but found 0
(#444) Blank line found at end of control structure
mod/naas/mod_form.php
(#28) Expected at least 1 space before "."; 0 found
(#28) Expected at least 1 space after "."; 0 found
(#34) Opening brace must not be followed by a blank line
mod/naas/outcome.php
(#85) Blank line found at start of control structure
mod/naas/settings.php
(#37) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#37) Closing parenthesis of a multi-line function call must be on a line by itself
(#74) Multi-line function call not indented correctly; expected 8 spaces but found 9
(#75) Multi-line function call not indented correctly; expected 4 spaces but found 5
mod/naas/view.php
(#35) Blank line found at end of control structure
(#56) Expected at least 1 space before "."; 0 found
(#56) Expected at least 1 space after "."; 0 found
(#56) Expected at least 1 space before "."; 0 found
(#56) Expected at least 1 space after "."; 0 found
(#66) Expected at least 1 space before "."; 0 found
(#66) Expected at least 1 space after "."; 0 found
(#66) Expected at least 1 space before "."; 0 found
(#66) Expected at least 1 space after "."; 0 found
(#66) Expected at least 1 space before "."; 0 found
(#66) Expected at least 1 space after "."; 0 found
(#66) Expected at least 1 space before "."; 0 found
(#66) Expected at least 1 space after "."; 0 found
(#73) Expected at least 1 space before "."; 0 found
(#73) Expected at least 1 space after "."; 0 found
(#73) Expected at least 1 space before "."; 0 found
(#73) Expected at least 1 space after "."; 0 found
(#73) Expected at least 1 space before "."; 0 found
(#73) Expected at least 1 space after "."; 0 found
(#73) Expected at least 1 space before "."; 0 found
(#73) Expected at least 1 space after "."; 0 found

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]