Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(150 errors, 156 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/msteams/backup/moodle2/backup_msteams_activity_task.class.php
(#2) Moodle boilerplate not found at first line
(#56) The static declaration must come after the visibility declaration
(#59) Commas (,) must be followed by white space.
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#61) No space found before comment text; expected "// Access a list of all links in a course" but found "//Access a list of all links in a course"
(#66) Inline comments must end in full-stops, exclamation marks, or question marks
(#66) No space found before comment text; expected "// Access the link supplying a course module id" but found "//Access the link supplying a course module id"
(#71) Inline comments must end in full-stops, exclamation marks, or question marks
(#71) No space found before comment text; expected "// Access the link supplying an instance id" but found "//Access the link supplying an instance id"
mod/msteams/backup/moodle2/backup_msteams_stepslib.php
(#2) Moodle boilerplate not found at first line
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Expected 2 spaces before asterisk; 1 found
(#31) Expected 2 spaces before asterisk; 1 found
(#34) Missing docblock for function define_structure
(#36) Inline comments must start with a capital letter, digit or 3-dots sequence
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) No space found before comment text; expected "// the URL module stores no user info" but found "//the URL module stores no user info"
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#39) Short array syntax must be used to define arrays
(#39) Short array syntax must be used to define arrays
(#42) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) No space found before comment text; expected "// nothing here for URLs" but found "//nothing here for URLs"
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) Short array syntax must be used to define arrays
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) No space found before comment text; expected "// module has no id annotations" but found "//module has no id annotations"
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#56) Inline comments must end in full-stops, exclamation marks, or question marks
mod/msteams/backup/moodle2/restore_msteams_activity_task.class.php
(#1) No one-line description found in phpdocs for docblock of file restore_msteams_activity_task.class.php
(#2) Moodle boilerplate not found at first line
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#47) Inline comments must start with a capital letter, digit or 3-dots sequence
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) The static declaration must come after the visibility declaration
(#56) Short array syntax must be used to define arrays
(#58) Short array syntax must be used to define arrays
(#67) The static declaration must come after the visibility declaration
(#68) Short array syntax must be used to define arrays
(#84) The static declaration must come after the visibility declaration
(#85) Short array syntax must be used to define arrays
(#104) The static declaration must come after the visibility declaration
(#105) Short array syntax must be used to define arrays
mod/msteams/backup/moodle2/restore_msteams_stepslib.php
(#1) No one-line description found in phpdocs for docblock of file restore_msteams_stepslib.php
(#2) Moodle boilerplate not found at first line
(#35) Missing docblock for function define_structure
(#37) Short array syntax must be used to define arrays
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#44) Missing docblock for function process_msteams
(#54) Inline comments must start with a capital letter, digit or 3-dots sequence
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#56) Inline comments must start with a capital letter, digit or 3-dots sequence
(#56) Inline comments must end in full-stops, exclamation marks, or question marks
(#60) Missing docblock for function after_execute
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
mod/msteams/classes/event/course_module_instance_list_viewed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/msteams/classes/event/course_module_viewed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#52) Missing docblock for function get_objectid_mapping
(#53) Short array syntax must be used to define arrays
mod/msteams/classes/external.php
(#51) Short array syntax must be used to define arrays
(#52) There should be a comma after the last array item in a multi-line array.
(#70) Short array syntax must be used to define arrays
(#71) There should be a comma after the last array item in a multi-line array.
(#73) Short array syntax must be used to define arrays
(#76) Short array syntax must be used to define arrays
(#87) Short array syntax must be used to define arrays
(#101) Short array syntax must be used to define arrays
(#103) There should be a comma after the last array item in a multi-line array.
(#116) Short array syntax must be used to define arrays
(#118) Short array syntax must be used to define arrays
(#132) Short array syntax must be used to define arrays
(#134) Short array syntax must be used to define arrays
(#135) Short array syntax must be used to define arrays
(#137) Short array syntax must be used to define arrays
(#142) Short array syntax must be used to define arrays
(#161) Short array syntax must be used to define arrays
(#163) Line exceeds 132 characters; contains 135 characters
(#170) Short array syntax must be used to define arrays
(#172) There should be a comma after the last array item in a multi-line array.
(#185) Short array syntax must be used to define arrays
(#188) Short array syntax must be used to define arrays
mod/msteams/classes/output/mobile.php
(#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#23) Missing @copyright tag
(#23) Missing @license tag
(#23) Missing docblock for class mobile
(#25) Missing docblock for function mobile_course_view
(#33) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#35) Short array syntax must be used to define arrays
(#37) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#42) Short array syntax must be used to define arrays
(#42) Expected 1 space before "=>"; 0 found
(#42) Expected 1 space after "=>"; 0 found
(#46) Logical operator "or" is prohibited; use "||" instead
(#49) Expected "} else {\n"; found "}\n else{\n"
(#50) Expected 1 space after "="; 0 found
(#53) Short array syntax must be used to define arrays
(#54) Short array syntax must be used to define arrays
(#55) Short array syntax must be used to define arrays
(#62) File must end with a newline character
mod/msteams/classes/privacy/provider.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#28) Missing docblock for class provider
(#29) Missing docblock for function get_metadata
(#29) There must not be a space before the colon in a return type declaration
(#29) Line exceeds 132 characters; contains 136 characters
mod/msteams/cookie.php
(#2) Moodle boilerplate not found at first line
(#33) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/msteams/db/access.php
(#28) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#32) Short array syntax must be used to define arrays
(#35) There should be a comma after the last array item in a multi-line array.
(#38) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
(#45) There should be a comma after the last array item in a multi-line array.
(#47) There should be a comma after the last array item in a multi-line array.
mod/msteams/db/log.php
(#2) Moodle boilerplate not found at first line
(#30) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#32) Short array syntax must be used to define arrays
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#33) Short array syntax must be used to define arrays
(#33) Expected 1 space before "=>"; 0 found
(#33) Expected 1 space after "=>"; 0 found
(#33) Expected 1 space before "=>"; 0 found
(#33) Expected 1 space after "=>"; 0 found
(#33) Expected 1 space before "=>"; 0 found
(#33) Expected 1 space after "=>"; 0 found
(#33) Expected 1 space before "=>"; 0 found
(#33) Expected 1 space after "=>"; 0 found
(#34) Short array syntax must be used to define arrays
(#34) Expected 1 space before "=>"; 0 found
(#34) Expected 1 space after "=>"; 0 found
(#34) Expected 1 space before "=>"; 0 found
(#34) Expected 1 space after "=>"; 0 found
(#34) Expected 1 space before "=>"; 0 found
(#34) Expected 1 space after "=>"; 0 found
(#34) Expected 1 space before "=>"; 0 found
(#34) Expected 1 space after "=>"; 0 found
mod/msteams/db/mobile.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file mobile.php
(#19) Short array syntax must be used to define arrays
(#20) Short array syntax must be used to define arrays
(#21) Short array syntax must be used to define arrays
(#22) Short array syntax must be used to define arrays
(#24) Inline comments must end in full-stops, exclamation marks, or question marks
(#25) Short array syntax must be used to define arrays
(#30) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#32) Short array syntax must be used to define arrays
(#34) There should be a comma after the last array item in a multi-line array.
(#35) There should be a comma after the last array item in a multi-line array.
(#36) File must end with a newline character
mod/msteams/db/services.php
(#29) Short array syntax must be used to define arrays
(#30) Short array syntax must be used to define arrays
(#36) Short array syntax must be used to define arrays
(#36) There should be a comma after the last array item in a multi-line array.
(#38) Short array syntax must be used to define arrays
(#41) Line exceeds 132 characters; contains 133 characters
(#45) Short array syntax must be used to define arrays
mod/msteams/db/upgrade.php
(#1) No one-line description found in phpdocs for docblock of file upgrade.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) Missing docblock for function xmldb_msteams_upgrade
mod/msteams/index.php
(#2) Moodle boilerplate not found at first line
(#29) Inline comments must start with a capital letter, digit or 3-dots sequence
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Short array syntax must be used to define arrays
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#36) Short array syntax must be used to define arrays
(#37) There should be a comma after the last array item in a multi-line array.
(#49) Short array syntax must be used to define arrays
(#68) Short array syntax must be used to define arrays
(#69) Short array syntax must be used to define arrays
(#71) Short array syntax must be used to define arrays
(#72) Short array syntax must be used to define arrays
(#97) Inline comments must start with a capital letter, digit or 3-dots sequence
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#101) Inline comments must start with a capital letter, digit or 3-dots sequence
(#101) Inline comments must end in full-stops, exclamation marks, or question marks
(#102) Short array syntax must be used to define arrays
mod/msteams/lang/de/msteams.php
(#2) Moodle boilerplate not found at first line
(#30) The string key "clicktoopen" is not in the correct order, it should be before "urlsuccessfullycreated"
(#36) The string key "indicator:cognitivedepth" is not in the correct order, it should be before "invalidstoredurl"
(#63) The string key "msteams:addinstance" is not in the correct order, it should be before "serverurl"
mod/msteams/lang/en/msteams.php
(#2) Moodle boilerplate not found at first line
(#30) The string key "clicktoopen" is not in the correct order, it should be before "urlsuccessfullycreated"
(#36) The string key "indicator:cognitivedepth" is not in the correct order, it should be before "invalidstoredurl"
(#66) The string key "msteams:addinstance" is not in the correct order, it should be before "serverurl"
mod/msteams/lib.php
(#2) Moodle boilerplate not found at first line
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#36) Inline comments must start with a capital letter, digit or 3-dots sequence
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) This comment is 45% valid code; is this commented out code?
(#36) No space found before comment text; expected "// case FEATURE_MOD_ARCHETYPE: return MOD_ARCHETYPE_RESOURCE;" but found "//case FEATURE_MOD_ARCHETYPE: return MOD_ARCHETYPE_RESOURCE;"
(#37) Closing brace must be on a line by itself
(#38) Closing brace must be on a line by itself
(#39) Closing brace must be on a line by itself
(#40) Closing brace must be on a line by itself
(#41) Closing brace must be on a line by itself
(#42) Closing brace must be on a line by itself
(#43) Closing brace must be on a line by itself
(#44) Closing brace must be on a line by itself
(#46) Closing brace must be on a line by itself
(#60) Short array syntax must be used to define arrays
(#74) Short array syntax must be used to define arrays
(#88) Short array syntax must be used to define arrays
(#97) Short array syntax must be used to define arrays
(#142) Short array syntax must be used to define arrays
(#142) Expected 1 space before "=>"; 0 found
(#142) Expected 1 space after "=>"; 0 found
(#149) Inline comments must start with a capital letter, digit or 3-dots sequence
(#149) Inline comments must end in full-stops, exclamation marks, or question marks
(#151) Short array syntax must be used to define arrays
(#151) Expected 1 space before "=>"; 0 found
(#151) Expected 1 space after "=>"; 0 found
(#170) Short array syntax must be used to define arrays
(#170) Expected 1 space before "=>"; 0 found
(#170) Expected 1 space after "=>"; 0 found
(#172) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
(#178) Inline comments must start with a capital letter, digit or 3-dots sequence
(#178) Inline comments must end in full-stops, exclamation marks, or question marks
(#178) No space found before comment text; expected "// note: there should be a way to differentiate links from normal resources" but found "//note: there should be a way to differentiate links from normal resources"
(#199) Variable "module_pagetype" must not contain underscores.
(#199) Short array syntax must be used to define arrays
(#199) Expected 1 space before "=>"; 0 found
(#199) Expected 1 space after "=>"; 0 found
(#200) Variable "module_pagetype" must not contain underscores.
(#211) Short array syntax must be used to define arrays
(#214) Short array syntax must be used to define arrays
(#214) Expected 1 space before "=>"; 0 found
(#214) Expected 1 space after "=>"; 0 found
(#215) Short array syntax must be used to define arrays
(#215) Expected 1 space before "=>"; 0 found
(#215) Expected 1 space after "=>"; 0 found
(#222) Short array syntax must be used to define arrays
(#251) Short array syntax must be used to define arrays
(#253) There should be a comma after the last array item in a multi-line array.
(#276) Short array syntax must be used to define arrays
(#277) Short array syntax must be used to define arrays
mod/msteams/mod_form.php
(#2) Moodle boilerplate not found at first line
(#29) "require_once" must be immediately followed by an open parenthesis
(#31) Missing docblock for class mod_msteams_mod_form
(#32) Missing docblock for function definition
(#32) Visibility must be declared on method "definition"
(#40) Short array syntax must be used to define arrays
(#42) Line exceeds 132 characters; contains 152 characters
(#43) Line exceeds 132 characters; contains 136 characters
(#46) Short array syntax must be used to define arrays
(#48) Inline comments must start with a capital letter, digit or 3-dots sequence
(#48) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#50) Short array syntax must be used to define arrays
(#50) Expected 1 space before "=>"; 0 found
(#50) Expected 1 space after "=>"; 0 found
(#60) Short array syntax must be used to define arrays
(#60) Expected 1 space before "=>"; 0 found
(#60) Expected 1 space after "=>"; 0 found
(#70) Inline comments must start with a capital letter, digit or 3-dots sequence
(#70) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#73) Inline comments must start with a capital letter, digit or 3-dots sequence
(#73) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#78) Missing docblock for function validation
(#78) Visibility must be declared on method "validation"
mod/msteams/settings.php
(#2) Moodle boilerplate not found at first line
(#32) Inline comments must start with a capital letter, digit or 3-dots sequence
(#32) No space found before comment text; expected "// --- modedit defaults -----------------------------------------------------------------------------------" but found "//--- modedit defaults -----------------------------------------------------------------------------------"
(#33) Line exceeds 132 characters; contains 154 characters
mod/msteams/view.php
(#2) Moodle boilerplate not found at first line
(#32) Inline comments must end in full-stops, exclamation marks, or question marks
(#33) Inline comments must start with a capital letter, digit or 3-dots sequence
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#37) Inline comments must end in full-stops, exclamation marks, or question marks
(#38) Short array syntax must be used to define arrays
(#38) Expected 1 space before "=>"; 0 found
(#38) Expected 1 space after "=>"; 0 found
(#43) Short array syntax must be used to define arrays
(#43) Expected 1 space before "=>"; 0 found
(#43) Expected 1 space after "=>"; 0 found
(#46) Short array syntax must be used to define arrays
(#46) Expected 1 space before "=>"; 0 found
(#46) Expected 1 space after "=>"; 0 found
(#55) Short array syntax must be used to define arrays
(#60) Logical operator "or" is prohibited; use "||" instead
(#64) Short array syntax must be used to define arrays
(#64) Expected 1 space before "=>"; 0 found
(#64) Expected 1 space after "=>"; 0 found
(#75) Inline comments must start with a capital letter, digit or 3-dots sequence
(#76) Inline comments must end in full-stops, exclamation marks, or question marks
(#84) Short array syntax must be used to define arrays
(#87) Short array syntax must be used to define arrays

Javascript coding style problems

(6 errors, 2 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/msteams/amd/src/main.js
(#3) 'AJAX' is defined but never used. (no-unused-vars)
(#3) 'NOTIFICATION' is defined but never used. (no-unused-vars)
(#3) 'STR' is defined but never used. (no-unused-vars)
(#3) 'TEMPLATES' is defined but never used. (no-unused-vars)
(#3) 'URL' is defined but never used. (no-unused-vars)
(#7) Unexpected console statement. (no-console)
(#15) Comments should not begin with a lowercase character. (capitalized-comments)
(#15) Expected space or tab after '//' in comment. (spaced-comment)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(8 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/msteams/backup/moodle2/restore_msteams_activity_task.class.php
(#80) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#82) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#96) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#98) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/msteams/lib.php
(#52) Phpdocs for function msteams_reset_userdata has incomplete parameters list
(#203) Phpdocs for function msteams_export_contents has incomplete parameters list
(#242) Phpdocs for function msteams_view has incomplete parameters list
(#161) Inline phpdocs tag {@link get_array_of_activities()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]