Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(108 errors, 57 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/msteams/backup/moodle2/backup_msteams_activity_task.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#56) The static declaration must come after the visibility declaration
(#59) Commas (,) must be followed by white space.
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#61) No space found before comment text; expected "// Access a list of all links in a course" but found "//Access a list of all links in a course"
(#66) Inline comments must end in full-stops, exclamation marks, or question marks
(#66) No space found before comment text; expected "// Access the link supplying a course module id" but found "//Access the link supplying a course module id"
(#71) Inline comments must end in full-stops, exclamation marks, or question marks
(#71) No space found before comment text; expected "// Access the link supplying an instance id" but found "//Access the link supplying an instance id"
mod/msteams/backup/moodle2/backup_msteams_stepslib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Expected 2 space(s) before asterisk; 1 found
(#31) Expected 2 space(s) before asterisk; 1 found
(#36) Inline comments must start with a capital letter, digit or 3-dots sequence
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) No space found before comment text; expected "// the URL module stores no user info" but found "//the URL module stores no user info"
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#42) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) No space found before comment text; expected "// nothing here for URLs" but found "//nothing here for URLs"
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) No space found before comment text; expected "// module has no id annotations" but found "//module has no id annotations"
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#56) Inline comments must end in full-stops, exclamation marks, or question marks
mod/msteams/backup/moodle2/restore_msteams_activity_task.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#47) Inline comments must start with a capital letter, digit or 3-dots sequence
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) The static declaration must come after the visibility declaration
(#67) The static declaration must come after the visibility declaration
(#84) The static declaration must come after the visibility declaration
(#104) The static declaration must come after the visibility declaration
mod/msteams/backup/moodle2/restore_msteams_stepslib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Inline comments must start with a capital letter, digit or 3-dots sequence
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#56) Inline comments must start with a capital letter, digit or 3-dots sequence
(#56) Inline comments must end in full-stops, exclamation marks, or question marks
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
mod/msteams/classes/event/course_module_instance_list_viewed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/msteams/classes/event/course_module_viewed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/msteams/classes/external.php
(#163) Line exceeds 132 characters; contains 135 characters
mod/msteams/classes/privacy/provider.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#29) Line exceeds 132 characters; contains 136 characters
mod/msteams/cookie.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#33) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/msteams/db/log.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#33) Expected 1 space before "=>"; 0 found
(#33) Expected 1 space after "=>"; 0 found
(#33) Expected 1 space before "=>"; 0 found
(#33) Expected 1 space after "=>"; 0 found
(#33) Expected 1 space before "=>"; 0 found
(#33) Expected 1 space after "=>"; 0 found
(#33) Expected 1 space before "=>"; 0 found
(#33) Expected 1 space after "=>"; 0 found
(#34) Expected 1 space before "=>"; 0 found
(#34) Expected 1 space after "=>"; 0 found
(#34) Expected 1 space before "=>"; 0 found
(#34) Expected 1 space after "=>"; 0 found
(#34) Expected 1 space before "=>"; 0 found
(#34) Expected 1 space after "=>"; 0 found
(#34) Expected 1 space before "=>"; 0 found
(#34) Expected 1 space after "=>"; 0 found
mod/msteams/db/services.php
(#41) Line exceeds 132 characters; contains 133 characters
mod/msteams/db/upgrade.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/msteams/index.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#29) Inline comments must start with a capital letter, digit or 3-dots sequence
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#97) Inline comments must start with a capital letter, digit or 3-dots sequence
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#101) Inline comments must start with a capital letter, digit or 3-dots sequence
(#101) Inline comments must end in full-stops, exclamation marks, or question marks
mod/msteams/lang/de/msteams.php
(#2) The opening <?php tag must be followed by exactly one newline.
mod/msteams/lang/en/msteams.php
(#2) The opening <?php tag must be followed by exactly one newline.
mod/msteams/lib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#36) Inline comments must start with a capital letter, digit or 3-dots sequence
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) This comment is 45% valid code; is this commented out code?
(#36) No space found before comment text; expected "// case FEATURE_MOD_ARCHETYPE: return MOD_ARCHETYPE_RESOURCE;" but found "//case FEATURE_MOD_ARCHETYPE: return MOD_ARCHETYPE_RESOURCE;"
(#37) Closing brace must be on a line by itself
(#38) Closing brace must be on a line by itself
(#39) Closing brace must be on a line by itself
(#40) Closing brace must be on a line by itself
(#41) Closing brace must be on a line by itself
(#42) Closing brace must be on a line by itself
(#43) Closing brace must be on a line by itself
(#44) Closing brace must be on a line by itself
(#46) Closing brace must be on a line by itself
(#142) Expected 1 space before "=>"; 0 found
(#142) Expected 1 space after "=>"; 0 found
(#149) Inline comments must start with a capital letter, digit or 3-dots sequence
(#149) Inline comments must end in full-stops, exclamation marks, or question marks
(#151) Expected 1 space before "=>"; 0 found
(#151) Expected 1 space after "=>"; 0 found
(#170) Expected 1 space before "=>"; 0 found
(#170) Expected 1 space after "=>"; 0 found
(#172) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
(#178) Inline comments must start with a capital letter, digit or 3-dots sequence
(#178) Inline comments must end in full-stops, exclamation marks, or question marks
(#178) No space found before comment text; expected "// note: there should be a way to differentiate links from normal resources" but found "//note: there should be a way to differentiate links from normal resources"
(#199) Variable "module_pagetype" must not contain underscores.
(#199) Expected 1 space before "=>"; 0 found
(#199) Expected 1 space after "=>"; 0 found
(#200) Variable "module_pagetype" must not contain underscores.
(#214) Expected 1 space before "=>"; 0 found
(#214) Expected 1 space after "=>"; 0 found
(#215) Expected 1 space before "=>"; 0 found
(#215) Expected 1 space after "=>"; 0 found
mod/msteams/mod_form.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#29) "require_once" must be immediately followed by an open parenthesis
(#32) Visibility must be declared on method "definition"
(#42) Line exceeds 132 characters; contains 152 characters
(#43) Line exceeds 132 characters; contains 136 characters
(#48) Inline comments must start with a capital letter, digit or 3-dots sequence
(#48) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#50) Expected 1 space before "=>"; 0 found
(#50) Expected 1 space after "=>"; 0 found
(#60) Expected 1 space before "=>"; 0 found
(#60) Expected 1 space after "=>"; 0 found
(#70) Inline comments must start with a capital letter, digit or 3-dots sequence
(#70) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#73) Inline comments must start with a capital letter, digit or 3-dots sequence
(#73) No space found before comment text; expected "// -------------------------------------------------------" but found "//-------------------------------------------------------"
(#78) Visibility must be declared on method "validation"
mod/msteams/settings.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#32) Inline comments must start with a capital letter, digit or 3-dots sequence
(#32) No space found before comment text; expected "// --- modedit defaults -----------------------------------------------------------------------------------" but found "//--- modedit defaults -----------------------------------------------------------------------------------"
(#33) Line exceeds 132 characters; contains 154 characters
mod/msteams/view.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#32) Inline comments must end in full-stops, exclamation marks, or question marks
(#33) Inline comments must start with a capital letter, digit or 3-dots sequence
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#37) Inline comments must end in full-stops, exclamation marks, or question marks
(#38) Expected 1 space before "=>"; 0 found
(#38) Expected 1 space after "=>"; 0 found
(#43) Expected 1 space before "=>"; 0 found
(#43) Expected 1 space after "=>"; 0 found
(#46) Expected 1 space before "=>"; 0 found
(#46) Expected 1 space after "=>"; 0 found
(#64) Expected 1 space before "=>"; 0 found
(#64) Expected 1 space after "=>"; 0 found
(#75) Inline comments must start with a capital letter, digit or 3-dots sequence
(#76) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(6 errors, 2 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/msteams/amd/src/main.js
(#3) 'AJAX' is defined but never used. (no-unused-vars)
(#3) 'NOTIFICATION' is defined but never used. (no-unused-vars)
(#3) 'STR' is defined but never used. (no-unused-vars)
(#3) 'TEMPLATES' is defined but never used. (no-unused-vars)
(#3) 'URL' is defined but never used. (no-unused-vars)
(#7) Unexpected console statement. (no-console)
(#15) Comments should not begin with a lowercase character. (capitalized-comments)
(#15) Expected space or tab after '//' in comment. (spaced-comment)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(25 errors, 13 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/msteams/backup/moodle2/backup_msteams_activity_task.class.php
(#2) Empty line found after PHP open tag
mod/msteams/backup/moodle2/backup_msteams_stepslib.php
(#2) Empty line found after PHP open tag
(#34) Function backup_msteams_activity_structure_step::define_structure is not documented
mod/msteams/backup/moodle2/restore_msteams_activity_task.class.php
(#2) Empty line found after PHP open tag
(#18) No one-line description found in phpdocs for file
(#30) No one-line description found in phpdocs for class restore_msteams_activity_task
(#80) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#82) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#96) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#98) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
mod/msteams/backup/moodle2/restore_msteams_stepslib.php
(#2) Empty line found after PHP open tag
(#35) Function restore_msteams_activity_structure_step::define_structure is not documented
(#44) Function restore_msteams_activity_structure_step::process_msteams is not documented
(#60) Function restore_msteams_activity_structure_step::after_execute is not documented
(#18) No one-line description found in phpdocs for file
mod/msteams/classes/event/course_module_viewed.php
(#52) Function course_module_viewed::get_objectid_mapping is not documented
mod/msteams/classes/external.php
(#35) Package mod_url is not valid
mod/msteams/classes/privacy/provider.php
(#28) Class provider is not documented
(#29) Function provider::get_metadata is not documented
mod/msteams/cookie.php
(#2) Empty line found after PHP open tag
(#18) No one-line description found in phpdocs for file
mod/msteams/db/log.php
(#2) Empty line found after PHP open tag
mod/msteams/db/upgrade.php
(#26) Function xmldb_msteams_upgrade is not documented
(#17) No one-line description found in phpdocs for file
mod/msteams/index.php
(#2) Empty line found after PHP open tag
mod/msteams/lang/de/msteams.php
(#2) Empty line found after PHP open tag
mod/msteams/lang/en/msteams.php
(#2) Empty line found after PHP open tag
mod/msteams/lib.php
(#2) Empty line found after PHP open tag
(#52) Phpdocs for function msteams_reset_userdata has incomplete parameters list
(#203) Phpdocs for function msteams_export_contents has incomplete parameters list
(#242) Phpdocs for function msteams_view has incomplete parameters list
(#161) Inline phpdocs tag {@link get_array_of_activities()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
mod/msteams/mod_form.php
(#2) Empty line found after PHP open tag
(#31) Class mod_msteams_mod_form is not documented
(#32) Function mod_msteams_mod_form::definition is not documented
(#78) Function mod_msteams_mod_form::validation is not documented
mod/msteams/settings.php
(#2) Empty line found after PHP open tag
mod/msteams/view.php
(#2) Empty line found after PHP open tag

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]