Comments

• 

  Anthony Borrow

  Wed, 21 May 2014, 12:48 AM

  Allan,
  
  Many thanks to you and NetSpot for sharing this plugin with the Moodle community. I can see where this would be especially useful with an art class where the students are building up portfolios but even in other settings like a series of video portfolios. It reminds me of having to do verbatims in counseling classes. It would be great just to be able to add the video or audio for a teacher to review.
  
  I was successfully able to install the plugin and it appears to function as expected; however, I did notice some undeclared variable warnings with the version.php during install which would be good to clean up. I would suggest installing the code with debugging set to show all errors.
  
  When I was checking copyrights, I noticed:
  
  ./db/uninstall.php: * @copyright NetSpot Pty Ltd
  which you may want to update for consistency.
  
  This version in for Moodle 2.5. Are there plans to make a 2.6 and 2.7 version available? If so, keep in mind that the add_to_logs should be updated in 2.7.
  
  I noticed that some of the files in this plugin reference a license that is not GPL compatible. All files in the plugin must be GPL compatible to be approved in Moodle plugins. You can see a list of all valid licenses at: http://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses. In particular, the lightbox code references CC 2.5 attribution which is not really for software.
  
  "Creative Commons Attribution 2.0 license (a.k.a. CC BY) (#ccby)
  This is a non-copyleft free license that is good for art and entertainment works, and educational works. Please don't use it for software or documentation, since it is incompatible with the GNU GPL and with the GNU FDL."
  
  It may be that changes have been made and it appears that a 4.0 version of the license in available. I would ask you to look into whether the 2.5 version is GPL-compatible but I suspect it is not. All code in Moodle Plugins must be GPL-compatible to be approved.
  
  It is encouraged to follow Moodle's coding style as outlined in:
  
  http://docs.moodle.org/dev/Coding_style
  http://docs.moodle.org/dev/Coding
  
  Tthe code checker plugin can be quite helpful in fine tuning your code and can be found at:
  
  https://moodle.org/plugins/view.php?plugin=local_codechecker
  
  You may wish to consider using that tool to further improve your plugin. Below, are the initial results:
  
  Files found: 39
  
  mod/mediagallery/gallery.php
  mod/mediagallery/locallib.php - 19 error(s) and 3 warning(s)
  mod/mediagallery/lib.php - 17 error(s) and 0 warning(s)
  mod/mediagallery/rest.php
  mod/mediagallery/renderer.php - 10 error(s) and 9 warning(s)
  mod/mediagallery/export.php
  mod/mediagallery/item_bulk_form.php
  mod/mediagallery/classes/export_form.php - 1 error(s) and 0 warning(s)
  mod/mediagallery/classes/gallery.php - 3 error(s) and 1 warning(s)
  mod/mediagallery/classes/search_form.php
  mod/mediagallery/classes/base.php
  mod/mediagallery/classes/item.php - 12 error(s) and 5 warning(s)
  mod/mediagallery/classes/collection.php - 0 error(s) and 1 warning(s)
  mod/mediagallery/gallery_form.php
  mod/mediagallery/mod_form.php
  mod/mediagallery/item_form.php - 2 error(s) and 8 warning(s)
  mod/mediagallery/lang/en/mediagallery.php - 1 error(s) and 0 warning(s)
  mod/mediagallery/styles.css
  mod/mediagallery/index.php
  mod/mediagallery/tests/behat/behat_mod_mediagallery.php - 1 error(s) and 1 warning(s)
  mod/mediagallery/tests/generator/lib.php
  mod/mediagallery/view.php - 0 error(s) and 3 warning(s)
  mod/mediagallery/backup/moodle2/backup_mediagallery_activity_task.class.php - 6 error(s) and 0 warning(s)
  mod/mediagallery/backup/moodle2/backup_mediagallery_stepslib.php
  mod/mediagallery/backup/moodle2/restore_mediagallery_activity_task.class.php - 1 error(s) and 0 warning(s)
  mod/mediagallery/backup/moodle2/restore_mediagallery_stepslib.php
  mod/mediagallery/db/log.php - 33 error(s) and 0 warning(s)
  mod/mediagallery/db/upgrade.php - 1 error(s) and 0 warning(s)
  mod/mediagallery/db/access.php - 1 error(s) and 0 warning(s)
  mod/mediagallery/db/install.php
  mod/mediagallery/db/uninstall.php - 1 error(s) and 0 warning(s)
  mod/mediagallery/version.php
  mod/mediagallery/item.php - 9 error(s) and 0 warning(s)
  mod/mediagallery/settings.php
  mod/mediagallery/storage.php
  mod/mediagallery/jquery/lightbox-2.6/css/lightbox.css
  mod/mediagallery/jquery/lightbox-2.6/css/screen.css
  mod/mediagallery/jquery/plugins.php
  mod/mediagallery/search.php - 2 error(s) and 0 warning(s)
  Total: 120 error(s) and 31 warning(s)
  
  Some of these were renaming variables and others were whitespace.
  
  I am going to create a set for this and the other media gallery related plugins. If you would like to provide a description for that set I would be happy to update the generic one that I will initially create.
  
  For now, I am going to mark this plugin as needing more work until we get the licensing issue resolved. Since this plugin is required for the others, I will mark them all as needing more work. Thanks for your patience with the review and approval process. Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts. Peace - Anthony
  
  
  
  
• 

  Adam Olley

  Wed, 21 May 2014, 9:54 AM

  Hi Anthony,
  
  Thanks for sharing should also be extended to UNSW.
  
  Thanks for the feedback. I've updated the repo and submitted a new version.
  
  As for the items you raised:
  jQuery lightbox license: I've removed this plugin entirely now. It was used during initial development until I had a working YUI module that fills its place (and does a bunch of other neat stuff to).
  
  db/uninstall.php: Removed this file. It's unnecessary.
  
  2.6/2.7: Yes, definitely for 2.7 at a minimum. 2.5 is what it's been tested on, and it may actually work just fine on 2.6 and 2.7 - but as it hasn't been tested there yet, and I imagine there are some small API changes to sort out, I wasn't willing to flag it against 2.6 or 2.7 yet.
  
  Coding styles: Normally my vim actually warns me of all the moodle coding violations. Seems when I had to reinstall a while back I forgot to re-add the moodle coding rules to my CodeSniffer set. These have been addressed in the new version.
  Except for item_form.php which has 2 false positives. It claims there are empty IF statements, but they clearly test a preg_match condition...
• 

  David Mudrák

  Wed, 21 May 2014, 3:37 PM

  Thanks Adam for fixing all the raised issues promptly. I can confirm the lightbox jquery module being removed from the recent package and two other js modules use MIT license that os GPL compatible.
  
  I appreciate included behat tests in your module and overall coding style. Thanks for it.
  
  I am now going to approve all plugins in the set. Wish you luck with maintaining them and looking forward to further updates and improvements. Welcome to Plugins directory!
• 

  g k

  Thu, 22 May 2014, 9:37 AM

  This mod does not work with 2.6.3+. When I tried to create a gallery, it went to whitespace and nothing more.
• 

  Adam Olley

  Thu, 22 May 2014, 9:46 AM

  Hi gk. I hope to have a 2.6 and 2.7 compatible version(s) available soon.
• 

  Adam Olley

  Tue, 3 June 2014, 1:33 PM

  I've done some testing on 2.6 and run into no obvious issues. As such I'm setting the latest builds of the plugins to work for 2.5 and 2.6.
  
  They work on 2.7, but I won't flag them as ready for 2.7 as they need the add_to_log calls ported to the new logging system.
• 

  Sarah Jane

  Fri, 25 July 2014, 7:29 PM

  can you tell me if this plugin would be able to be used as a vision board for the students?
  
  I would like the student to privately add images and for the teacher to be able to see and comment on.
  
  Do you think this will fit ?
  
  Sarah x
• 

  Adam Olley

  Mon, 28 July 2014, 9:52 AM

  Hi Sarah,
  
  Students would be able to create galleries to post pictures up to and could set the visibility setting for "Visible to others" to some date way off into the future.
  
  But that'd rely on each student setting that when they create their gallery in your collection.
  
  So they can have image boards - just having them "private" isn't straightforward right now.
• 

  Richard Chui

  Wed, 30 July 2014, 3:41 PM

  Hi Adam,
  
  First of all, thank you for developing this plugin.
  
  I have installed the plugin for my Moodle 2.6 installation. When accessing the Media Collection plugin, I will always see the following 2 errors.
  
  Notice: Use of undefined constant FILE_INTERNAL - assumed 'FILE_INTERNAL' in /opt/lampp/htdocs/moodle260-test/mod/mediagallery/locallib.php on line 51
  Notice: Use of undefined constant FILE_REFERENCE - assumed 'FILE_REFERENCE' in /opt/lampp/htdocs/moodle260-test/mod/mediagallery/locallib.php on line 51
  
  Checking locallib.php, I really do not see those constants defined anywhere.
  
  Then I uploaded a flv file to a gallery. But when viewing the item, I only see the file name and not the actual video. There seems to be some issues in displaying the video player.
  
  Your help would be greatly appreciated.
  
  Thanks,
  Richard
• 

  Richard Chui

  Sun, 24 Aug 2014, 3:52 PM

  Any update on the above? Much appreciated.
• 

  Adam Olley

  Mon, 25 Aug 2014, 8:00 AM

  Hi Richard,
  
  I've uploaded an update. It fixes the bug you described and also adds the ability to select files from within your collections/galleries from within the file picker.