Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(89 errors, 60 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/listgrades/backup/moodle2/backup_listgrades_stepslib.php
(#1) No one-line description found in phpdocs for docblock of file backup_listgrades_stepslib.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) Missing docblock for function define_structure
mod/listgrades/backup/moodle2/restore_listgrades_activity_task.class.php
(#1) No one-line description found in phpdocs for docblock of file restore_listgrades_activity_task.class.php
mod/listgrades/backup/moodle2/restore_listgrades_stepslib.php
(#1) No one-line description found in phpdocs for docblock of file restore_listgrades_stepslib.php
(#33) Missing docblock for function define_structure
(#42) Missing docblock for function process_listgrades
(#60) Line indented incorrectly; expected 12 spaces, found 13
(#64) Line indented incorrectly; expected 12 spaces, found 16
(#64) Closing brace indented incorrectly; expected 13 spaces, found 16
(#67) Closing brace indented incorrectly; expected 16 spaces, found 12
(#83) Line indented incorrectly; expected 16 spaces, found 20
(#84) Line indented incorrectly; expected 20 spaces, found 24
(#85) Line indented incorrectly; expected 24 spaces, found 28
(#87) Line indented incorrectly; expected 24 spaces, found 28
(#89) Line indented incorrectly; expected 24 spaces, found 28
(#92) Line indented incorrectly; expected 20 spaces, found 24
(#93) Line indented incorrectly; expected 16 spaces, found 20
(#104) Missing docblock for function after_execute
mod/listgrades/classes/event/course_module_instance_list_viewed.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/listgrades/classes/event/course_module_viewed.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#47) Missing docblock for function get_objectid_mapping
mod/listgrades/classes/privacy/provider.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#41) There must not be a space before the colon in a return type declaration
mod/listgrades/db/access.php
(#34) There should be a comma after the last array item in a multi-line array.
(#43) There should be a comma after the last array item in a multi-line array.
mod/listgrades/db/install.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#32) Missing docblock for function xmldb_listgrades_install
mod/listgrades/db/log.php
(#33) File must end with a newline character
mod/listgrades/db/upgrade.php
(#45) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#47) Missing docblock for function xmldb_listgrades_upgrade
mod/listgrades/index.php
(#45) Short array syntax must be used to define arrays
(#94) There should be a comma after the last array item in a multi-line array.
mod/listgrades/lang/ca/listgrades.php
(#2) Moodle boilerplate not found at first line
(#18) Missing @copyright tag
(#21) Incorrect @package tag for file listgrades.php. Expected mod_listgrades, found mod.
mod/listgrades/lang/en/listgrades.php
(#37) The string key "defaultintro" is not in the correct order, it should be before "defaultintrotext"
(#41) The string key "createlisting" is not in the correct order, it should be before "footerheader"
(#51) The string key "listgrades:addinstance" is not in the correct order, it should be before "opendate_help"
(#62) The string key "showuserfield" is not in the correct order, it should be before "showusername_help"
(#68) The string key "notopen" is not in the correct order, it should be before "userfieldmask_help"
(#71) Unexpected string end, it should be a line feed after a semicolon
(#71) File must end with a newline character
mod/listgrades/lang/es/listgrades.php
(#43) The string key "defaultintro_help" is not in the correct order, it should be before "defaultintrotext"
(#46) The string key "createlisting" is not in the correct order, it should be before "footerheader"
(#56) The string key "listgrades:addinstance" is not in the correct order, it should be before "opendate_help"
(#66) The string key "showuserfield" is not in the correct order, it should be before "showusername_help"
(#72) The string key "notopen" is not in the correct order, it should be before "userfieldmask_help"
(#75) The string key "useridnever" is not in the correct order, it should be before "useridonlyifnamecollide"
mod/listgrades/lib.php
(#1) No one-line description found in phpdocs for docblock of file lib.php
(#32) Closing brace must be on a line by itself
(#33) Closing brace must be on a line by itself
(#34) Closing brace must be on a line by itself
(#35) Closing brace must be on a line by itself
(#36) Closing brace must be on a line by itself
(#37) Closing brace must be on a line by itself
(#38) Closing brace must be on a line by itself
(#39) Closing brace must be on a line by itself
(#40) Closing brace must be on a line by itself
(#41) Closing brace must be on a line by itself
(#43) Closing brace must be on a line by itself
(#187) Whitespace found at end of line
(#252) Line exceeds 132 characters; contains 135 characters
(#350) Short array syntax must be used to define arrays
(#359) Short array syntax must be used to define arrays
(#364) Line exceeds maximum limit of 180 characters; contains 182 characters
(#386) Line exceeds 132 characters; contains 140 characters
(#529) There must not be a space before the colon in a return type declaration
mod/listgrades/locallib.php
(#32) Missing docblock for class grade_report_listing
(#41) Expected 1 space after "="; 2 found
(#49) Inline comments must start with a capital letter, digit or 3-dots sequence
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#56) Whitespace found at end of line
(#58) Whitespace found at end of line
(#65) Missing docblock for function get_item_names
(#80) Missing docblock for function get_category_names
(#89) Missing docblock for function get_gradeitems
(#96) Missing docblock for function get_grades
(#99) Missing docblock for function get_users
(#102) Missing docblock for function get_students_per_page
(#110) Missing docblock for function listgrades_mask
(#127) Whitespace found at end of line
(#128) Whitespace found at end of line
(#130) Whitespace found at end of line
(#131) Whitespace found at end of line
(#133) Whitespace found at end of line
(#134) Whitespace found at end of line
(#136) Whitespace found at end of line
(#137) Whitespace found at end of line
(#138) Whitespace found at end of line
(#139) Whitespace found at end of line
(#140) Whitespace found at end of line
(#143) Whitespace found at end of line
(#144) Whitespace found at end of line
(#145) Whitespace found at end of line
(#147) Whitespace found at end of line
(#165) Inline comments must end in full-stops, exclamation marks, or question marks
(#168) Inline comments must end in full-stops, exclamation marks, or question marks
(#170) Expected "} else if (...) {\n"; found "} else if (...){\n"
(#170) Expected "if (...) {\n"; found "if (...){\n"
(#177) Expected 1 space after "-"; 0 found
(#179) Inline comments must end in full-stops, exclamation marks, or question marks
(#213) Expected "if (...) {\n"; found "if(...) {\n"
(#214) Space found after square bracket; expected "[-" but found "[ -"
(#232) Missing docblock for function get_parent
(#238) Missing docblock for function get_visible_name
(#246) Missing docblock for function listgrades_get_editor_options
(#318) Short array syntax must be used to define arrays
mod/listgrades/mod_form.php
(#32) Missing docblock for class mod_listgrades_mod_form
(#33) Missing docblock for function definition
mod/listgrades/settings.php
(#31) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) Line exceeds 132 characters; contains 161 characters
(#44) Line exceeds 132 characters; contains 143 characters
mod/listgrades/tests/generator/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#39) Missing docblock for function create_instance
(#39) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $options.
mod/listgrades/tests/generator_test.php
(#23) Invalid @category tag value "phpunit".
(#27) Unit test generator_test should be declared as final.
(#28) Test method test_generator() is missing any coverage information, own or at class level
(#28) Test method test_generator() is missing a return type
mod/listgrades/tests/lib_test.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#40) Unit test lib_test should be declared as final.
(#46) The setUpBeforeClass() method in unit tests must always call to parent::setUpBeforeClass().
(#55) Test method test_listgrades_view() is missing any coverage information, own or at class level
(#55) Test method test_listgrades_view() is missing a return type
(#62) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
(#64) Short array syntax must be used to define arrays
(#82) Short array syntax must be used to define arrays
(#93) Test method test_listgrades_core_calendar_provide_event_action() is missing any coverage information, own or at class level
(#93) Test method test_listgrades_core_calendar_provide_event_action() is missing a return type
(#99) Short array syntax must be used to define arrays
(#119) Test method test_listgrades_core_calendar_provide_event_action_already_completed() is missing any coverage information, own or at class level
(#119) Test method test_listgrades_core_calendar_provide_event_action_already_completed() is missing a return type
(#128) Short array syntax must be used to define arrays
(#129) Short array syntax must be used to define arrays
(#130) Short array syntax must be used to define arrays
(#156) Test method test_listgrades_core_calendar_provide_event_action_user_override() is missing any coverage information, own or at class level
(#156) Test method test_listgrades_core_calendar_provide_event_action_user_override() is missing a return type
(#165) Short array syntax must be used to define arrays
(#166) Short array syntax must be used to define arrays
(#167) Short array syntax must be used to define arrays
mod/listgrades/view.php
(#151) Variable "sql_in" must not contain underscores.
(#158) Variable "sql_in" must not contain underscores.
(#170) Whitespace found at end of line
(#172) Whitespace found at end of line
(#180) Inline comments must start with a capital letter, digit or 3-dots sequence
(#221) Line exceeds 132 characters; contains 140 characters

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(10 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/listgrades/backup/moodle2/restore_listgrades_activity_task.class.php
(#76) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#78) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#92) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#94) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/listgrades/lib.php
(#49) Phpdocs for function listgrades_reset_userdata has incomplete parameters list
(#343) Phpdocs for function listgrades_export_contents has incomplete parameters list
(#492) Phpdocs for function mod_listgrades_core_calendar_provide_event_action has incomplete parameters list
mod/listgrades/locallib.php
(#33) Phpdocs for function grade_report_listing::__construct has incomplete parameters list
(#201) Phpdocs for function listgrades_get_gradeitems_for_backup has incomplete parameters list
(#254) Phpdocs for function listgrades_update_calendar has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]