Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(1 errors, 40 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/lightboxgallery/backup/moodle2/backup_lightboxgallery_stepslib.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/backup/moodle2/restore_lightboxgallery_stepslib.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/classes/event/course_module_instance_list_viewed.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/classes/event/course_module_viewed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/classes/event/gallery_comment_created.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/classes/event/gallery_searched.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/classes/event/image_updated.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/classes/gallery_page.php
(#119) File must end with a newline character
mod/lightboxgallery/classes/privacy/provider.php
(#36) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/classes/search/activity.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/comment.php
(#26) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#31) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#66) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#91) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/lightboxgallery/db/upgrade.php
(#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/edit/base.class.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/edit/caption/caption.class.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/edit/delete/delete.class.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/edit/flip/flip.class.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/edit/resize/resize.class.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/edit/rotate/rotate.class.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/edit/tag/import.php
(#24) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#27) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#30) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#48) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/lightboxgallery/edit/tag/tag.class.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/edit/thumbnail/thumbnail.class.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/imageedit.php
(#79) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/lightboxgallery/tests/generator/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/lightboxgallery/tests/lib_test.php
(#39) PHPUnit testcase name "mod_lightboxgallery_lib_testcase" does not match file name "lib_test"
(#39) PHPUnit class "mod_lightboxgallery_lib_testcase" does not have any namespace. It is recommended to add it to the "mod_lightboxgallery" namespace, using more levels if needed, in order to match the code being tested
(#40) Test method test_lightboxgallery_resize_text() is missing any coverage information, own or at class level
(#45) Test method test_lightboxgallery_edit_types() is missing any coverage information, own or at class level
mod/lightboxgallery/tests/privacy_test.php
(#45) PHPUnit testcase name "mod_lightboxgallery_privacy_testcase" does not match file name "privacy_test"
(#45) PHPUnit class "mod_lightboxgallery_privacy_testcase" does not have any namespace. It is recommended to add it to the "mod_lightboxgallery" namespace, using more levels if needed, in order to match the code being tested
(#53) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
(#87) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
(#128) Test method test_delete_data_for_user() is missing any coverage information, own or at class level
(#160) Test method test_export_data_for_user() is missing any coverage information, own or at class level
mod/lightboxgallery/view.php
(#44) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#48) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead

Javascript coding style problems

(1 errors, 4 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/lightboxgallery/module.js
(#1) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#1) 'YUI' is not defined. (no-undef)
(#1) Unexpected space before function parentheses. (space-before-function-paren)
(#1) Statement inside of curly braces should be on next line. (brace-style)
(#1) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(170 errors, 3 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/lightboxgallery/backup/moodle2/backup_lightboxgallery_stepslib.php
(#18) Package moodlecore is not valid
(#35) Function backup_lightboxgallery_activity_structure_step::define_structure is not documented
(#17) No one-line description found in phpdocs for file
mod/lightboxgallery/backup/moodle2/restore_lightboxgallery_activity_task.class.php
(#18) Package moodlecore is not valid
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class restore_lightboxgallery_activity_task
(#74) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#76) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#90) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#92) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/lightboxgallery/backup/moodle2/restore_lightboxgallery_stepslib.php
(#18) Package moodlecore is not valid
(#35) Function restore_lightboxgallery_activity_structure_step::define_structure is not documented
(#55) Function restore_lightboxgallery_activity_structure_step::process_lightboxgallery is not documented
(#67) Function restore_lightboxgallery_activity_structure_step::process_lightboxgallery_comment is not documented
(#81) Function restore_lightboxgallery_activity_structure_step::process_lightboxgallery_image_meta is not documented
(#91) Function restore_lightboxgallery_activity_structure_step::after_execute is not documented
(#17) No one-line description found in phpdocs for file
mod/lightboxgallery/classes/event/gallery_comment_created.php
(#109) Function gallery_comment_created::get_other_mapping is not documented
mod/lightboxgallery/classes/event/gallery_searched.php
(#115) Function gallery_searched::get_other_mapping is not documented
mod/lightboxgallery/classes/event/image_updated.php
(#102) Function image_updated::get_other_mapping is not documented
mod/lightboxgallery/classes/gallery_page.php
(#23) Package is not specified for class gallery_page. It is also not specified in file-level phpdocs
(#23) Class gallery_page is not documented
(#56) Function gallery_page::display_images is not documented
(#66) Function gallery_page::load_metadata is not documented
(#116) Function gallery_page::image_count is not documented
(#25) Variable gallery_page::$cm is not documented
(#26) Variable gallery_page::$editing is not documented
(#27) Variable gallery_page::$files is not documented
(#28) Variable gallery_page::$gallery is not documented
(#29) Variable gallery_page::$imagecount is not documented
(#30) Variable gallery_page::$metadata is not documented
(#31) Variable gallery_page::$page is not documented
(#32) Variable gallery_page::$pagefiles is not documented
(#33) Variable gallery_page::$pagethumbs is not documented
(#34) Variable gallery_page::$thumbnails is not documented
mod/lightboxgallery/classes/privacy/provider.php
(#255) Function provider::get_lightboxgallery_id_from_context is not documented
mod/lightboxgallery/comment.php
(#17) File-level phpdocs block is not found
mod/lightboxgallery/comment_form.php
(#30) Class mod_lightboxgallery_comment_form is not documented
(#32) Function mod_lightboxgallery_comment_form::definition is not documented
mod/lightboxgallery/db/log.php
(#17) No one-line description found in phpdocs for file
mod/lightboxgallery/db/upgrade.php
(#42) Function xmldb_lightboxgallery_upgrade is not documented
mod/lightboxgallery/edit/base.class.php
(#27) Package is not specified for class edit_base. It is also not specified in file-level phpdocs
(#22) Package mod_lighboxgallery is not valid
(#27) Class edit_base is not documented
(#38) Function edit_base::__construct is not documented
(#51) Function edit_base::processing is not documented
(#55) Function edit_base::enclose_in_form is not documented
(#67) Function edit_base::output is not documented
(#71) Function edit_base::process_form is not documented
(#29) Variable edit_base::$imageobj is not documented
(#31) Variable edit_base::$gallery is not documented
(#32) Variable edit_base::$image is not documented
(#33) Variable edit_base::$lbgimage is not documented
(#34) Variable edit_base::$tab is not documented
(#35) Variable edit_base::$showthumb is not documented
(#36) Variable edit_base::$context is not documented
mod/lightboxgallery/edit/caption/caption.class.php
(#19) Package is not specified for class edit_caption. It is also not specified in file-level phpdocs
(#19) Class edit_caption is not documented
(#21) Function edit_caption::__construct is not documented
(#25) Function edit_caption::output is not documented
(#31) Function edit_caption::process_form is not documented
mod/lightboxgallery/edit/crop/crop.class.php
(#21) Package is not specified for class edit_crop. It is also not specified in file-level phpdocs
(#21) Class edit_crop is not documented
(#23) Function edit_crop::__construct is not documented
(#27) Function edit_crop::output is not documented
(#69) Function edit_crop::process_form is not documented
mod/lightboxgallery/edit/delete/delete.class.php
(#19) Package is not specified for class edit_delete. It is also not specified in file-level phpdocs
(#19) Class edit_delete is not documented
(#21) Function edit_delete::__construct is not documented
(#25) Function edit_delete::output is not documented
(#33) Function edit_delete::process_form is not documented
mod/lightboxgallery/edit/flip/flip.class.php
(#22) Package is not specified for class edit_flip. It is also not specified in file-level phpdocs
(#22) Class edit_flip is not documented
(#24) Function edit_flip::__construct is not documented
(#28) Function edit_flip::output is not documented
(#37) Function edit_flip::process_form is not documented
mod/lightboxgallery/edit/resize/resize.class.php
(#19) Package is not specified for class edit_resize. It is also not specified in file-level phpdocs
(#19) Class edit_resize is not documented
(#25) Function edit_resize::__construct is not documented
(#32) Function edit_resize::output is not documented
(#58) Function edit_resize::process_form is not documented
(#21) Variable edit_resize::$strresize is not documented
(#22) Variable edit_resize::$strscale is not documented
(#23) Variable edit_resize::$resizeoptions is not documented
mod/lightboxgallery/edit/rotate/rotate.class.php
(#19) Package is not specified for class edit_rotate. It is also not specified in file-level phpdocs
(#19) Class edit_rotate is not documented
(#21) Function edit_rotate::__construct is not documented
(#25) Function edit_rotate::output is not documented
(#35) Function edit_rotate::process_form is not documented
mod/lightboxgallery/edit/tag/import.php
(#17) File-level phpdocs block is not found
mod/lightboxgallery/edit/tag/tag.class.php
(#19) Package is not specified for class edit_tag. It is also not specified in file-level phpdocs
(#19) Class edit_tag is not documented
(#21) Function edit_tag::__construct is not documented
(#25) Function edit_tag::output is not documented
(#74) Function edit_tag::process_form is not documented
mod/lightboxgallery/edit/thumbnail/thumbnail.class.php
(#19) Package is not specified for class edit_thumbnail. It is also not specified in file-level phpdocs
(#19) Class edit_thumbnail is not documented
(#21) Function edit_thumbnail::__construct is not documented
(#25) Function edit_thumbnail::output is not documented
(#48) Function edit_thumbnail::process_form is not documented
mod/lightboxgallery/imageadd.php
(#20) Package mod_lightworkgallery is not valid
mod/lightboxgallery/imageadd_form.php
(#33) Function mod_lightboxgallery_imageadd_form::definition is not documented
(#65) Function mod_lightboxgallery_imageadd_form::validation is not documented
(#91) Function mod_lightboxgallery_imageadd_form::can_resize is not documented
mod/lightboxgallery/imageclass.php
(#59) Function lightboxgallery_image::__construct is not documented
(#89) Function lightboxgallery_image::add_tag is not documented
(#101) Function lightboxgallery_image::create_thumbnail is not documented
(#119) Function lightboxgallery_image::create_index is not documented
(#147) Function lightboxgallery_image::delete_file is not documented
(#162) Function lightboxgallery_image::delete_tag is not documented
(#168) Function lightboxgallery_image::delete_thumbnail is not documented
(#175) Function lightboxgallery_image::flip_image is not documented
(#195) Function lightboxgallery_image::get_editing_options is not documented
(#218) Function lightboxgallery_image::get_image_caption is not documented
(#238) Function lightboxgallery_image::get_image_display_html is not documented
(#278) Function lightboxgallery_image::get_image_flipped is not documented
(#301) Function lightboxgallery_image::get_image_resized is not documented
(#332) Function lightboxgallery_image::get_image_rotated is not documented
(#339) Function lightboxgallery_image::get_image_url is not documented
(#343) Function lightboxgallery_image::get_tags is not documented
(#365) Function lightboxgallery_image::get_thumbnail is not documented
(#376) Function lightboxgallery_image::get_thumbnail_url is not documented
(#380) Function lightboxgallery_image::output_by_mimetype is not documented
(#394) Function lightboxgallery_image::resize_image is not documented
(#419) Function lightboxgallery_image::rotate_image is not documented
(#440) Function lightboxgallery_image::set_caption is not documented
(#458) Function lightboxgallery_image::copy_content_to_temp is not documented
(#462) Function lightboxgallery_image::set_stored_file is not documented
(#36) Variable lightboxgallery_image::$cm is not documented
(#37) Variable lightboxgallery_image::$cmid is not documented
(#38) Variable lightboxgallery_image::$context is not documented
(#39) Variable lightboxgallery_image::$gallery is not documented
(#40) Variable lightboxgallery_image::$imageurl is not documented
(#43) Variable lightboxgallery_image::$metadata is not documented
(#52) Variable lightboxgallery_image::$tags is not documented
(#53) Variable lightboxgallery_image::$thumbnail is not documented
(#54) Variable lightboxgallery_image::$thumburl is not documented
(#56) Variable lightboxgallery_image::$height is not documented
(#57) Variable lightboxgallery_image::$width is not documented
mod/lightboxgallery/index.php
(#21) Package mod_lightworkgallery is not valid
mod/lightboxgallery/lang/de/lightboxgallery.php
(#18) No one-line description found in phpdocs for file
mod/lightboxgallery/lib.php
(#37) Function lightboxgallery_supports is not documented
(#204) Function lightboxgallery_get_recent_mod_activity is not documented
(#263) Function lightboxgallery_print_recent_mod_activity is not documented
(#352) Function lightboxgallery_get_view_actions is not documented
(#356) Function lightboxgallery_get_post_actions is not documented
(#167) Phpdocs for function lightboxgallery_user_complete has incomplete parameters list
(#285) Phpdocs for function lightboxgallery_print_recent_activity has incomplete parameters list
(#340) Phpdocs for function lightboxgallery_get_participants has incomplete parameters list
(#506) Phpdocs for function mod_lightboxgallery_core_calendar_provide_event_action has incomplete parameters list
mod/lightboxgallery/locallib.php
(#101) Function lightboxgallery_config_defaults is not documented
(#116) Function lightboxgallery_edit_types is not documented
(#135) Function lightboxgallery_print_tags is not documented
(#162) Function lightboxgallery_resize_options is not documented
(#166) Function lightboxgallery_index_thumbnail is not documented
(#218) Function lightboxgallery_content_file_info::get_parent is not documented
(#224) Function lightboxgallery_content_file_info::get_visible_name is not documented
(#46) Phpdocs for function lightboxgallery_add_images has incomplete parameters list
(#51) Not recommended phpdocs tag @access used
mod/lightboxgallery/mod_form.php
(#34) Class mod_lightboxgallery_mod_form is not documented
(#36) Function mod_lightboxgallery_mod_form::definition is not documented
(#116) Function mod_lightboxgallery_mod_form::data_preprocessing is not documented
(#124) Function mod_lightboxgallery_mod_form::get_perpage_options is not documented
(#133) Function mod_lightboxgallery_mod_form::get_autoresize_options is not documented
mod/lightboxgallery/rsslib.php
(#134) Function lightboxgallery_rss_feeds is not documented
(#193) Function lightboxgallery_rss_get_sql is not documented
(#206) Function lightboxgallery_rss_header is not documented
(#17) File-level phpdocs block does not have @copyright tag
(#31) Not recommended phpdocs tag @global used
(#31) Not recommended phpdocs tag @global used
mod/lightboxgallery/tests/generator/lib.php
(#38) Function mod_lightboxgallery_generator::create_instance is not documented
mod/lightboxgallery/tests/privacy_test.php
(#209) Function mod_lightboxgallery_privacy_testcase::assert_exported_comments is not documented
(#17) File-level phpdocs block does not have @copyright tag

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 2 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

mod/lightboxgallery/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]