Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(65 errors, 76 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/labelwithgroup/backup/moodle1/lib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#68) Inline comments must start with a capital letter, digit or 3-dots sequence
(#68) Inline comments must end in full-stops, exclamation marks, or question marks
(#74) Inline comments must start with a capital letter, digit or 3-dots sequence
(#74) Inline comments must end in full-stops, exclamation marks, or question marks
(#77) Inline comments must start with a capital letter, digit or 3-dots sequence
(#77) Inline comments must end in full-stops, exclamation marks, or question marks
(#82) Inline comments must start with a capital letter, digit or 3-dots sequence
(#82) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) Inline comments must start with a capital letter, digit or 3-dots sequence
(#93) Inline comments must end in full-stops, exclamation marks, or question marks
mod/labelwithgroup/backup/moodle2/backup_labelwithgroup_activity_task.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#39) The static declaration must come after the visibility declaration
mod/labelwithgroup/backup/moodle2/backup_labelwithgroup_stepslib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#20) Inline comments must end in full-stops, exclamation marks, or question marks
(#23) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
mod/labelwithgroup/backup/moodle2/restore_labelwithgroup_activity_task.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#11) Inline comments must end in full-stops, exclamation marks, or question marks
(#23) Inline comments must end in full-stops, exclamation marks, or question marks
(#30) Inline comments must start with a capital letter, digit or 3-dots sequence
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#38) The static declaration must come after the visibility declaration
(#50) The static declaration must come after the visibility declaration
(#60) The static declaration must come after the visibility declaration
(#80) The static declaration must come after the visibility declaration
mod/labelwithgroup/backup/moodle2/restore_labelwithgroup_stepslib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#9) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#9) "require_once" must be immediately followed by an open parenthesis
(#24) Line exceeds 132 characters; contains 148 characters
(#26) Inline comments must end in full-stops, exclamation marks, or question marks
(#43) Inline comments must start with a capital letter, digit or 3-dots sequence
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Inline comments must start with a capital letter, digit or 3-dots sequence
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#64) Inline comments must end in full-stops, exclamation marks, or question marks
mod/labelwithgroup/classes/analytics/indicator/activity_base.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/labelwithgroup/classes/analytics/indicator/cognitive_depth.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/labelwithgroup/classes/analytics/indicator/social_breadth.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/labelwithgroup/classes/collapse.php
(#36) Opening brace should be on the same line as the declaration for class collapse
(#71) Line exceeds maximum limit of 180 characters; contains 300 characters
(#116) Whitespace found at end of line within string
(#122) Whitespace found at end of line within string
(#123) Line exceeds 132 characters; contains 141 characters
(#147) Whitespace found at end of line within string
(#155) File must end with a newline character
mod/labelwithgroup/classes/collapseslide.php
(#35) Opening brace should be on the same line as the declaration for class collapseslide
(#76) Line exceeds maximum limit of 180 characters; contains 298 characters
(#181) Whitespace found at end of line within string
(#187) Whitespace found at end of line within string
(#188) Line exceeds 132 characters; contains 141 characters
(#212) Whitespace found at end of line within string
(#219) File must end with a newline character
mod/labelwithgroup/classes/external.php
(#205) Whitespace found at end of line
(#220) File must end with a newline character
mod/labelwithgroup/classes/labeltemplateinterface.php
(#36) Opening brace should be on the same line as the declaration for interface labeltemplateinterface
(#65) File must end with a newline character
mod/labelwithgroup/classes/none.php
(#35) Opening brace should be on the same line as the declaration for class none
(#85) Opening brace should be on the same line as the declaration
(#89) Whitespace found at end of line within string
(#95) Whitespace found at end of line within string
(#96) Line exceeds 132 characters; contains 141 characters
(#120) Whitespace found at end of line within string
(#128) File must end with a newline character
mod/labelwithgroup/classes/privacy/provider.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/labelwithgroup/classes/search/activity.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/labelwithgroup/classes/slide.php
(#35) Opening brace should be on the same line as the declaration for class slide
(#61) Whitespace found at end of line within string
(#79) Whitespace found at end of line within string
(#161) Whitespace found at end of line within string
(#167) Whitespace found at end of line within string
(#168) Line exceeds 132 characters; contains 141 characters
(#192) Whitespace found at end of line within string
(#199) File must end with a newline character
mod/labelwithgroup/classes/templatefactory.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#37) Opening brace should be on the same line as the declaration for class templatefactory
(#56) Visibility must be declared on method "get_template_by_type"
(#68) File must end with a newline character
mod/labelwithgroup/db/log.php
(#30) File must end with a newline character
mod/labelwithgroup/db/upgrade.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/labelwithgroup/index.php
(#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
mod/labelwithgroup/lib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/labelwithgroup/mod_form.php
(#102) Line exceeds 132 characters; contains 135 characters
(#162) Visibility must be declared on method "data_postprocessing"
(#189) Variable "default_values" must not contain underscores.
(#190) Opening brace should be on the same line as the declaration
(#193) Variable "default_values" must not contain underscores.
(#194) Variable "default_values" must not contain underscores.
(#194) Variable "default_values" must not contain underscores.
(#197) Variable "default_values" must not contain underscores.
(#201) Variable "default_values" must not contain underscores.
(#202) Variable "default_values" must not contain underscores.
(#210) Variable "default_values" must not contain underscores.
(#211) Variable "default_values" must not contain underscores.
(#220) Variable "default_values" must not contain underscores.
(#221) Variable "default_values" must not contain underscores.
(#221) Variable "default_values" must not contain underscores.
(#222) Variable "default_values" must not contain underscores.
(#227) Variable "default_values" must not contain underscores.
(#227) Inline comments must end in full-stops, exclamation marks, or question marks
(#237) Opening brace should be on the same line as the declaration
(#238) Inline comments must end in full-stops, exclamation marks, or question marks
(#246) Inline comments must end in full-stops, exclamation marks, or question marks
mod/labelwithgroup/tests/externallib_test.php
(#40) PHPUnit testcase name "mod_labelwithgroup_external_testcase" does not match file name "externallib_test"
(#40) PHPUnit class "mod_labelwithgroup_external_testcase" does not have any namespace. It is recommended to add it to the "mod_labelwithgroup" namespace, using more levels if needed, in order to match the code being tested
(#45) Test method test_mod_labelwithgroup_get_labelwithgroups_by_courses() is missing any coverage information, own or at class level
(#159) Test method test_mod_labelwithgroup_get_labelwithgroups_by_user() is missing any coverage information, own or at class level
mod/labelwithgroup/tests/generator/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/labelwithgroup/tests/generator_test.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) PHPUnit testcase name "mod_labelwithgroup_generator_testcase" does not match file name "generator_test"
(#34) PHPUnit class "mod_labelwithgroup_generator_testcase" does not have any namespace. It is recommended to add it to the "mod_labelwithgroup" namespace, using more levels if needed, in order to match the code being tested
(#35) Test method test_generator() is missing any coverage information, own or at class level
mod/labelwithgroup/tests/lib_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#36) PHPUnit testcase name "mod_labelwithgroup_lib_testcase" does not match file name "lib_test"
(#36) PHPUnit class "mod_labelwithgroup_lib_testcase" does not have any namespace. It is recommended to add it to the "mod_labelwithgroup" namespace, using more levels if needed, in order to match the code being tested
(#56) Test method test_labelwithgroup_core_calendar_provide_event_action() is missing any coverage information, own or at class level
(#79) Test method test_labelwithgroup_core_calendar_provide_event_action_as_non_user() is missing any coverage information, own or at class level
(#104) Test method test_labelwithgroup_core_calendar_provide_event_action_in_hidden_section() is missing any coverage information, own or at class level
(#129) Test method test_labelwithgroup_core_calendar_provide_event_action_for_user() is missing any coverage information, own or at class level
(#161) Test method test_labelwithgroup_core_calendar_provide_event_action_already_completed() is missing any coverage information, own or at class level
(#192) Test method test_labelwithgroup_core_calendar_provide_event_action_already_completed_for_user() is missing any coverage information, own or at class level
(#232) Test method test_labelwithgroup_generate_none_template() is missing any coverage information, own or at class level
(#274) Test method test_labelwithgroup_generate_collapse_template() is missing any coverage information, own or at class level
(#285) Expected 1 space before "=>"; 0 found
(#285) Expected 1 space after "=>"; 0 found
(#290) Line exceeds 132 characters; contains 160 characters
(#319) Test method test_labelwithgroup_generate_slide_template() is missing any coverage information, own or at class level
(#366) Test method test_labelwithgroup_generate_collapse_slide_template() is missing any coverage information, own or at class level
(#427) File must end with a newline character
mod/labelwithgroup/view.php
(#33) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#37) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#41) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#47) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#50) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#53) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead

Javascript coding style problems

(16 errors, 15 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/labelwithgroup/amd/src/form_handler.js
(#15) Identifier 'pt_br' is not in camel case. (camelcase)
(#28) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#28) Missing JSDoc comment. (require-jsdoc)
(#34) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#34) Missing JSDoc comment. (require-jsdoc)
(#38) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#38) Missing JSDoc comment. (require-jsdoc)
(#45) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#45) Missing JSDoc comment. (require-jsdoc)
(#52) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#52) Missing JSDoc comment. (require-jsdoc)
(#64) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#64) Missing JSDoc comment. (require-jsdoc)
(#74) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#74) Missing JSDoc comment. (require-jsdoc)
(#80) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#80) Missing JSDoc comment. (require-jsdoc)
(#86) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#86) Missing JSDoc comment. (require-jsdoc)
(#105) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#105) Missing JSDoc comment. (require-jsdoc)
(#108) There should be no space before this paren. (space-in-parens)
(#116) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#116) Missing JSDoc comment. (require-jsdoc)
(#123) Expected an assignment or function call and instead saw an expression. (babel/no-unused-expressions)
(#138) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#138) Missing JSDoc comment. (require-jsdoc)
(#142) 'isInitialView' is not defined. (no-undef)
(#144) Expected an assignment or function call and instead saw an expression. (babel/no-unused-expressions)
(#144) 'isInitialView' is not defined. (no-undef)
(#147) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(4 errors, 1 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/labelwithgroup/styles.css
(#29) Expected "#FFF" to be "#fff" (color-hex-case)
(#10) Expected single space before "!" (declaration-bang-space-before)
(#10) Unexpected !important (declaration-no-important)
(#97) Unexpected URL scheme "data:" (function-url-scheme-blacklist)
(#101) Unexpected URL scheme "data:" (function-url-scheme-blacklist)

PHPDocs style problems

(25 errors, 5 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/labelwithgroup/backup/moodle1/lib.php
(#2) Empty line found after PHP open tag
(#18) No one-line description found in phpdocs for file
(#63) Phpdocs for function moodle1_mod_labelwithgroup_handler::process_labelwithgroup has incomplete parameters list
(#37) Inline phpdocs tag {@link convert_path} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#37) Inline phpdocs tag {@link convert_path} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
mod/labelwithgroup/backup/moodle2/backup_labelwithgroup_activity_task.class.php
(#2) Empty line found after PHP open tag
mod/labelwithgroup/backup/moodle2/backup_labelwithgroup_stepslib.php
(#2) Empty line found after PHP open tag
(#18) Function backup_labelwithgroup_activity_structure_step::define_structure is not documented
(#3) No one-line description found in phpdocs for file
mod/labelwithgroup/backup/moodle2/restore_labelwithgroup_activity_task.class.php
(#2) Empty line found after PHP open tag
(#3) No one-line description found in phpdocs for file
(#13) No one-line description found in phpdocs for class restore_labelwithgroup_activity_task
(#56) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#58) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#72) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#74) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
mod/labelwithgroup/backup/moodle2/restore_labelwithgroup_stepslib.php
(#2) Empty line found after PHP open tag
(#20) Function restore_labelwithgroup_activity_structure_step::define_structure is not documented
(#30) Function restore_labelwithgroup_activity_structure_step::process_labelwithgroup is not documented
(#50) Function restore_labelwithgroup_activity_structure_step::process_labelwithgroup_content is not documented
(#63) Function restore_labelwithgroup_activity_structure_step::after_execute is not documented
(#3) No one-line description found in phpdocs for file
(#71) Phpdocs for function restore_labelwithgroup_activity_structure_step::get_new_groupid has incomplete parameters list
mod/labelwithgroup/classes/collapse.php
(#123) Variable collapse::$_SESSION is not documented
mod/labelwithgroup/classes/collapseslide.php
(#188) Variable collapseslide::$_SESSION is not documented
mod/labelwithgroup/classes/none.php
(#96) Variable none::$_SESSION is not documented
mod/labelwithgroup/classes/slide.php
(#168) Variable slide::$_SESSION is not documented
mod/labelwithgroup/db/upgrade.php
(#30) Phpdocs for function xmldb_labelwithgroup_upgrade has incomplete parameters list
mod/labelwithgroup/mod_form.php
(#133) Phpdocs for function mod_labelwithgroup_mod_form::data_preprocessing has incomplete parameters list
(#160) Phpdocs for function mod_labelwithgroup_mod_form::data_postprocessing has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "gherkinlint" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(1 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

mod/labelwithgroup/tests/behat/labelwithgroup_notemplate.feature
(#3) Multiple empty lines are not allowed