Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(15 errors, 7 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/hvp/classes/editor_ajax.php
(#149) Public method name "editor_ajax::getTranslations" must be in lower-case letters only
(#149) Variable "language_code" must not contain underscores.
(#155) Variable "parsedLib" must be all lower-case
(#167) Variable "parsedLib" must be all lower-case
(#168) Variable "parsedLib" must be all lower-case
(#169) Variable "parsedLib" must be all lower-case
(#170) Variable "language_code" must not contain underscores.
mod/hvp/classes/editor_framework.php
(#176) Line indented incorrectly; expected at least 16 spaces, found 15
(#331) Public method name "editor_framework::getAvailableLanguages" must be in lower-case letters only
(#331) Variable "machineName" must be all lower-case
(#331) Variable "majorVersion" must be all lower-case
(#331) Variable "minorVersion" must be all lower-case
(#343) Variable "machineName" must be all lower-case
(#344) Variable "majorVersion" must be all lower-case
(#345) Variable "minorVersion" must be all lower-case
mod/hvp/classes/framework.php
(#1574) Inline comments must end in full-stops, exclamation marks, or question marks
mod/hvp/classes/mobile_auth.php
(#74) Inline comments must end in full-stops, exclamation marks, or question marks
(#105) Inline comments must end in full-stops, exclamation marks, or question marks
mod/hvp/classes/results.php
(#183) Inline comments must end in full-stops, exclamation marks, or question marks
mod/hvp/embed.php
(#74) Line exceeds 132 characters; contains 134 characters
mod/hvp/locallib.php
(#64) Line exceeds 132 characters; contains 138 characters
mod/hvp/mod_form.php
(#374) Line exceeds 132 characters; contains 157 characters

Javascript coding style problems

(1 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/hvp/editor.js
(#26) Parsing error: The keyword 'const' is reserved

CSS problems

(1 errors, 10 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/hvp/styles.css
(#2) Expected "#E5E5E5" to be "#e5e5e5" (color-hex-case)
(#19) Expected "#32373C" to be "#32373c" (color-hex-case)
(#26) Expected "#E1E1E1" to be "#e1e1e1" (color-hex-case)
(#30) Expected "#E1E1E1" to be "#e1e1e1" (color-hex-case)
(#35) Expected "#F9F9F9" to be "#f9f9f9" (color-hex-case)
(#85) Expected indentation of 4 spaces (indentation)
mod/hvp/xapi-custom-report.css
(#2) Expected "#FFF" to be "#fff" (color-hex-case)
(#3) Expected "#C9C9C9" to be "#c9c9c9" (color-hex-case)
(#5) Expected "#5C5C5C" to be "#5c5c5c" (color-hex-case)
(#35) Expected "#F3F3F3" to be "#f3f3f3" (color-hex-case)
(#36) Expected "#DFDFDF" to be "#dfdfdf" (color-hex-case)

PHPDocs style problems

(228 errors, 4 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/hvp/backup/moodle2/restore_hvp_stepslib.php
(#61) Phpdocs for function restore_hvp_activity_structure_step::process_hvp has incomplete parameters list
(#85) Phpdocs for function restore_hvp_activity_structure_step::process_content_user_data has incomplete parameters list
(#185) Phpdocs for function restore_hvp_libraries_structure_step::process_hvp_library has incomplete parameters list
(#220) Phpdocs for function restore_hvp_libraries_structure_step::process_hvp_library_translation has incomplete parameters list
(#249) Phpdocs for function restore_hvp_libraries_structure_step::process_hvp_library_dependency has incomplete parameters list
(#297) Phpdocs for function restore_hvp_libraries_structure_step::get_library_id has incomplete parameters list
(#336) Phpdocs for function restore_hvp_libraries_structure_step::update_missing_dependencies has incomplete parameters list
mod/hvp/classes/content_user_data.php
(#75) Phpdocs for function content_user_data::store_data has incomplete parameters list
(#125) Phpdocs for function content_user_data::fetch_existing_data has incomplete parameters list
(#140) Phpdocs for function content_user_data::get_user_data has incomplete parameters list
(#164) Phpdocs for function content_user_data::save_user_data has incomplete parameters list
(#210) Phpdocs for function content_user_data::delete_user_data has incomplete parameters list
(#230) Phpdocs for function content_user_data::load_pre_loaded_user_data has incomplete parameters list
mod/hvp/classes/editor_ajax.php
(#49) Function editor_ajax::getLatestLibraryVersions is not documented
(#87) Function editor_ajax::getContentTypeCache is not documented
(#109) Function editor_ajax::getAuthorsRecentlyUsedLibraries is not documented
(#136) Function editor_ajax::validateEditorToken is not documented
(#31) No one-line description found in phpdocs for class editor_ajax
mod/hvp/classes/editor_framework.php
(#55) Function editor_framework::getLanguage is not documented
(#83) Function editor_framework::keepFile is not documented
(#106) Function editor_framework::getLibraries is not documented
(#220) Function editor_framework::alterLibraryFiles is not documented
(#254) Function editor_framework::saveFileTemporarily is not documented
(#293) Function editor_framework::markFileForCleanup is not documented
(#313) Function editor_framework::removeTemporarilySavedFiles is not documented
(#33) No one-line description found in phpdocs for class editor_framework
mod/hvp/classes/event.php
(#29) Class event is not documented
(#66) Function event::saveStats is not documented
(#30) Variable event::$user is not documented
(#17) No one-line description found in phpdocs for file
(#32) There is no description in phpdocs for function __construct
(#32) Phpdocs for function event::__construct has incomplete parameters list
(#33) Invalid phpdocs tag @inheritdoc used
(#63) Invalid phpdocs tag @inheritdoc used
mod/hvp/classes/event/course_module_instance_list_viewed.php
(#21) Invalid inline phpdocs tag @copyright found
(#33) Invalid inline phpdocs tag @copyright found
mod/hvp/classes/event/course_module_viewed.php
(#21) Invalid inline phpdocs tag @copyright found
(#33) Invalid inline phpdocs tag @copyright found
mod/hvp/classes/file_storage.php
(#49) Function file_storage::saveLibrary is not documented
(#76) Function file_storage::saveContent is not documented
(#101) Function file_storage::deleteContent is not documented
(#110) Function file_storage::cloneContent is not documented
(#120) Function file_storage::getTmpPath is not documented
(#135) Function file_storage::exportContent is not documented
(#150) Function file_storage::exportLibrary is not documented
(#165) Function file_storage::saveExport is not documented
(#194) Function file_storage::getExportFile is not documented
(#209) Function file_storage::deleteExport is not documented
(#224) Function file_storage::hasExport is not documented
(#238) Function file_storage::cacheAssets is not documented
(#301) Function file_storage::getCachedAssets is not documented
(#333) Function file_storage::deleteCachedAssets is not documented
(#351) Function file_storage::getContent is not documented
(#382) Function file_storage::saveFile is not documented
(#419) Function file_storage::cloneContentFile is not documented
(#470) Function file_storage::getContentFile is not documented
(#483) Function file_storage::removeContentFile is not documented
(#500) Function file_storage::readFileTree is not documented
(#539) Function file_storage::exportFileTree is not documented
(#575) Function file_storage::deleteFileTree is not documented
(#606) Function file_storage::getFile is not documented
(#633) Function file_storage::getFilepath is not documented
(#644) Function file_storage::getFilename is not documented
(#658) Function file_storage::fileExists is not documented
(#671) Function file_storage::hasWriteAccess is not documented
(#697) Function file_storage::moveContentDirectory is not documented
(#749) Function file_storage::moveFile is not documented
(#811) Function file_storage::moveFileTree is not documented
(#839) Function file_storage::hasPresave is not documented
(#853) Function file_storage::getUpgradeScript is not documented
(#29) Invalid phpdocs tag @SuppressWarnings(PHPMD.TooManyPublicMethods) used
(#29) Invalid phpdocs tag @SuppressWarnings(PHPMD.ExcessiveClassComplexity) used
(#107) Invalid phpdocs tag @inheritdoc used
(#348) Invalid phpdocs tag @inheritdoc used
(#651) Not recommended phpdocs tag @method used
mod/hvp/classes/framework.php
(#145) Function framework::getPlatformInfo is not documented
(#159) Function framework::fetchExternalData is not documented
(#194) Function framework::setLibraryTutorialUrl is not documented
(#207) Function framework::setErrorMessage is not documented
(#217) Function framework::setInfoMessage is not documented
(#264) Function framework::printMessages is not documented
(#276) Function framework::getMessages is not documented
(#480) Function framework::getH5pPath is not documented
(#490) Function framework::getLibraryFileUrl is not documented
(#501) Function framework::getUploadedH5pFolderPath is not documented
(#519) Function framework::getUploadedH5pPath is not documented
(#533) Function framework::loadLibraries is not documented
(#554) Function framework::setUnsupportedLibraries is not documented
(#562) Function framework::getUnsupportedLibraries is not documented
(#570) Function framework::getAdminUrl is not documented
(#578) Function framework::getLibraryId is not documented
(#617) Function framework::isPatchedLibrary is not documented
(#646) Function framework::isInDevMode is not documented
(#654) Function framework::mayUpdateLibraries is not documented
(#687) Function framework::getLibraryUsage is not documented
(#718) Function framework::getLibraryContentCount is not documented
(#749) Function framework::saveLibraryData is not documented
(#848) Function framework::pathsToCsv is not documented
(#863) Function framework::lockDependencyStorage is not documented
(#871) Function framework::unlockDependencyStorage is not documented
(#879) Function framework::deleteLibrary is not documented
(#899) Function framework::saveLibraryDependencies is not documented
(#923) Function framework::updateContent is not documented
(#973) Function framework::insertContent is not documented
(#981) Function framework::resetContentUserData is not documented
(#996) Function framework::getWhitelist is not documented
(#1004) Function framework::copyLibraryUsage is not documented
(#1022) Function framework::loadLibrarySemantics is not documented
(#1040) Function framework::alterLibrarySemantics is not documented
(#1053) Function framework::loadContent is not documented
(#1150) Function framework::loadContentDependencies is not documented
(#1189) Function framework::getOption is not documented
(#1201) Function framework::setOption is not documented
(#1209) Function framework::updateContentFields is not documented
(#1226) Function framework::deleteLibraryDependencies is not documented
(#1236) Function framework::deleteContentData is not documented
(#1253) Function framework::deleteLibraryUsage is not documented
(#1263) Function framework::saveLibraryUsage is not documented
(#1290) Function framework::loadLibrary is not documented
(#1337) Function framework::clearFilteredParameters is not documented
(#1347) Function framework::getNumNotFiltered is not documented
(#1360) Function framework::getNumContent is not documented
(#1373) Function framework::isContentSlugAvailable is not documented
(#1383) Function framework::saveCachedAssets is not documented
(#1399) Function framework::deleteCachedAssets is not documented
(#1423) Function framework::getLibraryStats is not documented
(#1449) Function framework::getNumAuthors is not documented
(#1463) Function framework::afterExportCreated is not documented
(#1474) Function framework::hasPermission is not documented
(#1515) Function framework::replaceContentTypeCache is not documented
(#1551) Function framework::loadAddons is not documented
(#1588) Function framework::getLibraryConfig is not documented
(#1597) Function framework::libraryHasUpgrade is not documented
(#280) Phpdocs for function framework::t has incomplete parameters list
(#34) Invalid phpdocs tag @SuppressWarnings(PHPMD) used
(#156) Invalid phpdocs tag @inheritdoc used
(#551) Invalid phpdocs tag @inheritdoc used
(#575) Invalid phpdocs tag @inheritdoc used
(#896) Invalid phpdocs tag @inheritdoc used
(#920) Invalid phpdocs tag @inheritdoc used
(#970) Invalid phpdocs tag @inheritdoc used
(#978) Invalid phpdocs tag @inheritdoc used
(#993) Invalid phpdocs tag @inheritdoc used
(#1001) Invalid phpdocs tag @inheritdoc used
(#1019) Invalid phpdocs tag @inheritdoc used
(#1037) Invalid phpdocs tag @inheritdoc used
(#1186) Invalid phpdocs tag @inheritdoc used
(#1260) Invalid phpdocs tag @inheritdoc used
(#1460) Invalid phpdocs tag @inheritdoc used
(#1468) Not recommended phpdocs tag @method used
mod/hvp/classes/mobile_auth.php
(#29) Class mobile_auth is not documented
(#31) Constant mobile_auth::VALID_TIME is not documented
(#83) Phpdocs for function mobile_auth::has_valid_token has incomplete parameters list
mod/hvp/classes/output/mobile.php
(#17) File-level phpdocs block is not found
(#24) Class mobile is not documented
(#26) Function mobile::mobile_course_view is not documented
(#24) Package is not specified for class mobile. It is also not specified in file-level phpdocs
mod/hvp/classes/privacy/provider.php
(#218) Phpdocs for function provider::get_exportable_content_user_data has incomplete parameters list
(#264) Phpdocs for function provider::get_exportable_xapi_results has incomplete parameters list
(#345) Phpdocs for function provider::get_exportable_events has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
(#31) Class provider does not have @copyright tag
(#17) File-level phpdocs block does not have @license tag
(#31) Class provider does not have @license tag
(#31) Package is not specified for class provider. It is also not specified in file-level phpdocs
mod/hvp/classes/results.php
(#39) Variable results::$contentid is not documented
(#42) Variable results::$offset is not documented
(#42) Variable results::$limit is not documented
(#42) Variable results::$orderby is not documented
(#42) Variable results::$orderdir is not documented
(#42) Variable results::$filters is not documented
(#119) Phpdocs for function results::get_human_readable_results has incomplete parameters list
(#372) Phpdocs for function results::get_sql_results has incomplete parameters list
mod/hvp/classes/task/look_for_updates.php
(#36) Function look_for_updates::get_name is not documented
(#40) Function look_for_updates::execute is not documented
mod/hvp/classes/task/remove_old_auth_tokens.php
(#39) Function remove_old_auth_tokens::get_name is not documented
(#43) Function remove_old_auth_tokens::execute is not documented
mod/hvp/classes/task/remove_old_log_entries.php
(#36) Function remove_old_log_entries::get_name is not documented
(#40) Function remove_old_log_entries::execute is not documented
mod/hvp/classes/task/remove_tmpfiles.php
(#36) Function remove_tmpfiles::get_name is not documented
(#40) Function remove_tmpfiles::execute is not documented
mod/hvp/classes/user_grades.php
(#36) Function user_grades::handle_ajax is not documented
(#30) Class user_grades does not have @copyright tag
(#30) Class user_grades does not have @license tag
mod/hvp/classes/view_assets.php
(#48) Function view_assets::__construct is not documented
(#245) Function view_assets::getcontent is not documented
(#37) Variable view_assets::$cm is not documented
(#38) Variable view_assets::$course is not documented
(#39) Variable view_assets::$core is not documented
(#40) Variable view_assets::$content is not documented
(#41) Variable view_assets::$jsrequires is not documented
(#42) Variable view_assets::$cssrequires is not documented
(#44) Variable view_assets::$settings is not documented
(#45) Variable view_assets::$embedtype is not documented
(#46) Variable view_assets::$files is not documented
(#120) Phpdocs for function view_assets::getexportsettings has incomplete parameters list
(#147) Phpdocs for function view_assets::getembedcode has incomplete parameters list
(#167) Phpdocs for function view_assets::getresizecode has incomplete parameters list
(#31) Class view_assets does not have @copyright tag
(#31) Class view_assets does not have @license tag
mod/hvp/classes/xapi_result.php
(#30) Class xapi_result does not have @copyright tag
(#30) Class xapi_result does not have @license tag
mod/hvp/db/install.php
(#17) File-level phpdocs block is not found
(#19) Function xmldb_hvp_install is not documented
(#19) Package is not specified for function xmldb_hvp_install. It is also not specified in file-level phpdocs
mod/hvp/db/mobile.php
(#17) File-level phpdocs block is not found
mod/hvp/db/upgrade.php
(#343) Function hvp_upgrade_2018090300 is not documented
mod/hvp/lang/ca/hvp.php
(#17) File-level phpdocs block is not found
mod/hvp/lang/de/hvp.php
(#16) File-level phpdocs block is not found
mod/hvp/lang/en/hvp.php
(#17) File-level phpdocs block is not found
mod/hvp/lang/es/hvp.php
(#16) File-level phpdocs block is not found
mod/hvp/lang/fr/hvp.php
(#17) File-level phpdocs block is not found
mod/hvp/lang/he/hvp.php
(#17) File-level phpdocs block is not found
mod/hvp/lang/no/hvp.php
(#17) File-level phpdocs block is not found
mod/hvp/lang/pt/hvp.php
(#17) File-level phpdocs block is not found
mod/hvp/lang/pt_br/hvp.php
(#17) File-level phpdocs block is not found
mod/hvp/lang/tr/hvp.php
(#17) File-level phpdocs block is not found
mod/hvp/locallib.php
(#33) Phpdocs for function hvp_get_core_settings has incomplete parameters list
(#272) Phpdocs for function hvp_restrict_library has incomplete parameters list
(#287) Phpdocs for function hvp_content_upgrade_progress has incomplete parameters list
(#286) Not recommended phpdocs tag @method used
(#388) Not recommended phpdocs tag @method used
mod/hvp/mod_form.php
(#28) Class mod_hvp_mod_form is not documented
(#30) Function mod_hvp_mod_form::definition is not documented
(#173) Function mod_hvp_mod_form::data_preprocessing is not documented
(#126) Phpdocs for function mod_hvp_mod_form::set_display_options has incomplete parameters list
(#151) Phpdocs for function mod_hvp_mod_form::set_max_grade has incomplete parameters list
(#220) Phpdocs for function mod_hvp_mod_form::validate_upload has incomplete parameters list
(#271) Phpdocs for function mod_hvp_mod_form::validate_created has incomplete parameters list
mod/hvp/renderer.php
(#27) Invalid phpdocs tag @SuppressWarnings(PHPMD) used
mod/hvp/version.php
(#17) No one-line description found in phpdocs for file
(#18) Package mod is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:scss" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 6 warnings)

This section shows problems detected in mustache templates [More info]

mod/hvp/templates/contact_site_administrator.mustache
(#1) Example context missing (@template section not found.)
mod/hvp/templates/iframe_embedding_disabled.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 4: Attribute “core-link” not allowed on element “a” at this point. (dding" in <a href="/admin/settings.php?section=httpsecurity" core-link>Site A)
mod/hvp/templates/mobile_view_page.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 6: The “frameborder” attribute on the “iframe” element is obsolete. Use CSS instead. (te;"> <iframe src="/mod/hvp/embed.php?id=&user_id=&secret=" frameborder="0" allowfullscreen="allowfullscreen"> <)
mod/hvp/templates/review.mustache
(#1) Example context missing (@template section not found.)