Prechecker results: warning


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 16 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

public/mod/grouptool/classes/group_creation_form.php
(#54) Property name "$_sortlist" should not be prefixed with an underscore to indicate visibility
public/mod/grouptool/classes/output/sortlist.php
(#56) Property name "$_options" should not be prefixed with an underscore to indicate visibility
public/mod/grouptool/locallib.php
(#194) Line exceeds 132 characters; contains 157 characters
(#239) Line exceeds 132 characters; contains 140 characters
(#404) Line exceeds 132 characters; contains 137 characters
(#4226) Inline comments must end in full-stops, exclamation marks, or question marks
(#5313) Line exceeds 132 characters; contains 138 characters
(#7415) Line exceeds 132 characters; contains 171 characters
public/mod/grouptool/tests/privacy_test.php
(#26) PHPUnit class "mod_grouptool\local\tests\privacy_test", with namespace "mod_grouptool\local\tests", currently located at "tests/" directory, does not match its expected location at "tests/local/tests"
(#62) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
(#145) Test method test_get_users_in_context() is missing any coverage information, own or at class level
(#228) Test method test_export_user_data_student() is missing any coverage information, own or at class level
(#238) Test method test_export_user_data_teacher() is missing any coverage information, own or at class level
(#248) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
(#258) Test method test_delete_data_for_user() is missing any coverage information, own or at class level
(#280) Test method test_delete_data_for_users() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 13 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

public/mod/grouptool/amd/src/administration.js
(#93) Avoid nesting promises. (promise/no-nesting)
(#111) Avoid nesting promises. (promise/no-nesting)
(#199) Expected to return a value at the end of function. (consistent-return)
(#227) Avoid nesting promises. (promise/no-nesting)
(#247) Avoid nesting promises. (promise/no-nesting)
(#365) Avoid nesting promises. (promise/no-nesting)
(#396) Avoid nesting promises. (promise/no-nesting)
(#447) Avoid nesting promises. (promise/no-nesting)
(#478) Avoid nesting promises. (promise/no-nesting)
public/mod/grouptool/amd/src/message_group_button.js
(#44) Expected catch,fail,always() or return (promise/catch-or-return)
(#45) Each then() should return a value or throw (promise/always-return)
(#48) Each then() should return a value or throw (promise/always-return)
public/mod/grouptool/amd/src/sortlist.js
(#97) Avoid nesting promises. (promise/no-nesting)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 17 warnings)

This section shows problems detected in mustache templates [More info]

public/mod/grouptool/templates/downloadoptions.mustache
(#1) HTML Validation info, line 18: Empty heading. ( <h3 class="d-flex align-self-stretch align-items-center mb-0" aria-hidden="true"> )
public/mod/grouptool/templates/registrationnotification.mustache
(#1) HTML Validation info, line 8: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( </p> <hr /> <)
(#1) HTML Validation info, line 12: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( </p> <hr /></div)
public/mod/grouptool/templates/sortlist.mustache
(#1) HTML Validation info, line 8: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="checkbox" id="mod_grouptool_select_all" title="((select%2C+grouptool))" /> )
(#1) HTML Validation info, line 34: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="checkbox" name="selected[]" title="((select%2C+grouptool))" class="checkbox_status class0 " value="3" /> )
(#1) HTML Validation info, line 40: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="name[3]" value="Awesome group #1" class="form-control"/> )
(#1) HTML Validation info, line 49: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="order[3]" value="2" class="sort_order"/> )
(#1) HTML Validation info, line 55: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="size[3]" value="5" class="form-control"/> )
(#1) HTML Validation info, line 117: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="checkbox" name="selected[]" title="((select%2C+grouptool))" class="checkbox_status class0 " value="2" /> )
(#1) HTML Validation info, line 123: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="name[2]" value="First group" class="form-control"/> )
(#1) HTML Validation info, line 132: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="order[2]" value="1" class="sort_order"/> )
(#1) HTML Validation info, line 138: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="size[2]" value="10" class="form-control"/> )
(#1) HTML Validation info, line 200: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="checkbox" name="selected[]" title="((select%2C+grouptool))" class="checkbox_status class0 " value="1" /> )
(#1) HTML Validation info, line 206: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="name[1]" value="This groups in every grouping" class="form-control"/> )
(#1) HTML Validation info, line 215: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="order[1]" value="99999" class="sort_order"/> )
(#1) HTML Validation info, line 221: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="size[1]" value="3" class="form-control"/> )
public/mod/grouptool/templates/sortlist_entry.mustache
(#1) HTML Validation error, line 10: Stray start tag “tr”. (d><body><tr class="mod_grouptool_sortlist_entry draggable_item " data-groupings="[0]" data-order="1" data-id="3" data-status="1" data-name="Awesome group #1" data-size="5" > <)
(#1) HTML Validation error, line 11: Stray start tag “td”. ( > <td class="cell c0 checkbox_container"> )
(#1) HTML Validation info, line 16: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="checkbox" name="selected[]" title="((select%2C+grouptool))" class="checkbox_status class0 " value="3" /> )
(#1) HTML Validation error, line 18: Stray end tag “td”. (/div> </td> <)
(#1) HTML Validation error, line 19: Stray start tag “td”. (</td> <td class="cell c1 buttons js_invisible" data-drag><div><)
(#1) HTML Validation error, line 19: Stray end tag “td”. ())'></div></td> <)
(#1) HTML Validation error, line 20: Stray start tag “td”. (</td> <td class="cell c1 grpname" style="text-align:left;width:20%;"> )
(#1) HTML Validation info, line 22: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="name[3]" value="Awesome group #1" class="form-control"/> )
(#1) HTML Validation info, line 31: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="order[3]" value="1" class="sort_order"/> )
(#1) HTML Validation error, line 33: Stray end tag “td”. (/div> </td> )
(#1) HTML Validation error, line 35: Stray start tag “td”. ( <td class="cell c3 size addfield"> )
(#1) HTML Validation info, line 37: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <input type="hidden" name="size[3]" value="5" class="form-control"/> )
(#1) HTML Validation error, line 46: Stray end tag “td”. (> </td> <)
(#1) HTML Validation error, line 47: Stray start tag “td”. (</td> <td class="cell c4 mod_grouptool_sortlist_active_buttons"> )
(#1) HTML Validation error, line 57: Stray end tag “td”. (/div> </td> <)
(#1) HTML Validation error, line 58: Stray start tag “td”. (</td> <td class="cell c5 mod_grouptool_sortlist_entry_settings_buttons"> )
(#1) HTML Validation error, line 67: Stray end tag “td”. (/div> </td> <)
(#1) HTML Validation error, line 68: Stray start tag “td”. (</td> <td class="cell c6 buttons"> )
(#1) HTML Validation error, line 79: Attribute “disabled” not allowed on element “a” at this point. (> <a href="" data-delete class="deletebutton disabled " disabled aria-disabled="true" title="((%0A++++++++++++++++++++nodeletion%2C+grouptool%0A++++++++++++++++))" ><img )
(#1) HTML Validation info, line 79: An “aria-disabled” attribute whose value is “true” should not be specified on an “a” element that has an “href” attribute. (> <a href="" data-delete class="deletebutton disabled " disabled aria-disabled="true" title="((%0A++++++++++++++++++++nodeletion%2C+grouptool%0A++++++++++++++++))" ><img )
(#1) HTML Validation error, line 84: Stray end tag “td”. (/div> </td></tr>)
(#1) HTML Validation error, line 85: Stray end tag “tr”. ( </td></tr></bo)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]