Prechecker results: error


PHP lint problems

(2 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

mod/groupformation/lang/de/groupformation.php
BOM character found
mod/groupformation/lang/en/groupformation.php
BOM character found

PHP coding style problems

(27 errors, 4 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/groupformation/backup/moodle2/restore_groupformation_stepslib.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
mod/groupformation/classes/controller/questionnaire_controller.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/classes/grouping/participant_parser.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/classes/task/archive_activity_task.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/classes/task/build_groups_task.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/classes/util/csv_writer.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/db/install.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
mod/groupformation/db/tasks.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/db/uninstall.php
(#31) Expected MOODLE_INTERNAL check or config.php inclusion
mod/groupformation/grade.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
mod/groupformation/lang/de/groupformation.php
(#1) The first thing in a PHP file must be the <?php tag.
mod/groupformation/lang/en/groupformation.php
(#1) The first thing in a PHP file must be the <?php tag.
mod/groupformation/templates/analysis_statistics.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/analysis_status.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/grouping_generated_groups.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/grouping_incomplete_groups.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/grouping_no_data.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/grouping_settings.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/grouping_statistics.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/student_import_form_footer.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/student_import_form_header.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/student_import_result.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/students_overview_options.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/students_overview_survey_states.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/wrapper_analysis.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/wrapper_grouping.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/wrapper_student_evaluation.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/wrapper_student_groupview.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/wrapper_student_import_export.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/wrapper_students_overview.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
mod/groupformation/templates/wrapper_teacher_export.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.

Javascript coding style problems

(0 errors, 332 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

mod/groupformation/js/settings_functions.js
(#59) Confusing use of '!'.
(#74) 'loadGroupformationSettings' was used before it was defined.
(#77) Use '!==' to compare with '0'.
(#129) 'lines' is already defined.
(#135) 'i' is already defined.
(#135) 'l' is already defined.
(#152) Use '!==' to compare with '0'.
(#185) Confusing use of '!'.
(#368) Use '===' to compare with ''.
(#368) Confusing use of '!'.
(#378) Use '===' to compare with ''.
(#378) Confusing use of '!'.
(#445) Use '===' to compare with '0'.
(#447) Use '===' to compare with '0'.
(#450) Use '===' to compare with '0'.
(#463) Use '===' to compare with ''.
(#463) Confusing use of '!'.
(#479) Expected an assignment or function call and instead saw an expression.
(#479) Missing semicolon.
(#9) '$' is not defined.
(#12) '$' is not defined.
(#14) '$' is not defined.
(#16) '$' is not defined.
(#17) '$' is not defined.
(#19) '$' is not defined.
(#25) '$' is not defined.
(#28) '$' is not defined.
(#31) '$' is not defined.
(#32) '$' is not defined.
(#40) '$' is not defined.
(#41) '$' is not defined.
(#42) '$' is not defined.
(#45) '$' is not defined.
(#46) '$' is not defined.
(#49) '$' is not defined.
(#50) '$' is not defined.
(#51) '$' is not defined.
(#59) '$' is not defined.
(#61) '$' is not defined.
(#63) '$' is not defined.
(#64) '$' is not defined.
(#66) '$' is not defined.
(#68) '$' is not defined.
(#69) '$' is not defined.
(#70) '$' is not defined.
(#71) '$' is not defined.
(#77) '$' is not defined.
(#78) '$' is not defined.
(#79) '$' is not defined.
(#81) '$' is not defined.
(#82) '$' is not defined.
(#82) '$' is not defined.
(#83) '$' is not defined.
(#85) '$' is not defined.
(#86) '$' is not defined.
(#86) '$' is not defined.
(#87) '$' is not defined.
(#89) '$' is not defined.
(#90) '$' is not defined.
(#90) '$' is not defined.
(#91) '$' is not defined.
(#92) '$' is not defined.
(#94) '$' is not defined.
(#98) '$' is not defined.
(#103) '$' is not defined.
(#104) '$' is not defined.
(#105) '$' is not defined.
(#106) '$' is not defined.
(#109) '$' is not defined.
(#110) '$wrapper' is not defined.
(#110) '$' is not defined.
(#111) '$cat' is not defined.
(#112) '$' is not defined.
(#113) '$wrapper' is not defined.
(#113) '$cat' is not defined.
(#117) '$wrapper' is not defined.
(#117) '$cat' is not defined.
(#119) '$wrapper' is not defined.
(#119) '$cat' is not defined.
(#123) '$' is not defined.
(#124) '$' is not defined.
(#125) '$' is not defined.
(#126) '$' is not defined.
(#129) '$' is not defined.
(#130) '$wrapper' is not defined.
(#130) '$' is not defined.
(#131) '$cat' is not defined.
(#132) '$' is not defined.
(#133) '$wrapper' is not defined.
(#133) '$cat' is not defined.
(#137) '$wrapper' is not defined.
(#137) '$cat' is not defined.
(#139) '$wrapper' is not defined.
(#139) '$cat' is not defined.
(#142) '$' is not defined.
(#145) '$' is not defined.
(#146) '$' is not defined.
(#148) '$' is not defined.
(#152) '$' is not defined.
(#153) '$' is not defined.
(#155) '$' is not defined.
(#156) '$' is not defined.
(#158) '$' is not defined.
(#159) '$' is not defined.
(#160) '$' is not defined.
(#160) '$' is not defined.
(#162) '$' is not defined.
(#163) '$' is not defined.
(#165) '$' is not defined.
(#166) '$' is not defined.
(#169) '$' is not defined.
(#169) '$' is not defined.
(#170) '$' is not defined.
(#171) '$' is not defined.
(#174) '$' is not defined.
(#175) '$' is not defined.
(#184) '$' is not defined.
(#185) '$' is not defined.
(#186) '$' is not defined.
(#190) '$' is not defined.
(#191) '$' is not defined.
(#197) '$' is not defined.
(#199) '$' is not defined.
(#199) '$' is not defined.
(#201) '$' is not defined.
(#202) '$' is not defined.
(#206) '$' is not defined.
(#207) '$' is not defined.
(#207) '$' is not defined.
(#209) '$' is not defined.
(#210) '$' is not defined.
(#215) '$' is not defined.
(#216) '$' is not defined.
(#216) '$' is not defined.
(#218) '$' is not defined.
(#219) '$' is not defined.
(#226) '$' is not defined.
(#227) '$' is not defined.
(#228) '$' is not defined.
(#229) '$' is not defined.
(#230) '$' is not defined.
(#232) '$' is not defined.
(#233) '$' is not defined.
(#234) '$' is not defined.
(#239) '$' is not defined.
(#240) '$' is not defined.
(#249) '$' is not defined.
(#250) '$' is not defined.
(#251) '$' is not defined.
(#255) '$' is not defined.
(#256) '$' is not defined.
(#259) '$' is not defined.
(#260) '$' is not defined.
(#261) '$' is not defined.
(#267) '$' is not defined.
(#268) '$' is not defined.
(#269) '$' is not defined.
(#270) '$' is not defined.
(#276) '$thisID' is not defined.
(#276) '$' is not defined.
(#277) '$theNextID' is not defined.
(#277) '$thisID' is not defined.
(#279) '$thisMultifieldID' is not defined.
(#279) '$thisID' is not defined.
(#280) '$nextMultifieldID' is not defined.
(#280) '$theNextID' is not defined.
(#283) '$' is not defined.
(#284) '$' is not defined.
(#287) '$' is not defined.
(#287) '$nextMultifieldID' is not defined.
(#289) '$' is not defined.
(#291) '$theNextID' is not defined.
(#296) '$previewRowID' is not defined.
(#299) '$' is not defined.
(#299) '$previewRowID' is not defined.
(#303) '$' is not defined.
(#303) '$previewRowID' is not defined.
(#310) '$' is not defined.
(#311) '$previewRowID' is not defined.
(#312) '$multifieldID' is not defined.
(#314) '$' is not defined.
(#314) '$previewRowID' is not defined.
(#316) '$' is not defined.
(#316) '$multifieldID' is not defined.
(#330) '$' is not defined.
(#331) '$' is not defined.
(#332) '$' is not defined.
(#335) '$' is not defined.
(#336) '$' is not defined.
(#336) '$' is not defined.
(#337) '$value' is not defined.
(#338) '$value' is not defined.
(#343) '$' is not defined.
(#344) '$theID' is not defined.
(#344) '$' is not defined.
(#345) '$theID' is not defined.
(#349) '$' is not defined.
(#350) '$previewRowID' is not defined.
(#350) '$' is not defined.
(#352) '$' is not defined.
(#352) '$previewRowID' is not defined.
(#352) '$' is not defined.
(#356) '$' is not defined.
(#356) '$previewRowID' is not defined.
(#356) '$' is not defined.
(#367) '$' is not defined.
(#368) '$' is not defined.
(#369) '$' is not defined.
(#372) '$' is not defined.
(#377) '$' is not defined.
(#378) '$' is not defined.
(#379) '$' is not defined.
(#382) '$' is not defined.
(#386) '$' is not defined.
(#389) '$' is not defined.
(#394) '$' is not defined.
(#395) '$' is not defined.
(#396) '$' is not defined.
(#408) '$' is not defined.
(#409) '$' is not defined.
(#410) '$' is not defined.
(#413) '$' is not defined.
(#414) '$' is not defined.
(#415) '$' is not defined.
(#418) '$' is not defined.
(#419) '$' is not defined.
(#420) '$' is not defined.
(#423) '$' is not defined.
(#424) '$' is not defined.
(#425) '$' is not defined.
(#428) '$' is not defined.
(#429) '$' is not defined.
(#430) '$' is not defined.
(#431) '$' is not defined.
(#432) '$' is not defined.
(#435) '$' is not defined.
(#436) '$' is not defined.
(#437) '$' is not defined.
(#453) '$' is not defined.
(#454) '$' is not defined.
(#456) '$' is not defined.
(#457) '$' is not defined.
(#462) '$' is not defined.
(#463) '$' is not defined.
(#471) '$' is not defined.
(#471) '$' is not defined.
(#472) '$' is not defined.
(#472) '$' is not defined.
(#476) '$' is not defined.
(#477) '$' is not defined.
(#478) '$' is not defined.
(#479) '$' is not defined.
(#479) 'ne' is not defined.
(#481) '$' is not defined.
(#482) '$' is not defined.
(#483) '$' is not defined.
(#484) '$' is not defined.
(#484) '$' is not defined.
(#486) '$' is not defined.
(#487) '$' is not defined.
(#488) '$' is not defined.
(#490) '$' is not defined.
(#491) '$' is not defined.
(#492) '$' is not defined.
(#494) '$' is not defined.
(#495) '$' is not defined.
(#496) '$' is not defined.
(#501) '$' is not defined.
(#502) '$' is not defined.
(#502) '$' is not defined.
(#505) '$' is not defined.
(#506) '$' is not defined.
(#506) '$' is not defined.
(#509) '$' is not defined.
(#510) '$' is not defined.
(#511) '$' is not defined.
(#513) '$' is not defined.
(#517) '$' is not defined.
(#518) '$' is not defined.
(#519) '$' is not defined.
(#521) '$' is not defined.
(#30) 'ui' is defined but never used.
(#30) 'event' is defined but never used.
(#41) 'i' is defined but never used.
(#45) 'i' is defined but never used.
(#386) 'e' is defined but never used.
mod/groupformation/js/survey_functions.js
(#73) Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function.
(#9) '$' is not defined.
(#11) '$' is not defined.
(#14) '$' is not defined.
(#16) '$' is not defined.
(#20) '$' is not defined.
(#21) '$' is not defined.
(#24) '$' is not defined.
(#26) '$' is not defined.
(#29) '$' is not defined.
(#30) '$' is not defined.
(#31) '$' is not defined.
(#36) '$' is not defined.
(#41) '$' is not defined.
(#42) '$' is not defined.
(#43) '$' is not defined.
(#48) '$' is not defined.
(#49) '$' is not defined.
(#52) '$' is not defined.
(#53) '$' is not defined.
(#54) '$' is not defined.
(#55) '$' is not defined.
(#56) '$' is not defined.
(#57) '$' is not defined.
(#61) '$' is not defined.
(#64) '$' is not defined.
(#67) '$' is not defined.
(#74) '$' is not defined.
(#75) '$' is not defined.
(#76) '$' is not defined.
(#83) '$' is not defined.
(#84) '$' is not defined.
(#84) '$' is not defined.
(#88) '$' is not defined.
(#89) '$' is not defined.
(#95) '$' is not defined.
(#96) '$' is not defined.
(#97) '$' is not defined.
(#101) '$' is not defined.
(#102) '$' is not defined.
(#103) '$' is not defined.
(#14) 'i' is defined but never used.
(#64) 'data' is defined but never used.
(#63) 'ui' is defined but never used.
(#63) 'event' is defined but never used.
(#88) 'i' is defined but never used.

CSS problems

(1 errors, 13 warnings)

This section shows CSS problems detected by csslint [More info]

mod/groupformation/styles.css
(#30) Use of !important
(#153) Use of !important
(#211) Use of !important
(#333) Expected (normal | italic | oblique | inherit) but found 'none'.
(#406) float can't be used with display: inline-block.
(#436) Use of !important
(#610) Use of !important
(#651) Use of !important
(#678) Use of !important
(#679) Use of !important
(#680) Use of !important
(#683) Use of !important
(#694) Duplicate property 'border' found.
(#744) Use of !important

PHPDocs style problems

(50 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/groupformation/backup/moodle2/backup_groupformation_activity_task.class.php
(#16) File-level phpdocs block does not have @copyright tag
mod/groupformation/backup/moodle2/backup_groupformation_stepslib.php
(#16) File-level phpdocs block does not have @copyright tag
(#26) Class backup_groupformation_activity_structure_step does not have @copyright tag
mod/groupformation/backup/moodle2/restore_groupformation_activity_task.class.php
(#16) File-level phpdocs block does not have @copyright tag
(#27) Class restore_groupformation_activity_task does not have @copyright tag
mod/groupformation/backup/moodle2/restore_groupformation_stepslib.php
(#16) File-level phpdocs block does not have @copyright tag
(#25) Class restore_groupformation_activity_structure_step does not have @copyright tag
mod/groupformation/classes/controller/analysis_controller.php
(#68) Phpdocs for function mod_groupformation_analysis_controller::__construct has incomplete parameters list
(#83) Phpdocs for function mod_groupformation_analysis_controller::trigger_questionnaire has incomplete parameters list
mod/groupformation/classes/controller/evaluation_controller.php
(#59) Phpdocs for function mod_groupformation_evaluation_controller::__construct has incomplete parameters list
(#74) Phpdocs for function mod_groupformation_evaluation_controller::render has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
(#22) Invalid phpdocs tag @coppyright used
mod/groupformation/classes/controller/grouping_controller.php
(#88) Phpdocs for function mod_groupformation_grouping_controller::__construct has incomplete parameters list
(#155) Phpdocs for function mod_groupformation_grouping_controller::start has incomplete parameters list
(#414) Phpdocs for function mod_groupformation_grouping_controller::get_scroll_to_link has incomplete parameters list
(#469) Phpdocs for function mod_groupformation_grouping_controller::get_group_members has incomplete parameters list
mod/groupformation/classes/controller/import_export_controller.php
(#62) Phpdocs for function mod_groupformation_import_export_controller::__construct has incomplete parameters list
(#76) Phpdocs for function mod_groupformation_import_export_controller::generate_answers_url has incomplete parameters list
(#119) Phpdocs for function mod_groupformation_import_export_controller::render_overview has incomplete parameters list
(#167) Phpdocs for function mod_groupformation_import_export_controller::render_form has incomplete parameters list
(#187) Phpdocs for function mod_groupformation_import_export_controller::render_result has incomplete parameters list
mod/groupformation/classes/controller/logging_controller.php
(#42) Phpdocs for function mod_groupformation_logging_controller::handle has incomplete parameters list
(#59) Phpdocs for function mod_groupformation_logging_controller::create_log_entry has incomplete parameters list
mod/groupformation/classes/controller/questionnaire_controller.php
(#79) Phpdocs for function mod_groupformation_questionnaire_controller::__construct has incomplete parameters list
(#329) Phpdocs for function mod_groupformation_questionnaire_controller::prepare_question has incomplete parameters list
mod/groupformation/classes/controller/student_group_view_controller.php
(#17) No one-line description found in phpdocs for file
(#53) Phpdocs for function mod_groupformation_student_group_view_controller::__construct has incomplete parameters list
(#66) Phpdocs for function mod_groupformation_student_group_view_controller::render has incomplete parameters list
mod/groupformation/classes/controller/student_overview_controller.php
(#88) Phpdocs for function mod_groupformation_student_overview_controller::__construct has incomplete parameters list
mod/groupformation/classes/grouping/criterion_calculator.php
(#59) Phpdocs for function mod_groupformation_criterion_calculator::__construct has incomplete parameters list
(#136) Phpdocs for function mod_groupformation_criterion_calculator::get_knowledge has incomplete parameters list
(#250) Phpdocs for function mod_groupformation_criterion_calculator::filter_criteria_specs has incomplete parameters list
(#343) Phpdocs for function mod_groupformation_criterion_calculator::filter_criterion_specs_for_eval has incomplete parameters list
mod/groupformation/classes/moodle_interface/groups_manager.php
(#60) Phpdocs for function mod_groupformation_groups_manager::assign_user_to_group has incomplete parameters list
(#80) Phpdocs for function mod_groupformation_groups_manager::get_topic_name has incomplete parameters list
(#97) Phpdocs for function mod_groupformation_groups_manager::create_group has incomplete parameters list
(#222) Phpdocs for function mod_groupformation_groups_manager::has_group has incomplete parameters list
(#309) Phpdocs for function mod_groupformation_groups_manager::get_users_for_generated_group has incomplete parameters list
mod/groupformation/classes/moodle_interface/job_manager.php
(#117) Phpdocs for function mod_groupformation_job_manager::set_job has incomplete parameters list
(#658) Phpdocs for function mod_groupformation_job_manager::create_groups has incomplete parameters list
mod/groupformation/classes/util/template_builder.php
(#31) Invalid inline phpdocs tag @package found
mod/groupformation/classes/util/xml_loader.php
(#32) Class mod_groupformation_xml_loader does not have @copyright tag
mod/groupformation/grade.php
(#17) File-level phpdocs block does not have @copyright tag
mod/groupformation/lang/de/groupformation.php
(#2) Empty line found after PHP open tag
(#1) File-level phpdocs block is not found
mod/groupformation/lang/en/groupformation.php
(#2) Empty line found after PHP open tag
(#1) File-level phpdocs block is not found
mod/groupformation/lib.php
(#74) Phpdocs for function groupformation_add_instance has incomplete parameters list
(#203) Phpdocs for function groupformation_user_outline has incomplete parameters list
(#338) Phpdocs for function groupformation_scale_used_anywhere has incomplete parameters list
(#460) Phpdocs for function groupformation_pluginfile has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]