Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(520 errors, 228 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/goone/backup/moodle2/backup_goone_stepslib.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#47) Short array syntax must be used to define arrays; (#48) Short array syntax must be used to define arrays; (#59) Short array syntax must be used to define arrays; (#60) Short array syntax must be used to define arrays; (#69) Short array syntax must be used to define arrays; (#73) Short array syntax must be used to define arrays
mod/goone/backup/moodle2/restore_goone_activity_task.class.php: (#58) Short array syntax must be used to define arrays; (#67) Short array syntax must be used to define arrays; (#75) Short array syntax must be used to define arrays; (#83) Short array syntax must be used to define arrays
mod/goone/backup/moodle2/restore_goone_stepslib.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#43) Short array syntax must be used to define arrays
mod/goone/bulk.php: (#1) End of line character is invalid; expected "\n" but found "\r\n"; (#46) Short array syntax must be used to define arrays; (#46) Line exceeds maximum limit of 180 characters; contains 218 characters; (#48) Short array syntax must be used to define arrays
mod/goone/classes/completion/custom_completion.php: (#23) Missing @copyright tag; (#47) Short array syntax must be used to define arrays; (#74) There should be a comma after the last array item in a multi-line array.
mod/goone/classes/privacy/provider.php: (#37) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#60) There must not be a space before the colon in a return type declaration; (#82) There must not be a space before the colon in a return type declaration
mod/goone/classes/settings/admin_setting_clientid_with_token_validator.php: (#33) Missing docblock for class admin_setting_clientid_with_token_validator; (#35) Missing docblock for function write_setting; (#40) Missing docblock for function output_html
mod/goone/classes/settings/setting_statictext.php: (#1) DocBlock missing a @package tag for file setting_statictext.php. Expected @package mod_goone; (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/goone/classes/task/check_mark_completion.php: (#1) End of line character is invalid; expected "\n" but found "\r\n"; (#46) No space found before comment text; expected "// Local internal completion checks." but found "//Local internal completion checks."; (#49) Expected 1 space before "=>"; 0 found; (#49) Expected 1 space after "=>"; 0 found; (#52) No space found before comment text; expected "// Get moodle course module completion record." but found "//Get moodle course module completion record."; (#53) Expected 1 space before "=>"; 0 found; (#53) Expected 1 space after "=>"; 0 found; (#54) Expected 1 space before "=>"; 0 found; (#54) Expected 1 space after "=>"; 0 found; (#55) Expected 1 space before "=>"; 0 found; (#55) Expected 1 space after "=>"; 0 found; (#56) Expected 1 space before "=>"; 0 found; (#56) Expected 1 space after "=>"; 0 found; (#56) Expected 1 space before "=>"; 0 found; (#56) Expected 1 space after "=>"; 0 found; (#58) Expected 1 space before "=>"; 0 found; (#58) Expected 1 space after "=>"; 0 found; (#58) Expected 1 space before "=>"; 0 found; (#58) Expected 1 space after "=>"; 0 found; (#60) No space found before comment text; expected "// If record completed in activity tables and not in" but found "//If record completed in activity tables and not in"; (#61) No space found before comment text; expected "// course module completion then mark it as complete in moodle." but found "//course module completion then mark it as complete in moodle."; (#62) Expected "if (...) {\n"; found "if(...){\n"; (#65) No space found before comment text; expected "// Set timemodified from goone completion table." but found "//Set timemodified from goone completion table."; (#68) No space found before comment text; expected "// Set timemodified as current timestamp as correct timemodified date not found." but found "//Set timemodified as current timestamp as correct timemodified date not found."; (#75) No space found before comment text; expected "// Check viewed and mark it." but found "//Check viewed and mark it."; (#77) Expected 1 space before "=>"; 0 found; (#77) Expected 1 space after "=>"; 0 found; (#77) Expected 1 space before "=>"; 0 found; (#77) Expected 1 space after "=>"; 0 found; (#81) No space found before comment text; expected "// Set timemodified from goone completion table." but found "//Set timemodified from goone completion table."; (#84) No space found before comment text; expected "// Set timemodified as current timestamp as correct timemodified date not found." but found "//Set timemodified as current timestamp as correct timemodified date not found."; (#94) No space found before comment text; expected "// Check viewed and mark it." but found "//Check viewed and mark it."; (#96) Expected 1 space before "=>"; 0 found; (#96) Expected 1 space after "=>"; 0 found; (#96) Expected 1 space before "=>"; 0 found; (#96) Expected 1 space after "=>"; 0 found; (#100) No space found before comment text; expected "// Set timemodified from goone completion table." but found "//Set timemodified from goone completion table."; (#103) No space found before comment text; expected "// Set timemodified as current timestamp as correct timemodified date not found." but found "//Set timemodified as current timestamp as correct timemodified date not found."; (#114) Expected 1 space before "=>"; 0 found; (#114) Expected 1 space after "=>"; 0 found; (#115) Expected 1 space before "=>"; 0 found; (#115) Expected 1 space after "=>"; 0 found; (#116) Expected 1 space before "=>"; 0 found; (#116) Expected 1 space after "=>"; 0 found; (#117) Expected 1 space before "=>"; 0 found; (#117) Expected 1 space after "=>"; 0 found; (#117) Expected 1 space before "=>"; 0 found; (#117) Expected 1 space after "=>"; 0 found; (#131) Inline comments must end in full-stops, exclamation marks, or question marks; (#131) No space found before comment text; expected "// API completion checks" but found "//API completion checks"; (#133) No space found before comment text; expected "// Get enrolments for all the user in all goone lo_ids." but found "//Get enrolments for all the user in all goone lo_ids."; (#138) Expected 1 space before "=>"; 0 found; (#138) Expected 1 space after "=>"; 0 found; (#140) No space found before comment text; expected "// Get enrolments completed from goone." but found "//Get enrolments completed from goone."; (#141) Expected 1 space before "=>"; 0 found; (#141) Expected 1 space after "=>"; 0 found; (#141) Expected 1 space before "=>"; 0 found; (#141) Expected 1 space after "=>"; 0 found; (#141) Line exceeds 132 characters; contains 155 characters; (#142) No space found before comment text; expected "// Get course module." but found "//Get course module."; (#143) Expected 1 space before "=>"; 0 found; (#143) Expected 1 space after "=>"; 0 found; (#143) Commas (,) must be followed by white space.; (#143) Expected 1 space before "=>"; 0 found; (#143) Expected 1 space after "=>"; 0 found; (#143) Commas (,) must be followed by white space.; (#143) Expected 1 space before "=>"; 0 found; (#143) Expected 1 space after "=>"; 0 found; (#145) No space found before comment text; expected "// Get user details from goone." but found "//Get user details from goone."; (#149) No space found before comment text; expected "// Search user by email, firstname and lastname and username (external_user_id)." but found "//Search user by email, firstname and lastname and username (external_user_id)."; (#150) Short array syntax must be used to define arrays; (#150) Expected 1 space before "=>"; 0 found; (#150) Expected 1 space after "=>"; 0 found; (#151) Short array syntax must be used to define arrays; (#151) Expected 1 space before "=>"; 0 found; (#151) Expected 1 space after "=>"; 0 found; (#151) Expected 1 space before "=>"; 0 found; (#151) Expected 1 space after "=>"; 0 found; (#151) Line exceeds 132 characters; contains 153 characters; (#153) Line exceeds maximum limit of 180 characters; contains 194 characters; (#157) Inline comments must end in full-stops, exclamation marks, or question marks; (#157) No space found before comment text; expected "// Search users by external id which is username" but found "//Search users by external id which is username"; (#160) Short array syntax must be used to define arrays; (#160) Expected 1 space before "=>"; 0 found; (#160) Expected 1 space after "=>"; 0 found; (#160) Line exceeds 132 characters; contains 144 characters; (#160) Whitespace found at end of line; (#162) Whitespace found at end of line; (#168) No space found before comment text; expected "// Get course module completion record, if not found" but found "//Get course module completion record, if not found"; (#169) No space found before comment text; expected "// will be created if found will be updated only if completionstatus not as 1 (completed)." but found "//will be created if found will be updated only if completionstatus not as 1 (completed)."; (#170) Expected 1 space before "=>"; 0 found; (#170) Expected 1 space after "=>"; 0 found; (#170) Expected 1 space before "=>"; 0 found; (#170) Expected 1 space after "=>"; 0 found; (#178) No space found before comment text; expected "// Check viewed and mark it." but found "//Check viewed and mark it."; (#180) Expected 1 space before "=>"; 0 found; (#180) Expected 1 space after "=>"; 0 found; (#180) Expected 1 space before "=>"; 0 found; (#180) Expected 1 space after "=>"; 0 found; (#196) No space found before comment text; expected "// Check viewed and mark it." but found "//Check viewed and mark it."; (#198) Expected 1 space before "=>"; 0 found; (#198) Expected 1 space after "=>"; 0 found; (#198) Expected 1 space before "=>"; 0 found; (#198) Expected 1 space after "=>"; 0 found
mod/goone/datamodel.php: (#38) Short array syntax must be used to define arrays; (#41) Short array syntax must be used to define arrays; (#45) Short array syntax must be used to define arrays; (#48) Short array syntax must be used to define arrays; (#58) Short array syntax must be used to define arrays
mod/goone/db/access.php: (#27) Short array syntax must be used to define arrays; (#29) Short array syntax must be used to define arrays; (#33) Short array syntax must be used to define arrays; (#35) There should be a comma after the last array item in a multi-line array.; (#37) There should be a comma after the last array item in a multi-line array.; (#39) Short array syntax must be used to define arrays; (#42) Short array syntax must be used to define arrays; (#47) There should be a comma after the last array item in a multi-line array.; (#48) There should be a comma after the last array item in a multi-line array.; (#51) Short array syntax must be used to define arrays; (#54) Short array syntax must be used to define arrays; (#55) There should be a comma after the last array item in a multi-line array.
mod/goone/db/caches.php: (#28) Short array syntax must be used to define arrays; (#29) Short array syntax must be used to define arrays; (#30) There should be a comma after the last array item in a multi-line array.; (#31) There should be a comma after the last array item in a multi-line array.
mod/goone/db/tasks.php: (#1) End of line character is invalid; expected "\n" but found "\r\n"; (#2) Line 1 of the opening comment must start "// This file is part of".; (#4) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".; (#5) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".; (#6) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".; (#7) Line 6 of the opening comment must start "// (at your option) any later version.".; (#9) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".; (#10) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".; (#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".; (#12) Line 11 of the opening comment must start "// GNU General Public License for more details.".; (#14) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".; (#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".; (#27) Short array syntax must be used to define arrays; (#28) Short array syntax must be used to define arrays; (#35) There should be a comma after the last array item in a multi-line array.; (#36) There should be a comma after the last array item in a multi-line array.
mod/goone/db/upgrade.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#49) Expected "if (...) {\n"; found "if(...){ \n"; (#49) Whitespace found at end of line; (#51) Whitespace found at end of line
mod/goone/externallib.php: (#50) Whitespace found at end of line; (#65) There should be a comma after the last array item in a multi-line array.; (#108) There should be a comma after the last array item in a multi-line array.; (#119) There should be a comma after the last array item in a multi-line array.; (#136) Line exceeds 132 characters; contains 133 characters; (#151) There should be a comma after the last array item in a multi-line array.; (#197) There should be a comma after the last array item in a multi-line array.; (#199) Whitespace found at end of line; (#208) There should be a comma after the last array item in a multi-line array.; (#219) There should be a comma after the last array item in a multi-line array.; (#243) There should be a comma after the last array item in a multi-line array.; (#249) Missing docblock for function bulk_goone_process_course_per_item; (#250) Whitespace found at end of line; (#254) Whitespace found at end of line; (#263) There should be a comma after the last array item in a multi-line array.; (#273) There should be a comma after the last array item in a multi-line array.; (#274) Line indented incorrectly; expected at least 12 spaces, found 8; (#277) Missing docblock for function bulk_goone_process_course_single_course; (#292) Whitespace found at end of line; (#293) Expected 1 space before "=>"; 0 found; (#294) There should be a comma after the last array item in a multi-line array.; (#304) There should be a comma after the last array item in a multi-line array.; (#309) Missing docblock for function bulk_goone_process_add_to_existing_course; (#309) Variable "course_section" must not contain underscores.; (#310) Variable "course_section" must not contain underscores.; (#324) Whitespace found at end of line; (#325) Expected 1 space before "=>"; 0 found; (#326) There should be a comma after the last array item in a multi-line array.; (#336) There should be a comma after the last array item in a multi-line array.
mod/goone/index.php: (#31) Short array syntax must be used to define arrays
mod/goone/lang/en/goone.php: (#102) Inline comments must end in full-stops, exclamation marks, or question marks; (#108) Expected 1 space after "="; 2 found; (#109) Expected 1 space after "="; 2 found; (#110) Expected 1 space after "="; 2 found; (#111) Expected 1 space after "="; 2 found; (#150) File must end with a newline character
mod/goone/lib.php: (#54) Short array syntax must be used to define arrays; (#76) Short array syntax must be used to define arrays; (#78) Short array syntax must be used to define arrays; (#80) There should be a comma after the last array item in a multi-line array.; (#173) Short array syntax must be used to define arrays; (#189) Short array syntax must be used to define arrays; (#193) Short array syntax must be used to define arrays; (#205) Short array syntax must be used to define arrays; (#218) Short array syntax must be used to define arrays; (#221) Short array syntax must be used to define arrays; (#265) Short array syntax must be used to define arrays; (#269) Short array syntax must be used to define arrays; (#299) Short array syntax must be used to define arrays; (#302) There should be a comma after the last array item in a multi-line array.; (#334) Short array syntax must be used to define arrays; (#377) Short array syntax must be used to define arrays; (#469) Short array syntax must be used to define arrays; (#514) Short array syntax must be used to define arrays; (#581) Short array syntax must be used to define arrays; (#586) There should be a comma after the last array item in a multi-line array.; (#640) Short array syntax must be used to define arrays; (#650) Logical operator "and" is prohibited; use "&&" instead; (#650) Logical operator "or" is prohibited; use "||" instead; (#678) Short array syntax must be used to define arrays; (#680) Short array syntax must be used to define arrays; (#734) Short array syntax must be used to define arrays; (#780) Short array syntax must be used to define arrays; (#786) Short array syntax must be used to define arrays; (#814) Inline comments must end in full-stops, exclamation marks, or question marks; (#820) Whitespace found at end of line; (#829) Variable "la_minmax" must not contain underscores.; (#829) Short array syntax must be used to define arrays; (#832) Variable "la_minmax" must not contain underscores.; (#832) Short array syntax must be used to define arrays; (#832) Expected 1 space before "=>"; 0 found; (#832) Expected 1 space after "=>"; 0 found; (#832) Commas (,) must be followed by white space.; (#832) Expected 1 space before "=>"; 0 found; (#832) Expected 1 space after "=>"; 0 found; (#835) Variable "la_minmax" must not contain underscores.; (#835) Short array syntax must be used to define arrays; (#835) Expected 1 space before "=>"; 0 found; (#835) Expected 1 space after "=>"; 0 found; (#835) Commas (,) must be followed by white space.; (#835) Expected 1 space before "=>"; 0 found; (#835) Expected 1 space after "=>"; 0 found; (#838) Variable "la_minmax" must not contain underscores.; (#838) Short array syntax must be used to define arrays; (#838) Expected 1 space before "=>"; 0 found; (#838) Expected 1 space after "=>"; 0 found; (#838) Commas (,) must be followed by white space.; (#838) Expected 1 space before "=>"; 0 found; (#838) Expected 1 space after "=>"; 0 found; (#841) Line indented incorrectly; expected at least 12 spaces, found 11; (#841) Variable "la_minmax" must not contain underscores.; (#841) Short array syntax must be used to define arrays; (#841) Expected 1 space before "=>"; 0 found; (#841) Expected 1 space after "=>"; 0 found; (#844) Variable "la_minmax" must not contain underscores.; (#863) Short array syntax must be used to define arrays; (#868) There should be a comma after the last array item in a multi-line array.; (#920) Line exceeds 132 characters; contains 161 characters; (#931) Expected 1 space before ".="; 0 found; (#931) Expected 1 space after ".="; 0 found; (#933) Line exceeds 132 characters; contains 135 characters; (#942) Logical operator "and" is prohibited; use "&&" instead; (#942) Logical operator "or" is prohibited; use "||" instead; (#993) Short array syntax must be used to define arrays; (#995) Whitespace found at end of line within string; (#996) Whitespace found at end of line within string; (#997) Whitespace found at end of line within string; (#1002) Whitespace found at end of line within string; (#1003) Whitespace found at end of line within string; (#1011) Short array syntax must be used to define arrays; (#1011) Expected 1 space before "=>"; 0 found; (#1011) Expected 1 space after "=>"; 0 found; (#1012) Variable "la_coursesections" must not contain underscores.; (#1013) Line indented incorrectly; expected 12 spaces, found 13; (#1018) Line indented incorrectly; expected at least 20 spaces, found 19; (#1021) Variable "la_coursesections" must not contain underscores.; (#1021) Short array syntax must be used to define arrays; (#1021) Expected 1 space before "=>"; 0 found; (#1021) Expected 1 space after "=>"; 0 found; (#1021) Expected 1 space before "=>"; 0 found; (#1021) Expected 1 space after "=>"; 0 found; (#1022) Line indented incorrectly; expected 12 spaces, found 13; (#1023) Variable "la_coursesections" must not contain underscores.; (#1026) Variable "la_searchresult" must not contain underscores.; (#1028) Variable "la_searchresult" must not contain underscores.; (#1042) Space found before semicolon; expected "0;" but found "0 ;"; (#1043) Expected 1 space after "="; 0 found; (#1045) Line indented incorrectly; expected 4 spaces, found 3; (#1050) Whitespace found at end of line; (#1051) Short array syntax must be used to define arrays; (#1051) Expected 1 space before "=>"; 0 found; (#1051) Expected 1 space after "=>"; 0 found; (#1051) Expected 1 space before "=>"; 0 found; (#1051) Expected 1 space after "=>"; 0 found; (#1052) Commas (,) must be followed by white space.; (#1052) Whitespace found at end of line; (#1053) Short array syntax must be used to define arrays; (#1053) Expected 1 space before "=>"; 0 found; (#1053) Expected 1 space after "=>"; 0 found; (#1053) Expected 1 space before "=>"; 0 found; (#1053) Expected 1 space after "=>"; 0 found; (#1061) Line indented incorrectly; expected 4 spaces, found 3; (#1062) Variable "la_items" must not contain underscores.; (#1063) Short array syntax must be used to define arrays; (#1064) Line indented incorrectly; expected 8 spaces, found 10; (#1064) Variable "la_items" must not contain underscores.; (#1065) Inline control structures are not allowed; (#1067) Line indented incorrectly; expected 12 spaces, found 14; (#1068) Line indented incorrectly; expected 16 spaces, found 18; (#1069) Line indented incorrectly; expected 20 spaces, found 24; (#1069) Empty IF statement detected; (#1070) Line indented incorrectly; expected 20 spaces, found 24; (#1072) Line indented incorrectly; expected 20 spaces, found 24; (#1072) Whitespace found at end of line; (#1073) Space found before semicolon; expected "id;" but found "id ;"; (#1074) Line indented incorrectly; expected 16 spaces, found 20; (#1074) Closing brace indented incorrectly; expected 18 spaces, found 20; (#1076) Line indented incorrectly; expected 16 spaces, found 20; (#1077) Line indented incorrectly; expected 12 spaces, found 14; (#1078) Line indented incorrectly; expected 8 spaces, found 7; (#1078) Closing brace indented incorrectly; expected 10 spaces, found 7; (#1079) Line indented incorrectly; expected at least 8 spaces, found 7; (#1080) Line indented incorrectly; expected 8 spaces, found 7; (#1081) Line indented incorrectly; expected at least 12 spaces, found 8; (#1081) Whitespace found at end of line; (#1082) Line indented incorrectly; expected at least 12 spaces, found 8; (#1083) Line indented incorrectly; expected at least 12 spaces, found 8; (#1083) Short array syntax must be used to define arrays; (#1083) Expected 1 space before "=>"; 0 found; (#1083) Expected 1 space after "=>"; 0 found; (#1083) Expected 1 space before "=>"; 0 found; (#1083) Expected 1 space after "=>"; 0 found; (#1083) Short array syntax must be used to define arrays; (#1083) Expected 1 space before "=>"; 0 found; (#1083) Expected 1 space after "=>"; 0 found; (#1083) Expected 1 space before "=>"; 0 found; (#1083) Expected 1 space after "=>"; 0 found; (#1083) Line exceeds maximum limit of 180 characters; contains 183 characters; (#1084) Line indented incorrectly; expected at least 12 spaces, found 8; (#1084) Commas (,) must be followed by white space.; (#1085) Line indented incorrectly; expected 8 spaces, found 7; (#1086) Line indented incorrectly; expected at least 8 spaces, found 7; (#1087) Line indented incorrectly; expected at least 8 spaces, found 7; (#1088) Closing brace indented incorrectly; expected 3 spaces, found 4; (#1099) Line indented incorrectly; expected 4 spaces, found 3; (#1104) Commas (,) must be followed by white space.; (#1104) Whitespace found at end of line; (#1105) Short array syntax must be used to define arrays; (#1105) Expected 1 space before "=>"; 0 found; (#1105) Expected 1 space after "=>"; 0 found; (#1105) Expected 1 space before "=>"; 0 found; (#1105) Expected 1 space after "=>"; 0 found; (#1106) Commas (,) must be followed by white space.; (#1106) Whitespace found at end of line; (#1107) Short array syntax must be used to define arrays; (#1107) Expected 1 space before "=>"; 0 found; (#1107) Expected 1 space after "=>"; 0 found; (#1107) Expected 1 space before "=>"; 0 found; (#1107) Expected 1 space after "=>"; 0 found; (#1113) Whitespace found at end of line; (#1115) Line indented incorrectly; expected 4 spaces, found 3; (#1116) Line indented incorrectly; expected at least 8 spaces, found 6; (#1116) Variable "la_items" must not contain underscores.; (#1117) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1117) Inline comments must end in full-stops, exclamation marks, or question marks; (#1117) Line indented incorrectly; expected at least 8 spaces, found 6; (#1117) Whitespace found at end of line; (#1118) Line indented incorrectly; expected 8 spaces, found 6; (#1119) Line indented incorrectly; expected at least 12 spaces, found 8; (#1120) Line indented incorrectly; expected 8 spaces, found 6; (#1121) Line indented incorrectly; expected 8 spaces, found 6; (#1121) Variable "la_items" must not contain underscores.; (#1122) Line indented incorrectly; expected at least 12 spaces, found 8; (#1122) Inline control structures are not allowed; (#1122) Whitespace found at end of line; (#1123) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1123) Inline comments must end in full-stops, exclamation marks, or question marks; (#1123) Line indented incorrectly; expected at least 12 spaces, found 8; (#1124) Line indented incorrectly; expected at least 12 spaces, found 8; (#1125) Line indented incorrectly; expected 12 spaces, found 8; (#1126) Line indented incorrectly; expected 16 spaces, found 12; (#1127) Line indented incorrectly; expected at least 20 spaces, found 16; (#1128) Line indented incorrectly; expected 16 spaces, found 12; (#1128) Whitespace found at end of line; (#1129) Line indented incorrectly; expected 12 spaces, found 8; (#1130) Line indented incorrectly; expected 8 spaces, found 6; (#1131) Line indented incorrectly; expected at least 8 spaces, found 6; (#1131) Short array syntax must be used to define arrays; (#1131) Expected 1 space before "=>"; 0 found; (#1131) Expected 1 space after "=>"; 0 found; (#1131) Expected 1 space before "=>"; 0 found; (#1131) Expected 1 space after "=>"; 0 found; (#1131) Line exceeds 132 characters; contains 159 characters; (#1132) Line indented incorrectly; expected at least 8 spaces, found 6; (#1132) Short array syntax must be used to define arrays; (#1132) Expected 1 space before "=>"; 0 found; (#1132) Expected 1 space after "=>"; 0 found; (#1132) Expected 1 space before "=>"; 0 found; (#1132) Expected 1 space after "=>"; 0 found; (#1132) Line exceeds 132 characters; contains 160 characters; (#1133) Line indented incorrectly; expected at least 8 spaces, found 6; (#1134) Line indented incorrectly; expected 4 spaces, found 3; (#1144) Variable "course_section" must not contain underscores.; (#1146) Variable "la_coursesection" must not contain underscores.; (#1146) Variable "course_section" must not contain underscores.; (#1147) Variable "la_selecteditemsids" must not contain underscores.; (#1149) Short array syntax must be used to define arrays; (#1149) Expected 1 space before "=>"; 0 found; (#1149) Expected 1 space after "=>"; 0 found; (#1149) Variable "la_coursesection" must not contain underscores.; (#1151) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1151) Inline comments must end in full-stops, exclamation marks, or question marks; (#1154) Variable "la_coursesection" must not contain underscores.; (#1156) Whitespace found at end of line; (#1159) Variable "la_selecteditemsids" must not contain underscores.; (#1160) Inline control structures are not allowed; (#1160) Whitespace found at end of line; (#1161) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1161) Inline comments must end in full-stops, exclamation marks, or question marks; (#1164) Variable "la_coursesection" must not contain underscores.; (#1166) Whitespace found at end of line; (#1168) Line indented incorrectly; expected 8 spaces, found 6; (#1168) Closing brace indented incorrectly; expected 8 spaces, found 6; (#1170) Short array syntax must be used to define arrays; (#1170) Expected 1 space before "=>"; 0 found; (#1170) Expected 1 space after "=>"; 0 found; (#1170) Expected 1 space before "=>"; 0 found; (#1170) Expected 1 space after "=>"; 0 found; (#1170) Line exceeds 132 characters; contains 139 characters; (#1170) Space found before semicolon; expected ");" but found ") ;"; (#1171) Short array syntax must be used to define arrays; (#1171) Expected 1 space before "=>"; 0 found; (#1171) Expected 1 space after "=>"; 0 found; (#1171) Expected 1 space before "=>"; 0 found; (#1171) Expected 1 space after "=>"; 0 found; (#1171) Line exceeds 132 characters; contains 147 characters; (#1171) Space found before semicolon; expected ");" but found ") ;"; (#1172) Whitespace found at end of line; (#1196) Inline comments must end in full-stops, exclamation marks, or question marks; (#1208) Short array syntax must be used to define arrays; (#1208) Expected 1 space before "=>"; 0 found; (#1208) Expected 1 space after "=>"; 0 found; (#1210) Short array syntax must be used to define arrays; (#1210) Expected 1 space before "=>"; 0 found; (#1210) Expected 1 space after "=>"; 0 found; (#1217) Short array syntax must be used to define arrays; (#1222) There should be a comma after the last array item in a multi-line array.; (#1230) Inline comments must end in full-stops, exclamation marks, or question marks; (#1256) Short array syntax must be used to define arrays; (#1256) Expected 1 space before "=>"; 0 found; (#1256) Expected 1 space after "=>"; 0 found; (#1266) Expected 1 space after "="; 0 found; (#1275) Short array syntax must be used to define arrays; (#1275) Expected 1 space before "=>"; 0 found; (#1275) Expected 1 space after "=>"; 0 found; (#1285) Whitespace found at end of line; (#1291) Variable "endpoint_method" must not contain underscores.; (#1291) Variable "value_id" must not contain underscores.; (#1293) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1293) Inline comments must end in full-stops, exclamation marks, or question marks; (#1295) Variable "value_id" must not contain underscores.; (#1296) Variable "endpoint_method" must not contain underscores.; (#1298) Variable "endpoint_method" must not contain underscores.; (#1298) Variable "value_id" must not contain underscores.; (#1302) Short array syntax must be used to define arrays; (#1310) Variable "endpoint_method" must not contain underscores.; (#1310) Variable "value_id" must not contain underscores.; (#1317) Whitespace found at end of line; (#1336) Missing docblock for function mod_goone_check_webhook; (#1337) Opening brace should be on the same line as the declaration; (#1346) Short array syntax must be used to define arrays; (#1356) Expected "if (...) {\n"; found "if(...) {\n"; (#1357) Short array syntax must be used to define arrays; (#1357) Expected 1 space before "=>"; 0 found; (#1357) Expected 1 space after "=>"; 0 found; (#1357) Expected 1 space before "=>"; 0 found; (#1357) Expected 1 space after "=>"; 0 found; (#1358) Expected "} else {\n"; found "}else{\n"; (#1359) Short array syntax must be used to define arrays; (#1359) Expected 1 space before "=>"; 0 found; (#1359) Expected 1 space after "=>"; 0 found; (#1359) Expected 1 space before "=>"; 0 found; (#1359) Expected 1 space after "=>"; 0 found; (#1363) Missing docblock for function mod_goone_view_api_payload_logs; (#1376) Short array syntax must be used to define arrays; (#1377) Line indented incorrectly; expected 4 spaces, found 8; (#1379) Line indented incorrectly; expected 4 spaces, found 8; (#1385) Missing docblock for function mod_goone_api_payload_process_post; (#1392) Variable "la_postjson" must not contain underscores.; (#1393) Short array syntax must be used to define arrays; (#1395) Variable "la_signature" must not contain underscores.; (#1396) Variable "la_signature" must not contain underscores.; (#1397) Variable "la_signatureitems" must not contain underscores.; (#1398) Variable "la_signatureitems" must not contain underscores.; (#1403) Variable "calculatedSignature" must be all lower-case; (#1405) Expected "if (...) {\n"; found "if(...) {\n"; (#1406) Variable "calculatedSignature" must be all lower-case; (#1408) Variable "la_postjson" must not contain underscores.; (#1412) No space found before comment text; expected "// Search user by email, firstname and lastname and username (external_user_id)." but found "//Search user by email, firstname and lastname and username (external_user_id)."; (#1413) Short array syntax must be used to define arrays; (#1413) Expected 1 space before "=>"; 0 found; (#1413) Expected 1 space after "=>"; 0 found; (#1414) Short array syntax must be used to define arrays; (#1414) Expected 1 space before "=>"; 0 found; (#1414) Expected 1 space after "=>"; 0 found; (#1414) Expected 1 space before "=>"; 0 found; (#1414) Expected 1 space after "=>"; 0 found; (#1414) Line exceeds 132 characters; contains 145 characters; (#1416) Line exceeds maximum limit of 180 characters; contains 186 characters; (#1420) Inline comments must end in full-stops, exclamation marks, or question marks; (#1420) No space found before comment text; expected "// Search users by external id which is username" but found "//Search users by external id which is username"; (#1423) Short array syntax must be used to define arrays; (#1423) Expected 1 space before "=>"; 0 found; (#1423) Expected 1 space after "=>"; 0 found; (#1423) Line exceeds 132 characters; contains 136 characters; (#1423) Whitespace found at end of line; (#1425) Whitespace found at end of line; (#1429) Short array syntax must be used to define arrays; (#1429) Expected 1 space before "=>"; 0 found; (#1429) Expected 1 space after "=>"; 0 found; (#1429) Variable "la_postjson" must not contain underscores.; (#1430) Short array syntax must be used to define arrays; (#1430) Expected 1 space before "=>"; 0 found; (#1430) Expected 1 space after "=>"; 0 found; (#1433) Short array syntax must be used to define arrays; (#1433) Expected 1 space before "=>"; 0 found; (#1433) Expected 1 space after "=>"; 0 found; (#1433) Expected 1 space before "=>"; 0 found; (#1433) Expected 1 space after "=>"; 0 found; (#1433) Expected 1 space before "=>"; 0 found; (#1433) Expected 1 space after "=>"; 0 found; (#1433) Line exceeds 132 characters; contains 147 characters; (#1434) Short array syntax must be used to define arrays; (#1434) Expected 1 space before "=>"; 0 found; (#1434) Expected 1 space after "=>"; 0 found; (#1434) Expected 1 space before "=>"; 0 found; (#1434) Expected 1 space after "=>"; 0 found; (#1434) Line exceeds 132 characters; contains 137 characters; (#1438) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1438) This comment is 58% valid code; is this commented out code?; (#1438) No space found before comment text; expected "// $cmc->viewed = 1;" but found "//$cmc->viewed = 1;"; (#1441) No space found before comment text; expected "// Check viewed and mark it." but found "//Check viewed and mark it."; (#1443) Expected 1 space before "=>"; 0 found; (#1443) Expected 1 space after "=>"; 0 found; (#1443) Expected 1 space before "=>"; 0 found; (#1443) Expected 1 space after "=>"; 0 found; (#1452) Expected "} else if (...) {\n"; found "} else if(...) {\n"; (#1452) Expected "if (...) {\n"; found "if(...) {\n"; (#1457) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1457) This comment is 58% valid code; is this commented out code?; (#1457) No space found before comment text; expected "// $newcmc->viewed = 1;" but found "//$newcmc->viewed = 1;"; (#1461) No space found before comment text; expected "// Check viewed and mark it." but found "//Check viewed and mark it."; (#1463) Expected 1 space before "=>"; 0 found; (#1463) Expected 1 space after "=>"; 0 found; (#1463) Expected 1 space before "=>"; 0 found; (#1463) Expected 1 space after "=>"; 0 found; (#1474) Expected "} else {\n"; found "}else{\n"; (#1476) Space found before semicolon; expected ");" but found ") ;"; (#1492) Variable "la_postjson" must not contain underscores.; (#1495) No space found before comment text; expected "// Search user by email or firstname and lastname." but found "//Search user by email or firstname and lastname."; (#1496) Short array syntax must be used to define arrays; (#1496) Expected 1 space before "=>"; 0 found; (#1496) Expected 1 space after "=>"; 0 found; (#1497) Short array syntax must be used to define arrays; (#1497) Expected 1 space before "=>"; 0 found; (#1497) Expected 1 space after "=>"; 0 found; (#1497) Expected 1 space before "=>"; 0 found; (#1497) Expected 1 space after "=>"; 0 found; (#1497) Line exceeds 132 characters; contains 141 characters; (#1499) Line indented incorrectly; expected at least 16 spaces, found 13; (#1499) Line exceeds 132 characters; contains 174 characters; (#1503) Short array syntax must be used to define arrays; (#1503) Expected 1 space before "=>"; 0 found; (#1503) Expected 1 space after "=>"; 0 found; (#1503) Variable "la_postjson" must not contain underscores.; (#1504) Short array syntax must be used to define arrays; (#1504) Expected 1 space before "=>"; 0 found; (#1504) Expected 1 space after "=>"; 0 found; (#1507) Short array syntax must be used to define arrays; (#1507) Expected 1 space before "=>"; 0 found; (#1507) Expected 1 space after "=>"; 0 found; (#1507) Expected 1 space before "=>"; 0 found; (#1507) Expected 1 space after "=>"; 0 found; (#1507) Expected 1 space before "=>"; 0 found; (#1507) Expected 1 space after "=>"; 0 found; (#1507) Line exceeds 132 characters; contains 143 characters; (#1508) Short array syntax must be used to define arrays; (#1508) Expected 1 space before "=>"; 0 found; (#1508) Expected 1 space after "=>"; 0 found; (#1508) Expected 1 space before "=>"; 0 found; (#1508) Expected 1 space after "=>"; 0 found; (#1508) Line exceeds 132 characters; contains 133 characters; (#1516) Expected "} else if (...) {\n"; found "} else if(...) {\n"; (#1516) Expected "if (...) {\n"; found "if(...) {\n"; (#1527) Expected "} else {\n"; found "}else{\n"; (#1529) Space found before semicolon; expected ");" but found ") ;"; (#1538) Expected "} else {\n"; found "}else {\n"; (#1547) Missing docblock for function mod_goone_create_webhook_api_request; (#1552) Expected "if (...) {\n"; found "if(...) {\n"; (#1555) Line indented incorrectly; expected 8 spaces, found 12; (#1568) Short array syntax must be used to define arrays; (#1579) Line indented incorrectly; expected 8 spaces, found 16; (#1584) Short array syntax must be used to define arrays; (#1584) Expected 1 space before "=>"; 0 found; (#1584) Expected 1 space after "=>"; 0 found; (#1584) Expected 1 space before "=>"; 0 found; (#1584) Line exceeds 132 characters; contains 155 characters; (#1587) Line indented incorrectly; expected 8 spaces, found 16; (#1590) Short array syntax must be used to define arrays; (#1590) Expected 1 space before "=>"; 0 found; (#1590) Expected 1 space after "=>"; 0 found; (#1590) Expected 1 space before "=>"; 0 found; (#1590) Line exceeds 132 characters; contains 156 characters; (#1593) Line indented incorrectly; expected 8 spaces, found 12; (#1597) Line indented incorrectly; expected 8 spaces, found 12; (#1607) Short array syntax must be used to define arrays; (#1607) Expected 1 space before "=>"; 0 found; (#1607) Expected 1 space after "=>"; 0 found; (#1607) Expected 1 space before "=>"; 0 found; (#1607) Line exceeds 132 characters; contains 141 characters
mod/goone/mod_form.php: (#26) Old MOODLE_INTERNAL check detected. Replace it by "defined('MOODLE_INTERNAL') || die();"; (#35) Short array syntax must be used to define arrays; (#37) There should be a comma after the last array item in a multi-line array.; (#42) Short array syntax must be used to define arrays; (#44) There should be a comma after the last array item in a multi-line array.; (#68) Short array syntax must be used to define arrays; (#72) Short array syntax must be used to define arrays; (#74) Short array syntax must be used to define arrays; (#77) Short array syntax must be used to define arrays; (#99) Short array syntax must be used to define arrays
mod/goone/payload.php: (#1) Missing @copyright tag; (#1) Missing @license tag; (#1) Missing docblock for file payload.php; (#1) End of line character is invalid; expected "\n" but found "\r\n"; (#24) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#29) Variable "create_webhook" must not contain underscores.; (#31) Expected "if (...) {\n"; found "if(...) {\n"; (#31) Variable "create_webhook" must not contain underscores.; (#32) Spaces must be used to indent lines; tabs are not allowed; (#32) Tab found within whitespace; (#32) Line indented incorrectly; expected at least 4 spaces, found 1; (#34) Variable "create_webhook" must not contain underscores.; (#35) Spaces must be used to indent lines; tabs are not allowed; (#35) Tab found within whitespace; (#35) Line indented incorrectly; expected at least 4 spaces, found 1; (#36) Whitespace found at end of line; (#37) Variable "create_webhook" must not contain underscores.; (#38) Spaces must be used to indent lines; tabs are not allowed; (#38) Tab found within whitespace; (#38) Line indented incorrectly; expected at least 4 spaces, found 1; (#40) Expected "if (...) {\n"; found "if(...){\n"; (#40) Variable "create_webhook" must not contain underscores.; (#41) Spaces must be used to indent lines; tabs are not allowed; (#41) Tab found within whitespace; (#41) Line indented incorrectly; expected at least 4 spaces, found 1; (#42) File must end with a newline character
mod/goone/settings.php: (#38) Short array syntax must be used to define arrays; (#39) Short array syntax must be used to define arrays; (#45) Line exceeds 132 characters; contains 135 characters; (#45) Whitespace found at end of line; (#46) Whitespace found at end of line; (#49) Whitespace found at end of line; (#52) Whitespace found at end of line; (#62) Commas (,) must be followed by white space.; (#68) Commas (,) must be followed by white space.; (#70) Inline comments must start with a capital letter, digit or 3-dots sequence; (#70) This comment is 69% valid code; is this commented out code?; (#70) No space found before comment text; expected "// $setting = new setting_statictext($name, $migratebutton);" but found "//$setting = new setting_statictext($name, $migratebutton);"; (#71) No space found before comment text; expected "// $settings->add($setting);" but found "//$settings->add($setting);"; (#83) Short array syntax must be used to define arrays; (#85) There should be a comma after the last array item in a multi-line array.; (#112) Line indented incorrectly; expected at least 8 spaces, found 4
mod/goone/tests/custom_completion_test.php: (#46) PHPUnit testcase name "activity_custom_completion_test" does not match file name "custom_completion_test"; (#52) Data provider method "get_state_provider" will need to be converted to static in future.; (#56) There should be a comma after the last array item in a multi-line array.; (#72) Test method test_get_state() is missing any coverage information, own or at class level; (#85) Inline comments must end in full-stops, exclamation marks, or question marks; (#103) Test method test_get_defined_custom_rules() is missing any coverage information, own or at class level; (#112) Test method test_get_custom_rule_descriptions() is missing any coverage information, own or at class level; (#119) There should be a comma after the last array item in a multi-line array.; (#137) Test method test_is_defined() is missing any coverage information, own or at class level; (#141) There should be a comma after the last array item in a multi-line array.; (#161) Data provider method "get_available_custom_rules_provider" will need to be converted to static in future.; (#164) There should be a comma after the last array item in a multi-line array.; (#167) There should be a comma after the last array item in a multi-line array.; (#179) Test method test_get_available_custom_rules() is missing any coverage information, own or at class level; (#187) There should be a comma after the last array item in a multi-line array.; (#203) No one-line description found in phpdocs for docblock of function create_instance
mod/goone/tests/generator/lib.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#48) Short array syntax must be used to define arrays
mod/goone/tests/generator_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#36) PHPUnit testcase name "mod_goone_generator_testcase" does not match file name "generator_test"; (#36) PHPUnit class "mod_goone_generator_testcase" does not have any namespace. It is recommended to add it to the "mod_goone" namespace, using more levels if needed, in order to match the code being tested; (#38) Test method test_create_instance() is missing any coverage information, own or at class level; (#45) Short array syntax must be used to define arrays; (#46) Short array syntax must be used to define arrays; (#47) Short array syntax must be used to define arrays; (#48) Short array syntax must be used to define arrays; (#49) Short array syntax must be used to define arrays; (#51) Short array syntax must be used to define arrays; (#53) Short array syntax must be used to define arrays; (#54) Short array syntax must be used to define arrays
mod/goone/tests/lib_test.php: (#38) PHPUnit testcase name "mod_goone_lib_testcase" does not match file name "lib_test"; (#38) PHPUnit class "mod_goone_lib_testcase" does not have any namespace. It is recommended to add it to the "mod_goone" namespace, using more levels if needed, in order to match the code being tested; (#40) Test method test_goone_supports() is missing any coverage information, own or at class level; (#46) Test method test_goone_convert_hours_mins() is missing any coverage information, own or at class level; (#52) Test method test_goone_set_completion() is missing any coverage information, own or at class level; (#57) Short array syntax must be used to define arrays; (#61) Short array syntax must be used to define arrays; (#62) Short array syntax must be used to define arrays; (#68) Test method test_goone_check_capabilities() is missing any coverage information, own or at class level; (#71) Short array syntax must be used to define arrays; (#85) Test method test_goone_get_lang() is missing any coverage information, own or at class level; (#95) Test method test_goone_extract_scorm_token() is missing any coverage information, own or at class level; (#109) Test method test_goone_clean_hits() is missing any coverage information, own or at class level; (#115) Test method test_goone_inject_datamodel() is missing any coverage information, own or at class level; (#121) Test method test_goone_session_state() is missing any coverage information, own or at class level; (#126) Short array syntax must be used to define arrays; (#130) Short array syntax must be used to define arrays; (#131) Short array syntax must be used to define arrays; (#137) Test method test_goone_signup_url() is missing any coverage information, own or at class level; (#148) Test method test_goone_get_coursemodule_info() is missing any coverage information, own or at class level; (#151) Line exceeds 132 characters; contains 133 characters
mod/goone/version.php: (#32) Short array syntax must be used to define arrays
mod/goone/view.php: (#42) Short array syntax must be used to define arrays; (#45) Short array syntax must be used to define arrays; (#53) Short array syntax must be used to define arrays; (#62) Short array syntax must be used to define arrays; (#69) Short array syntax must be used to define arrays; (#73) Short array syntax must be used to define arrays; (#74) Short array syntax must be used to define arrays; (#87) Short array syntax must be used to define arrays; (#88) There should be a comma after the last array item in a multi-line array.; (#95) Short array syntax must be used to define arrays; (#100) Short array syntax must be used to define arrays

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "gherkinlint" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Gherkin .feature problems

(2 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

mod/goone/tests/behat/goone_configuration.feature: (#33) New line at EOF(end of file) is required
mod/goone/tests/behat/add_activity.feature: (#27) New line at EOF(end of file) is required

Prechecker results: error

Overview

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems