Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(1171 errors, 353 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/goodhabits/ajax_save_entry.php: (#63) Variable "prev_completed_cal_units_crit" must not contain underscores.; (#69) Variable "has_checked" must not contain underscores.; (#73) Variable "newly_completed_cal_units_crit" must not contain underscores.; (#74) Variable "has_checked" must not contain underscores.; (#74) Logical operator "and" is prohibited; use "&&" instead; (#74) Variable "prev_completed_cal_units_crit" must not contain underscores.; (#77) Variable "newly_completed_cal_units_crit" must not contain underscores.; (#81) Variable "newly_completed_cal_units_crit" must not contain underscores.
mod/goodhabits/backup/moodle2/backup_goodhabits_stepslib.php: (#33) Missing docblock for function define_structure; (#38) Short array syntax must be used to define arrays; (#38) Short array syntax must be used to define arrays; (#42) Short array syntax must be used to define arrays; (#42) Short array syntax must be used to define arrays; (#46) Short array syntax must be used to define arrays; (#46) Short array syntax must be used to define arrays; (#51) Short array syntax must be used to define arrays; (#51) Short array syntax must be used to define arrays; (#60) Short array syntax must be used to define arrays; (#63) Short array syntax must be used to define arrays; (#64) Short array syntax must be used to define arrays; (#65) Short array syntax must be used to define arrays
mod/goodhabits/backup/moodle2/restore_goodhabits_activity_task.class.php: (#57) Short array syntax must be used to define arrays; (#59) Short array syntax must be used to define arrays; (#69) Short array syntax must be used to define arrays; (#85) Short array syntax must be used to define arrays; (#101) Short array syntax must be used to define arrays
mod/goodhabits/backup/moodle2/restore_goodhabits_stepslib.php: (#34) Short array syntax must be used to define arrays
mod/goodhabits/classes/AutoSimple.php: (#1) No one-line description found in phpdocs for docblock of file AutoSimple.php; (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#34) Opening brace should be on the same line as the declaration for class AutoSimple; (#35) Missing member variable doc comment; (#37) Missing member variable doc comment; (#39) Missing member variable doc comment; (#41) Missing member variable doc comment; (#42) Missing docblock for function __construct; (#43) Opening brace should be on the same line as the declaration; (#50) Missing docblock for function execute; (#51) Opening brace should be on the same line as the declaration; (#65) File must end with a newline character
mod/goodhabits/classes/BreaksHelper.php: (#1) No one-line description found in phpdocs for docblock of file BreaksHelper.php; (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#50) Short array syntax must be used to define arrays; (#54) There should be a comma after the last array item in a multi-line array.; (#79) Short array syntax must be used to define arrays; (#80) There should be a comma after the last array item in a multi-line array.; (#96) Short array syntax must be used to define arrays; (#98) There should be a comma after the last array item in a multi-line array.; (#130) Short array syntax must be used to define arrays; (#143) Variable "error_margin" must not contain underscores.; (#146) Variable "error_margin" must not contain underscores.; (#147) Variable "error_margin" must not contain underscores.; (#148) Logical operator "and" is prohibited; use "&&" instead; (#155) Missing docblock for function process_skip; (#155) Variable "skip_timestamp" must not contain underscores.; (#156) Opening brace should be on the same line as the declaration; (#161) Variable "skip_timestamp" must not contain underscores.; (#162) Variable "skip_timestamp" must not contain underscores.; (#167) Variable "break_added" must not contain underscores.; (#168) Variable "break_added" must not contain underscores.
mod/goodhabits/classes/External.php: (#1) No one-line description found in phpdocs for docblock of file External.php; (#16) Boilerplate comment must be followed by a single blank line or end of file; (#19) Invalid docblock tag "@basedon".; (#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#40) No one-line description found in phpdocs for docblock of function get_review_subjects_parameters; (#91) There should be a comma after the last array item in a multi-line array.; (#109) No one-line description found in phpdocs for docblock of function get_review_subjects_returns
mod/goodhabits/classes/Helper.php: (#1) No one-line description found in phpdocs for docblock of file Helper.php; (#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#40) Invalid docblock tag "@const".; (#67) Short array syntax must be used to define arrays; (#215) Missing docblock for function strings_as_data; (#216) Opening brace should be on the same line as the declaration; (#233) Short array syntax must be used to define arrays; (#247) Short array syntax must be used to define arrays; (#303) Missing docblock for function add_layout_url_param; (#304) Opening brace should be on the same line as the declaration; (#306) Variable "is_basic_mobile" must not contain underscores.; (#307) Variable "is_basic_mobile" must not contain underscores.; (#312) Missing docblock for function get_string; (#316) Missing docblock for function get_flexi_cal_unit_from_timestamp; (#317) Opening brace should be on the same line as the declaration; (#324) Missing docblock for function get_instance_from_instance_id; (#325) Opening brace should be on the same line as the declaration; (#334) Missing docblock for function check_to_update_completion_state; (#335) Opening brace should be on the same line as the declaration; (#336) Variable "any_rule" must not contain underscores.; (#339) Variable "any_rule" must not contain underscores.; (#343) Variable "any_rule" must not contain underscores.; (#357) Missing docblock for function get_entries; (#361) Whitespace found at end of line within string; (#362) Whitespace found at end of line within string; (#381) Missing docblock for function get_all_entries; (#385) Whitespace found at end of line within string; (#386) Whitespace found at end of line within string; (#399) Missing docblock for function unit_has_all_complete; (#400) Opening brace should be on the same line as the declaration; (#421) Opening brace should be on the same line as the declaration; (#424) Whitespace found at end of line within string; (#426) Whitespace found at end of line within string; (#427) Whitespace found at end of line within string; (#429) Whitespace found at end of line within string; (#448) Missing docblock for function has_completed_cal_units_crit; (#449) Opening brace should be on the same line as the declaration; (#450) Variable "min_cal_units" must not contain underscores.; (#451) Variable "pre_complete" must not contain underscores.; (#451) Must use "self::" for local static member reference; (#452) Variable "pre_complete" must not contain underscores.; (#452) Variable "min_cal_units" must not contain underscores.; (#466) Opening brace should be on the same line as the declaration; (#479) Whitespace found at end of line within string; (#485) Whitespace found at end of line within string; (#503) Missing docblock for function rm_from_array; (#503) Variable "val_to_remove" must not contain underscores.; (#504) Opening brace should be on the same line as the declaration; (#505) Variable "val_to_remove" must not contain underscores.; (#512) Missing docblock for function get_timestamp_error_margin; (#513) Opening brace should be on the same line as the declaration; (#517) Missing docblock for function get_context_from_instance_id; (#518) Opening brace should be on the same line as the declaration; (#527) Missing docblock for function form_warning_text; (#528) Opening brace should be on the same line as the declaration; (#533) Missing docblock for function get_simple_questions; (#533) Variable "all_complete" must not contain underscores.; (#534) Opening brace should be on the same line as the declaration; (#535) Variable "all_complete" must not contain underscores.; (#536) Variable "num_all_complete" must not contain underscores.; (#538) Variable "num_all_complete" must not contain underscores.; (#538) Variable "all_complete" must not contain underscores.; (#540) Variable "suffix_1" must not contain underscores.; (#540) Variable "num_all_complete" must not contain underscores.; (#541) Variable "suffix_2" must not contain underscores.; (#541) Variable "suffix_1" must not contain underscores.; (#542) Variable "number_questions_in_sequence" must not contain underscores.; (#543) Variable "num_all_complete" must not contain underscores.; (#543) Variable "number_questions_in_sequence" must not contain underscores.; (#544) Variable "suffix_1" must not contain underscores.; (#544) Commas (,) must be followed by white space.; (#545) Variable "suffix_2" must not contain underscores.; (#545) Commas (,) must be followed by white space.; (#548) Variable "suffix_1" must not contain underscores.; (#549) Variable "suffix_2" must not contain underscores.; (#554) Missing docblock for function get_avg; (#554) Declaring an optional parameter before a required parameter is deprecated since PHP 8.0. Parameter $column is optional, while parameter $habit is required. The $column parameter is implicitly treated as a required parameter.; (#555) Opening brace should be on the same line as the declaration; (#571) There should be a comma after the last array item in a multi-line array.; (#577) Missing docblock for function get_first_entry; (#598) There should be a comma after the last array item in a multi-line array.
mod/goodhabits/classes/PreferencesManager.php: (#1) No one-line description found in phpdocs for docblock of file PreferencesManager.php; (#31) Opening brace should be on the same line as the declaration for class PreferencesManager; (#32) Missing member variable doc comment; (#33) Missing member variable doc comment; (#34) Missing member variable doc comment; (#34) Member variable "site_config" must not contain underscores.; (#36) Missing member variable doc comment; (#36) Member variable "instance_rec" must not contain underscores.; (#37) Missing member variable doc comment; (#37) Member variable "pref_rec" must not contain underscores.; (#39) Missing docblock for constant PreferencesManager::CM_OPTION_REQUIRED; (#40) Missing docblock for constant PreferencesManager::CM_OPTION_OPTIONAL_DEFAULT_ALLOW; (#41) Missing docblock for constant PreferencesManager::CM_OPTION_OPTIONAL_DEFAULT_DISALLOW; (#42) Missing docblock for constant PreferencesManager::CM_OPTION_DISABLE; (#44) Missing docblock for constant PreferencesManager::ACCESS_AS_ADMIN; (#45) Missing docblock for constant PreferencesManager::ACCESS_AS_PEER; (#47) Missing docblock for function __construct; (#55) Missing docblock for function show_scores; (#56) Opening brace should be on the same line as the declaration; (#61) Missing docblock for function enable_help; (#62) Opening brace should be on the same line as the declaration; (#75) Opening brace should be on the same line as the declaration; (#79) Variable "cm_setting" must not contain underscores.; (#80) Variable "cm_setting" must not contain underscores.; (#103) Missing docblock for function get_review_mod_status; (#104) Opening brace should be on the same line as the declaration; (#108) Variable "cm_setting" must not contain underscores.; (#109) Variable "cm_setting" must not contain underscores.; (#116) Missing docblock for function is_review_opt_in; (#117) Opening brace should be on the same line as the declaration; (#118) Variable "cm_setting" must not contain underscores.; (#119) Variable "cm_setting" must not contain underscores.; (#125) Missing docblock for function is_review_option_enabled; (#126) Opening brace should be on the same line as the declaration; (#130) Variable "cm_setting" must not contain underscores.; (#131) Variable "cm_setting" must not contain underscores.; (#131) Logical operator "or" is prohibited; use "||" instead; (#131) Variable "cm_setting" must not contain underscores.; (#137) Missing docblock for function is_review_option_required; (#138) Opening brace should be on the same line as the declaration; (#142) Variable "cm_setting" must not contain underscores.; (#143) Variable "cm_setting" must not contain underscores.; (#149) Missing docblock for function get_preferred_string; (#150) Opening brace should be on the same line as the declaration; (#155) Variable "pref_field" must not contain underscores.; (#156) Variable "pref_val" must not contain underscores.; (#156) Variable "pref_field" must not contain underscores.; (#157) Variable "pref_val" must not contain underscores.; (#159) Variable "pref_val" must not contain underscores.; (#164) Missing docblock for function process_form; (#165) Opening brace should be on the same line as the declaration; (#168) Variable "text_data" must not contain underscores.; (#172) Variable "text_data" must not contain underscores.; (#181) Variable "text_data" must not contain underscores.; (#191) Missing docblock for function get_text_data_from_post; (#192) Opening brace should be on the same line as the declaration; (#193) Variable "text_data" must not contain underscores.; (#202) Variable "text_data" must not contain underscores.; (#206) Variable "text_data" must not contain underscores.; (#209) Missing docblock for function pop_pref_from_data; (#209) Variable "text_data" must not contain underscores.; (#210) Opening brace should be on the same line as the declaration; (#216) Variable "text_data" must not contain underscores.; (#221) Missing docblock for function get_pref_rec; (#222) Opening brace should be on the same line as the declaration; (#233) Missing docblock for function get_cm_options; (#234) Opening brace should be on the same line as the declaration; (#243) Missing docblock for function get_reviews_admin_default; (#244) Opening brace should be on the same line as the declaration; (#248) Missing docblock for function get_reviews_peers_default; (#249) Opening brace should be on the same line as the declaration; (#253) Inline comments must start with a capital letter, digit or 3-dots sequence; (#253) Line indented incorrectly; expected at least 4 spaces, found 0; (#253) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#254) Line indented incorrectly; expected at least 4 spaces, found 0; (#254) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#255) Line indented incorrectly; expected at least 4 spaces, found 0; (#255) 4 slashes comments are not allowed; use "// Comment." instead; (#255) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#256) Line indented incorrectly; expected at least 4 spaces, found 0; (#256) 4 slashes comments are not allowed; use "// Comment." instead; (#256) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#257) Line indented incorrectly; expected at least 4 spaces, found 0; (#257) 4 slashes comments are not allowed; use "// Comment." instead; (#257) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#258) Line indented incorrectly; expected at least 4 spaces, found 0; (#258) 4 slashes comments are not allowed; use "// Comment." instead; (#258) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#259) Line indented incorrectly; expected at least 4 spaces, found 0; (#259) 4 slashes comments are not allowed; use "// Comment." instead; (#260) Line indented incorrectly; expected at least 4 spaces, found 0; (#260) 4 slashes comments are not allowed; use "// Comment." instead; (#260) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#261) Line indented incorrectly; expected at least 4 spaces, found 0; (#261) 4 slashes comments are not allowed; use "// Comment." instead; (#261) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#262) Line indented incorrectly; expected at least 4 spaces, found 0; (#262) 4 slashes comments are not allowed; use "// Comment." instead; (#262) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#263) Line indented incorrectly; expected at least 4 spaces, found 0; (#263) 4 slashes comments are not allowed; use "// Comment." instead; (#263) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#264) Line indented incorrectly; expected at least 4 spaces, found 0; (#264) 4 slashes comments are not allowed; use "// Comment." instead; (#264) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#265) Inline comments must end in full-stops, exclamation marks, or question marks; (#265) Line indented incorrectly; expected at least 4 spaces, found 0; (#265) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#276) Variable "review_subject_id" must not contain underscores.; (#277) Opening brace should be on the same line as the declaration; (#279) Variable "access_as_admin" must not contain underscores.; (#280) Variable "access_as_peer" must not contain underscores.; (#281) Variable "other_required_caps" must not contain underscores.; (#282) Variable "has_all_other" must not contain underscores.; (#282) Variable "other_required_caps" must not contain underscores.; (#283) Variable "has_all_other" must not contain underscores.; (#289) Variable "allow_admin_mod" must not contain underscores.; (#290) Variable "allow_admin_mod" must not contain underscores.; (#292) Variable "access_as_admin" must not contain underscores.; (#295) Variable "review_subject_id" must not contain underscores.; (#296) Variable "subject_mgr" must not contain underscores.; (#296) Variable "review_subject_id" must not contain underscores.; (#297) Variable "subject_allow_admin" must not contain underscores.; (#297) Variable "subject_mgr" must not contain underscores.; (#298) Variable "subject_allow_admin" must not contain underscores.; (#299) Variable "access_as_admin" must not contain underscores.; (#303) Variable "allow_peer" must not contain underscores.; (#305) Variable "allow_peer" must not contain underscores.; (#307) Variable "access_as_peer" must not contain underscores.; (#310) Variable "is_peer_opt_in" must not contain underscores.; (#312) Variable "is_peer_opt_in" must not contain underscores.; (#312) Logical operator "and" is prohibited; use "&&" instead; (#312) Variable "access_as_peer" must not contain underscores.; (#313) Variable "any_other_to_review" must not contain underscores.; (#314) Variable "any_other_to_review" must not contain underscores.; (#316) Variable "access_as_peer" must not contain underscores.; (#319) Variable "access_as_admin" must not contain underscores.; (#323) Variable "access_as_peer" must not contain underscores.; (#329) Missing docblock for function does_any_other_user_allow_peer_review; (#330) Opening brace should be on the same line as the declaration; (#339) Missing docblock for function get_users_who_allow_peer_review; (#340) Opening brace should be on the same line as the declaration; (#346) There should be a comma after the last array item in a multi-line array.; (#351) Missing docblock for function default_yes_setting; (#351) Variable "pref_rec" must not contain underscores.; (#352) Opening brace should be on the same line as the declaration; (#353) Variable "pref_rec" must not contain underscores.; (#357) Variable "pref_rec" must not contain underscores.; (#365) File must end with a newline character
mod/goodhabits/classes/ViewHelper.php: (#1) No one-line description found in phpdocs for docblock of file ViewHelper.php; (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#37) Missing docblock for constant ViewHelper::REVIEW_OPTION_DISABLE; (#39) Missing docblock for constant ViewHelper::REVIEW_OPTION_NO_OPTING; (#94) Short array syntax must be used to define arrays; (#98) Missing docblock for function get_access_review_as_string_id; (#99) Opening brace should be on the same line as the declaration; (#100) Variable "accessing_as" must not contain underscores.; (#101) Variable "access_as_string_id" must not contain underscores.; (#102) Variable "accessing_as" must not contain underscores.; (#103) Variable "access_as_string_id" must not contain underscores.; (#105) Variable "access_as_string_id" must not contain underscores.; (#114) Variable "accessing_as_string_id" must not contain underscores.; (#115) Variable "accessing_as_text" must not contain underscores.; (#115) Variable "accessing_as_string_id" must not contain underscores.; (#116) Variable "accessing_as" must not contain underscores.; (#116) Variable "accessing_as_text" must not contain underscores.; (#118) Short array syntax must be used to define arrays; (#119) Variable "accessing_as" must not contain underscores.; (#122) Inline comments must start with a capital letter, digit or 3-dots sequence; (#122) This comment is 52% valid code; is this commented out code?; (#122) Line indented incorrectly; expected at least 8 spaces, found 0; (#122) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#123) Line indented incorrectly; expected at least 8 spaces, found 0; (#123) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#124) Line indented incorrectly; expected at least 8 spaces, found 0; (#124) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#125) Line indented incorrectly; expected at least 8 spaces, found 0; (#125) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#126) Inline comments must end in full-stops, exclamation marks, or question marks; (#126) Line indented incorrectly; expected at least 8 spaces, found 0; (#126) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#136) Short array syntax must be used to define arrays; (#138) There should be a comma after the last array item in a multi-line array.
mod/goodhabits/classes/calendar/FlexiCalendar.php: (#1) No one-line description found in phpdocs for docblock of file FlexiCalendar.php; (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#67) Missing docblock for constant FlexiCalendar::DEFAULT_NUM_ENTRIES; (#69) Missing docblock for constant FlexiCalendar::PLUGIN_AREA_VIEW; (#71) Missing docblock for constant FlexiCalendar::PLUGIN_AREA_REVIEW; (#73) Missing docblock for constant FlexiCalendar::STRING_TYPE_SINGULAR; (#74) Missing docblock for constant FlexiCalendar::STRING_TYPE_PLURAL; (#75) Missing docblock for constant FlexiCalendar::STRING_TYPE_DEFINITE_ARTICLE; (#76) Missing docblock for constant FlexiCalendar::STRING_TYPE_ANSWER_LATEST; (#77) Missing docblock for constant FlexiCalendar::STRING_TYPE_CHOSEN; (#78) Missing docblock for constant FlexiCalendar::STRING_TYPE_SKIPPED; (#79) Missing docblock for constant FlexiCalendar::STRING_TYPE_SKIP_HELP; (#80) Missing docblock for constant FlexiCalendar::STRING_TYPE_GRID_OPEN_HELP; (#100) Missing docblock for function add_body_classes; (#101) Opening brace should be on the same line as the declaration; (#104) Logical operator "and" is prohibited; use "&&" instead; (#112) No one-line description found in phpdocs for docblock of function get_display_set; (#122) Opening brace should be on the same line as the declaration; (#133) Opening brace should be on the same line as the declaration; (#135) Variable "earliest_limits" must not contain underscores.; (#136) Variable "earliest_limits" must not contain underscores.; (#145) Opening brace should be on the same line as the declaration; (#158) Opening brace should be on the same line as the declaration; (#160) Variable "latest_limits" must not contain underscores.; (#161) Variable "latest_limits" must not contain underscores.; (#170) Opening brace should be on the same line as the declaration; (#189) No one-line description found in phpdocs for docblock of function get_period_duration; (#193) Missing docblock for function get_period_duration_string; (#193) Variable "string_type" must not contain underscores.; (#194) Opening brace should be on the same line as the declaration; (#195) Variable "string_type" must not contain underscores.; (#196) Variable "string_type" must not contain underscores.; (#198) Variable "string_type" must not contain underscores.; (#201) Variable "singular_id" must not contain underscores.; (#202) Variable "other_id" must not contain underscores.; (#202) Variable "singular_id" must not contain underscores.; (#203) Variable "plural_id" must not contain underscores.; (#206) Variable "singular_id" must not contain underscores.; (#207) Variable "other_id" must not contain underscores.; (#207) Variable "singular_id" must not contain underscores.; (#208) Variable "plural_id" must not contain underscores.; (#211) Variable "singular_id" must not contain underscores.; (#212) Variable "other_id" must not contain underscores.; (#212) Variable "singular_id" must not contain underscores.; (#213) Variable "plural_id" must not contain underscores.; (#215) Variable "string_type" must not contain underscores.; (#216) Variable "singular_id" must not contain underscores.; (#218) Variable "string_type" must not contain underscores.; (#219) Variable "plural_id" must not contain underscores.; (#221) Variable "other_id" must not contain underscores.; (#243) Variable "numentries_offset" must not contain underscores.; (#245) Variable "numentries_offset" must not contain underscores.; (#246) Variable "numentries_offset" must not contain underscores.; (#260) Short array syntax must be used to define arrays; (#280) Variable "override_num_entries" must not contain underscores.; (#281) Inline comments must start with a capital letter, digit or 3-dots sequence; (#281) This comment is 50% valid code; is this commented out code?; (#281) Line indented incorrectly; expected at least 8 spaces, found 0; (#281) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#282) Line indented incorrectly; expected at least 8 spaces, found 0; (#282) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#283) Line indented incorrectly; expected at least 8 spaces, found 0; (#283) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#284) Variable "override_num_entries" must not contain underscores.; (#285) Variable "pre_num_entries" must not contain underscores.; (#286) Variable "override_num_entries" must not contain underscores.; (#289) Variable "override_num_entries" must not contain underscores.; (#290) Variable "pre_num_entries" must not contain underscores.; (#292) Short array syntax must be used to define arrays; (#307) Missing docblock for function get_back_date; (#308) Opening brace should be on the same line as the declaration; (#316) Missing docblock for function get_to_date; (#317) Opening brace should be on the same line as the declaration; (#318) Variable "to_date" must not contain underscores.; (#320) Variable "to_date" must not contain underscores.; (#332) Variable "override_num_entries" must not contain underscores.; (#333) Variable "override_num_entries" must not contain underscores.; (#334) Variable "pre_num_entries" must not contain underscores.; (#335) Variable "override_num_entries" must not contain underscores.; (#338) Variable "add_days" must not contain underscores.; (#339) Variable "add_days" must not contain underscores.; (#340) Variable "override_num_entries" must not contain underscores.; (#341) Variable "pre_num_entries" must not contain underscores.; (#352) Short array syntax must be used to define arrays
mod/goodhabits/classes/calendar/FlexiCalendarUnit.php: (#1) No one-line description found in phpdocs for docblock of file FlexiCalendarUnit.php; (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#81) Short array syntax must be used to define arrays; (#88) Missing docblock for function get_moodle_user_date; (#89) Opening brace should be on the same line as the declaration; (#96) Missing docblock for function display_unit_inline; (#97) Opening brace should be on the same line as the declaration; (#102) Missing docblock for function skip_url; (#102) Variable "to_date" must not contain underscores.; (#103) Opening brace should be on the same line as the declaration; (#104) Short array syntax must be used to define arrays; (#104) Variable "to_date" must not contain underscores.; (#111) Missing docblock for function answer_questions_url; (#112) Opening brace should be on the same line as the declaration; (#113) Short array syntax must be used to define arrays; (#148) Short array syntax must be used to define arrays; (#155) Missing docblock for function get_limits; (#156) Opening brace should be on the same line as the declaration; (#158) Variable "error_margin" must not contain underscores.; (#161) Variable "error_margin" must not contain underscores.; (#162) Variable "error_margin" must not contain underscores.; (#166) Missing docblock for function get_closest_entry; (#167) Opening brace should be on the same line as the declaration; (#172) Variable "entry_time" must not contain underscores.; (#173) Variable "entry_time" must not contain underscores.; (#173) Logical operator "and" is prohibited; use "&&" instead; (#173) Variable "entry_time" must not contain underscores.
mod/goodhabits/classes/completion/custom_completion.php: (#27) Missing @copyright tag; (#27) Missing @license tag; (#30) Invalid docblock tag "@basedon".; (#32) DocBlock missing a @package tag for class custom_completion. Expected @package mod_goodhabits; (#46) Variable "gh_id" must not contain underscores.; (#48) Variable "gh_id" must not contain underscores.; (#50) Variable "min_habits" must not contain underscores.; (#51) Variable "min_entries" must not contain underscores.; (#52) Variable "min_cal_units" must not contain underscores.; (#57) Variable "min_habits" must not contain underscores.; (#60) Variable "num_entries" must not contain underscores.; (#61) Variable "num_entries" must not contain underscores.; (#61) Variable "min_entries" must not contain underscores.; (#65) Variable "min_cal_units" must not contain underscores.; (#95) Variable "gh_id" must not contain underscores.; (#97) Variable "gh_id" must not contain underscores.
mod/goodhabits/classes/event/course_module_instance_list_viewed.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/goodhabits/classes/event/course_module_viewed.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#46) Short array syntax must be used to define arrays; (#48) There should be a comma after the last array item in a multi-line array.; (#67) Missing docblock for function get_objectid_mapping; (#68) Short array syntax must be used to define arrays
mod/goodhabits/classes/form/add_break.php: (#1) No one-line description found in phpdocs for docblock of file add_break.php; (#25) Missing docblock for class add_break; (#26) Opening brace should be on the same line as the declaration for class add_break; (#28) Missing docblock for function definition
mod/goodhabits/classes/form/add_habit.php: (#1) No one-line description found in phpdocs for docblock of file add_habit.php; (#27) Missing docblock for class add_habit; (#28) Opening brace should be on the same line as the declaration for class add_habit; (#30) Missing docblock for function definition; (#40) Short array syntax must be used to define arrays; (#42) Short array syntax must be used to define arrays; (#44) Short array syntax must be used to define arrays; (#46) There should be a comma after the last array item in a multi-line array.
mod/goodhabits/classes/form/historical_data_filter.php: (#1) Moodle boilerplate not found; (#10) Missing @copyright tag; (#10) Missing @license tag; (#10) Missing docblock for class historical_data_filter; (#12) Missing docblock for function definition; (#19) Variable "subject_id" must not contain underscores.; (#21) Inline comments must end in full-stops, exclamation marks, or question marks; (#23) Variable "subject_id" must not contain underscores.; (#24) Variable "subject_id" must not contain underscores.; (#29) Inline comments must end in full-stops, exclamation marks, or question marks; (#35) Inline comments must start with a capital letter, digit or 3-dots sequence; (#35) This comment is 84% valid code; is this commented out code?; (#35) Line indented incorrectly; expected at least 8 spaces, found 0; (#35) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#38) Inline comments must end in full-stops, exclamation marks, or question marks; (#50) Missing docblock for function add_advanced_options; (#51) Opening brace should be on the same line as the declaration; (#64) There should be a comma after the last array item in a multi-line array.
mod/goodhabits/classes/form/preferences.php: (#1) No one-line description found in phpdocs for docblock of file preferences.php; (#27) Missing docblock for class preferences; (#28) Opening brace should be on the same line as the declaration for class preferences; (#30) Missing docblock for function definition; (#34) Whitespace found at end of line; (#46) Variable "allow_review_admin" must not contain underscores.; (#47) Variable "allow_review_peers" must not contain underscores.; (#49) Variable "show_scores" must not contain underscores.; (#51) Variable "enable_help" must not contain underscores.; (#55) Variable "allow_review_admin" must not contain underscores.; (#56) Variable "allow_review_peers" must not contain underscores.; (#57) Variable "show_scores" must not contain underscores.; (#58) Variable "enable_help" must not contain underscores.; (#62) Variable "allow_review_peers" must not contain underscores.; (#68) Variable "has_all" must not contain underscores.; (#69) Variable "has_all" must not contain underscores.; (#81) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#83) Inline comments must start with a capital letter, digit or 3-dots sequence; (#93) Variable "cells_text" must not contain underscores.; (#104) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#111) Variable "cells_text" must not contain underscores.; (#112) Variable "cells_text" must not contain underscores.; (#113) Variable "cells_text" must not contain underscores.; (#116) Variable "cells_text" must not contain underscores.; (#117) Variable "cells_text" must not contain underscores.; (#118) Variable "cells_text" must not contain underscores.; (#121) Variable "cells_text" must not contain underscores.; (#122) Variable "cells_text" must not contain underscores.; (#123) Variable "cells_text" must not contain underscores.
mod/goodhabits/classes/form/select_user_review.php: (#1) No one-line description found in phpdocs for docblock of file select_user_review.php; (#25) Missing docblock for class select_user_review; (#27) Missing docblock for function definition; (#51) There should be a comma after the last array item in a multi-line array.
mod/goodhabits/classes/habit/Habit.php: (#1) No one-line description found in phpdocs for docblock of file Habit.php; (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#66) Short array syntax must be used to define arrays; (#68) Short array syntax must be used to define arrays; (#109) There should be a comma after the last array item in a multi-line array.; (#114) Short array syntax must be used to define arrays; (#130) Short array syntax must be used to define arrays; (#143) Short array syntax must be used to define arrays; (#197) Short array syntax must be used to define arrays
mod/goodhabits/classes/habit/HabitEntry.php: (#1) No one-line description found in phpdocs for docblock of file HabitEntry.php; (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#67) Missing docblock for constant HabitEntry::ENTRY_TYPE_TWO_DIMENSIONAL; (#101) Missing docblock for function get_sql_params; (#102) Opening brace should be on the same line as the declaration; (#104) Short array syntax must be used to define arrays; (#115) Missing docblock for function get_any_existing_similar_timestamp_record; (#116) Opening brace should be on the same line as the declaration; (#121) Whitespace found at end of line within string; (#129) Missing docblock for function get_snap_to_time; (#130) Opening brace should be on the same line as the declaration; (#137) Missing docblock for function upsert; (#138) Opening brace should be on the same line as the declaration; (#158) No one-line description found in phpdocs for docblock of function save; (#163) No one-line description found in phpdocs for docblock of function update
mod/goodhabits/classes/habit/HabitEntryTwoDimensional.php: (#1) No one-line description found in phpdocs for docblock of file HabitEntryTwoDimensional.php; (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/goodhabits/classes/habit/HabitItemsHelper.php: (#1) No one-line description found in phpdocs for docblock of file HabitItemsHelper.php; (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#38) Missing docblock for constant HabitItemsHelper::HABIT_NAME_MAXLENGTH; (#39) Missing docblock for constant HabitItemsHelper::HABIT_DESC_MAXLENGTH; (#41) Missing docblock for constant HabitItemsHelper::ACTIVITY_SORT_ORDER_OFFSET; (#71) Variable "personal_habits" must not contain underscores.; (#73) Variable "personal_habits" must not contain underscores.; (#73) Variable "personal_habits" must not contain underscores.; (#75) Variable "personal_habits" must not contain underscores.; (#79) Missing docblock for function get_next_incomplete_for_user_date; (#79) Variable "calendar_unit" must not contain underscores.; (#80) Opening brace should be on the same line as the declaration; (#81) Variable "calendar_unit" must not contain underscores.; (#87) Missing docblock for function get_incomplete_for_user_date; (#87) Variable "calendar_unit" must not contain underscores.; (#88) Opening brace should be on the same line as the declaration; (#90) Variable "calendar_unit" must not contain underscores.; (#92) Whitespace found at end of line within string; (#93) The use of backticks in strings is not recommended; (#94) Whitespace found at end of line within string; (#108) Missing docblock for function habit_item_ids_to_recs; (#109) Opening brace should be on the same line as the declaration; (#132) Short array syntax must be used to define arrays; (#142) Missing docblock for function order_by_sortorder; (#143) Opening brace should be on the same line as the declaration; (#160) Short array syntax must be used to define arrays; (#174) Short array syntax must be used to define arrays; (#191) Short array syntax must be used to define arrays; (#216) Short array syntax must be used to define arrays; (#242) Missing docblock for function get_new_sortorder; (#243) Opening brace should be on the same line as the declaration; (#250) There should be a comma after the last array item in a multi-line array.; (#252) Variable "prev_sortorder" must not contain underscores.; (#253) Variable "prev_sortorder" must not contain underscores.; (#254) Variable "prev_sortorder" must not contain underscores.; (#256) Variable "prev_sortorder" must not contain underscores.; (#289) Short array syntax must be used to define arrays; (#315) Short array syntax must be used to define arrays; (#320) Missing docblock for function check_completion_status; (#321) Opening brace should be on the same line as the declaration; (#322) Variable "course_id" must not contain underscores.; (#323) Variable "course_id" must not contain underscores.; (#349) Short array syntax must be used to define arrays; (#354) Missing docblock for function get_habit_by_id; (#355) Opening brace should be on the same line as the declaration; (#360) Missing docblock for function check_change_sort_order; (#361) Opening brace should be on the same line as the declaration; (#363) Variable "habit_id" must not contain underscores.; (#367) Variable "habit_id" must not contain underscores.; (#372) Variable "habit_id" must not contain underscores.; (#375) Variable "habit_id" must not contain underscores.; (#379) Missing docblock for function change_sort_order; (#379) Variable "habit_id" must not contain underscores.; (#380) Opening brace should be on the same line as the declaration; (#382) Variable "item_to_move" must not contain underscores.; (#382) Variable "habit_id" must not contain underscores.; (#383) Variable "item_to_move" must not contain underscores.; (#384) Inline doc block comments are not allowed; use "// Comment." instead; (#389) Variable "order_by_direction" must not contain underscores.; (#392) Variable "order_by_direction" must not contain underscores.; (#397) Variable "item_to_move" must not contain underscores.; (#398) Variable "item_to_move" must not contain underscores.; (#399) Variable "item_to_move" must not contain underscores.; (#399) There should be a comma after the last array item in a multi-line array.; (#404) Variable "item_to_move" must not contain underscores.; (#405) Variable "item_to_move" must not contain underscores.; (#409) Missing docblock for function ensure_sortorder_numbers; (#409) Variable "return_activity_next" must not contain underscores.; (#410) Opening brace should be on the same line as the declaration; (#414) Variable "activity_count" must not contain underscores.; (#415) Variable "activity_offset" must not contain underscores.; (#421) Variable "activity_offset" must not contain underscores.; (#421) Variable "activity_count" must not contain underscores.; (#427) Variable "activity_count" must not contain underscores.; (#432) Variable "to_return" must not contain underscores.; (#432) Variable "return_activity_next" must not contain underscores.; (#432) Variable "activity_offset" must not contain underscores.; (#432) Variable "activity_count" must not contain underscores.; (#433) Variable "to_return" must not contain underscores.; (#446) Short array syntax must be used to define arrays; (#465) Logical operator "and" is prohibited; use "&&" instead; (#483) Short array syntax must be used to define arrays; (#484) Short array syntax must be used to define arrays; (#485) Logical operator "and" is prohibited; use "&&" instead; (#498) Short array syntax must be used to define arrays; (#500) Variable "icon_pix" must not contain underscores.; (#501) Variable "icon_pix" must not contain underscores.; (#519) Short array syntax must be used to define arrays; (#535) Short array syntax must be used to define arrays; (#539) Short array syntax must be used to define arrays; (#572) Missing docblock for function get_sort_arrow; (#572) Variable "habit_id" must not contain underscores.; (#573) Opening brace should be on the same line as the declaration; (#577) Variable "habit_id" must not contain underscores.; (#579) Short array syntax must be used to define arrays
mod/goodhabits/classes/historical_data/Helper.php: (#1) Moodle boilerplate not found; (#6) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#8) Missing @copyright tag; (#8) Missing @license tag; (#8) Missing docblock for class Helper; (#10) Missing member variable doc comment; (#10) Member variable "graph_dates" must not contain underscores.; (#12) Missing docblock for function get_habit_entries; (#12) Variable "habit_ids" must not contain underscores.; (#15) Variable "habit_ids" must not contain underscores.; (#19) Whitespace found at end of line within string; (#21) Whitespace found at end of line within string; (#49) Variable "graph_dates" must not contain underscores.; (#50) Variable "graph_dates" must not contain underscores.; (#53) Variable "habit_id" must not contain underscores.; (#54) Variable "habit_name" must not contain underscores.; (#56) Variable "habit_name" must not contain underscores.; (#57) Variable "habit_name" must not contain underscores.; (#59) Variable "habit_name" must not contain underscores.; (#68) Missing docblock for function add_missing_dates; (#69) Opening brace should be on the same line as the declaration; (#71) Variable "graph_dates" must not contain underscores.; (#71) Variable "graph_dates" must not contain underscores.; (#73) Inline comments must end in full-stops, exclamation marks, or question marks; (#74) Variable "start_date" must not contain underscores.; (#75) Variable "end_date" must not contain underscores.; (#77) Inline comments must end in full-stops, exclamation marks, or question marks; (#78) Variable "existing_dates" must not contain underscores.; (#79) Variable "graph_dates" must not contain underscores.; (#79) Variable "date_str" must not contain underscores.; (#80) Inline comments must end in full-stops, exclamation marks, or question marks; (#81) Variable "date_str" must not contain underscores.; (#82) Variable "start_date" must not contain underscores.; (#82) Variable "end_date" must not contain underscores.; (#83) Variable "existing_dates" must not contain underscores.; (#87) Inline comments must end in full-stops, exclamation marks, or question marks; (#88) Variable "existing_dates" must not contain underscores.; (#89) Variable "earliest_existing" must not contain underscores.; (#89) Variable "existing_dates" must not contain underscores.; (#90) Variable "earliest_existing" must not contain underscores.; (#90) Variable "start_date" must not contain underscores.; (#91) Variable "diff_days" must not contain underscores.; (#92) Variable "diff_days" must not contain underscores.; (#94) Variable "base_date" must not contain underscores.; (#94) Variable "earliest_existing" must not contain underscores.; (#95) Variable "base_date" must not contain underscores.; (#97) Inline comments must end in full-stops, exclamation marks, or question marks; (#98) Variable "base_date" must not contain underscores.; (#98) Variable "start_date" must not contain underscores.; (#99) Variable "base_date" must not contain underscores.; (#102) Variable "base_date" must not contain underscores.; (#102) Variable "start_date" must not contain underscores.; (#105) Inline comments must end in full-stops, exclamation marks, or question marks; (#107) Variable "base_date" must not contain underscores.; (#109) Inline comments must end in full-stops, exclamation marks, or question marks; (#110) Variable "end_date" must not contain underscores.; (#111) Inline comments must end in full-stops, exclamation marks, or question marks; (#115) Inline comments must end in full-stops, exclamation marks, or question marks; (#116) Variable "existing_dates" must not contain underscores.; (#117) Variable "base_date" must not contain underscores.; (#119) Variable "start_date" must not contain underscores.; (#120) Inline comments must end in full-stops, exclamation marks, or question marks; (#125) Inline comments must end in full-stops, exclamation marks, or question marks; (#126) Variable "graph_dates" must not contain underscores.; (#128) Inline comments must end in full-stops, exclamation marks, or question marks; (#130) Variable "dateA" must be all lower-case; (#131) Variable "dateB" must be all lower-case; (#132) Variable "dateA" must be all lower-case; (#132) Variable "dateB" must be all lower-case; (#135) Variable "graph_dates" must not contain underscores.; (#138) Missing docblock for function remove_redundant_years; (#139) Variable "graph_dates" must not contain underscores.; (#139) Variable "graph_dates" must not contain underscores.; (#140) Variable "seen_years" must not contain underscores.; (#141) Variable "graph_dates" must not contain underscores.; (#141) Variable "date_str" must not contain underscores.; (#142) Inline comments must end in full-stops, exclamation marks, or question marks; (#143) Variable "date_str" must not contain underscores.; (#144) Inline control structures are not allowed; (#144) Inline comments must end in full-stops, exclamation marks, or question marks; (#147) Variable "seen_years" must not contain underscores.; (#148) Inline comments must end in full-stops, exclamation marks, or question marks; (#149) Variable "seen_years" must not contain underscores.; (#151) Inline comments must end in full-stops, exclamation marks, or question marks; (#152) Variable "date_str" must not contain underscores.; (#155) Variable "date_str" must not contain underscores.; (#155) Inline comments must end in full-stops, exclamation marks, or question marks; (#160) Missing docblock for function populate_effort_outcome_series; (#160) Variable "entries_data" must not contain underscores.; (#160) Variable "chart_type" must not contain underscores.; (#161) Opening brace should be on the same line as the declaration; (#162) Variable "series_arr" must not contain underscores.; (#163) Variable "graph_dates" must not contain underscores.; (#164) Variable "chart_type" must not contain underscores.; (#164) Logical operator "and" is prohibited; use "&&" instead; (#165) Variable "chart_type" must not contain underscores.; (#168) Variable "entries_data" must not contain underscores.; (#168) Variable "habit_entries" must not contain underscores.; (#169) Variable "series_data" must not contain underscores.; (#171) Line indented incorrectly; expected 12 spaces, found 16; (#172) Line indented incorrectly; expected 16 spaces, found 20; (#172) Variable "habit_entries" must not contain underscores.; (#173) Variable "series_data" must not contain underscores.; (#173) Variable "habit_entries" must not contain underscores.; (#174) Line indented incorrectly; expected 16 spaces, found 20; (#175) Variable "series_data" must not contain underscores.; (#176) Line indented incorrectly; expected 16 spaces, found 20; (#177) Line indented incorrectly; expected 12 spaces, found 16; (#179) Variable "string_id" must not contain underscores.; (#180) Variable "metric_name" must not contain underscores.; (#180) Variable "string_id" must not contain underscores.; (#181) Variable "metric_name" must not contain underscores.; (#181) Variable "series_data" must not contain underscores.; (#182) Line indented incorrectly; expected 12 spaces, found 16; (#182) Variable "chart_type" must not contain underscores.; (#184) Line indented incorrectly; expected 12 spaces, found 16; (#185) Variable "series_arr" must not contain underscores.; (#188) Variable "series_arr" must not contain underscores.; (#191) Missing docblock for function map_metric_term; (#191) Variable "form_term" must not contain underscores.; (#192) Opening brace should be on the same line as the declaration; (#193) Variable "form_term" must not contain underscores.; (#203) Missing docblock for function get_metric_value; (#203) Variable "habit_entries" must not contain underscores.; (#204) Opening brace should be on the same line as the declaration; (#206) Variable "habit_entries" must not contain underscores.; (#206) Variable "habit_entries" must not contain underscores.; (#213) Variable "habit_entries" must not contain underscores.; (#219) No one-line description found in phpdocs for docblock of function get_graph_dates; (#220) Opening brace should be on the same line as the declaration; (#221) Variable "graph_dates" must not contain underscores.; (#223) File must end with a newline character
mod/goodhabits/classes/privacy/provider.php: (#1) No one-line description found in phpdocs for docblock of file provider.php; (#56) There must not be a space before the colon in a return type declaration; (#82) There must not be a space before the colon in a return type declaration; (#172) Short array syntax must be used to define arrays; (#186) Short array syntax must be used to define arrays; (#225) Short array syntax must be used to define arrays; (#256) Short array syntax must be used to define arrays; (#289) Short array syntax must be used to define arrays
mod/goodhabits/classes/review/ReviewSubject.php: (#1) No one-line description found in phpdocs for docblock of file ReviewSubject.php; (#31) Opening brace should be on the same line as the declaration for class ReviewSubject; (#36) Member variable "pref_manager" must not contain underscores.; (#37) Missing member variable doc comment; (#39) Missing member variable doc comment; (#41) Missing member variable doc comment; (#43) Missing member variable doc comment; (#43) Member variable "allow_reviews_admin" must not contain underscores.; (#44) Missing member variable doc comment; (#44) Member variable "allow_reviews_peers" must not contain underscores.; (#46) Missing docblock for function __construct; (#62) Variable "is_admin" must not contain underscores.; (#62) Variable "is_reviewer_peer" must not contain underscores.; (#63) Opening brace should be on the same line as the declaration; (#64) Variable "is_admin" must not contain underscores.; (#64) Logical operator "and" is prohibited; use "&&" instead; (#67) Variable "is_reviewer_peer" must not contain underscores.; (#67) Logical operator "and" is prohibited; use "&&" instead; (#73) Missing docblock for function get_user; (#74) Opening brace should be on the same line as the declaration; (#78) Missing docblock for function get_userid; (#79) Opening brace should be on the same line as the declaration; (#84) File must end with a newline character
mod/goodhabits/classes/review/Reviewer.php: (#1) No one-line description found in phpdocs for docblock of file Reviewer.php; (#32) Opening brace should be on the same line as the declaration for class Reviewer; (#33) Missing member variable doc comment; (#35) Missing member variable doc comment; (#37) Missing member variable doc comment; (#39) Missing member variable doc comment; (#41) Missing member variable doc comment; (#43) Missing member variable doc comment; (#45) Missing member variable doc comment; (#45) Member variable "missing_caps" must not contain underscores.; (#47) Missing member variable doc comment; (#49) Missing member variable doc comment; (#51) Missing member variable doc comment; (#51) Member variable "allow_reviews_peers" must not contain underscores.; (#53) Missing docblock for function __construct; (#59) Missing docblock for function get_userid; (#60) Opening brace should be on the same line as the declaration; (#64) Missing docblock for function can_review; (#65) Opening brace should be on the same line as the declaration; (#69) Variable "subject_id" must not contain underscores.; (#70) Variable "subject_id" must not contain underscores.; (#77) Missing docblock for function get_candidates; (#78) Opening brace should be on the same line as the declaration; (#81) Whitespace found at end of line within string; (#83) Whitespace found at end of line within string; (#110) Missing docblock for function filter_candidates; (#111) Opening brace should be on the same line as the declaration; (#122) Missing docblock for function candidate_success; (#123) Opening brace should be on the same line as the declaration; (#127) Missing docblock for function init; (#128) Opening brace should be on the same line as the declaration; (#136) Missing docblock for function init_is_admin; (#137) Opening brace should be on the same line as the declaration; (#141) Missing docblock for function init_missing_caps; (#142) Opening brace should be on the same line as the declaration; (#153) Missing docblock for function init_allow_peers; (#154) Opening brace should be on the same line as the declaration; (#155) Variable "pref_manager" must not contain underscores.; (#156) Variable "is_peer" must not contain underscores.; (#156) Variable "pref_manager" must not contain underscores.; (#157) Variable "has_peer_cap" must not contain underscores.; (#158) Variable "is_peer" must not contain underscores.; (#158) Logical operator "and" is prohibited; use "&&" instead; (#158) Variable "has_peer_cap" must not contain underscores.; (#161) Missing docblock for function set_query; (#162) Opening brace should be on the same line as the declaration; (#166) Missing docblock for function get_subjects; (#167) Opening brace should be on the same line as the declaration; (#179) Missing docblock for function get_missing_caps; (#180) Opening brace should be on the same line as the declaration; (#192) Opening brace should be on the same line as the declaration; (#194) There should be a comma after the last array item in a multi-line array.; (#198) Missing docblock for function get_peer_required_caps; (#199) Opening brace should be on the same line as the declaration; (#201) There should be a comma after the last array item in a multi-line array.; (#207) Missing docblock for function get_admin_required_caps; (#208) Opening brace should be on the same line as the declaration; (#210) There should be a comma after the last array item in a multi-line array.; (#216) File must end with a newline character
mod/goodhabits/db/access.php: (#1) No one-line description found in phpdocs for docblock of file access.php; (#26) Short array syntax must be used to define arrays; (#27) Short array syntax must be used to define arrays; (#31) Short array syntax must be used to define arrays; (#32) There should be a comma after the last array item in a multi-line array.; (#33) There should be a comma after the last array item in a multi-line array.; (#36) Short array syntax must be used to define arrays; (#39) Short array syntax must be used to define arrays; (#42) There should be a comma after the last array item in a multi-line array.; (#45) Short array syntax must be used to define arrays; (#49) Short array syntax must be used to define arrays; (#52) There should be a comma after the last array item in a multi-line array.; (#55) Short array syntax must be used to define arrays; (#59) Short array syntax must be used to define arrays; (#62) There should be a comma after the last array item in a multi-line array.; (#65) Short array syntax must be used to define arrays; (#69) Short array syntax must be used to define arrays; (#70) There should be a comma after the last array item in a multi-line array.; (#71) There should be a comma after the last array item in a multi-line array.; (#74) Short array syntax must be used to define arrays; (#78) Short array syntax must be used to define arrays; (#81) There should be a comma after the last array item in a multi-line array.; (#84) Short array syntax must be used to define arrays; (#88) Short array syntax must be used to define arrays; (#90) There should be a comma after the last array item in a multi-line array.; (#91) There should be a comma after the last array item in a multi-line array.; (#94) Short array syntax must be used to define arrays; (#98) Short array syntax must be used to define arrays; (#100) There should be a comma after the last array item in a multi-line array.; (#101) There should be a comma after the last array item in a multi-line array.; (#104) Short array syntax must be used to define arrays; (#108) Short array syntax must be used to define arrays; (#110) There should be a comma after the last array item in a multi-line array.; (#111) There should be a comma after the last array item in a multi-line array.; (#114) Short array syntax must be used to define arrays; (#117) Short array syntax must be used to define arrays; (#120) There should be a comma after the last array item in a multi-line array.; (#123) Short array syntax must be used to define arrays; (#126) Short array syntax must be used to define arrays; (#129) There should be a comma after the last array item in a multi-line array.; (#130) There should be a comma after the last array item in a multi-line array.
mod/goodhabits/db/install.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/goodhabits/db/services.php: (#21) Invalid @category tag value "services".; (#32) Duplicate array key found. The value will be overwritten. The string array key "classpath" was first seen on line 31
mod/goodhabits/db/uninstall.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/goodhabits/db/upgrade.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/goodhabits/historical_data.php: (#1) No one-line description found in phpdocs for docblock of file historical_data.php; (#33) Variable "habit_id" must not contain underscores.; (#35) Variable "subject_id" must not contain underscores.; (#43) Variable "subject_id" must not contain underscores.; (#44) Variable "reviewer_user_id" must not contain underscores.; (#45) Variable "subject_fullname" must not contain underscores.; (#45) Variable "subject_id" must not contain underscores.; (#46) Variable "reviewer_user_id" must not contain underscores.; (#48) Variable "subject_id" must not contain underscores.; (#53) Variable "subject_id" must not contain underscores.; (#72) Short array syntax must be used to define arrays; (#77) Variable "subject_id" must not contain underscores.; (#78) Short array syntax must be used to define arrays; (#78) Variable "subject_id" must not contain underscores.; (#79) Variable "review_page_url" must not contain underscores.; (#80) Variable "subject_fullname" must not contain underscores.; (#80) Variable "review_page_url" must not contain underscores.; (#87) Variable "subject_id" must not contain underscores.; (#88) Variable "access_as_string_id" must not contain underscores.; (#89) Variable "subject_fullname" must not contain underscores.; (#89) Variable "access_as_string_id" must not contain underscores.; (#94) Variable "habit_id" must not contain underscores.; (#95) Variable "first_habit" must not contain underscores.; (#96) Variable "habit_id" must not contain underscores.; (#96) Variable "first_habit" must not contain underscores.; (#99) Inline comments must end in full-stops, exclamation marks, or question marks; (#102) Variable "habit_id" must not contain underscores.; (#106) There should be a comma after the last array item in a multi-line array.; (#106) Variable "subject_id" must not contain underscores.; (#114) Inline comments must end in full-stops, exclamation marks, or question marks; (#115) Variable "habit_id" must not contain underscores.; (#123) There should be a comma after the last array item in a multi-line array.; (#130) Logical operator "and" is prohibited; use "&&" instead; (#131) Variable "bar_option" must not contain underscores.; (#132) Variable "line_option" must not contain underscores.; (#134) Variable "bar_parts" must not contain underscores.; (#134) Variable "bar_option" must not contain underscores.; (#135) Variable "bar_habit_id" must not contain underscores.; (#135) Variable "bar_parts" must not contain underscores.; (#136) Variable "bar_metric" must not contain underscores.; (#136) Variable "bar_parts" must not contain underscores.; (#136) Inline comments must start with a capital letter, digit or 3-dots sequence; (#136) Inline comments must end in full-stops, exclamation marks, or question marks; (#138) Variable "line_parts" must not contain underscores.; (#138) Variable "line_option" must not contain underscores.; (#139) Variable "line_habit_id" must not contain underscores.; (#139) Variable "line_parts" must not contain underscores.; (#140) Variable "line_metric" must not contain underscores.; (#140) Variable "line_parts" must not contain underscores.; (#142) Variable "bar_entries" must not contain underscores.; (#142) Variable "bar_habit_id" must not contain underscores.; (#143) Variable "line_entries" must not contain underscores.; (#143) Variable "line_habit_id" must not contain underscores.; (#145) Variable "bar_data" must not contain underscores.; (#145) Variable "bar_entries" must not contain underscores.; (#146) Variable "line_data" must not contain underscores.; (#146) Variable "line_entries" must not contain underscores.; (#150) Variable "bar_metric" must not contain underscores.; (#152) Variable "bar_series" must not contain underscores.; (#152) Variable "bar_data" must not contain underscores.; (#154) Variable "line_metric" must not contain underscores.; (#156) Variable "line_series" must not contain underscores.; (#156) Variable "line_data" must not contain underscores.; (#162) Variable "x_series" must not contain underscores.; (#162) Variable "bar_series" must not contain underscores.; (#163) Variable "y_series" must not contain underscores.; (#163) Variable "line_series" must not contain underscores.; (#166) Variable "habit_id" must not contain underscores.; (#168) Variable "entries_data" must not contain underscores.; (#172) Variable "x_series" must not contain underscores.; (#172) Variable "entries_data" must not contain underscores.; (#173) Variable "y_series" must not contain underscores.; (#173) Variable "entries_data" must not contain underscores.; (#181) Variable "y_series" must not contain underscores.; (#181) Variable "series_item" must not contain underscores.; (#183) Variable "series_item" must not contain underscores.; (#186) Variable "x_series" must not contain underscores.; (#186) Variable "series_item" must not contain underscores.; (#187) Variable "series_item" must not contain underscores.; (#203) File must end with a newline character
mod/goodhabits/index.php: (#31) Short array syntax must be used to define arrays; (#36) Short array syntax must be used to define arrays; (#37) There should be a comma after the last array item in a multi-line array.; (#42) Short array syntax must be used to define arrays; (#55) Short array syntax must be used to define arrays; (#62) Short array syntax must be used to define arrays; (#63) Short array syntax must be used to define arrays; (#65) Short array syntax must be used to define arrays; (#66) Short array syntax must be used to define arrays; (#68) Short array syntax must be used to define arrays; (#69) Short array syntax must be used to define arrays; (#75) Short array syntax must be used to define arrays; (#77) Short array syntax must be used to define arrays; (#80) Short array syntax must be used to define arrays; (#84) Logical operator "or" is prohibited; use "||" instead; (#85) Short array syntax must be used to define arrays; (#87) Short array syntax must be used to define arrays
mod/goodhabits/lang/en/goodhabits.php: (#29) The string key "modulename" is not in the correct order, it should be before "pluginname"; (#31) The string key "goodhabitsname" is not in the correct order, it should be before "modulenameplural"; (#34) The string key "general_settings" is not in the correct order, it should be before "goodhabitssettings"; (#35) The string key "default_settings" is not in the correct order, it should be before "general_settings"; (#40) The string key "by_day" is not in the correct order, it should be before "pluginadministration"; (#43) The string key "submit_text_change_cal" is not in the correct order, it should be before "x_days"; (#44) The string key "add_new_habit_name" is not in the correct order, it should be before "submit_text_change_cal"; (#45) The string key "add_new_habit_desc" is not in the correct order, it should be before "add_new_habit_name"; (#46) The string key "add_new_habit" is not in the correct order, it should be before "add_new_habit_desc"; (#48) The string key "settings_heading" is not in the correct order, it should be before "week_displayunit"; (#49) The string key "settings_desc" is not in the correct order, it should be before "settings_heading"; (#52) The string key "good_habits:manage_entries" is not in the correct order, it should be before "settings_desc"; (#55) The string key "delete_all_entries" is not in the correct order, it should be before "good_habits:view"; (#56) The string key "confirm_delete_entries_text" is not in the correct order, it should be before "delete_all_entries"; (#62) The string key "mod_goodhabits_subcontext" is not in the correct order, it should be before "privacy:metadata:y_axis_val"; (#64) The string key "habit_added" is not in the correct order, it should be before "mod_goodhabits_subcontext"; (#66) The string key "add_new_habit_personal" is not in the correct order, it should be before "habit_entries_deleted"; (#67) The string key "add_new_habit_global" is not in the correct order, it should be before "add_new_habit_personal"; (#70) The string key "cancel" is not in the correct order, it should be before "entry_for"; (#73) The string key "imagetitle" is not in the correct order, it should be before "save"; (#76) The string key "x_small_label_left" is not in the correct order, it should be before "ylabel"; (#77) The string key "x_small_label_center" is not in the correct order, it should be before "x_small_label_left"; (#82) The string key "x_select_label" is not in the correct order, it should be before "y_small_label_top"; (#84) The string key "x_default" is not in the correct order, it should be before "y_select_label"; (#86) The string key "overlay_1_1" is not in the correct order, it should be before "y_default"; (#96) The string key "manage_breaks" is not in the correct order, it should be before "overlay_3_3"; (#99) The string key "manage_activity_habits_title" is not in the correct order, it should be before "manage_habits_title"; (#102) The string key "fromdate_text" is not in the correct order, it should be before "manage_prefs_title"; (#104) The string key "addbreak_submit_text" is not in the correct order, it should be before "todate_text"; (#106) The string key "activity_addhabit_submit_text" is not in the correct order, it should be before "addhabit_submit_text"; (#108) The string key "activity_edithabit_submit_text" is not in the correct order, it should be before "edithabit_submit_text"; (#110) The string key "actions" is not in the correct order, it should be before "home_link"; (#113) The string key "break_deleted" is not in the correct order, it should be before "edit"; (#114) The string key "break_added" is not in the correct order, it should be before "break_deleted"; (#117) The string key "habit_level" is not in the correct order, it should be before "review_no_habits"; (#119) The string key "new_habit_desc" is not in the correct order, it should be before "new_habit_name"; (#120) The string key "habit_type" is not in the correct order, it should be before "new_habit_desc"; (#123) The string key "habit_deleted" is not in the correct order, it should be before "habit_type_personal"; (#125) The string key "habit_entries_deleted" is duplicated; (#127) The string key "delete_entries" is not in the correct order, it should be before "habit_num_entries"; (#131) The string key "js_confirm_deletebreak" is not in the correct order, it should be before "js_confirm_deletehabitentries"; (#132) The string key "freq" is not in the correct order, it should be before "js_confirm_deletebreak"; (#134) The string key "freq_desc" is not in the correct order, it should be before "freq_help"; (#139) The string key "access_review_entries_as_admin" is not in the correct order, it should be before "review_entries_name"; (#142) The string key "review_select_submit" is not in the correct order, it should be before "select_users"; (#143) The string key "checkmark_title" is not in the correct order, it should be before "review_select_submit"; (#146) The string key "accessing_review_when_disabled" is not in the correct order, it should be before "checkmark_title_empty"; (#150) The string key "name_append_is_activity" is not in the correct order, it should be before "personal"; (#151) The string key "habit_name_title_activity" is not in the correct order, it should be before "name_append_is_activity"; (#153) The string key "activity_title_text" is not in the correct order, it should be before "manage_activity_habits"; (#156) The string key "habit_not_published_title" is not in the correct order, it should be before "showhide"; (#157) The string key "completionentriesgroup" is not in the correct order, it should be before "habit_not_published_title"; (#158) The string key "completionentries" is not in the correct order, it should be before "completionentriesgroup"; (#160) The string key "goodhabits:manage_activity_habits" is not in the correct order, it should be before "goodhabits:review_as_admin"; (#165) The string key "review" is not in the correct order, it should be before "review_enable_opt_out"; (#168) The string key "mobile_view" is not in the correct order, it should be before "small_viewport_message"; (#169) The string key "exit_mobile_view" is not in the correct order, it should be before "mobile_view"; (#171) The string key "answer_questions" is not in the correct order, it should be before "notification_skip_added"; (#173) The string key "saved" is not in the correct order, it should be before "skip"; (#174) The string key "all_complete" is not in the correct order, it should be before "saved"; (#178) The string key "blocks_of_days" is not in the correct order, it should be before "weeks"; (#181) The string key "blocks_of_day" is not in the correct order, it should be before "week"; (#183) Unexpected comment found. Auto-fixing will not work after this comment; (#183) Inline comments must start with a capital letter, digit or 3-dots sequence; (#183) This comment is 78% valid code; is this commented out code?; (#183) No space found before comment text; expected "// $string['completed_cal_units'] = 'Number of {$a->period_duration} completed: {$a->completed}';" but found "//$string['completed_cal_units'] = 'Number of {$a->period_duration} completed: {$a->completed}';"; (#185) The string key "completion_habits" is not in the correct order, it should be before "label_remaining"; (#186) Unexpected comment found. Auto-fixing will not work after this comment; (#186) Inline comments must start with a capital letter, digit or 3-dots sequence; (#186) This comment is 74% valid code; is this commented out code?; (#186) No space found before comment text; expected "// $string['completionentries'] = 'You have to add a minimum number of entries';" but found "//$string['completionentries'] = 'You have to add a minimum number of entries';"; (#187) Unexpected comment found. Auto-fixing will not work after this comment; (#187) No space found before comment text; expected "// $string['completioncalendarunits'] = 'You have to complete a minimum number of days/weeks';" but found "//$string['completioncalendarunits'] = 'You have to complete a minimum number of days/weeks';"; (#189) The string key "completiondetail:min_entries" is not in the correct order, it should be before "completiondetail:min_habits"; (#190) The string key "completiondetail:min_cal_units" is not in the correct order, it should be before "completiondetail:min_entries"; (#192) The string key "simple_view_effort" is not in the correct order, it should be before "starting"; (#194) The string key "simple_view_back" is not in the correct order, it should be before "simple_view_outcome"; (#195) The string key "allow_reviews_peers" is not in the correct order, it should be before "simple_view_back"; (#197) The string key "allow_reviews_admin" is not in the correct order, it should be before "allow_reviews_peers_help"; (#199) The string key "allow_review_others" is not in the correct order, it should be before "allow_reviews_admin_help"; (#201) The string key "prefs_appearance" is not in the correct order, it should be before "prefs_tracker_privacy_header"; (#202) The string key "pref_updated" is not in the correct order, it should be before "prefs_appearance"; (#203) The string key "default_settings_desc" is not in the correct order, it should be before "pref_updated"; (#206) The string key "opt_def_disallow" is not in the correct order, it should be before "required"; (#207) The string key "opt_def_allow" is not in the correct order, it should be before "opt_def_disallow"; (#208) The string key "cm_reviews_admin" is not in the correct order, it should be before "opt_def_allow"; (#212) The string key "grid_box_wording_intro" is not in the correct order, it should be before "no_access"; (#213) The string key "goodhabits:review_as_peer" is not in the correct order, it should be before "grid_box_wording_intro"; (#215) The string key "cm_reviews_admin_help" is not in the correct order, it should be before "lacking_peer_caps"; (#233) The string key "answer_latest_questions" is not in the correct order, it should be before "get_started"; (#234) The string key "answer_latest_day" is not in the correct order, it should be before "answer_latest_questions"; (#236) The string key "answer_latest_block_of_days" is not in the correct order, it should be before "answer_latest_week"; (#238) The string key "show_scores" is not in the correct order, it should be before "simple_all_complete"; (#242) The string key "enable_help" is not in the correct order, it should be before "show_scores_help"; (#248) Unexpected comment found. Auto-fixing will not work after this comment; (#249) The string key "dyk_heading" is not in the correct order, it should be before "example"; (#250) The string key "dyk_add_entry_heading" is not in the correct order, it should be before "dyk_heading"; (#251) The string key "dyk_add_entry_1" is not in the correct order, it should be before "dyk_add_entry_heading"; (#252) Unexpected comment found. Auto-fixing will not work after this comment; (#252) Inline comments must start with a capital letter, digit or 3-dots sequence; (#252) This comment is 78% valid code; is this commented out code?; (#252) No space found before comment text; expected "// $string['dyk_add_entry_2'] = 'This opens up a grid to allow you to reflect on a habit for a particular {$a}.';" but found "//$string['dyk_add_entry_2'] = 'This opens up a grid to allow you to reflect on a habit for a particular {$a}.';"; (#258) The string key "dyk_cal_unit_options_1" is not in the correct order, it should be before "dyk_cal_unit_options_heading"; (#261) Unexpected comment found. Auto-fixing will not work after this comment; (#261) Inline comments must start with a capital letter, digit or 3-dots sequence; (#261) This comment is 78% valid code; is this commented out code?; (#261) No space found before comment text; expected "// $string['dyk_cal_unit_options_4'] = 'Skipping a {$a} will grey it out, so you know you don\'t want to add any entries for that week, and it can be ignored.';" but found "//$string['dyk_cal_unit_options_4'] = 'Skipping a {$a} will grey it out, so you know you don\'t want to add any entries for that week, and it can be ignored.';"; (#265) The string key "dyk_prefs_1" is not in the correct order, it should be before "dyk_prefs_heading"; (#270) The string key "dyk_mng_habits_heading" is not in the correct order, it should be before "dyk_prefs_4"; (#271) The string key "dyk_mng_habits_1" is not in the correct order, it should be before "dyk_mng_habits_heading"; (#291) The string key "block_of_days" is not in the correct order, it should be before "simple_view_outcome_5"; (#294) The string key "def_article_block_of_days" is not in the correct order, it should be before "def_article_week"; (#295) The string key "chosen_day" is not in the correct order, it should be before "def_article_block_of_days"; (#297) The string key "chosen_block_of_days" is not in the correct order, it should be before "chosen_week"; (#300) The string key "skipped_block_of_days" is not in the correct order, it should be before "skipped_week"; (#301) The string key "skip_help_day" is not in the correct order, it should be before "skipped_block_of_days"; (#303) The string key "skip_help_block_of_days" is not in the correct order, it should be before "skip_help_week"; (#304) The string key "grid_open_help_day" is not in the correct order, it should be before "skip_help_block_of_days"; (#306) The string key "grid_open_help_block_of_days" is not in the correct order, it should be before "grid_open_help_week"; (#307) The string key "average_eff_out" is not in the correct order, it should be before "grid_open_help_block_of_days"; (#310) The string key "historical_data" is not in the correct order, it should be before "no_entries"; (#313) The string key "enddate" is not in the correct order, it should be before "startdate"; (#315) The string key "advancedsettings" is not in the correct order, it should be before "goodhabits:view_own_historical_data"; (#319) The string key "difference" is not in the correct order, it should be before "outcome"; (#320) The string key "bardata" is not in the correct order, it should be before "difference"; (#322) The string key "difflabel" is not in the correct order, it should be before "linedata"
mod/goodhabits/lib.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#99) Short array syntax must be used to define arrays; (#112) Short array syntax must be used to define arrays; (#115) Short array syntax must be used to define arrays; (#132) Short array syntax must be used to define arrays; (#138) Variable "min_habits" must not contain underscores.; (#140) Variable "min_habits" must not contain underscores.; (#160) Variable "num_cal_rqd" must not contain underscores.; (#162) Variable "num_cal_rqd" must not contain underscores.; (#174) Missing docblock for function goodhabits_get_coursemodule_info; (#176) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#202) Missing docblock for function goodhabits_get_completion_active_rule_descriptions; (#206) Missing docblock for function mod_goodhabits_get_completion_active_rule_descriptions
mod/goodhabits/manage_breaks.php: (#1) No one-line description found in phpdocs for docblock of file manage_breaks.php; (#49) Short array syntax must be used to define arrays; (#64) Short array syntax must be used to define arrays; (#77) Short array syntax must be used to define arrays; (#82) Short array syntax must be used to define arrays; (#99) Short array syntax must be used to define arrays
mod/goodhabits/manage_habits.php: (#1) No one-line description found in phpdocs for docblock of file manage_habits.php; (#61) Short array syntax must be used to define arrays; (#99) Variable "num_activity_habits" must not contain underscores.; (#101) Variable "personal_habits" must not contain underscores.; (#103) Variable "personal_habits" must not contain underscores.; (#104) Variable "personal_habits" must not contain underscores.; (#104) Variable "personal_habits" must not contain underscores.; (#105) Variable "personal_habits" must not contain underscores.; (#108) Variable "activity_count" must not contain underscores.; (#109) Variable "personal_count" must not contain underscores.; (#110) Variable "num_personal_habits" must not contain underscores.; (#110) Variable "personal_habits" must not contain underscores.; (#113) Short array syntax must be used to define arrays; (#127) Logical operator "and" is prohibited; use "&&" instead; (#128) Variable "activity_count" must not contain underscores.; (#128) Variable "num_activity_habits" must not contain underscores.; (#131) Variable "activity_count" must not contain underscores.; (#134) Variable "activity_count" must not contain underscores.; (#137) Variable "personal_count" must not contain underscores.; (#137) Variable "num_personal_habits" must not contain underscores.; (#141) Variable "personal_count" must not contain underscores.; (#144) Variable "personal_count" must not contain underscores.; (#154) Logical operator "and" is prohibited; use "&&" instead; (#155) Variable "rendered_table" must not contain underscores.; (#156) Variable "rendered_table" must not contain underscores.; (#164) Short array syntax must be used to define arrays
mod/goodhabits/mod_form.php: (#53) Short array syntax must be used to define arrays; (#84) Variable "site_config" must not contain underscores.; (#85) Variable "site_config" must not contain underscores.; (#103) Variable "caps_text" must not contain underscores.; (#105) Variable "caps_text" must not contain underscores.; (#108) Variable "caps_text" must not contain underscores.; (#110) Variable "caps_text" must not contain underscores.; (#112) Functions must not contain multiple empty lines in a row; found 2 empty lines; (#129) Short array syntax must be used to define arrays; (#142) Short array syntax must be used to define arrays; (#151) Short array syntax must be used to define arrays; (#160) Short array syntax must be used to define arrays; (#172) Short array syntax must be used to define arrays; (#190) Functions must not contain multiple empty lines in a row; found 4 empty lines; (#194) Short array syntax must be used to define arrays; (#197) Missing docblock for function get_suffixed_name; (#212) Variable "completion_entries_enabled" must not contain underscores.; (#213) Variable "completion_entries" must not contain underscores.; (#214) Variable "completion_entries_condition" must not contain underscores.; (#214) Variable "completion_entries" must not contain underscores.; (#214) Logical operator "and" is prohibited; use "&&" instead; (#214) Variable "completion_entries_enabled" must not contain underscores.; (#216) Variable "completion_cu_enabled" must not contain underscores.; (#217) Variable "completion_calendar_units" must not contain underscores.; (#218) Variable "completion_calendar_units_condition" must not contain underscores.; (#218) Variable "completion_calendar_units" must not contain underscores.; (#218) Logical operator "and" is prohibited; use "&&" instead; (#218) Variable "completion_cu_enabled" must not contain underscores.; (#220) Variable "completion_entries_condition" must not contain underscores.; (#220) Logical operator "or" is prohibited; use "||" instead; (#220) Variable "completion_calendar_units_condition" must not contain underscores.
mod/goodhabits/preferences.php: (#1) No one-line description found in phpdocs for docblock of file preferences.php; (#54) Short array syntax must be used to define arrays; (#62) Short array syntax must be used to define arrays; (#71) Variable "msg_success" must not contain underscores.; (#72) Variable "msg_success" must not contain underscores.
mod/goodhabits/renderer.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#28) Missing docblock for class mod_goodhabits_renderer; (#51) Variable "to_date" must not contain underscores.; (#54) Variable "backurl_small_screen" must not contain underscores.; (#56) Variable "forwardurl_small_screen" must not contain underscores.; (#60) Variable "backurl_small_screen" must not contain underscores.; (#61) Variable "forwardurl_small_screen" must not contain underscores.; (#72) Variable "all_complete" must not contain underscores.; (#78) Variable "imploded_classes" must not contain underscores.; (#80) Variable "flexi_cal_unit" must not contain underscores.; (#81) Variable "flexi_cal_unit" must not contain underscores.; (#82) Variable "flexi_cal_unit" must not contain underscores.; (#83) Variable "flexi_cal_unit" must not contain underscores.; (#84) Variable "flexi_cal_unit" must not contain underscores.; (#84) Variable "imploded_classes" must not contain underscores.; (#85) Variable "flexi_cal_unit" must not contain underscores.; (#85) Variable "to_date" must not contain underscores.; (#86) Variable "flexi_cal_unit" must not contain underscores.; (#87) Variable "flexi_cal_unit" must not contain underscores.; (#87) Variable "all_complete" must not contain underscores.; (#89) Variable "flexi_cal_unit" must not contain underscores.; (#105) Declaring an optional parameter before a required parameter is deprecated since PHP 8.0. Parameter $userid is optional, while parameter $instanceid is required. The $userid parameter is implicitly treated as a required parameter.; (#123) Declaring an optional parameter before a required parameter is deprecated since PHP 8.0. Parameter $userid is optional, while parameter $instanceid is required. The $userid parameter is implicitly treated as a required parameter.; (#124) Variable "habit_data" must not contain underscores.; (#125) Variable "habit_data" must not contain underscores.; (#131) Variable "habit_data" must not contain underscores.; (#134) Logical operator "and" is prohibited; use "&&" instead; (#137) Logical operator "and" is prohibited; use "&&" instead; (#145) Variable "habit_data" must not contain underscores.; (#146) Variable "habit_data" must not contain underscores.; (#150) Variable "habit_data" must not contain underscores.; (#151) Variable "habit_data" must not contain underscores.; (#152) Variable "habit_data" must not contain underscores.; (#153) Variable "effort_avg" must not contain underscores.; (#154) Variable "outcome_avg" must not contain underscores.; (#156) Variable "habit_data" must not contain underscores.; (#156) Variable "effort_avg" must not contain underscores.; (#157) Variable "habit_data" must not contain underscores.; (#157) Variable "outcome_avg" must not contain underscores.; (#158) Variable "habit_data" must not contain underscores.; (#158) Variable "effort_avg" must not contain underscores.; (#159) Variable "habit_data" must not contain underscores.; (#159) Variable "outcome_avg" must not contain underscores.; (#161) Variable "first_entry" must not contain underscores.; (#162) Variable "habit_data" must not contain underscores.; (#162) Variable "first_entry" must not contain underscores.; (#163) Variable "first_entry" must not contain underscores.; (#169) There should be a comma after the last array item in a multi-line array.; (#172) Variable "habit_data" must not contain underscores.; (#173) Variable "habit_data" must not contain underscores.; (#175) Variable "current_period_end" must not contain underscores.; (#180) There should be a comma after the last array item in a multi-line array.; (#180) Variable "current_period_end" must not contain underscores.; (#183) Variable "habit_data" must not contain underscores.; (#186) Variable "habit_data" must not contain underscores.; (#188) Variable "habit_data" must not contain underscores.; (#201) Declaring an optional parameter before a required parameter is deprecated since PHP 8.0. Parameter $userid is optional, while parameter $instanceid is required. The $userid parameter is implicitly treated as a required parameter.; (#201) Line exceeds 132 characters; contains 133 characters; (#215) Variable "prefs_mgr" must not contain underscores.; (#216) Variable "pref_show_scores" must not contain underscores.; (#216) Variable "prefs_mgr" must not contain underscores.; (#218) Variable "pref_show_scores" must not contain underscores.; (#228) Variable "show_scores" must not contain underscores.; (#228) Variable "pref_show_scores" must not contain underscores.; (#229) Variable "data_checkmark" must not contain underscores.; (#234) Variable "is_filled" must not contain underscores.; (#238) Variable "is_filled" must not contain underscores.; (#246) Logical operator "and" is prohibited; use "&&" instead; (#252) Variable "show_scores" must not contain underscores.; (#255) Variable "show_scores" must not contain underscores.; (#261) Variable "data_checkmark" must not contain underscores.; (#261) Variable "is_filled" must not contain underscores.; (#262) Variable "data_checkmark" must not contain underscores.; (#263) Variable "data_checkmark" must not contain underscores.; (#264) Variable "data_checkmark" must not contain underscores.; (#265) Variable "data_checkmark" must not contain underscores.; (#266) Variable "data_checkmark" must not contain underscores.; (#267) Variable "data_checkmark" must not contain underscores.; (#269) Variable "data_checkmark" must not contain underscores.; (#291) Variable "pref_mgr" must not contain underscores.; (#293) Short array syntax must be used to define arrays; (#307) Short array syntax must be used to define arrays; (#308) There should be a comma after the last array item in a multi-line array.; (#311) Short array syntax must be used to define arrays; (#314) There should be a comma after the last array item in a multi-line array.; (#322) Variable "overlay_strings" must not contain underscores.; (#324) Variable "overlay_strings" must not contain underscores.; (#324) Variable "overlay_string" must not contain underscores.; (#325) Variable "overlay_string" must not contain underscores.; (#325) Variable "pref_mgr" must not contain underscores.; (#325) Variable "overlay_string" must not contain underscores.; (#343) Short array syntax must be used to define arrays; (#356) Variable "string_id" must not contain underscores.; (#357) Short array syntax must be used to define arrays; (#359) Variable "string_id" must not contain underscores.; (#363) Missing docblock for function print_see_historical_data; (#363) Variable "subject_id" must not contain underscores.; (#364) Short array syntax must be used to define arrays; (#365) Variable "subject_id" must not contain underscores.; (#366) Variable "subject_id" must not contain underscores.; (#373) Missing docblock for function print_exit_mobile_view; (#374) Short array syntax must be used to define arrays; (#380) Missing docblock for function print_mobile_view; (#381) Short array syntax must be used to define arrays; (#388) Missing docblock for function print_preferences; (#389) Short array syntax must be used to define arrays; (#403) Short array syntax must be used to define arrays; (#417) Short array syntax must be used to define arrays; (#432) Short array syntax must be used to define arrays; (#466) Missing docblock for function print_review_no_habits; (#467) Opening brace should be on the same line as the declaration; (#478) Short array syntax must be used to define arrays; (#483) Inline comments must start with a capital letter, digit or 3-dots sequence; (#483) This comment is 44% valid code; is this commented out code?; (#483) Line indented incorrectly; expected at least 4 spaces, found 0; (#483) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#484) Line indented incorrectly; expected at least 4 spaces, found 0; (#484) Expected 1 space before comment text but found 5; use block comment if you need indentation; (#485) Line indented incorrectly; expected at least 4 spaces, found 0; (#485) Expected 1 space before comment text but found 5; use block comment if you need indentation; (#486) Line indented incorrectly; expected at least 4 spaces, found 0; (#486) Expected 1 space before comment text but found 5; use block comment if you need indentation; (#487) Line indented incorrectly; expected at least 4 spaces, found 0; (#487) Expected 1 space before comment text but found 5; use block comment if you need indentation; (#488) Line indented incorrectly; expected at least 4 spaces, found 0; (#488) Expected 1 space before comment text but found 5; use block comment if you need indentation; (#489) Line indented incorrectly; expected at least 4 spaces, found 0; (#489) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#490) Line indented incorrectly; expected at least 4 spaces, found 0; (#490) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#491) Line indented incorrectly; expected at least 4 spaces, found 0; (#491) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#492) Line indented incorrectly; expected at least 4 spaces, found 0; (#492) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#493) Line indented incorrectly; expected at least 4 spaces, found 0; (#493) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#494) Line indented incorrectly; expected at least 4 spaces, found 0; (#494) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#495) Line indented incorrectly; expected at least 4 spaces, found 0; (#495) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#496) Line indented incorrectly; expected at least 4 spaces, found 0; (#496) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#510) Short array syntax must be used to define arrays; (#510) Line exceeds 132 characters; contains 140 characters; (#511) Opening brace should be on the same line as the declaration; (#512) global $OUTPUT cannot be used in renderers. Use $this->output.; (#523) Variable "template_data" must not contain underscores.; (#525) Variable "template_data" must not contain underscores.; (#527) Variable "template_data" must not contain underscores.; (#529) Variable "template_data" must not contain underscores.; (#530) Variable "template_data" must not contain underscores.; (#532) Variable "template_data" must not contain underscores.; (#535) global $OUTPUT cannot be used in renderers. Use $this->output.; (#535) Variable "template_data" must not contain underscores.; (#538) Missing docblock for function get_help_data; (#539) Opening brace should be on the same line as the declaration; (#543) Variable "prefs_mgr" must not contain underscores.; (#544) Variable "enable_help" must not contain underscores.; (#544) Variable "prefs_mgr" must not contain underscores.; (#550) Variable "enable_help" must not contain underscores.; (#556) Variable "answer_latest_string" must not contain underscores.; (#557) Variable "units_with_all_complete" must not contain underscores.; (#562) No space found before comment text; expected "// TODO: Change this to check for just one entry." but found "//TODO: Change this to check for just one entry."; (#563) Variable "units_with_all_complete" must not contain underscores.; (#566) Variable "answer_latest_string" must not contain underscores.; (#568) Empty ELSE statement detected; (#569) This comment is 52% valid code; is this commented out code?; (#570) Line indented incorrectly; expected at least 12 spaces, found 0; (#570) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#571) Line indented incorrectly; expected at least 12 spaces, found 0; (#571) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#572) Line indented incorrectly; expected at least 12 spaces, found 0; (#572) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#573) Line indented incorrectly; expected at least 12 spaces, found 0; (#573) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#574) Line indented incorrectly; expected at least 12 spaces, found 0; (#574) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#575) Line indented incorrectly; expected at least 12 spaces, found 0; (#575) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#576) Line indented incorrectly; expected at least 12 spaces, found 0; (#576) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#577) Inline comments must end in full-stops, exclamation marks, or question marks; (#577) Line indented incorrectly; expected at least 12 spaces, found 0; (#577) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#582) global $OUTPUT cannot be used in renderers. Use $this->output.; (#591) Variable "dyk_help_text" must not contain underscores.; (#591) global $OUTPUT cannot be used in renderers. Use $this->output.; (#592) Variable "dyk_help_text" must not contain underscores.; (#598) Missing docblock for function print_viewport_too_small_message; (#604) Missing docblock for function get_completion_data; (#605) Opening brace should be on the same line as the declaration; (#609) Variable "compl_data" must not contain underscores.; (#610) Variable "period_duration_string" must not contain underscores.; (#612) Inline comments must start with a capital letter, digit or 3-dots sequence; (#612) This comment is 56% valid code; is this commented out code?; (#612) Line indented incorrectly; expected at least 8 spaces, found 0; (#612) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#613) Line indented incorrectly; expected at least 8 spaces, found 0; (#613) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#614) Variable "num_complete" must not contain underscores.; (#615) Inline comments must start with a capital letter, digit or 3-dots sequence; (#615) This comment is 63% valid code; is this commented out code?; (#615) Line indented incorrectly; expected at least 8 spaces, found 0; (#615) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#617) Variable "compl_data" must not contain underscores.; (#617) Variable "period_duration_string" must not contain underscores.; (#618) Variable "compl_data" must not contain underscores.; (#618) Variable "num_complete" must not contain underscores.; (#620) Short array syntax must be used to define arrays; (#622) Variable "to_complete" must not contain underscores.; (#623) Variable "to_complete" must not contain underscores.; (#624) Variable "compl_data" must not contain underscores.; (#625) Variable "num_remaining" must not contain underscores.; (#625) Variable "to_complete" must not contain underscores.; (#625) Variable "num_complete" must not contain underscores.; (#626) Variable "num_remaining" must not contain underscores.; (#627) Variable "num_remaining" must not contain underscores.; (#629) Variable "compl_data" must not contain underscores.; (#629) Variable "num_remaining" must not contain underscores.; (#632) Variable "compl_data" must not contain underscores.
mod/goodhabits/review.php: (#1) No one-line description found in phpdocs for docblock of file review.php; (#41) Variable "can_access_review" must not contain underscores.; (#41) Logical operator "or" is prohibited; use "||" instead; (#41) Line exceeds 132 characters; contains 143 characters; (#43) Variable "reviewer_user_id" must not contain underscores.; (#45) Variable "can_access_review" must not contain underscores.; (#50) Variable "reviewer_user_id" must not contain underscores.; (#52) Variable "can_review_user" must not contain underscores.; (#53) Variable "can_review_user" must not contain underscores.; (#74) Short array syntax must be used to define arrays; (#105) Variable "access_as_string_id" must not contain underscores.; (#109) Variable "access_as_string_id" must not contain underscores.; (#113) Short array syntax must be used to define arrays; (#116) Variable "can_see_historical_data" must not contain underscores.; (#117) Variable "can_see_historical_data" must not contain underscores.
mod/goodhabits/settings.php: (#1) No one-line description found in phpdocs for docblock of file settings.php
mod/goodhabits/simple.php: (#37) Short array syntax must be used to define arrays; (#40) Variable "is_basic_mobile" must not contain underscores.; (#49) No space found before comment text; expected "// TODO: Combine logic with view.php in single class." but found "//TODO: Combine logic with view.php in single class."; (#50) Short array syntax must be used to define arrays; (#52) There should be a comma after the last array item in a multi-line array.; (#61) Short array syntax must be used to define arrays; (#65) Inline comments must start with a capital letter, digit or 3-dots sequence; (#65) This comment is 86% valid code; is this commented out code?; (#65) No space found before comment text; expected "// $PAGE->set_secondary_active_tab("goodhabits_simple");" but found "//$PAGE->set_secondary_active_tab("goodhabits_simple");"; (#76) Variable "is_basic_mobile" must not contain underscores.; (#85) Variable "calendar_unit" must not contain underscores.; (#87) Variable "calendar_unit" must not contain underscores.; (#90) Variable "all_complete" must not contain underscores.; (#91) Variable "all_complete" must not contain underscores.; (#93) Variable "calendar_unit" must not contain underscores.; (#98) Variable "calendar_unit" must not contain underscores.; (#100) Variable "calendar_unit" must not contain underscores.; (#103) Variable "calendar_unit" must not contain underscores.; (#105) Variable "calendar_unit" must not contain underscores.; (#106) Variable "item_ids" must not contain underscores.; (#108) Variable "habits_recs" must not contain underscores.; (#108) Variable "item_ids" must not contain underscores.; (#109) Variable "habits_recs" must not contain underscores.; (#109) Variable "habits_recs" must not contain underscores.; (#112) Variable "habits_recs" must not contain underscores.; (#112) Variable "habits_rec" must not contain underscores.; (#114) Variable "habits_rec" must not contain underscores.; (#115) Variable "habits_rec" must not contain underscores.; (#116) Variable "habits_rec" must not contain underscores.; (#126) Short array syntax must be used to define arrays; (#127) Variable "next_calendar_unit" must not contain underscores.; (#127) Variable "calendar_unit" must not contain underscores.; (#128) Variable "to_date" must not contain underscores.; (#128) Variable "next_calendar_unit" must not contain underscores.; (#129) Variable "to_date" must not contain underscores.; (#130) Variable "view_url" must not contain underscores.; (#132) Variable "view_url" must not contain underscores.; (#134) Variable "template_data" must not contain underscores.; (#141) Variable "view_url" must not contain underscores.; (#143) There should be a comma after the last array item in a multi-line array.; (#146) Variable "template_data" must not contain underscores.
mod/goodhabits/view.php: (#39) Variable "is_basic_mobile" must not contain underscores.; (#43) Short array syntax must be used to define arrays; (#44) Short array syntax must be used to define arrays; (#47) Short array syntax must be used to define arrays; (#61) Short array syntax must be used to define arrays; (#63) There should be a comma after the last array item in a multi-line array.; (#80) Inline comments must start with a capital letter, digit or 3-dots sequence; (#80) This comment is 84% valid code; is this commented out code?; (#80) No space found before comment text; expected "// $auto->execute();" but found "//$auto->execute();"; (#83) Short array syntax must be used to define arrays; (#95) Variable "is_basic_mobile" must not contain underscores.; (#109) Variable "is_basic_mobile" must not contain underscores.; (#115) Variable "is_basic_mobile" must not contain underscores.; (#123) This comment is 63% valid code; is this commented out code?; (#123) 4 slashes comments are not allowed; use "// Comment." instead; (#123) No space found before comment text; expected "// TODO: Check settings." but found "////TODO: Check settings."; (#124) Line exceeds 132 characters; contains 149 characters; (#124) Inline comments must end in full-stops, exclamation marks, or question marks; (#124) No space found before comment text; expected "// $canreview = (has_capability('mod/goodhabits:review_as_admin', $PAGE->context) OR has_capability('mod/goodhabits:review_as_peer', $PAGE->context));" but found "//$canreview = (has_capability('mod/goodhabits:review_as_admin', $PAGE->context) OR has_capability('mod/goodhabits:review_as_peer', $PAGE->context));"; (#125) Variable "access_review_as" must not contain underscores.; (#127) Variable "access_review_string" must not contain underscores.; (#128) Variable "access_review_as" must not contain underscores.; (#129) Variable "access_review_string" must not contain underscores.; (#132) Variable "access_review_as" must not contain underscores.; (#146) Variable "access_review_string" must not contain underscores.; (#163) Inline comments must start with a capital letter, digit or 3-dots sequence; (#163) This comment is 86% valid code; is this commented out code?; (#163) No space found before comment text; expected "// $renderer->print_mobile_view($instanceid);" but found "//$renderer->print_mobile_view($instanceid);"

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

Overview

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems