PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(45 errors, 35 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- mod/giportfolio/backup/moodle2/restore_giportfolio_stepslib.php
- (#28) Expected MOODLE_INTERNAL check or config.php inclusion
- mod/giportfolio/classes/event/chapter_created.php
- (#52) Inline doc block type-hinting for '$event' does not match next code line 'return...'
- mod/giportfolio/classes/event/chapter_deleted.php
- (#52) Inline doc block type-hinting for '$event' does not match next code line 'return...'
- (#73) Line exceeds 132 characters; contains 155 characters
- mod/giportfolio/classes/event/chapter_updated.php
- (#52) Inline doc block type-hinting for '$event' does not match next code line 'return...'
- mod/giportfolio/classes/event/chapter_viewed.php
- (#52) Inline doc block type-hinting for '$event' does not match next code line 'return...'
- (#91) Line exceeds 132 characters; contains 133 characters
- mod/giportfolio/classes/event/course_module_instance_list_viewed.php
- (#47) Must use "self::" for local static member reference
- (#48) Closing brace must be on a line by itself
- mod/giportfolio/classes/event/course_module_viewed.php
- (#51) Inline doc block type-hinting for '$event' does not match next code line 'return...'
- mod/giportfolio/db/upgrade.php
- (#50) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#50) Inline comments must end in full-stops, exclamation marks, or question marks
- mod/giportfolio/db/upgradelib.php
- (#167) Empty CATCH statement detected
- mod/giportfolio/editstudent.php
- (#57) Line indented incorrectly; expected 0 spaces, found 4
- (#60) Line indented incorrectly; expected 0 spaces, found 4
- (#65) Line indented incorrectly; expected 0 spaces, found 4
- (#74) Line indented incorrectly; expected 0 spaces, found 4
- (#75) Line indented incorrectly; expected 4 spaces, found 8
- (#77) Line indented incorrectly; expected 4 spaces, found 8
- (#79) Line indented incorrectly; expected 4 spaces, found 8
- (#81) Line indented incorrectly; expected 0 spaces, found 4
- (#83) Line indented incorrectly; expected 4 spaces, found 8
- (#88) Line indented incorrectly; expected 4 spaces, found 8
- (#110) Line indented incorrectly; expected 4 spaces, found 8
- (#114) Line indented incorrectly; expected 0 spaces, found 4
- mod/giportfolio/lib.php
- (#620) Inline doc block type-hinting for '$files' does not match next code line 'if...'
- mod/giportfolio/locallib.php
- (#828) Opening brace must be the last content on the line
- (#832) Opening brace must be the last content on the line
- (#832) Line exceeds 132 characters; contains 152 characters
- (#849) Opening brace must be the last content on the line
- (#1064) Opening brace must be the last content on the line
- (#1087) Opening brace must be the last content on the line
- (#1101) Opening brace must be the last content on the line
- (#1142) Opening brace must be the last content on the line
- (#1159) Opening brace must be the last content on the line
- mod/giportfolio/mod_form.php
- (#127) Visibility must be declared on method "definition_after_data"
- mod/giportfolio/tests/events_test.php
- (#97) Line exceeds 132 characters; contains 133 characters
- (#115) Line exceeds 132 characters; contains 135 characters
- (#181) Line exceeds 132 characters; contains 137 characters
- mod/giportfolio/tests/generator_test.php
- (#32) Expected MOODLE_INTERNAL check or config.php inclusion
- (#49) Line exceeds 132 characters; contains 143 characters
- (#66) Line exceeds 132 characters; contains 141 characters
- (#68) Line exceeds 132 characters; contains 133 characters
- (#69) Line exceeds 132 characters; contains 135 characters
- mod/giportfolio/tool/export/lang/de/giportfoliotool_export.php
- (#2) The opening <?php tag must be followed by exactly one newline.
- mod/giportfolio/tool/export/lang/en/giportfoliotool_export.php
- (#2) The opening <?php tag must be followed by exactly one newline.
- mod/giportfolio/tool/export/locallib.php
- (#53) Line exceeds 132 characters; contains 146 characters
- (#54) Line exceeds 132 characters; contains 150 characters
- (#55) Line exceeds 132 characters; contains 151 characters
- mod/giportfolio/tool/export/zipgiportfolio.php
- (#82) Inline comments must end in full-stops, exclamation marks, or question marks
- (#85) Inline comments must end in full-stops, exclamation marks, or question marks
- (#112) Inline comments must end in full-stops, exclamation marks, or question marks
- (#143) Inline comments must end in full-stops, exclamation marks, or question marks
- mod/giportfolio/tool/print/pdfgiportfolio.php
- (#85) Public method name "PORTFOLIOPDF::Header" must be in lower-case letters only
- (#94) Public method name "PORTFOLIOPDF::Footer" must be in lower-case letters only
- (#129) Inline comments must end in full-stops, exclamation marks, or question marks
- (#129) No space found before comment text; expected "// $pdf->SetCreator(PDF_CREATOR);" but found "//$pdf->SetCreator(PDF_CREATOR);"
- (#136) Inline comments must end in full-stops, exclamation marks, or question marks
- (#136) No space found before comment text; expected "// $pdf->SetHeaderData(PDF_HEADER_LOGO, PDF_HEADER_LOGO_WIDTH, PDF_HEADER_TITLE.' 001', PDF_HEADER_STRING);" but found "//$pdf->SetHeaderData(PDF_HEADER_LOGO, PDF_HEADER_LOGO_WIDTH, PDF_HEADER_TITLE.' 001', PDF_HEADER_STRING);"
- (#138) This comment is 52% valid code; is this commented out code?
- (#139) No space found before comment text; expected "// $pdf->setHeaderFont(Array(PDF_FONT_NAME_MAIN, '', PDF_FONT_SIZE_MAIN));" but found "//$pdf->setHeaderFont(Array(PDF_FONT_NAME_MAIN, '', PDF_FONT_SIZE_MAIN));"
- (#140) Inline comments must end in full-stops, exclamation marks, or question marks
- (#140) No space found before comment text; expected "// $pdf->setFooterFont(Array(PDF_FONT_NAME_DATA, '', PDF_FONT_SIZE_DATA));" but found "//$pdf->setFooterFont(Array(PDF_FONT_NAME_DATA, '', PDF_FONT_SIZE_DATA));"
- (#143) Inline comments must end in full-stops, exclamation marks, or question marks
- (#143) No space found before comment text; expected "// $pdf->SetDefaultMonospacedFont(PDF_FONT_MONOSPACED);" but found "//$pdf->SetDefaultMonospacedFont(PDF_FONT_MONOSPACED);"
- (#145) This comment is 49% valid code; is this commented out code?
- (#146) No space found before comment text; expected "// $pdf->SetMargins(PDF_MARGIN_LEFT, PDF_MARGIN_TOP, PDF_MARGIN_RIGHT);" but found "//$pdf->SetMargins(PDF_MARGIN_LEFT, PDF_MARGIN_TOP, PDF_MARGIN_RIGHT);"
- (#147) No space found before comment text; expected "// $pdf->SetHeaderMargin(PDF_MARGIN_HEADER);" but found "//$pdf->SetHeaderMargin(PDF_MARGIN_HEADER);"
- (#148) Inline comments must end in full-stops, exclamation marks, or question marks
- (#148) No space found before comment text; expected "// $pdf->SetFooterMargin(PDF_MARGIN_FOOTER);" but found "//$pdf->SetFooterMargin(PDF_MARGIN_FOOTER);"
- (#151) Inline comments must end in full-stops, exclamation marks, or question marks
- (#151) No space found before comment text; expected "// $pdf->SetAutoPageBreak(true, PDF_MARGIN_BOTTOM);" but found "//$pdf->SetAutoPageBreak(true, PDF_MARGIN_BOTTOM);"
- (#154) Inline comments must end in full-stops, exclamation marks, or question marks
- (#154) No space found before comment text; expected "// $pdf->setImageScale(PDF_IMAGE_SCALE_RATIO);" but found "//$pdf->setImageScale(PDF_IMAGE_SCALE_RATIO);"
- mod/giportfolio/tool/print/pdflib.php
- (#124) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#126) Inline comments must end in full-stops, exclamation marks, or question marks
- (#134) Inline comments must end in full-stops, exclamation marks, or question marks
- (#145) Inline comments must start with a capital letter, digit or 3-dots sequence
- mod/giportfolio/tool/print/tests/events_test.php
- (#64) Line exceeds 132 characters; contains 151 characters
- mod/giportfolio/updategrade.php
- (#67) Expected 1 space before ":"; 0 found
Javascript coding style problems
(0 errors, 2 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
- mod/giportfolio/collapse.js
- (#1) Expected space or tab after '/*' in comment. (spaced-comment)
- (#2) Identifier 'mod_giportfolio_collapse' is not in camel case. (camelcase)
CSS problems
(13 errors, 9 warnings)
This section shows CSS problems detected by stylelint [More info]
- mod/giportfolio/styles.css
- (#134) Expected single space before "}" of a single-line block (block-closing-brace-space-before)
- (#134) Unexpected single-line block (block-no-single-line)
- (#134) Expected single space after "{" of a single-line block (block-opening-brace-space-after)
- (#148) Expected "#37CAF8" to be "#37caf8" (color-hex-case)
- (#153) Expected "#37CAF8" to be "#37caf8" (color-hex-case)
- (#170) Expected "#EEF0F1" to be "#eef0f1" (color-hex-case)
- (#143) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
- mod/giportfolio/tool/export/styles.css
- (#17) Expected single space before "{" (block-opening-brace-space-before)
- (#2) Unexpected unknown property "text-size" (property-no-unknown)
- (#7) Unexpected unknown property "text-size" (property-no-unknown)
- (#9) Unexpected unknown property "text-style" (property-no-unknown)
- mod/giportfolio/tool/print/print.css
- (#48) Expected "#FFFFFF" to be "#ffffff" (color-hex-case)
- (#58) Expected "#EEEEEE" to be "#eeeeee" (color-hex-case)
- (#47) Expected "#000000" to be "#000" (color-hex-length)
- (#48) Expected "#FFFFFF" to be "#FFF" (color-hex-length)
- (#57) Expected "#000000" to be "#000" (color-hex-length)
- (#58) Expected "#EEEEEE" to be "#EEE" (color-hex-length)
- (#1) Expected newline after "," (selector-list-comma-newline-after)
- (#1) Expected newline after "," (selector-list-comma-newline-after)
- (#1) Expected newline after "," (selector-list-comma-newline-after)
- (#1) Expected newline after "," (selector-list-comma-newline-after)
- (#1) Expected newline after "," (selector-list-comma-newline-after)
PHPDocs style problems
(111 errors, 4 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- mod/giportfolio/backup/moodle1/lib.php
- (#27) Class moodle1_mod_giportfolio_handler does not have @copyright tag
- (#27) Class moodle1_mod_giportfolio_handler does not have @license tag
- mod/giportfolio/backup/moodle2/backup_giportfolio_activity_task.class.php
- (#30) No one-line description found in phpdocs for class backup_giportfolio_activity_task
- (#30) Class backup_giportfolio_activity_task does not have @copyright tag
- (#30) Class backup_giportfolio_activity_task does not have @license tag
- mod/giportfolio/backup/moodle2/backup_giportfolio_stepslib.php
- (#32) Function backup_giportfolio_activity_structure_step::define_structure is not documented
- (#27) Class backup_giportfolio_activity_structure_step does not have @copyright tag
- (#27) Class backup_giportfolio_activity_structure_step does not have @license tag
- mod/giportfolio/backup/moodle2/restore_giportfolio_activity_task.class.php
- (#30) No one-line description found in phpdocs for class restore_giportfolio_activity_task
- (#30) Class restore_giportfolio_activity_task does not have @copyright tag
- (#30) Class restore_giportfolio_activity_task does not have @license tag
- mod/giportfolio/backup/moodle2/restore_giportfolio_stepslib.php
- (#30) Function restore_giportfolio_activity_structure_step::define_structure is not documented
- (#44) Function restore_giportfolio_activity_structure_step::process_giportfolio is not documented
- (#55) Function restore_giportfolio_activity_structure_step::process_giportfolio_chapter is not documented
- (#69) Function restore_giportfolio_activity_structure_step::process_giportfolio_contribution is not documented
- (#84) Function restore_giportfolio_activity_structure_step::after_execute is not documented
- (#25) Class restore_giportfolio_activity_structure_step does not have @copyright tag
- (#25) Class restore_giportfolio_activity_structure_step does not have @license tag
- mod/giportfolio/classes/plugininfo/giportfoliotool.php
- (#31) Class giportfoliotool is not documented
- (#32) Function giportfoliotool::is_uninstall_allowed is not documented
- mod/giportfolio/db/upgrade.php
- (#27) Function xmldb_giportfolio_upgrade is not documented
- mod/giportfolio/db/upgradelib.php
- (#136) Phpdocs for function mod_giportfolio_migrate_area has incomplete parameters list
- mod/giportfolio/edit_form.php
- (#30) Class giportfolio_chapter_edit_form is not documented
- (#32) Function giportfolio_chapter_edit_form::definition is not documented
- mod/giportfolio/edit_studentform.php
- (#30) Class giportfolio_chapter_editstudent_form is not documented
- (#32) Function giportfolio_chapter_editstudent_form::definition is not documented
- mod/giportfolio/editcontribution_form.php
- (#31) Class mod_giportfolio_contribution_edit_form is not documented
- (#32) Function mod_giportfolio_contribution_edit_form::definition is not documented
- mod/giportfolio/lib.php
- (#170) Function giportfolio_include_klassenbuchtrainer is not documented
- (#233) Function giportfolio_regrade is not documented
- (#263) Function giportfolio_get_user_grades is not documented
- (#376) Function giportfolio_get_participants is not documented
- (#826) Function mod_giportfolio_comment_validate is not documented
- (#851) Function giportfolio_automatic_grading is not documented
- (#869) Function mod_giportfolio_comment_permissions is not documented
- (#886) Function mod_giportfolio_cm_info_view is not documented
- (#54) Phpdocs for function giportfolio_add_instance has incomplete parameters list
- (#210) Phpdocs for function giportfolio_user_complete has incomplete parameters list
- (#224) Phpdocs for function giportfolio_print_recent_activity has incomplete parameters list
- (#254) Phpdocs for function giportfolio_grades has incomplete parameters list
- (#327) Phpdocs for function giportfolio_grade_item_update has incomplete parameters list
- (#391) Phpdocs for function giportfolio_scale_used has incomplete parameters list
- (#404) Phpdocs for function giportfolio_scale_used_anywhere has incomplete parameters list
- (#600) Not recommended phpdocs tag @global used
- (#600) Not recommended phpdocs tag @global used
- mod/giportfolio/locallib.php
- (#226) Function giportfolio_get_chapter_title is not documented
- (#271) Function giportfolio_add_fake_block is not documented
- (#317) Function giportfolio_add_fakeuser_block is not documented
- (#727) Function giportfolio_get_userviewtoc is not documented
- (#828) Function giportfolio_get_collaborative_status is not documented
- (#832) Function giportfolio_get_user_contributions is not documented
- (#849) Function giportfolio_get_user_chapters is not documented
- (#867) Function giportfolio_get_user_contribution_status is not documented
- (#882) Function giportfolio_get_giportfolios_number is not documented
- (#915) Function giportfolio_chapter_count_contributions is not documented
- (#941) Function giportfolio_adduser_fake_block is not documented
- (#1012) Function giportfolio_quick_update_grades is not documented
- (#1064) Function giportfolio_quick_update_feedback is not documented
- (#1087) Function giportfolio_get_gradeitem is not documented
- (#1101) Function giportfolio_get_usergrade_id is not documented
- (#1115) Function giportfolio_get_last_chapter is not documented
- (#1142) Function giportfolio_get_first_userchapter is not documented
- (#1159) Function giportfolio_check_user_chapter is not documented
- (#1169) Function giportfolio_delete_user_contributions is not documented
- (#1197) Function giportfolio_delete_chapter_contributions is not documented
- (#1227) Function giportfolio_file_info::__construct is not documented
- (#1222) Variable giportfolio_file_info::$course is not documented
- (#1223) Variable giportfolio_file_info::$cm is not documented
- (#1224) Variable giportfolio_file_info::$areas is not documented
- (#1225) Variable giportfolio_file_info::$filearea is not documented
- (#527) Phpdocs for function giportfolio_get_usertoc has incomplete parameters list
- (#1218) Class giportfolio_file_info does not have @copyright tag
- (#1218) Class giportfolio_file_info does not have @license tag
- mod/giportfolio/mod_form.php
- (#31) Class mod_giportfolio_mod_form is not documented
- (#33) Function mod_giportfolio_mod_form::definition is not documented
- (#127) Function mod_giportfolio_mod_form::definition_after_data is not documented
- mod/giportfolio/search_form.php
- (#30) Class giportfolio_search_form is not documented
- (#32) Function giportfolio_search_form::definition is not documented
- mod/giportfolio/submissions.php
- (#17) File-level phpdocs block is not found
- (#381) Phpdocs for function quickgrade_mode_allowed has incomplete parameters list
- (#375) Package is not specified for function quickgrade_mode_allowed. It is also not specified in file-level phpdocs
- mod/giportfolio/tests/events_test.php
- (#21) Category phpunit is not valid
- (#33) Category phpunit is not valid
- mod/giportfolio/tests/generator/lib.php
- (#29) Class mod_giportfolio_generator is not documented
- (#46) Function mod_giportfolio_generator::create_instance is not documented
- (#68) Function mod_giportfolio_generator::create_chapter is not documented
- (#125) Function mod_giportfolio_generator::create_content is not documented
- mod/giportfolio/tool/export/lang/de/giportfoliotool_export.php
- (#2) Empty line found after PHP open tag
- (#3) File-level phpdocs block is not found
- mod/giportfolio/tool/export/lang/en/giportfoliotool_export.php
- (#2) Empty line found after PHP open tag
- (#3) File-level phpdocs block is not found
- mod/giportfolio/tool/export/locallib.php
- (#33) Phpdocs for function giportfoliotool_export_get_summary has incomplete parameters list
- (#123) Phpdocs for function giportfoliotool_export_add_filearea_to_zip has incomplete parameters list
- (#20) Package giportfoliotool_print is not valid
- mod/giportfolio/tool/print/db/access.php
- (#20) Package giportfoliotool is not valid
- mod/giportfolio/tool/print/index.php
- (#20) Package giportfoliotool is not valid
- mod/giportfolio/tool/print/lang/de/giportfoliotool_print.php
- (#17) File-level phpdocs block does not have @copyright tag
- (#20) Package giportfoliotool is not valid
- mod/giportfolio/tool/print/lang/en/giportfoliotool_print.php
- (#20) Package giportfoliotool is not valid
- mod/giportfolio/tool/print/lib.php
- (#28) Function giportfoliotool_print_extend_settings_navigation is not documented
- (#20) Package giportfoliotool is not valid
- mod/giportfolio/tool/print/locallib.php
- (#20) Package giportfoliotool is not valid
- mod/giportfolio/tool/print/pdfgiportfolio.php
- (#82) Class PORTFOLIOPDF is not documented
- (#85) Function PORTFOLIOPDF::Header is not documented
- (#94) Function PORTFOLIOPDF::Footer is not documented
- (#20) Package giportfoliotool is not valid
- mod/giportfolio/tool/print/pdfgiportfolio_details_dist.php
- (#17) File-level phpdocs block is not found
- mod/giportfolio/tool/print/pdflib.php
- (#27) Function pdfgiportfolio_fix_image_links is not documented
- (#88) Function pdfgiportfolio_fix_svg_images is not documented
- mod/giportfolio/tool/print/tests/events_test.php
- (#21) Category phpunit is not valid
- (#33) Category phpunit is not valid
- mod/giportfolio/tool/print/version.php
- (#20) Package giportfoliotool is not valid
- mod/giportfolio/updategrade_form.php
- (#31) Class mod_giporotfolio_grading_form is not documented
- (#32) Function mod_giporotfolio_grading_form::definition is not documented
- (#67) Function mod_giporotfolio_grading_form::add_grades_section is not documented
Update savepoints problems
(7 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
- mod/giportfolio/db/upgrade.php
- Detected more 'if' blocks (29) than 'savepoint' calls (27)
- version 2004081100 is missing corresponding savepoint call
- version 2011110902 has wrong savepoint call with version 2011110912
- version 2011110903 has wrong savepoint call with version 2011110912
- version 2011110907 has wrong savepoint call with version 2011110912
- version 2011110910 has wrong savepoint call with version 2011110912
- version 2012072600 is missing corresponding savepoint call
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(1 errors, 1 warnings)
This section shows files built by grunt and not commited [More info]
- Task "stylelint:css" failed. Use --force to continue.
- Problems running grunt
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]