Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(139 errors, 85 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/gamoteca/ajax.php
(#37) File must end with a newline character
mod/gamoteca/backup/moodle2/backup_gamoteca_activity_task.class.php
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#59) The static declaration must come after the visibility declaration
(#62) Commas (,) must be followed by white space.
(#64) Inline comments must end in full-stops, exclamation marks, or question marks
(#65) Expected 1 space before "="; 0 found
(#65) Expected 1 space after "="; 0 found
(#66) Expected 1 space before "="; 0 found
(#68) Inline comments must end in full-stops, exclamation marks, or question marks
(#69) Expected 1 space before "="; 0 found
(#69) Expected 1 space after "="; 0 found
(#70) Expected 1 space before "="; 0 found
mod/gamoteca/backup/moodle2/backup_gamoteca_stepslib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
mod/gamoteca/backup/moodle2/restore_gamoteca_activity_task.class.php
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#60) The static declaration must come after the visibility declaration
(#74) The static declaration must come after the visibility declaration
(#91) The static declaration must come after the visibility declaration
mod/gamoteca/backup/moodle2/restore_gamoteca_stepslib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
mod/gamoteca/classes/event/course_module_viewed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/gamoteca/classes/event/gamoteca_created.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/gamoteca/classes/event/gamoteca_deleted.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/gamoteca/classes/event/gamoteca_updated.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/gamoteca/classes/external/gamotecaupdate.php
(#120) Inline comments must start with a capital letter, digit or 3-dots sequence
(#120) This comment is 82% valid code; is this commented out code?
(#120) No space found before comment text; expected "// $completion->update_state($cm, $completionstate, $game['userid']);" but found "//$completion->update_state($cm, $completionstate, $game['userid']);"
(#122) Inline comments must start with a capital letter, digit or 3-dots sequence
(#122) This comment is 78% valid code; is this commented out code?
(#122) No space found before comment text; expected "// $completion->invalidatecache($gamoteca->course, $game['userid'], true);" but found "//$completion->invalidatecache($gamoteca->course, $game['userid'], true);"
mod/gamoteca/classes/output/mobile.php
(#1) Line exceeds 132 characters; contains 177 characters
(#1) Line 1 of the opening comment must start "// This file is part of".
(#1) Whitespace found at end of line
(#2) Line exceeds 132 characters; contains 177 characters
(#2) Whitespace found at end of line
(#3) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#3) Whitespace found at end of line
(#4) Line exceeds 132 characters; contains 177 characters
(#4) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#4) Whitespace found at end of line
(#5) Line exceeds 132 characters; contains 177 characters
(#5) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#5) Whitespace found at end of line
(#6) Line exceeds 132 characters; contains 177 characters
(#6) Line 6 of the opening comment must start "// (at your option) any later version.".
(#6) Whitespace found at end of line
(#7) Line exceeds 132 characters; contains 177 characters
(#7) Whitespace found at end of line
(#8) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#8) Whitespace found at end of line
(#9) Line exceeds 132 characters; contains 177 characters
(#9) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#9) Whitespace found at end of line
(#10) Line exceeds 132 characters; contains 177 characters
(#10) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#10) Whitespace found at end of line
(#11) Line exceeds 132 characters; contains 177 characters
(#11) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#11) Whitespace found at end of line
(#12) Line exceeds 132 characters; contains 177 characters
(#12) Whitespace found at end of line
(#13) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#13) Whitespace found at end of line
(#14) Line exceeds 132 characters; contains 177 characters
(#14) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#14) Whitespace found at end of line
(#15) Line exceeds 132 characters; contains 177 characters
(#15) Whitespace found at end of line
(#16) Line exceeds 132 characters; contains 177 characters
(#16) Whitespace found at end of line
(#17) Whitespace found at end of line
(#18) Line exceeds 132 characters; contains 177 characters
(#18) Whitespace found at end of line
(#19) Whitespace found at end of line
(#20) Line exceeds 132 characters; contains 177 characters
(#20) Whitespace found at end of line
(#21) Line exceeds 132 characters; contains 177 characters
(#21) Whitespace found at end of line
(#22) Line exceeds 132 characters; contains 177 characters
(#22) Whitespace found at end of line
(#23) Line exceeds 132 characters; contains 177 characters
(#23) Whitespace found at end of line
(#24) Line exceeds 132 characters; contains 177 characters
(#24) Whitespace found at end of line
(#25) Line exceeds maximum limit of 180 characters; contains 181 characters
(#25) Whitespace found at end of line
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) Line exceeds 132 characters; contains 177 characters
(#26) Whitespace found at end of line
(#27) Line exceeds 132 characters; contains 161 characters
(#27) Whitespace found at end of line
(#28) Line exceeds maximum limit of 180 characters; contains 328 characters
(#28) Whitespace found at end of line
(#29) Line exceeds 132 characters; contains 167 characters
(#29) Whitespace found at end of line
(#30) Whitespace found at end of line
(#31) Line exceeds 132 characters; contains 177 characters
(#31) Whitespace found at end of line
(#32) Whitespace found at end of line
(#33) Line exceeds 132 characters; contains 177 characters
(#33) Whitespace found at end of line
(#34) Line exceeds 132 characters; contains 177 characters
(#34) Whitespace found at end of line
(#35) Line exceeds 132 characters; contains 177 characters
(#35) Whitespace found at end of line
(#36) Line exceeds 132 characters; contains 177 characters
(#36) Whitespace found at end of line
(#37) Line exceeds 132 characters; contains 177 characters
(#37) Whitespace found at end of line
(#38) Line exceeds 132 characters; contains 177 characters
(#38) Whitespace found at end of line
(#39) Whitespace found at end of line
(#40) Line exceeds 132 characters; contains 177 characters
(#40) Whitespace found at end of line
(#41) Line exceeds 132 characters; contains 177 characters
(#41) Whitespace found at end of line
(#42) Line exceeds 132 characters; contains 177 characters
(#42) Whitespace found at end of line
(#43) Whitespace found at end of line
(#44) Whitespace found at end of line
(#45) Whitespace found at end of line
(#46) Whitespace found at end of line
(#48) Whitespace found at end of line
(#50) Whitespace found at end of line
(#52) Line exceeds 132 characters; contains 177 characters
(#52) Whitespace found at end of line
(#53) Commas (,) must be followed by white space.
(#53) Line exceeds 132 characters; contains 171 characters
(#53) Whitespace found at end of line
(#54) Line exceeds 132 characters; contains 177 characters
(#54) Whitespace found at end of line
(#55) Line exceeds 132 characters; contains 177 characters
(#55) Whitespace found at end of line
(#56) Line exceeds maximum limit of 180 characters; contains 181 characters
(#56) Whitespace found at end of line
(#57) Line exceeds 132 characters; contains 177 characters
(#57) Whitespace found at end of line
(#58) Line exceeds 132 characters; contains 177 characters
(#58) Whitespace found at end of line
(#59) Line exceeds 132 characters; contains 177 characters
(#59) Whitespace found at end of line
(#60) Line exceeds 132 characters; contains 177 characters
(#60) Whitespace found at end of line
(#61) Line exceeds 132 characters; contains 177 characters
(#61) Whitespace found at end of line
(#62) Line exceeds 132 characters; contains 177 characters
(#62) Whitespace found at end of line
(#63) Line exceeds maximum limit of 180 characters; contains 181 characters
(#63) Whitespace found at end of line
(#64) Line exceeds 132 characters; contains 177 characters
(#64) Whitespace found at end of line
(#65) Line exceeds 132 characters; contains 177 characters
(#65) Whitespace found at end of line
(#66) Line exceeds maximum limit of 180 characters; contains 188 characters
(#66) Whitespace found at end of line
(#67) Line exceeds 132 characters; contains 177 characters
(#67) Whitespace found at end of line
(#68) Whitespace found at end of line
(#69) Line exceeds 132 characters; contains 163 characters
(#69) Whitespace found at end of line
(#70) Whitespace found at end of line
(#71) Line exceeds maximum limit of 180 characters; contains 190 characters
(#71) Whitespace found at end of line
(#74) Line exceeds maximum limit of 180 characters; contains 222 characters
(#74) Whitespace found at end of line
(#76) Line exceeds 132 characters; contains 171 characters
(#76) Whitespace found at end of line
(#77) Line exceeds 132 characters; contains 177 characters
(#77) Whitespace found at end of line
(#78) Line exceeds 132 characters; contains 177 characters
(#78) Whitespace found at end of line
(#79) Line exceeds 132 characters; contains 177 characters
(#79) Whitespace found at end of line
(#80) Line exceeds 132 characters; contains 177 characters
(#80) Whitespace found at end of line
(#81) Line exceeds maximum limit of 180 characters; contains 181 characters
(#81) Whitespace found at end of line
(#82) Line exceeds 132 characters; contains 177 characters
(#82) Whitespace found at end of line
(#83) Line exceeds 132 characters; contains 177 characters
(#83) Whitespace found at end of line
(#84) Whitespace found at end of line
(#85) Line exceeds 132 characters; contains 177 characters
(#85) Whitespace found at end of line
(#86) Line exceeds 132 characters; contains 177 characters
(#86) Whitespace found at end of line
(#87) Line exceeds 132 characters; contains 177 characters
(#87) Whitespace found at end of line
(#88) Line exceeds 132 characters; contains 177 characters
(#88) Whitespace found at end of line
(#89) Line exceeds 132 characters; contains 177 characters
(#89) Whitespace found at end of line
(#90) Line exceeds 132 characters; contains 177 characters
(#90) Whitespace found at end of line
(#91) Line exceeds 132 characters; contains 177 characters
(#91) File must end with a newline character
(#91) Whitespace found at end of line
mod/gamoteca/db/mobile.php
(#36) Whitespace found at end of line
(#38) Whitespace found at end of line
(#43) Expected 1 space after "=>"; 2 found
(#53) File must end with a newline character
mod/gamoteca/db/upgrade.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/gamoteca/index.php
(#85) Logical operator "or" is prohibited; use "||" instead
mod/gamoteca/lib.php
(#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#45) No space found before comment text; expected "// Rimosso per incompatibilità con mobile, da capire le conseguenze" but found "//Rimosso per incompatibilità con mobile, da capire le conseguenze"
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#47) Expected 1 space before comment text but found 5; use block comment if you need indentation
mod/gamoteca/mod_form.php
(#62) Expected 1 space before "=>"; 0 found
(#62) Expected 1 space after "=>"; 0 found
(#62) Line exceeds 132 characters; contains 147 characters
mod/gamoteca/pix/flex_icons.php
(#4) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#5) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#6) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#7) Line 6 of the opening comment must start "// (at your option) any later version.".
(#9) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#10) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#12) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#14) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
mod/gamoteca/version.php
(#35) File must end with a newline character
mod/gamoteca/view.php
(#29) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(3 errors, 7 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/gamoteca/amd/src/gamoteca.js
(#9) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#17) 'linkid' is defined but never used. (no-unused-vars)
(#17) 'url' is defined but never used. (no-unused-vars)
(#17) 'windowmessage' is defined but never used. (no-unused-vars)
(#23) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#24) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#31) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#32) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#45) Unexpected space before function parentheses. (space-before-function-paren)
(#53) Expected space(s) after "if". (keyword-spacing)

CSS problems

(2 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/gamoteca/styles.css
(#11) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#11) Expected indentation of 4 spaces (indentation)

PHPDocs style problems

(15 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/gamoteca/backup/moodle2/backup_gamoteca_activity_task.class.php
(#56) Phpdocs for function backup_gamoteca_activity_task::encode_content_links has incomplete parameters list
mod/gamoteca/backup/moodle2/restore_gamoteca_activity_task.class.php
(#21) Category restore is not valid
(#86) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#87) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/gamoteca/backup/moodle2/restore_gamoteca_stepslib.php
(#21) Category restore is not valid
(#54) Phpdocs for function restore_gamoteca_activity_structure_step::process_gamoteca has incomplete parameters list
(#73) Phpdocs for function restore_gamoteca_activity_structure_step::process_gamoteca_data has incomplete parameters list
mod/gamoteca/classes/event/course_module_viewed.php
(#51) Function course_module_viewed::get_objectid_mapping is not documented
mod/gamoteca/classes/output/mobile.php
(#20) Package mod_zoom is not valid
(#33) Package mod_zoom is not valid
(#2) Empty line found after PHP open tag
(#52) Function mobile::mobile_course_view is not documented
mod/gamoteca/db/upgrade.php
(#28) Function xmldb_gamoteca_upgrade is not documented
mod/gamoteca/lib.php
(#224) Phpdocs for function gamoteca_getuser_game_state has incomplete parameters list
mod/gamoteca/mod_form.php
(#138) Phpdocs for function mod_gamoteca_mod_form::data_preprocessing has incomplete parameters list
mod/gamoteca/pix/flex_icons.php
(#26) File-level phpdocs block is not found

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 6 warnings)

This section shows problems detected in mustache templates [More info]

mod/gamoteca/templates/mobile_view_page.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 7: Bad value “” for attribute “src” on element “img”: Must be non-empty. (> <img src="" core-external-content component="mod_gamoteca" style="width:250px"> <)
(#1) HTML Validation error, line 7: Attribute “core-external-content” not allowed on element “img” at this point. (> <img src="" core-external-content component="mod_gamoteca" style="width:250px"> <)
(#1) HTML Validation error, line 7: Attribute “component” not allowed on element “img” at this point. (> <img src="" core-external-content component="mod_gamoteca" style="width:250px"> <)
(#1) HTML Validation error, line 7: An “img” element must have an “alt” attribute, except under certain conditions. For details, consult guidance on providing text alternatives for images. (> <img src="" core-external-content component="mod_gamoteca" style="width:250px"> <)
(#1) HTML Validation error, line 30: Attribute “core-link” not allowed on element “a” at this point. (> <a href="" target="_blank" core-link style="position: relative; font-size: 12px!important; line-height: 50px; text-transform: uppercase; text-decoration: none; letter-spacing: .02em; font-weight: 700; color: #4d4d4d!important; border-color: rgba(0,0,0,.2); padding: 16px 20px; margin-top:20px; color: #fff!important; text-decoration: none!important; border-color: transparent; background-color: #009fe3; text-align:center">Open g)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]