Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(289 errors, 26 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/edusharing/backup/moodle2/backup_edusharing_activity_task.class.php: (#34) Opening brace must not be followed by a blank line; (#63) Expected at least 1 space before "."; 0 found; (#63) Expected at least 1 space after "."; 0 found; (#63) Expected at least 1 space before "."; 0 found; (#63) Expected at least 1 space after "."; 0 found; (#67) Expected at least 1 space before "."; 0 found; (#67) Expected at least 1 space after "."; 0 found; (#67) Expected at least 1 space before "."; 0 found; (#67) Expected at least 1 space after "."; 0 found
mod/edusharing/backup/moodle2/backup_edusharing_stepslib.php: (#26) Opening brace must not be followed by a blank line; (#61) Function closing brace must go on the next line following the body; found 1 blank lines before brace
mod/edusharing/backup/moodle2/restore_edusharing_activity_task.class.php: (#37) Opening brace must not be followed by a blank line; (#109) Opening parenthesis of a multi-line function call must be the last content on the line; (#109) Only one argument is allowed per line in a multi-line function call; (#109) Only one argument is allowed per line in a multi-line function call; (#109) Only one argument is allowed per line in a multi-line function call; (#110) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#110) Only one argument is allowed per line in a multi-line function call; (#110) Only one argument is allowed per line in a multi-line function call; (#110) Closing parenthesis of a multi-line function call must be on a line by itself
mod/edusharing/backup/moodle2/restore_edusharing_stepslib.php: (#30) Expected at least 1 space before "."; 0 found; (#30) Expected at least 1 space after "."; 0 found; (#35) Opening brace must not be followed by a blank line
mod/edusharing/classes/EduSharingService.php: (#64) There must be 1 space after the property type declaration; 5 found; (#147) Opening parenthesis of a multi-line function call must be the last content on the line; (#534) Space before opening parenthesis of function call prohibited
mod/edusharing/classes/InstallUpgradeLogic.php: (#17) Expected no space between directive and the equals sign in a declare statement; (#17) Expected no space between equal sign and the directive value in a declare statement; (#40) There must be 1 space after the property type declaration; 6 found; (#98) The first expression of a multi-line control structure must be on the line after the opening parenthesis
mod/edusharing/classes/MetaDataFrontend.php: (#17) Expected no space between directive and the equals sign in a declare statement; (#17) Expected no space between equal sign and the directive value in a declare statement
mod/edusharing/classes/MetadataLogic.php: (#101) Opening parenthesis of a multi-line function call must be the last content on the line; (#101) Only one argument is allowed per line in a multi-line function call; (#101) Only one argument is allowed per line in a multi-line function call; (#102) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#102) Closing parenthesis of a multi-line function call must be on a line by itself; (#106) Opening parenthesis of a multi-line function call must be the last content on the line; (#106) Only one argument is allowed per line in a multi-line function call; (#106) Only one argument is allowed per line in a multi-line function call; (#107) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#107) Closing parenthesis of a multi-line function call must be on a line by itself; (#122) Space before opening parenthesis of function call prohibited; (#139) Only one argument is allowed per line in a multi-line function call; (#154) Opening parenthesis of a multi-line function call must be the last content on the line; (#154) Only one argument is allowed per line in a multi-line function call; (#154) Only one argument is allowed per line in a multi-line function call; (#155) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#155) Closing parenthesis of a multi-line function call must be on a line by itself
mod/edusharing/classes/PluginRegistrationFrontend.php: (#17) Expected no space between directive and the equals sign in a declare statement; (#17) Expected no space between equal sign and the directive value in a declare statement; (#42) Expected at least 1 space before "."; 0 found; (#42) Expected at least 1 space after "."; 0 found; (#42) Expected at least 1 space before "."; 0 found; (#42) Expected at least 1 space after "."; 0 found; (#56) Expected at least 1 space before "."; 0 found; (#56) Expected at least 1 space after "."; 0 found; (#58) Expected at least 1 space before "."; 0 found; (#58) Expected at least 1 space after "."; 0 found; (#58) Expected at least 1 space before "."; 0 found; (#58) Expected at least 1 space after "."; 0 found
mod/edusharing/classes/external/GetSecuredNode.php: (#42) Opening brace must not be followed by a blank line
mod/edusharing/db/upgrade.php: (#45) Incorrect spacing between argument "$oldversion" and equals sign; expected 1 but found 0; (#45) Incorrect spacing between default value and equals sign for argument "$oldversion"; expected 1 but found 0; (#64) Expected at least 1 space before "."; 0 found; (#64) Expected at least 1 space after "."; 0 found; (#79) Expected at least 1 space before "."; 0 found; (#79) Expected at least 1 space after "."; 0 found; (#79) Expected at least 1 space before "."; 0 found; (#80) Expected at least 1 space before "."; 0 found; (#80) Expected at least 1 space after "."; 0 found; (#95) Opening parenthesis of a multi-line function call must be the last content on the line; (#102) Opening parenthesis of a multi-line function call must be the last content on the line; (#112) Expected at least 1 space before "."; 0 found; (#112) Expected at least 1 space after "."; 0 found; (#119) Blank line found at end of control structure; (#126) Blank line found at start of control structure; (#150) Blank line found at start of control structure; (#171) Blank line found at start of control structure
mod/edusharing/defaults.php: (#30) Expected 1 blank line at end of file; 2 found
mod/edusharing/lib.php: (#131) Parentheses must be used when instantiating a new class
mod/edusharing/mod_form.php: (#57) Opening parenthesis of a multi-line function call must be the last content on the line; (#57) Only one argument is allowed per line in a multi-line function call; (#58) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#58) Only one argument is allowed per line in a multi-line function call; (#58) Closing parenthesis of a multi-line function call must be on a line by itself; (#68) Opening parenthesis of a multi-line function call must be the last content on the line; (#68) Only one argument is allowed per line in a multi-line function call; (#69) Opening parenthesis of a multi-line function call must be the last content on the line; (#69) Only one argument is allowed per line in a multi-line function call; (#70) Multi-line function call not indented correctly; expected 16 spaces but found 24; (#70) Multi-line function call not indented correctly; expected 20 spaces but found 24; (#70) Closing parenthesis of a multi-line function call must be on a line by itself; (#70) Closing parenthesis of a multi-line function call must be on a line by itself; (#71) Opening parenthesis of a multi-line function call must be the last content on the line; (#71) Only one argument is allowed per line in a multi-line function call; (#73) Multi-line function call not indented correctly; expected 16 spaces but found 20; (#73) Closing parenthesis of a multi-line function call must be on a line by itself; (#74) Opening parenthesis of a multi-line function call must be the last content on the line; (#74) Only one argument is allowed per line in a multi-line function call; (#75) Multi-line function call not indented correctly; expected 16 spaces but found 20; (#75) Only one argument is allowed per line in a multi-line function call; (#75) Closing parenthesis of a multi-line function call must be on a line by itself; (#98) Opening parenthesis of a multi-line function call must be the last content on the line; (#98) Only one argument is allowed per line in a multi-line function call; (#99) Opening parenthesis of a multi-line function call must be the last content on the line; (#99) Only one argument is allowed per line in a multi-line function call; (#100) Multi-line function call not indented correctly; expected 20 spaces but found 28; (#100) Multi-line function call not indented correctly; expected 24 spaces but found 28; (#100) Closing parenthesis of a multi-line function call must be on a line by itself; (#100) Closing parenthesis of a multi-line function call must be on a line by itself; (#104) Opening parenthesis of a multi-line function call must be the last content on the line; (#104) Only one argument is allowed per line in a multi-line function call; (#105) Multi-line function call not indented correctly; expected 28 spaces but found 32; (#105) Closing parenthesis of a multi-line function call must be on a line by itself; (#110) Opening parenthesis of a multi-line function call must be the last content on the line; (#110) Only one argument is allowed per line in a multi-line function call; (#111) Multi-line function call not indented correctly; expected 16 spaces but found 20; (#111) Closing parenthesis of a multi-line function call must be on a line by itself; (#113) Opening parenthesis of a multi-line function call must be the last content on the line; (#113) Only one argument is allowed per line in a multi-line function call; (#113) Only one argument is allowed per line in a multi-line function call; (#114) Multi-line function call not indented correctly; expected 16 spaces but found 20; (#114) Only one argument is allowed per line in a multi-line function call; (#114) Only one argument is allowed per line in a multi-line function call; (#114) Closing parenthesis of a multi-line function call must be on a line by itself; (#115) Opening parenthesis of a multi-line function call must be the last content on the line; (#115) Only one argument is allowed per line in a multi-line function call; (#115) Only one argument is allowed per line in a multi-line function call; (#116) Multi-line function call not indented correctly; expected 16 spaces but found 20; (#116) Only one argument is allowed per line in a multi-line function call; (#116) Only one argument is allowed per line in a multi-line function call; (#116) Closing parenthesis of a multi-line function call must be on a line by itself; (#117) Opening parenthesis of a multi-line function call must be the last content on the line; (#117) Only one argument is allowed per line in a multi-line function call; (#118) Multi-line function call not indented correctly; expected 16 spaces but found 20; (#118) Only one argument is allowed per line in a multi-line function call; (#118) Only one argument is allowed per line in a multi-line function call; (#118) Closing parenthesis of a multi-line function call must be on a line by itself; (#123) Opening parenthesis of a multi-line function call must be the last content on the line; (#123) Only one argument is allowed per line in a multi-line function call; (#124) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#124) Closing parenthesis of a multi-line function call must be on a line by itself; (#130) Opening parenthesis of a multi-line function call must be the last content on the line; (#130) Only one argument is allowed per line in a multi-line function call; (#131) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#131) Only one argument is allowed per line in a multi-line function call; (#131) Closing parenthesis of a multi-line function call must be on a line by itself; (#155) PHP parameter type declarations must be lowercase; expected "string" but found "String"; (#155) PHP return type declarations must be lowercase; expected "string" but found "String"
mod/edusharing/settings.php: (#65) Opening parenthesis of a multi-line function call must be the last content on the line; (#66) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#66) Only one argument is allowed per line in a multi-line function call; (#66) Only one argument is allowed per line in a multi-line function call; (#66) Only one argument is allowed per line in a multi-line function call; (#66) Only one argument is allowed per line in a multi-line function call; (#66) Closing parenthesis of a multi-line function call must be on a line by itself; (#68) Opening parenthesis of a multi-line function call must be the last content on the line; (#87) Opening parenthesis of a multi-line function call must be the last content on the line; (#87) Only one argument is allowed per line in a multi-line function call; (#88) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#88) Only one argument is allowed per line in a multi-line function call; (#88) Only one argument is allowed per line in a multi-line function call; (#88) Only one argument is allowed per line in a multi-line function call; (#88) Closing parenthesis of a multi-line function call must be on a line by itself; (#89) Opening parenthesis of a multi-line function call must be the last content on the line; (#90) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#90) Only one argument is allowed per line in a multi-line function call; (#90) Only one argument is allowed per line in a multi-line function call; (#90) Only one argument is allowed per line in a multi-line function call; (#90) Only one argument is allowed per line in a multi-line function call; (#90) Closing parenthesis of a multi-line function call must be on a line by itself; (#91) Opening parenthesis of a multi-line function call must be the last content on the line; (#92) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#92) Only one argument is allowed per line in a multi-line function call; (#92) Only one argument is allowed per line in a multi-line function call; (#92) Only one argument is allowed per line in a multi-line function call; (#92) Only one argument is allowed per line in a multi-line function call; (#92) Closing parenthesis of a multi-line function call must be on a line by itself; (#93) Opening parenthesis of a multi-line function call must be the last content on the line; (#94) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#94) Only one argument is allowed per line in a multi-line function call; (#94) Only one argument is allowed per line in a multi-line function call; (#94) Only one argument is allowed per line in a multi-line function call; (#94) Only one argument is allowed per line in a multi-line function call; (#94) Closing parenthesis of a multi-line function call must be on a line by itself; (#95) Opening parenthesis of a multi-line function call must be the last content on the line; (#96) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#96) Only one argument is allowed per line in a multi-line function call; (#96) Only one argument is allowed per line in a multi-line function call; (#96) Only one argument is allowed per line in a multi-line function call; (#96) Only one argument is allowed per line in a multi-line function call; (#96) Closing parenthesis of a multi-line function call must be on a line by itself; (#97) Opening parenthesis of a multi-line function call must be the last content on the line; (#98) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#98) Only one argument is allowed per line in a multi-line function call; (#98) Only one argument is allowed per line in a multi-line function call; (#98) Only one argument is allowed per line in a multi-line function call; (#98) Only one argument is allowed per line in a multi-line function call; (#98) Closing parenthesis of a multi-line function call must be on a line by itself; (#99) Opening parenthesis of a multi-line function call must be the last content on the line; (#100) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#100) Only one argument is allowed per line in a multi-line function call; (#100) Only one argument is allowed per line in a multi-line function call; (#100) Only one argument is allowed per line in a multi-line function call; (#100) Only one argument is allowed per line in a multi-line function call; (#100) Closing parenthesis of a multi-line function call must be on a line by itself; (#103) Opening parenthesis of a multi-line function call must be the last content on the line; (#110) Opening parenthesis of a multi-line function call must be the last content on the line; (#116) Opening parenthesis of a multi-line function call must be the last content on the line; (#118) Multi-line function call not indented correctly; expected 8 spaces but found 9; (#119) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#119) Only one argument is allowed per line in a multi-line function call; (#119) Only one argument is allowed per line in a multi-line function call; (#119) Closing parenthesis of a multi-line function call must be on a line by itself; (#125) Opening parenthesis of a multi-line function call must be the last content on the line; (#127) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#127) Closing parenthesis of a multi-line function call must be on a line by itself; (#134) Opening parenthesis of a multi-line function call must be the last content on the line; (#134) Only one argument is allowed per line in a multi-line function call; (#135) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#135) Only one argument is allowed per line in a multi-line function call; (#135) Closing parenthesis of a multi-line function call must be on a line by itself; (#138) Opening parenthesis of a multi-line function call must be the last content on the line; (#138) Only one argument is allowed per line in a multi-line function call; (#139) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#139) Only one argument is allowed per line in a multi-line function call; (#139) Closing parenthesis of a multi-line function call must be on a line by itself; (#142) Opening parenthesis of a multi-line function call must be the last content on the line; (#142) Only one argument is allowed per line in a multi-line function call; (#143) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#143) Only one argument is allowed per line in a multi-line function call; (#143) Closing parenthesis of a multi-line function call must be on a line by itself; (#146) Opening parenthesis of a multi-line function call must be the last content on the line; (#146) Only one argument is allowed per line in a multi-line function call; (#147) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#147) Only one argument is allowed per line in a multi-line function call; (#147) Closing parenthesis of a multi-line function call must be on a line by itself; (#155) Opening parenthesis of a multi-line function call must be the last content on the line; (#155) Only one argument is allowed per line in a multi-line function call; (#156) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#156) Only one argument is allowed per line in a multi-line function call; (#156) Only one argument is allowed per line in a multi-line function call; (#156) Closing parenthesis of a multi-line function call must be on a line by itself; (#159) Opening parenthesis of a multi-line function call must be the last content on the line; (#165) Opening parenthesis of a multi-line function call must be the last content on the line; (#166) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#166) Only one argument is allowed per line in a multi-line function call; (#166) Closing parenthesis of a multi-line function call must be on a line by itself
mod/edusharing/tests/edusharing_service_test.php: (#48) Opening brace must not be followed by a blank line; (#294) Opening parenthesis of a multi-line function call must be the last content on the line; (#294) Only one argument is allowed per line in a multi-line function call; (#295) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#295) Only one argument is allowed per line in a multi-line function call; (#295) Only one argument is allowed per line in a multi-line function call; (#295) Closing parenthesis of a multi-line function call must be on a line by itself; (#794) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#794) Closing parenthesis of a multi-line function call must be on a line by itself
mod/edusharing/tests/install_upgrade_logic_test.php: (#17) Expected no space between directive and the equals sign in a declare statement; (#17) Expected no space between equal sign and the directive value in a declare statement; (#41) Opening brace must not be followed by a blank line
mod/edusharing/tests/metadata_logic_test.php: (#53) Test method test_if_import_metadata_sets_all_config_entries_on_success() is missing any coverage information, own or at class level; (#80) Opening parenthesis of a multi-line function call must be the last content on the line; (#81) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#81) Closing parenthesis of a multi-line function call must be on a line by itself; (#89) Opening parenthesis of a multi-line function call must be the last content on the line; (#90) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#90) Closing parenthesis of a multi-line function call must be on a line by itself; (#105) Test method test_if_import_metadata_generates_new_app_id_if_none_present() is missing any coverage information, own or at class level; (#129) Opening parenthesis of a multi-line function call must be the last content on the line; (#130) Multi-line function call not indented correctly; expected 8 spaces but found 12; (#130) Closing parenthesis of a multi-line function call must be on a line by itself; (#140) Test method test_if_import_metadata_uses_configured_app_id_if_found() is missing any coverage information, own or at class level; (#176) Test method test_if_import_metadata_uses_app_id_class_variable_if_set() is missing any coverage information, own or at class level; (#210) Test method test_if_import_metadata_does_not_set_host_aliases_if_none_are_set() is missing any coverage information, own or at class level; (#246) Test method test_if_import_metadata_sets_host_aliases_if_set_as_class_variables() is missing any coverage information, own or at class level; (#283) Test method test_if_import_metadata_does_not_set_wlo_guest_user_if_none_provided() is missing any coverage information, own or at class level; (#320) Test method test_if_import_metadata_does_set_wlo_guest_user_if_class_variable_is_set() is missing any coverage information, own or at class level; (#358) Test method test_if_import_metadata_generates_new_key_pair_if_none_found() is missing any coverage information, own or at class level; (#396) Test method test_if_create_xml_metadata_creates_xml_with_all_needed_entries() is missing any coverage information, own or at class level
mod/edusharing/tests/plugin_registration_test.php: (#17) Expected no space between directive and the equals sign in a declare statement; (#17) Expected no space between equal sign and the directive value in a declare statement
mod/edusharing/tests/testUtils/FakeConfig.php: (#33) Opening brace must not be followed by a blank line
mod/edusharing/tests/testUtils/TestStringGenerator.php: (#37) PHP return type declarations must be lowercase; expected "string" but found "String"; (#48) Expected at least 1 space after "."; 0 found; (#53) Expected at least 1 space before "."; 0 found; (#62) Expected at least 1 space after "."; 0 found
mod/edusharing/tests/utility_functions_test.php: (#17) Expected no space between directive and the equals sign in a declare statement; (#17) Expected no space between equal sign and the directive value in a declare statement; (#45) Test method test_if_get_object_id_from_url_returns_proper_path_if_url_is_ok() is missing any coverage information, own or at class level; (#55) Test method test_if_get_object_id_from_url_triggers_warning_if_url_is_malformed() is missing any coverage information, own or at class level; (#56) Expected 1 space after FUNCTION keyword; 0 found; (#72) Test method test_if_get_repository_id_from_url_returns_host_if_url_is_ok() is missing any coverage information, own or at class level; (#83) Test method test_if_get_repository_throws_exception_if_url_is_malformed() is missing any coverage information, own or at class level; (#95) Test method test_if_get_auth_key_returns_user_id_if_sso_is_active_and_obfuscation_is_active() is missing any coverage information, own or at class level; (#115) Test method test_get_auth_key_returns_guest_id_if_guest_option_is_active() is missing any coverage information, own or at class level; (#135) Test method test_get_auth_key_returns_configured_auth_key_if_set() is missing any coverage information, own or at class level; (#155) Test method test_get_auth_key_returns_auth_key_in_profile_if_all_previous_are_not_met() is missing any coverage information, own or at class level; (#175) Test method test_get_auth_key_returns_user_name_as_last_resort() is missing any coverage information, own or at class level; (#194) Test method test_if_set_moodle_ids_in_edusharing_entries_does_not_set_anything_if_no_matches() is missing any coverage information, own or at class level; (#203) Function closing brace must go on the next line following the body; found 1 blank lines before brace; (#211) Test method test_if_set_moodle_ids_in_edusharing_entries_sets_found_resource_ids_to_db() is missing any coverage information, own or at class level; (#230) Expected 1 space after FUNCTION keyword; 0 found; (#252) Expected 1 space after FUNCTION keyword; 0 found; (#277) Test method test_if_set_module_in_db_only_sets_section_id_if_no_module_id_provided() is missing any coverage information, own or at class level; (#296) Expected 1 space after FUNCTION keyword; 0 found; (#315) Expected 1 space after FUNCTION keyword; 0 found; (#340) Test method test_if_set_module_in_db_does_not_set_anything_to_db_if_no_matches_found() is missing any coverage information, own or at class level; (#358) Test method test_if_get_course_module_info_returns_proper_info_if_data_found_in_db() is missing any coverage information, own or at class level; (#396) Expected 1 space after FUNCTION keyword; 0 found; (#416) Test method test_if_get_course_module_info_returns_false_if_no_record_found() is missing any coverage information, own or at class level; (#441) Test method test_get_inline_object_matches_returns_only_atto_matches_from_input() is missing any coverage information, own or at class level
mod/edusharing/view.php: (#68) Opening parenthesis of a multi-line function call must be the last content on the line; (#70) Multi-line function call not indented correctly; expected 4 spaces but found 8; (#70) Closing parenthesis of a multi-line function call must be on a line by itself

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

Update savepoints problems

(1 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

mod/edusharing/db/upgrade.php: 'return true;' not found

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

Overview

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems