Prechecker results: error


Overview

(1 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

The patchset contains changes to upgrade.txt or UPGRADING.md files.

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(26 errors, 25 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/courselinks/backup/moodle2/backup_courselinks_stepslib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#44) There should be a comma after the last array item in a multi-line array.
mod/courselinks/backup/moodle2/restore_courselinks_activity_task.class.php
(#72) Inline comments must start with a capital letter, digit or 3-dots sequence
(#72) This comment is 65% valid code; is this commented out code?
(#90) Inline comments must start with a capital letter, digit or 3-dots sequence
(#90) This comment is 69% valid code; is this commented out code?
mod/courselinks/backup/moodle2/restore_courselinks_stepslib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/courselinks/classes/event/course_module_viewed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/courselinks/classes/output/mobile.php
(#62) Commas (,) must be followed by white space.
mod/courselinks/classes/privacy/provider.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#42) There must not be a space before the colon in a return type declaration
mod/courselinks/db/access.php
(#35) There should be a comma after the last array item in a multi-line array.
(#36) There should be a comma after the last array item in a multi-line array.
(#46) There should be a comma after the last array item in a multi-line array.
(#48) There should be a comma after the last array item in a multi-line array.
mod/courselinks/db/upgrade.php
(#43) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/courselinks/index.php
(#34) File must end with a newline character
mod/courselinks/lang/en/courselinks.php
(#39) The string key "display:card" is not in the correct order, it should be before "display_help"
(#48) The string key "modulename_help" is not in the correct order, it should be before "modulenameplural"
(#51) The string key "opentype" is not in the correct order, it should be before "pluginname"
(#56) The string key "open:new_tab" is not in the correct order, it should be before "opentype_help"
(#61) The string key "privacy:metadata" is not in the correct order, it should be before "show_all_courses_help"
mod/courselinks/lang/es/courselinks.php
(#39) The string key "display:card" is not in the correct order, it should be before "display_help"
(#48) The string key "modulename_help" is not in the correct order, it should be before "modulenameplural"
(#54) The string key "open:new_tab" is not in the correct order, it should be before "opentype_help"
mod/courselinks/lang/fr/courselinks.php
(#39) The string key "display:card" is not in the correct order, it should be before "display_help"
(#42) The string key "display:list" is not in the correct order, it should be before "error_links"
(#48) The string key "modulename_help" is not in the correct order, it should be before "modulenameplural"
(#54) The string key "open:new_tab" is not in the correct order, it should be before "opentype_help"
mod/courselinks/lib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#36) Closing brace must be on a line by itself
(#37) Closing brace must be on a line by itself
(#38) Closing brace must be on a line by itself
(#39) Closing brace must be on a line by itself
(#40) Closing brace must be on a line by itself
(#41) Closing brace must be on a line by itself
(#42) Closing brace must be on a line by itself
(#43) Closing brace must be on a line by itself
(#44) Closing brace must be on a line by itself
(#45) Closing brace must be on a line by itself
(#46) Closing brace must be on a line by itself
(#290) Variable "cards_by_line" must not contain underscores.
(#291) Variable "class_by_number" must not contain underscores.
(#308) Variable "class_by_number" must not contain underscores.
(#308) Variable "cards_by_line" must not contain underscores.
(#312) Line exceeds 132 characters; contains 176 characters
(#340) There should be a comma after the last array item in a multi-line array.
(#354) There should be a comma after the last array item in a multi-line array.
(#386) There should be a comma after the last array item in a multi-line array.
(#411) Line exceeds 132 characters; contains 140 characters
mod/courselinks/mod_form.php
(#100) Line exceeds 132 characters; contains 134 characters

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(2 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/courselinks/lib.php
(#31) Phpdocs for function courselinks_supports has incomplete parameters list
(#460) Phpdocs for function courselinks_has_access has incomplete parameters list

Update savepoints problems

(1 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

mod/courselinks/db/upgrade.php
version 2022081800 has wrong savepoint call with version 2022082200

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 1 warnings)

This section shows problems detected in mustache templates [More info]

mod/courselinks/templates/mobile_view.mustache
(#1) Example context missing.

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]