Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(133 errors, 47 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/completionmarker/backup/moodle2/backup_completionmarker_activity_task.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#23) Whitespace found at end of line
(#55) The static declaration must come after the visibility declaration
mod/completionmarker/backup/moodle2/backup_completionmarker_stepslib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#20) Whitespace found at end of line
(#35) Inline comments must end in full-stops, exclamation marks, or question marks
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
mod/completionmarker/backup/moodle2/restore_completionmarker_activity_task.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#21) Whitespace found at end of line
(#27) Line exceeds 132 characters; contains 135 characters
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Inline comments must start with a capital letter, digit or 3-dots sequence
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#54) The static declaration must come after the visibility declaration
(#66) The static declaration must come after the visibility declaration
(#76) The static declaration must come after the visibility declaration
(#96) The static declaration must come after the visibility declaration
mod/completionmarker/backup/moodle2/restore_completionmarker_stepslib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#21) Whitespace found at end of line
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must start with a capital letter, digit or 3-dots sequence
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
(#53) Inline comments must start with a capital letter, digit or 3-dots sequence
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#58) Inline comments must end in full-stops, exclamation marks, or question marks
mod/completionmarker/classes/privacy/provider.php
(#22) Whitespace found at end of line
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#32) Whitespace found at end of line
mod/completionmarker/db/access.php
(#21) Whitespace found at end of line
mod/completionmarker/db/upgrade.php
(#21) Whitespace found at end of line
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#33) Expected "if (...) {\n"; found "if(...){\n"
(#36) Variable "newField" must be all lower-case
(#38) Variable "newField" must be all lower-case
(#39) Variable "newField" must be all lower-case
(#44) Functions must not contain multiple empty lines in a row; found 2 empty lines
mod/completionmarker/index.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#22) Whitespace found at end of line
(#30) Expected 1 space before "=>"; 0 found
(#30) Expected 1 space after "=>"; 0 found
(#93) Line exceeds 132 characters; contains 143 characters
(#96) Inline comments must start with a capital letter, digit or 3-dots sequence
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
mod/completionmarker/lang/en/completionmarker.php
(#21) Whitespace found at end of line
(#37) File must end with a newline character
mod/completionmarker/lib.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#22) Whitespace found at end of line
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#41) Closing brace must be on a line by itself
(#42) Closing brace must be on a line by itself
(#43) Closing brace must be on a line by itself
(#44) Closing brace must be on a line by itself
(#45) Closing brace must be on a line by itself
(#46) Closing brace must be on a line by itself
(#47) Closing brace must be on a line by itself
(#48) Closing brace must be on a line by itself
(#49) Closing brace must be on a line by itself
(#50) Closing brace must be on a line by itself
(#51) Whitespace found at end of line
(#52) Closing brace must be on a line by itself
(#59) Commas (,) must be followed by white space.
(#73) Line exceeds 132 characters; contains 147 characters
(#73) Inline comments must start with a capital letter, digit or 3-dots sequence
(#73) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) Whitespace found at end of line
(#96) Expected 1 space before "=>"; 0 found
(#96) Expected 1 space after "=>"; 0 found
(#97) Whitespace found at end of line
(#102) Expected 1 space before opening brace; found 0
(#109) File must end with a newline character
mod/completionmarker/mod_form.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#22) Whitespace found at end of line
(#28) "require_once" must be immediately followed by an open parenthesis
(#31) Visibility must be declared on method "definition"
(#34) Commas (,) must be followed by white space.
(#44) Visibility must be declared on method "definition_after_data"
(#45) Opening brace should be on the same line as the declaration
(#53) Visibility must be declared on method "validation"
mod/completionmarker/renderer.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#2) Line 1 of the opening comment must start "// This file is part of".
(#4) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#5) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#6) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#7) Line 6 of the opening comment must start "// (at your option) any later version.".
(#9) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#10) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#12) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#14) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#22) Whitespace found at end of line
(#26) Expected 1 space before opening brace; found 0
(#28) Expected 1 space before opening brace; found 0
(#29) global $PAGE cannot be used in renderers. Use $this->page.
(#34) Expected "if (...) {\n"; found "if(...){\n"
(#38) Expected 1 space before "=>"; 0 found
(#38) Expected 1 space after "=>"; 0 found
(#40) Variable "label_completed" must not contain underscores.
(#40) Line exceeds 132 characters; contains 154 characters
(#41) Variable "label_uncompleted" must not contain underscores.
(#41) Line exceeds 132 characters; contains 146 characters
(#43) Expected "if (...) {\n"; found "if(...){\n"
(#44) Variable "label_completed" must not contain underscores.
(#45) Expected "} else {\n"; found "}else{\n"
(#46) Variable "label_uncompleted" must not contain underscores.
(#51) global $PAGE cannot be used in renderers. Use $this->page.
(#51) Variable "label_completed" must not contain underscores.
(#51) Variable "label_uncompleted" must not contain underscores.
(#55) File must end with a newline character
mod/completionmarker/tests/completionmarker_test.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#22) Whitespace found at end of line
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#33) Whitespace found at end of line
(#36) PHPUnit testcase name "completionmarker_testcase" does not match file name "completionmarker_test"
(#36) PHPUnit class "completionmarker_testcase" does not have any namespace. It is recommended to add it to the "mod_completionmarker" namespace, using more levels if needed, in order to match the code being tested
(#44) Expected 1 space before opening brace; found 0
(#48) Whitespace found at end of line
(#50) Whitespace found at end of line
(#58) Whitespace found at end of line
(#61) Whitespace found at end of line
(#65) Test method test_default_settings() is missing any coverage information, own or at class level
(#65) Expected 1 space before opening brace; found 0
(#70) Inline comments must start with a capital letter, digit or 3-dots sequence
(#70) Inline comments must end in full-stops, exclamation marks, or question marks
(#75) File must end with a newline character
mod/completionmarker/tests/coverage.php
(#20) Whitespace found at end of line
(#30) Whitespace found at end of line
mod/completionmarker/tests/generator/lib.php
(#22) Whitespace found at end of line
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#33) Whitespace found at end of line
(#47) File must end with a newline character
mod/completionmarker/tests/generator_test.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#2) Line 1 of the opening comment must start "// This file is part of".
(#4) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#5) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#6) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#7) Line 6 of the opening comment must start "// (at your option) any later version.".
(#9) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#10) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#12) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#14) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#23) Whitespace found at end of line
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) Whitespace found at end of line
(#37) PHPUnit testcase name "mod_completionmarker_generator_testcase" does not match file name "generator_test"
(#37) PHPUnit class "mod_completionmarker_generator_testcase" does not have any namespace. It is recommended to add it to the "mod_completionmarker" namespace, using more levels if needed, in order to match the code being tested
(#38) Test method test_generator() is missing any coverage information, own or at class level
(#72) File must end with a newline character
mod/completionmarker/version.php
(#21) Whitespace found at end of line
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
mod/completionmarker/view.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#22) Whitespace found at end of line
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) Expected 1 space before "=>"; 0 found
(#32) Expected 1 space after "=>"; 0 found
(#37) Expected 1 space before "=>"; 0 found
(#37) Expected 1 space after "=>"; 0 found
(#40) Variable "course_section" must not contain underscores.
(#40) Expected 1 space before "=>"; 0 found
(#40) Expected 1 space after "=>"; 0 found
(#44) Commas (,) must be followed by white space.
(#44) Expected 1 space before "=>"; 0 found
(#44) Expected 1 space after "=>"; 0 found
(#44) Commas (,) must be followed by white space.
(#44) Expected 1 space before "=>"; 0 found
(#44) Expected 1 space after "=>"; 0 found
(#44) Variable "course_section" must not contain underscores.

Javascript coding style problems

(0 errors, 17 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/completionmarker/amd/src/completionmarker.js
(#3) Unexpected space before function parentheses. (space-before-function-paren)
(#3) Identifier 'label_completed' is not in camel case. (camelcase)
(#3) Identifier 'label_uncompleted' is not in camel case. (camelcase)
(#5) Missing space before opening brace. (space-before-blocks)
(#12) Missing space before opening brace. (space-before-blocks)
(#13) Unnecessary escape character: \'. (no-useless-escape)
(#13) Unnecessary escape character: \'. (no-useless-escape)
(#15) Expected space(s) after "if". (keyword-spacing)
(#15) Missing space before opening brace. (space-before-blocks)
(#18) Expected space(s) before "else". (keyword-spacing)
(#18) Expected space(s) after "else". (keyword-spacing)
(#25) Missing space before opening brace. (space-before-blocks)
(#29) Comments should not begin with a lowercase character. (capitalized-comments)
(#35) Multiple spaces found before '// for moodle ...'. (no-multi-spaces)
(#35) Comments should not begin with a lowercase character. (capitalized-comments)
(#36) Unnecessary escape character: \'. (no-useless-escape)
(#36) Unnecessary escape character: \'. (no-useless-escape)

CSS problems

(3 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

mod/completionmarker/styles.css
(#27) Expected single space before "{" (block-opening-brace-space-before)
(#24) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#1) Expected newline after "," (selector-list-comma-newline-after)

PHPDocs style problems

(18 errors, 19 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/completionmarker/backup/moodle2/backup_completionmarker_activity_task.class.php
(#2) Empty line found after PHP open tag
mod/completionmarker/backup/moodle2/backup_completionmarker_stepslib.php
(#2) Empty line found after PHP open tag
(#33) Function backup_completionmarker_activity_structure_step::define_structure is not documented
(#18) No one-line description found in phpdocs for file
mod/completionmarker/backup/moodle2/restore_completionmarker_activity_task.class.php
(#2) Empty line found after PHP open tag
(#18) No one-line description found in phpdocs for file
(#29) No one-line description found in phpdocs for class restore_completionmarker_activity_task
(#72) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#74) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#88) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#90) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
mod/completionmarker/backup/moodle2/restore_completionmarker_stepslib.php
(#2) Empty line found after PHP open tag
(#34) Function restore_completionmarker_activity_structure_step::define_structure is not documented
(#43) Function restore_completionmarker_activity_structure_step::process_completionmarker is not documented
(#57) Function restore_completionmarker_activity_structure_step::after_execute is not documented
(#18) No one-line description found in phpdocs for file
mod/completionmarker/db/upgrade.php
(#28) Function xmldb_completionmarker_upgrade is not documented
mod/completionmarker/index.php
(#2) Empty line found after PHP open tag
mod/completionmarker/lib.php
(#2) Empty line found after PHP open tag
(#56) Function completionmarker_get_coursemodule_info is not documented
(#65) Function completionmarker_add_instance is not documented
(#80) Function completionmarker_update_instance is not documented
(#93) Function completionmarker_delete_instance is not documented
(#102) Function completionmarker_cm_info_view is not documented
(#28) There is no description in phpdocs for function completionmarker_supports
mod/completionmarker/mod_form.php
(#2) Empty line found after PHP open tag
(#30) Class mod_completionmarker_mod_form is not documented
(#31) Function mod_completionmarker_mod_form::definition is not documented
(#44) Function mod_completionmarker_mod_form::definition_after_data is not documented
(#53) Function mod_completionmarker_mod_form::validation is not documented
mod/completionmarker/renderer.php
(#2) Empty line found after PHP open tag
(#26) Class mod_completionmarker_renderer is not documented
(#28) Function mod_completionmarker_renderer::custom_content is not documented
mod/completionmarker/tests/coverage.php
(#29) Package completionmarker_coverage is not valid
mod/completionmarker/tests/generator/lib.php
(#38) Function mod_completionmarker_generator::create_instance is not documented
mod/completionmarker/tests/generator_test.php
(#2) Empty line found after PHP open tag
mod/completionmarker/view.php
(#2) Empty line found after PHP open tag

Update savepoints problems

(0 errors, 1 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

mod/completionmarker/db/upgrade.php
Detected fewer 'if' blocks (0) than 'savepoint' calls (1). Repeated savepoints?

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]