Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(1 errors, 19 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/collabora/backup/moodle2/backup_collabora_settingslib.php
(#23) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/backup/moodle2/backup_collabora_stepslib.php
(#23) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/backup/moodle2/restore_collabora_stepslib.php
(#23) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/api.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/collabora.php
(#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/curl_security_helper.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/event/course_module_instance_list_viewed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/event/course_module_viewed.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/event/document_locked.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/event/document_repaired.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/event/document_unlocked.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/output/confirmation.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/output/content.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/classes/output/renderer.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/db/caches.php
(#31) File must end with a newline character
mod/collabora/db/upgrade.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/tests/generator/lib.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/collabora/tests/icons_test.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) PHPUnit testcase name "mod_collabora_icons_testcase" does not match file name "icons_test"
(#26) PHPUnit class "mod_collabora_icons_testcase" does not have any namespace. It is recommended to add it to the "mod_collabora" namespace, using more levels if needed, in order to match the code being tested

Javascript coding style problems

(2 errors, 3 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/collabora/amd/src/modal_iframe.js
(#17) @package should be empty. (jsdoc/empty-tags)
(#27) Unexpected space before function parentheses. (space-before-function-paren)
(#32) Unexpected space before function parentheses. (space-before-function-paren)
mod/collabora/amd/src/resizeiframe.js
(#16) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#16) Missing JSDoc comment. (require-jsdoc)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(87 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/collabora/backup/moodle2/backup_collabora_settingslib.php
(#17) No one-line description found in phpdocs for file
mod/collabora/backup/moodle2/backup_collabora_stepslib.php
(#34) Function backup_collabora_activity_structure_step::define_structure is not documented
(#17) No one-line description found in phpdocs for file
mod/collabora/backup/moodle2/restore_collabora_activity_task.class.php
(#17) No one-line description found in phpdocs for file
(#27) No one-line description found in phpdocs for class restore_collabora_activity_task
mod/collabora/backup/moodle2/restore_collabora_stepslib.php
(#34) Function restore_collabora_activity_structure_step::define_structure is not documented
(#48) Function restore_collabora_activity_structure_step::process_collabora is not documented
(#61) Function restore_collabora_activity_structure_step::process_collabora_document is not documented
(#77) Function restore_collabora_activity_structure_step::after_execute is not documented
(#17) No one-line description found in phpdocs for file
mod/collabora/classes/api.php
(#29) Class api is not documented
(#52) Function api::__construct is not documented
(#59) Function api::handle_request is not documented
(#64) Function api::get_userid_from_token is not documented
(#197) Function api::get_user is not documented
(#48) Constant api::REQUEST_GETFILE is not documented
(#49) Constant api::REQUEST_PUTFILE is not documented
(#50) Constant api::REQUEST_CHECKFILEINFO is not documented
(#164) There is no description in phpdocs for function get_stored_file
mod/collabora/classes/collabora.php
(#33) Class collabora is not documented
(#65) Function collabora::format_menu is not documented
(#75) Function collabora::display_menu is not documented
(#82) Function collabora::get_accepted_types is not documented
(#167) Function collabora::__construct is not documented
(#180) Function collabora::display_name is not documented
(#184) Function collabora::display_description is not documented
(#188) Function collabora::is_locked is not documented
(#192) Function collabora::can_lock_unlock is not documented
(#199) Function collabora::process_lock_unlock is not documented
(#244) Function collabora::send_groupfile is not documented
(#458) Function collabora::get_lock_icon is not documented
(#34) Constant collabora::FORMAT_UPLOAD is not documented
(#35) Constant collabora::FORMAT_TEXT is not documented
(#36) Constant collabora::FORMAT_SPREADSHEET is not documented
(#37) Constant collabora::FORMAT_WORDPROCESSOR is not documented
(#38) Constant collabora::FORMAT_PRESENTATION is not documented
(#40) Constant collabora::DISPLAY_CURRENT is not documented
(#41) Constant collabora::DISPLAY_NEW is not documented
(#43) Constant collabora::FILEAREA_INITIAL is not documented
(#44) Constant collabora::FILEAREA_GROUP is not documented
(#47) Constant collabora::ACCEPTED_LANGS is not documented
(#48) Constant collabora::FALLBACK_LANG is not documented
mod/collabora/classes/curl_security_helper.php
(#31) Class curl_security_helper is not documented
(#34) Function curl_security_helper::__construct is not documented
(#32) Variable curl_security_helper::$url is not documented
(#17) No one-line description found in phpdocs for file
mod/collabora/classes/event/course_module_instance_list_viewed.php
(#37) Function course_module_instance_list_viewed::trigger_from_course is not documented
mod/collabora/classes/event/course_module_viewed.php
(#38) Function course_module_viewed::trigger_from_course_cm is not documented
(#61) Function course_module_viewed::get_objectid_mapping is not documented
mod/collabora/classes/event/document_locked.php
(#45) Function document_locked::trigger_from_document is not documented
(#120) Function document_locked::get_objectid_mapping is not documented
(#124) Function document_locked::get_other_mapping is not documented
mod/collabora/classes/event/document_repaired.php
(#45) Function document_repaired::trigger_from_document is not documented
(#120) Function document_repaired::get_objectid_mapping is not documented
(#124) Function document_repaired::get_other_mapping is not documented
mod/collabora/classes/event/document_unlocked.php
(#45) Function document_unlocked::trigger_from_document is not documented
(#120) Function document_unlocked::get_objectid_mapping is not documented
(#124) Function document_unlocked::get_other_mapping is not documented
mod/collabora/classes/output/confirmation.php
(#29) Class confirmation is not documented
(#59) Function confirmation::export_for_template is not documented
(#17) No one-line description found in phpdocs for file
(#36) Phpdocs for function confirmation::__construct has incomplete parameters list
mod/collabora/classes/output/content.php
(#29) Class content is not documented
(#33) Function content::__construct is not documented
(#74) Function content::export_for_template is not documented
(#17) No one-line description found in phpdocs for file
mod/collabora/classes/output/renderer.php
(#29) Class renderer is not documented
(#30) Function renderer::is_boost_based is not documented
(#17) No one-line description found in phpdocs for file
mod/collabora/classes/privacy/provider.php
(#20) Package collabora is not valid
(#40) Package collabora is not valid
mod/collabora/db/upgrade.php
(#26) Function xmldb_collabora_upgrade is not documented
mod/collabora/lib.php
(#28) Function collabora_supports is not documented
(#77) Function collabora_update_instance is not documented
(#94) Function collabora_delete_instance is not documented
(#166) Function collabora_get_coursemodule_info is not documented
(#189) Function collabora_pluginfile is not documented
(#51) There is no description in phpdocs for function collabora_add_instance
(#52) Phpdocs for function collabora_add_instance has incomplete parameters list
(#226) Phpdocs for function collabora_extend_settings_navigation has incomplete parameters list
mod/collabora/mod_form.php
(#29) Class mod_collabora_mod_form is not documented
(#30) Function mod_collabora_mod_form::get_filemanager_opts is not documented
(#39) Function mod_collabora_mod_form::get_file_link is not documented
(#52) Function mod_collabora_mod_form::definition is not documented
(#116) Function mod_collabora_mod_form::validation is not documented
mod/collabora/tests/generator/lib.php
(#28) Function mod_collabora_generator::create_instance is not documented
mod/collabora/tests/icons_test.php
(#27) Variable mod_collabora_icons_testcase::$course is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 2 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

mod/collabora/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 2 warnings)

This section shows problems detected in mustache templates [More info]

mod/collabora/templates/content.mustache
(#1) HTML Validation info, line 33: Empty heading. ( <h3 class="my-0 py-0"> )
mod/collabora/templates/modal.mustache
(#1) HTML Validation info, line 9: Empty heading. (> <h3 class="my-0 py-0"> )

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]