Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(10 errors, 127 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/checkmark/backup/moodle2/backup_checkmark_stepslib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/backup/moodle2/restore_checkmark_stepslib.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/MTablePDF.php
(#155) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#272) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#325) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#343) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#355) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#468) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#618) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/checkmark/classes/basetemplate.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/course_module_instance_list_viewed.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#37) File must end with a newline character
mod/checkmark/classes/event/course_module_viewed.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/example_created.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/example_deleted.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/example_updated.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/grade_updated.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/group_override.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#80) File must end with a newline character
mod/checkmark/classes/event/group_override_created.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#84) File must end with a newline character
mod/checkmark/classes/event/group_override_deleted.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#83) File must end with a newline character
mod/checkmark/classes/event/group_override_priority_changed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/group_override_updated.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/printpreview_viewed.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/submission_edited.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/submission_overwritten.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/submission_updated.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#68) File must end with a newline character
mod/checkmark/classes/event/submissions_exported.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/submissions_viewed.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/submissions_viewed_base.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/user_override.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#80) File must end with a newline character
mod/checkmark/classes/event/user_override_created.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/user_override_deleted.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/event/user_override_updated.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/example.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/export.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/exportform.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#218) Logical operator "and" is prohibited; use "&&" instead
mod/checkmark/classes/grades/gradeitems.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/gradingsummary.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/local/exporttemplates/grades.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/local/exporttemplates/grades_extended.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/local/exporttemplates/signature.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/local/exporttemplates/signature_extended.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/observer.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/overrideform.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/search/activity.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/submission.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/classes/submissionstable.php
(#159) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#1330) This comment is 50% valid code; is this commented out code?
(#1576) Logical operator "or" is prohibited; use "||" instead
(#1764) This comment is 50% valid code; is this commented out code?
mod/checkmark/classes/task/send_notifications.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/db/manual_upgrade.php
(#31) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/checkmark/db/tasks.php
(#37) File must end with a newline character
mod/checkmark/db/upgrade.php
(#1236) Inline comments must end in full-stops, exclamation marks, or question marks
(#1257) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#1257) Line exceeds 132 characters; contains 165 characters
mod/checkmark/export.php
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#34) Inline comments must start with a capital letter, digit or 3-dots sequence
(#34) Inline comments must end in full-stops, exclamation marks, or question marks
mod/checkmark/externallib.php
(#47) Line exceeds 132 characters; contains 138 characters
(#223) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/checkmark/grade.php
(#32) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#36) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#40) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/checkmark/grading_form.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/index.php
(#33) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/checkmark/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#316) Logical operator "or" is prohibited; use "||" instead
(#1466) Logical operator "and" is prohibited; use "&&" instead
(#1594) Logical operator "and" is prohibited; use "&&" instead
(#1794) Logical operator "or" is prohibited; use "||" instead
(#2124) Logical operator "and" is prohibited; use "&&" instead
mod/checkmark/locallib.php
(#133) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#143) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#149) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#204) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#207) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#210) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#215) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#218) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#221) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#372) Logical operator "and" is prohibited; use "&&" instead
(#825) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#830) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#1331) Logical operator "or" is prohibited; use "||" instead
(#1795) Line exceeds 132 characters; contains 139 characters
(#1890) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#2156) Logical operator "and" is prohibited; use "&&" instead
(#2332) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#3144) Line exceeds 132 characters; contains 138 characters
(#3227) Line exceeds 132 characters; contains 133 characters
(#3258) Logical operator "or" is prohibited; use "||" instead
(#3428) Logical operator "or" is prohibited; use "||" instead
(#3559) Logical operator "or" is prohibited; use "||" instead
(#3609) This comment is 62% valid code; is this commented out code?
mod/checkmark/overrides.php
(#75) Logical operator "and" is prohibited; use "&&" instead
mod/checkmark/renderer.php
(#91) Logical operator "and" is prohibited; use "&&" instead
(#347) File must end with a newline character
mod/checkmark/submissions.php
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#34) Inline comments must start with a capital letter, digit or 3-dots sequence
(#34) Inline comments must end in full-stops, exclamation marks, or question marks
mod/checkmark/tests/externallib_test.php
(#38) PHPUnit testcase name "mod_checkmark_external_testcase" does not match file name "externallib_test"
(#38) PHPUnit class "mod_checkmark_external_testcase" does not have any namespace. It is recommended to add it to the "mod_checkmark" namespace, using more levels if needed, in order to match the code being tested
(#48) Test method test_get_checkmarks_by_courses() is missing any coverage information, own or at class level
(#109) Test method test_get_checkmark() is missing any coverage information, own or at class level
(#124) Test method test_get_checkmark_hidden() is missing any coverage information, own or at class level
(#159) Test method test_get_submit() is missing any coverage information, own or at class level
(#199) Test method test_get_submit_negative() is missing any coverage information, own or at class level
(#269) File must end with a newline character
mod/checkmark/tests/formvalidation_test.php
(#26) Old MOODLE_INTERNAL check detected. Replace it by "defined('MOODLE_INTERNAL') || die();"
(#42) PHPUnit testcase name "checkmark_formvalidation_test" does not match file name "formvalidation_test"
(#42) PHPUnit class "checkmark_formvalidation_test" does not have any namespace. It is recommended to add it to the "mod_checkmark" namespace, using more levels if needed, in order to match the code being tested
(#46) Test method test_countmismatch() is missing any coverage information, own or at class level
(#73) Test method test_summismatch() is missing any coverage information, own or at class level
(#100) Test method test_both_errors() is missing any coverage information, own or at class level
(#132) Test method test_noflexiblenaming() is missing any coverage information, own or at class level
(#159) Test method test_noerror() is missing any coverage information, own or at class level
mod/checkmark/tests/generator/behat_mod_checkmark_generator.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/tests/generator/lib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/checkmark/tests/overridedates_test.php
(#26) Old MOODLE_INTERNAL check detected. Replace it by "defined('MOODLE_INTERNAL') || die();"
(#51) PHPUnit testcase name "checkmark_overridedates_test" does not match file name "overridedates_test"
(#51) PHPUnit class "checkmark_overridedates_test" does not have any namespace. It is recommended to add it to the "mod_checkmark" namespace, using more levels if needed, in order to match the code being tested
(#96) Test method test_add_user_override() is missing any coverage information, own or at class level
(#122) Test method test_add_group_override() is missing any coverage information, own or at class level
(#143) Test method test_update_user_override() is missing any coverage information, own or at class level
(#171) Test method test_update_group_override() is missing any coverage information, own or at class level
(#207) Test method test_add_identical_overwrite() is missing any coverage information, own or at class level
(#224) Test method test_delete_user_override() is missing any coverage information, own or at class level
(#245) Test method test_delete_group_override() is missing any coverage information, own or at class level
(#265) Test method test_reorder_grouppriority() is missing any coverage information, own or at class level
(#389) File must end with a newline character

Javascript coding style problems

(0 errors, 68 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/checkmark/amd/src/grading.js
(#1) Unexpected space before function parentheses. (space-before-function-paren)
(#3) Unexpected space before function parentheses. (space-before-function-paren)
(#3) A space is required after ','. (comma-spacing)
(#8) Unexpected space before function parentheses. (space-before-function-paren)
(#12) Unexpected space before function parentheses. (space-before-function-paren)
(#14) Expected space(s) after "if". (keyword-spacing)
(#20) Unexpected space before function parentheses. (space-before-function-paren)
(#22) Unexpected space before function parentheses. (space-before-function-paren)
(#23) Expected space(s) after "if". (keyword-spacing)
(#26) Unexpected space before function parentheses. (space-before-function-paren)
(#35) Unexpected space before function parentheses. (space-before-function-paren)
(#43) Expected catch,fail() or return (promise/catch-or-return)
(#43) Each then() should return a value or throw (promise/always-return)
(#43) Unexpected space before function parentheses. (space-before-function-paren)
(#48) Unexpected space before function parentheses. (space-before-function-paren)
(#52) Unexpected space before function parentheses. (space-before-function-paren)
(#55) A space is required after ','. (comma-spacing)
(#58) Unexpected space before function parentheses. (space-before-function-paren)
(#59) Unexpected space before function parentheses. (space-before-function-paren)
mod/checkmark/amd/src/quickgrade.js
(#1) Unexpected space before function parentheses. (space-before-function-paren)
(#3) Unexpected space before function parentheses. (space-before-function-paren)
(#3) A space is required after ','. (comma-spacing)
(#8) Unexpected space before function parentheses. (space-before-function-paren)
(#8) Unexpected empty function. (no-empty-function)
(#11) Unexpected space before function parentheses. (space-before-function-paren)
(#12) Expected space(s) after "if". (keyword-spacing)
(#20) Unexpected space before function parentheses. (space-before-function-paren)
(#22) Unexpected space before function parentheses. (space-before-function-paren)
(#23) Expected space(s) after "if". (keyword-spacing)
(#26) Unexpected space before function parentheses. (space-before-function-paren)
(#35) Unexpected space before function parentheses. (space-before-function-paren)
(#35) A space is required after ','. (comma-spacing)
(#44) Expected catch,fail() or return (promise/catch-or-return)
(#44) Each then() should return a value or throw (promise/always-return)
(#44) Unexpected space before function parentheses. (space-before-function-paren)
(#50) Unexpected space before function parentheses. (space-before-function-paren)
(#54) Unexpected space before function parentheses. (space-before-function-paren)
(#57) A space is required after ','. (comma-spacing)
(#61) Unexpected space before function parentheses. (space-before-function-paren)
(#62) Unexpected space before function parentheses. (space-before-function-paren)
(#63) ["value"] is better written in dot notation. (dot-notation)
(#64) A space is required after ','. (comma-spacing)
mod/checkmark/amd/src/submission.js
(#34) Unexpected empty function. (no-empty-function)
mod/checkmark/amd/src/utils.js
(#1) Unexpected space before function parentheses. (space-before-function-paren)
(#3) Unexpected space before function parentheses. (space-before-function-paren)
(#8) Unexpected space before function parentheses. (space-before-function-paren)
(#16) Unexpected space before function parentheses. (space-before-function-paren)
(#25) Unquoted number literal '200' used as key. (quote-props)
(#25) Unexpected space before function parentheses. (space-before-function-paren)
(#38) Unexpected space before function parentheses. (space-before-function-paren)
(#41) Unexpected space before function parentheses. (space-before-function-paren)
(#44) Identifier 'classes_arr' is not in camel case. (camelcase)
(#45) Identifier 'classes_arr' is not in camel case. (camelcase)
(#45) Unexpected space before function parentheses. (space-before-function-paren)
(#53) Unexpected space before function parentheses. (space-before-function-paren)
(#56) Unexpected space before function parentheses. (space-before-function-paren)
(#59) Unexpected space before function parentheses. (space-before-function-paren)
(#60) A space is required after ','. (comma-spacing)
(#63) Unexpected space before function parentheses. (space-before-function-paren)
(#88) There should be no space after '['. (array-bracket-spacing)
(#91) A space is required after ','. (comma-spacing)
(#94) A space is required after ','. (comma-spacing)
(#100) Expected catch,fail() or return (promise/catch-or-return)
(#100) Each then() should return a value or throw (promise/always-return)
(#100) Unexpected space before function parentheses. (space-before-function-paren)
(#116) Unexpected space before function parentheses. (space-before-function-paren)
(#117) Unexpected space before function parentheses. (space-before-function-paren)
(#120) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(7 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

mod/checkmark/amd/build/checkboxcontroller.min.js.map
Uncommitted change detected.
mod/checkmark/amd/build/grading.min.js.map
Uncommitted change detected.
mod/checkmark/amd/build/overrides.min.js.map
Uncommitted change detected.
mod/checkmark/amd/build/quickgrade.min.js.map
Uncommitted change detected.
mod/checkmark/amd/build/settings.min.js.map
Uncommitted change detected.
mod/checkmark/amd/build/submission.min.js.map
Uncommitted change detected.
mod/checkmark/amd/build/utils.min.js.map
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]