Prechecker results: error

Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(134 errors, 200 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

public/mod/certifygen/classes/certifygen.php: (#173) Inline comments must start with a capital letter, digit or 3-dots sequence; (#173) This comment is 56% valid code; is this commented out code?; (#173) No space found before comment text; expected "// private static function get_users_issued_select(int $courseid, int $templateid): array {" but found "//private static function get_users_issued_select(int $courseid, int $templateid): array {"; (#174) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#175) Expected 1 space before comment text but found 14; use block comment if you need indentation; (#176) Expected 1 space before comment text but found 13; use block comment if you need indentation; (#177) Expected 1 space before comment text but found 19; use block comment if you need indentation; (#178) Expected 1 space before comment text but found 19; use block comment if you need indentation; (#179) Expected 1 space before comment text but found 19; use block comment if you need indentation; (#181) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#182) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#183) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#184) Inline comments must end in full-stops, exclamation marks, or question marks; (#184) No space found before comment text; expected "// }" but found "//}"
public/mod/certifygen/classes/completion/custom_completion.php: (#55) Line indented incorrectly; expected 0 spaces, found 1; (#73) Inline comments must end in full-stops, exclamation marks, or question marks; (#106) There should be a comma after the last array item in a multi-line array.; (#121) Closing brace indented incorrectly; expected 1 spaces, found 0
public/mod/certifygen/classes/event/certificate_downloaded.php: (#85) Blank line found at end of control structure; (#85) Whitespace found at end of line
public/mod/certifygen/classes/event/course_module_instance_list_viewed.php: (#1) Moodle boilerplate not found; (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#48) Short array syntax must be used to define arrays; (#49) There should be a comma after the last array item in a multi-line array.; (#51) Must use "self::" for local static member reference
public/mod/certifygen/classes/external/get_id_instance_certificate_external.php: (#83) Whitespace found at end of line
public/mod/certifygen/classes/external/getmycertificatedata_external.php: (#109) Inline comments must end in full-stops, exclamation marks, or question marks
public/mod/certifygen/classes/filters/certifygenfilter.php: (#82) Line exceeds 132 characters; contains 177 characters; (#85) Line exceeds 132 characters; contains 157 characters
public/mod/certifygen/classes/persistents/certifygen_validations.php: (#175) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $userid.; (#196) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $user.
public/mod/certifygen/classes/privacy/provider.php: (#103) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#104) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#105) Multi-line function call not indented correctly; expected 12 spaces but found 16
public/mod/certifygen/classes/tables/activityteacher_table.php: (#92) Visibility must be declared on method "__construct"; (#97) Inline doc block type-hinting for '$cm' does not match next code line '[...'
public/mod/certifygen/db/upgrade.php: (#60) Blank line found at start of control structure; (#86) Blank line found at start of control structure; (#100) Blank line found at start of control structure; (#114) Functions must not contain multiple empty lines in a row; found 2 empty lines
public/mod/certifygen/lang/gl/certifygen.php: (#237) Expected 1 blank line at end of file; 2 found
public/mod/certifygen/lib.php: (#453) Multi-line function declaration not indented correctly; expected 4 spaces but found 8; (#623) Inline doc block comments are not allowed; use "// Comment." instead; (#633) Inline comments must start with a capital letter, digit or 3-dots sequence; (#633) This comment is 49% valid code; is this commented out code?; (#633) No space found before comment text; expected "// function certifygen_get_completion_state($course, $cm, $userid, $type) {" but found "//function certifygen_get_completion_state($course, $cm, $userid, $type) {"; (#635) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#636) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#638) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#639) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#640) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#641) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#642) Expected 1 space before comment text but found 20; use block comment if you need indentation; (#643) Expected 1 space before comment text but found 20; use block comment if you need indentation; (#644) Expected 1 space before comment text but found 20; use block comment if you need indentation; (#645) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#646) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#647) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#648) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#649) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#650) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#651) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#652) Inline comments must end in full-stops, exclamation marks, or question marks; (#652) No space found before comment text; expected "// }" but found "//}"; (#653) Inline doc block comments are not allowed; use "// Comment." instead; (#659) Inline comments must start with a capital letter, digit or 3-dots sequence; (#659) This comment is 55% valid code; is this commented out code?; (#659) No space found before comment text; expected "// function mod_certifygen_get_completion_active_rule_descriptions($cm) {" but found "//function mod_certifygen_get_completion_active_rule_descriptions($cm) {"; (#660) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#661) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#662) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#663) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#665) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#666) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#667) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#668) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#669) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#670) Expected 1 space before comment text but found 20; use block comment if you need indentation; (#671) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#672) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#673) Expected 1 space before comment text but found 12; use block comment if you need indentation; (#674) Expected 1 space before comment text but found 16; use block comment if you need indentation; (#675) Expected 1 space before comment text but found 8; use block comment if you need indentation; (#676) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#677) Expected 1 space before comment text but found 4; use block comment if you need indentation; (#678) Inline comments must end in full-stops, exclamation marks, or question marks; (#678) No space found before comment text; expected "// }" but found "//}"
public/mod/certifygen/mod_form.php: (#123) Opening parenthesis of a multi-line function call must be the last content on the line; (#124) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#125) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#126) Multi-line function call not indented correctly; expected 8 spaces but found 16; (#126) Closing parenthesis of a multi-line function call must be on a line by itself; (#146) Visibility must be declared on method "data_preprocessing"; (#146) Variable "default_values" must not contain underscores.; (#147) Variable "default_values" must not contain underscores.; (#152) Variable "default_values" must not contain underscores.; (#153) Variable "default_values" must not contain underscores.; (#154) Variable "default_values" must not contain underscores.; (#155) Variable "default_values" must not contain underscores.
public/mod/certifygen/report/basic/classes/useofthecoursealgorithm.php: (#325) The use of the AS keyword to alias tables is bad for cross-db
public/mod/certifygen/report/basic/lang/ca/certifygenreport_basic.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "certifygenreport_basic_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "footer" is not in the correct order, it should be before "logo_desc"; (#44) The string key "and" is not in the correct order, it should be before "footer_desc"; (#46) The string key "courseinfo" is not in the correct order, it should be before "reporttext"; (#51) The string key "cdetail_1" is not in the correct order, it should be before "coursetypedesc"; (#54) The string key "cannotusealgorith_nostudents" is not in the correct order, it should be before "cdetail_3"
public/mod/certifygen/report/basic/lang/en/certifygenreport_basic.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "certifygenreport_basic_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "footer" is not in the correct order, it should be before "logo_desc"; (#44) The string key "and" is not in the correct order, it should be before "footer_desc"; (#46) The string key "courseinfo" is not in the correct order, it should be before "reporttext"; (#51) The string key "cdetail_1" is not in the correct order, it should be before "coursetypedesc"; (#54) The string key "cannotusealgorith_nostudents" is not in the correct order, it should be before "cdetail_3"
public/mod/certifygen/report/basic/lang/es/certifygenreport_basic.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "certifygenreport_basic_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "footer" is not in the correct order, it should be before "logo_desc"; (#44) The string key "and" is not in the correct order, it should be before "footer_desc"; (#46) The string key "courseinfo" is not in the correct order, it should be before "reporttext"; (#51) The string key "cdetail_1" is not in the correct order, it should be before "coursetypedesc"; (#54) The string key "cannotusealgorith_nostudents" is not in the correct order, it should be before "cdetail_3"
public/mod/certifygen/report/basic/lang/eu/certifygenreport_basic.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "certifygenreport_basic_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "footer" is not in the correct order, it should be before "logo_desc"; (#44) The string key "and" is not in the correct order, it should be before "footer_desc"; (#46) The string key "courseinfo" is not in the correct order, it should be before "reporttext"; (#51) The string key "cdetail_1" is not in the correct order, it should be before "coursetypedesc"; (#54) The string key "cannotusealgorith_nostudents" is not in the correct order, it should be before "cdetail_3"
public/mod/certifygen/report/basic/lang/gl/certifygenreport_basic.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "certifygenreport_basic_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "footer" is not in the correct order, it should be before "logo_desc"; (#44) The string key "and" is not in the correct order, it should be before "footer_desc"; (#46) The string key "courseinfo" is not in the correct order, it should be before "reporttext"; (#51) The string key "cdetail_1" is not in the correct order, it should be before "coursetypedesc"; (#54) The string key "cannotusealgorith_nostudents" is not in the correct order, it should be before "cdetail_3"
public/mod/certifygen/repository/csv/lang/ca/certifygenrepository_csv.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/csv/lang/en/certifygenrepository_csv.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#38) The string key "certifygenvalidationcsvnotfound" is not in the correct order, it should be before "privacy:metadata"
public/mod/certifygen/repository/csv/lang/es/certifygenrepository_csv.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/csv/lang/eu/certifygenrepository_csv.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/csv/lang/gl/certifygenrepository_csv.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/localrepository/lang/ca/certifygenrepository_localrepository.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/localrepository/lang/en/certifygenrepository_localrepository.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/localrepository/lang/es/certifygenrepository_localrepository.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/localrepository/lang/eu/certifygenrepository_localrepository.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/localrepository/lang/gl/certifygenrepository_localrepository.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/onedrive/classes/certifygenrepository_onedrive.php: (#1) No one-line description found in phpdocs for docblock of file certifygenrepository_onedrive.php
public/mod/certifygen/repository/onedrive/lang/ca/certifygenrepository_onedrive.php.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "privacy:metadata" is not in the correct order, it should be before "settings_folder_desc"; (#41) The string key "privacy:metadata:userid" is not in the correct order, it should be before "privacy:metadata:validationid"; (#42) The string key "privacy:metadata:url" is not in the correct order, it should be before "privacy:metadata:userid"
public/mod/certifygen/repository/onedrive/lang/en/certifygenrepository_onedrive.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "privacy:metadata" is not in the correct order, it should be before "settings_folder_desc"; (#41) The string key "privacy:metadata:userid" is not in the correct order, it should be before "privacy:metadata:validationid"; (#42) The string key "privacy:metadata:url" is not in the correct order, it should be before "privacy:metadata:userid"
public/mod/certifygen/repository/onedrive/lang/es/certifygenrepository_onedrive.php.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "privacy:metadata" is not in the correct order, it should be before "settings_folder_desc"; (#41) The string key "privacy:metadata:userid" is not in the correct order, it should be before "privacy:metadata:validationid"; (#42) The string key "privacy:metadata:url" is not in the correct order, it should be before "privacy:metadata:userid"
public/mod/certifygen/repository/onedrive/lang/eu/certifygenrepository_onedrive.php.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "privacy:metadata" is not in the correct order, it should be before "settings_folder_desc"; (#41) The string key "privacy:metadata:userid" is not in the correct order, it should be before "privacy:metadata:validationid"; (#42) The string key "privacy:metadata:url" is not in the correct order, it should be before "privacy:metadata:userid"
public/mod/certifygen/repository/onedrive/lang/gl/certifygenrepository_onedrive.php.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "privacy:metadata" is not in the correct order, it should be before "settings_folder_desc"; (#41) The string key "privacy:metadata:userid" is not in the correct order, it should be before "privacy:metadata:validationid"; (#42) The string key "privacy:metadata:url" is not in the correct order, it should be before "privacy:metadata:userid"
public/mod/certifygen/repository/url/lang/ca/certifygenrepository_url.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/url/lang/en/certifygenrepository_url.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/url/lang/es/certifygenrepository_url.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/url/lang/eu/certifygenrepository_url.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/repository/url/lang/gl/certifygenrepository_url.php: (#35) The string key "enable" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/tests/deletemodel_external_test.php: (#54) Unit test deletemodel_external_test should be declared as final.; (#58) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/deleteteacherrequest_external_test.php: (#53) Unit test deleteteacherrequest_external_test should be declared as final.; (#57) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/downloadcertificate_external_test.php: (#56) Unit test downloadcertificate_external_test should be declared as final.; (#60) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/downloadteachercertificate_external_test.php: (#56) Unit test downloadteachercertificate_external_test should be declared as final.; (#60) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/emitcertificate_external_test.php: (#54) Unit test emitcertificate_external_test should be declared as final.; (#58) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/emitteacherrequest_external_test.php: (#54) Unit test emitteacherrequest_external_test should be declared as final.; (#58) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/get_courses_as_student_external_test.php: (#52) Unit test get_courses_as_student_external_test should be declared as final.; (#56) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/get_courses_as_teacher_external_test.php: (#52) Unit test get_courses_as_teacher_external_test should be declared as final.; (#56) The setUp() method in unit tests must always call to parent::setUp().; (#127) Test method test_get_courses_as_teacher() is missing any coverage information, own or at class level
public/mod/certifygen/tests/get_id_instance_certificate_external_test.php: (#53) Unit test get_id_instance_certificate_external_test should be declared as final.; (#57) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/get_json_teacher_certificate_external_test.php: (#52) Unit test get_json_teacher_certificate_external_test should be declared as final.; (#56) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/get_pdf_certificate_external_test.php: (#55) Unit test get_pdf_certificate_external_test should be declared as final.; (#59) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/get_pdf_teacher_certificate_external_test.php: (#54) Unit test get_pdf_teacher_certificate_external_test should be declared as final.; (#58) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/getcoursesnames_external_test.php: (#51) Unit test getcoursesnames_external_test should be declared as final.; (#55) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/getmodellisttable_external_test.php: (#52) Unit test getmodellisttable_external_test should be declared as final.; (#56) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/getmycertificatedata_external_test.php: (#52) Unit test getmycertificatedata_external_test should be declared as final.; (#56) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/getteacherrequestviewdata_external_test.php: (#53) Unit test getteacherrequestviewdata_external_test should be declared as final.; (#57) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/revokecertificate_external_test.php: (#55) Unit test revokecertificate_external_test should be declared as final.; (#67) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/searchcategory_external_test.php: (#57) Unit test searchcategory_external_test should be declared as final.; (#61) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/searchcourse_external_test.php: (#51) Unit test searchcourse_external_test should be declared as final.; (#55) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/tests/searchmycourses_external_test.php: (#53) Unit test searchmycourses_external_test should be declared as final.; (#57) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/validation/cmd/classes/certifygenvalidation_cmd.php: (#100) Whitespace found at end of line
public/mod/certifygen/validation/cmd/lang/ca/certifygenvalidation_cmd.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#38) The string key "certifygenvalidation_cmd_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "originalfilespath" is not in the correct order, it should be before "privacy:metadata"; (#46) The string key "temp_file_not_exists" is not in the correct order, it should be before "validatedfilespath_help"; (#47) The string key "missing_directory_permissions" is not in the correct order, it should be before "temp_file_not_exists"; (#48) The string key "error_cmd_code" is not in the correct order, it should be before "missing_directory_permissions"
public/mod/certifygen/validation/cmd/lang/en/certifygenvalidation_cmd.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#38) The string key "certifygenvalidation_cmd_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "originalfilespath" is not in the correct order, it should be before "privacy:metadata"; (#46) The string key "path_not_exists" is not in the correct order, it should be before "validatedfilespath_help"; (#51) The string key "error_cmd_code" is not in the correct order, it should be before "wsoutput_help"; (#53) The string key "missing_directory_permissions" is not in the correct order, it should be before "temp_file_not_exists"
public/mod/certifygen/validation/cmd/lang/es/certifygenvalidation_cmd.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#38) The string key "certifygenvalidation_cmd_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "originalfilespath" is not in the correct order, it should be before "privacy:metadata"; (#46) The string key "path_not_exists" is not in the correct order, it should be before "validatedfilespath_help"
public/mod/certifygen/validation/cmd/lang/eu/certifygenvalidation_cmd.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#38) The string key "certifygenvalidation_cmd_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "originalfilespath" is not in the correct order, it should be before "privacy:metadata"; (#46) The string key "path_not_exists" is not in the correct order, it should be before "validatedfilespath_help"
public/mod/certifygen/validation/cmd/lang/gl/certifygenvalidation_cmd.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#38) The string key "certifygenvalidation_cmd_settings" is not in the correct order, it should be before "path_help"; (#42) The string key "originalfilespath" is not in the correct order, it should be before "privacy:metadata"; (#46) The string key "path_not_exists" is not in the correct order, it should be before "validatedfilespath_help"
public/mod/certifygen/validation/csv/classes/certifygenvalidation_csv.php: (#158) Whitespace found at end of line within string; (#195) Whitespace found at end of line within string; (#220) Whitespace found at end of line within string; (#247) Whitespace found at end of line within string; (#491) Whitespace found at end of line within string
public/mod/certifygen/validation/csv/lang/ca/certifygenvalidation_csv.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#40) The string key "appID" is not in the correct order, it should be before "firmaquerycatalogserviceurl_help"; (#45) The string key "csv_result_not_expected" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/validation/csv/lang/en/certifygenvalidation_csv.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#40) The string key "appID" is not in the correct order, it should be before "firmaquerycatalogserviceurl_help"; (#45) The string key "csv_result_not_expected" is not in the correct order, it should be before "pluginnamesettings"; (#51) The string key "getstatuserror" is not in the correct order, it should be before "wsoutput_help"; (#53) The string key "certifygenvalidationcsvnotfound" is not in the correct order, it should be before "validationidnotfound"
public/mod/certifygen/validation/csv/lang/eu/certifygenvalidation_csv.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#40) The string key "appID" is not in the correct order, it should be before "firmaquerycatalogserviceurl_help"; (#45) The string key "csv_result_not_expected" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/validation/csv/lang/gl/certifygenvalidation_csv.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#40) The string key "appID" is not in the correct order, it should be before "firmaquerycatalogserviceurl_help"; (#45) The string key "csv_result_not_expected" is not in the correct order, it should be before "pluginnamesettings"
public/mod/certifygen/validation/electronic/lang/ca/certifygenvalidation_electronic.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#37) The string key "path" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "password" is not in the correct order, it should be before "pathdesc"; (#41) The string key "name" is not in the correct order, it should be before "passworddesc"; (#43) The string key "location" is not in the correct order, it should be before "namedesc"; (#47) The string key "contactinfo" is not in the correct order, it should be before "reasondesc"
public/mod/certifygen/validation/electronic/lang/en/certifygenvalidation_electronic.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#37) The string key "path" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "password" is not in the correct order, it should be before "pathdesc"; (#41) The string key "name" is not in the correct order, it should be before "passworddesc"; (#43) The string key "location" is not in the correct order, it should be before "namedesc"; (#47) The string key "contactinfo" is not in the correct order, it should be before "reasondesc"
public/mod/certifygen/validation/electronic/lang/es/certifygenvalidation_electronic.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#37) The string key "path" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "password" is not in the correct order, it should be before "pathdesc"; (#41) The string key "name" is not in the correct order, it should be before "passworddesc"; (#43) The string key "location" is not in the correct order, it should be before "namedesc"; (#47) The string key "contactinfo" is not in the correct order, it should be before "reasondesc"
public/mod/certifygen/validation/electronic/lang/eu/certifygenvalidation_electronic.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#37) The string key "path" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "password" is not in the correct order, it should be before "pathdesc"; (#41) The string key "name" is not in the correct order, it should be before "passworddesc"; (#43) The string key "location" is not in the correct order, it should be before "namedesc"; (#47) The string key "contactinfo" is not in the correct order, it should be before "reasondesc"
public/mod/certifygen/validation/electronic/lang/gl/certifygenvalidation_electronic.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#37) The string key "path" is not in the correct order, it should be before "pluginnamesettings"; (#39) The string key "password" is not in the correct order, it should be before "pathdesc"; (#41) The string key "name" is not in the correct order, it should be before "passworddesc"; (#43) The string key "location" is not in the correct order, it should be before "namedesc"; (#47) The string key "contactinfo" is not in the correct order, it should be before "reasondesc"
public/mod/certifygen/validation/none/lang/ca/certifygenvalidation_none.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#36) The string key "certifygenvalidation_none_settings" is not in the correct order, it should be before "enable_help"
public/mod/certifygen/validation/none/lang/en/certifygenvalidation_none.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#36) The string key "certifygenvalidation_none_settings" is not in the correct order, it should be before "enable_help"
public/mod/certifygen/validation/none/lang/es/certifygenvalidation_none.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#36) The string key "certifygenvalidation_none_settings" is not in the correct order, it should be before "enable_help"
public/mod/certifygen/validation/none/lang/eu/certifygenvalidation_none.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#36) The string key "certifygenvalidation_none_settings" is not in the correct order, it should be before "enable_help"; (#43) The string key "wsoutput" is duplicated; (#44) The string key "wsoutput_help" is duplicated
public/mod/certifygen/validation/none/lang/gl/certifygenvalidation_none.php: (#34) The string key "enable" is not in the correct order, it should be before "pluginname"; (#36) The string key "certifygenvalidation_none_settings" is not in the correct order, it should be before "enable_help"
public/mod/certifygen/validation/webservice/classes/external/change_status_external.php: (#148) Inline comments must start with a capital letter, digit or 3-dots sequence; (#148) This comment is 60% valid code; is this commented out code?; (#148) No space found before comment text; expected "// 'usermodifed' => $USER->id," but found "//'usermodifed' => $USER->id,"; (#149) No space found before comment text; expected "// 'data' => ''," but found "//'data' => '',"; (#153) There should be a comma after the last array item in a multi-line array.
public/mod/certifygen/validation/webservice/classes/external/get_draft_teacher_certificate_external.php: (#112) Whitespace found at end of line; (#118) Whitespace found at end of line; (#125) Whitespace found at end of line; (#126) Whitespace found at end of line
public/mod/certifygen/validation/webservice/tests/change_status_external_test.php: (#52) Unit test change_status_external_test should be declared as final.; (#56) The setUp() method in unit tests must always call to parent::setUp().; (#137) Multi-line function call not indented correctly; expected 12 spaces but found 16
public/mod/certifygen/validation/webservice/tests/get_draft_certificate_external_test.php: (#60) Unit test get_draft_certificate_external_test should be declared as final.; (#64) The setUp() method in unit tests must always call to parent::setUp().; (#164) This comment is 42% valid code; is this commented out code?; (#165) Inline comments must end in full-stops, exclamation marks, or question marks; (#165) No space found before comment text; expected "// set_config('userfield', 'profile_' . $field->id, 'mod_certifygen');" but found "//set_config('userfield', 'profile_' . $field->id, 'mod_certifygen');"; (#350) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#351) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#352) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#479) This comment is 48% valid code; is this commented out code?; (#480) Inline comments must end in full-stops, exclamation marks, or question marks; (#480) No space found before comment text; expected "// self::getDataGenerator()->enrol_user($student->id, $course1->id, 'student');" but found "//self::getDataGenerator()->enrol_user($student->id, $course1->id, 'student');"
public/mod/certifygen/validation/webservice/tests/get_draft_teacher_certificate_external_test.php: (#60) Unit test get_draft_teacher_certificate_external_test should be declared as final.; (#64) The setUp() method in unit tests must always call to parent::setUp().
public/mod/certifygen/validation/webservice/tests/start_student_certificate_external_test.php: (#60) Unit test start_student_certificate_external_test should be declared as final.; (#64) The setUp() method in unit tests must always call to parent::setUp().; (#165) This comment is 42% valid code; is this commented out code?; (#166) Inline comments must end in full-stops, exclamation marks, or question marks; (#166) No space found before comment text; expected "// set_config('userfield', 'profile_' . $field->id, 'mod_certifygen');" but found "//set_config('userfield', 'profile_' . $field->id, 'mod_certifygen');"
public/mod/certifygen/validation/webservice/tests/start_teacher_certificate_external_test.php: (#59) Unit test start_teacher_certificate_external_test should be declared as final.; (#63) The setUp() method in unit tests must always call to parent::setUp().; (#248) Multi-line function call not indented correctly; expected 12 spaces but found 16; (#347) Multi-line function call not indented correctly; expected 12 spaces but found 16
public/mod/certifygen/version.php: (#37) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(4 errors, 57 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

public/mod/certifygen/amd/src/activitymanager.js: (#18) Trailing spaces not allowed. (no-trailing-spaces); (#59) Unexpected space before function parentheses. (space-before-function-paren); (#79) Avoid nesting promises. (promise/no-nesting); (#97) Expected to return a value at the end of function. (consistent-return); (#104) Avoid nesting promises. (promise/no-nesting); (#108) Too many nested callbacks (6). Maximum allowed is 5. (max-nested-callbacks); (#108) Each then() should return a value or throw (promise/always-return); (#109) Too many nested callbacks (7). Maximum allowed is 5. (max-nested-callbacks); (#293) Comments should not begin with a lowercase character. (capitalized-comments); (#293) Expected space or tab after '//' in comment. (spaced-comment); (#302) Each then() should return a value or throw (promise/always-return)
public/mod/certifygen/amd/src/modelcreate.js: (#18) Trailing spaces not allowed. (no-trailing-spaces); (#35) Extra space after key 'GET_LIST_TABLE'. (key-spacing); (#50) Unexpected space before function parentheses. (space-before-function-paren); (#60) Unexpected space before function parentheses. (space-before-function-paren); (#66) Multiple spaces found before 'typeElement'. (no-multi-spaces); (#71) Unexpected space before function parentheses. (space-before-function-paren); (#120) Unexpected space before function parentheses. (space-before-function-paren); (#127) Unexpected space before function parentheses. (space-before-function-paren); (#128) Each then() should return a value or throw (promise/always-return); (#137) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
public/mod/certifygen/amd/src/modelmanagement.js: (#18) Trailing spaces not allowed. (no-trailing-spaces); (#88) Expected catch,fail,always() or return (promise/catch-or-return); (#88) Each then() should return a value or throw (promise/always-return); (#120) Unexpected space before function parentheses. (space-before-function-paren); (#127) Unexpected space before function parentheses. (space-before-function-paren); (#128) Each then() should return a value or throw (promise/always-return); (#145) Avoid nesting promises. (promise/no-nesting); (#160) Expected to return a value at the end of function. (consistent-return); (#160) Unexpected space before function parentheses. (space-before-function-paren); (#166) Avoid nesting promises. (promise/no-nesting); (#170) Each then() should return a value or throw (promise/always-return); (#172) Too many nested callbacks (6). Maximum allowed is 5. (max-nested-callbacks); (#181) Unexpected space before function parentheses. (space-before-function-paren); (#186) A function with a name starting with an uppercase letter should only be used as a constructor. (@babel/new-cap)
public/mod/certifygen/amd/src/requestmanagement.js: (#18) Trailing spaces not allowed. (no-trailing-spaces); (#109) Unexpected space before function parentheses. (space-before-function-paren); (#123) Avoid nesting promises. (promise/no-nesting); (#141) Expected to return a value at the end of function. (consistent-return); (#148) Avoid nesting promises. (promise/no-nesting); (#152) Too many nested callbacks (6). Maximum allowed is 5. (max-nested-callbacks); (#152) Each then() should return a value or throw (promise/always-return); (#153) Too many nested callbacks (7). Maximum allowed is 5. (max-nested-callbacks); (#170) Unexpected space before function parentheses. (space-before-function-paren); (#184) Avoid nesting promises. (promise/no-nesting); (#202) Expected to return a value at the end of function. (consistent-return); (#209) Avoid nesting promises. (promise/no-nesting); (#213) Too many nested callbacks (6). Maximum allowed is 5. (max-nested-callbacks); (#213) Each then() should return a value or throw (promise/always-return); (#214) Too many nested callbacks (7). Maximum allowed is 5. (max-nested-callbacks); (#231) Unexpected space before function parentheses. (space-before-function-paren); (#250) Each then() should return a value or throw (promise/always-return); (#269) Avoid nesting promises. (promise/no-nesting); (#281) There should be no space after '{'. (@babel/object-curly-spacing); (#283) Expected to return a value at the end of function. (consistent-return); (#290) Avoid nesting promises. (promise/no-nesting); (#294) Too many nested callbacks (6). Maximum allowed is 5. (max-nested-callbacks); (#294) Each then() should return a value or throw (promise/always-return); (#296) Too many nested callbacks (7). Maximum allowed is 5. (max-nested-callbacks); (#300) Too many nested callbacks (7). Maximum allowed is 5. (max-nested-callbacks); (#349) Each then() should return a value or throw (promise/always-return)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

PHPDocs style problems

(57 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

public/mod/certifygen/classes/certifygen.php: (#334) Phpdocs for function certifygen::get_issues_for_course_by_lang has incomplete parameters list; (#719) Phpdocs for function certifygen::can_be_issued has incomplete parameters list; (#780) Phpdocs for function certifygen::send_notification has incomplete parameters list
public/mod/certifygen/classes/certifygen_file.php: (#68) Phpdocs for function certifygen_file::__construct has incomplete parameters list
public/mod/certifygen/classes/event/certificate_downloaded.php: (#75) Phpdocs for function certificate_downloaded::create_from_validation has incomplete parameters list
public/mod/certifygen/classes/event/certificate_issued.php: (#73) Phpdocs for function certificate_issued::create_from_validation has incomplete parameters list
public/mod/certifygen/classes/external/get_json_teacher_certificate_external.php: (#77) Phpdocs for function get_json_teacher_certificate_external::get_json_teacher_certificate has incomplete parameters list
public/mod/certifygen/classes/filters/certifygenfilter.php: (#57) Phpdocs for function certifygenfilter::__construct has incomplete parameters list; (#69) Phpdocs for function certifygenfilter::filter has incomplete parameters list
public/mod/certifygen/classes/forms/modelform.php: (#333) Phpdocs for function modelform::validation has incomplete parameters list
public/mod/certifygen/classes/forms/teacherrequestform.php: (#187) Phpdocs for function teacherrequestform::validation has incomplete parameters list
public/mod/certifygen/classes/output/views/activity_view.php: (#112) Phpdocs for function activity_view::export_for_template has incomplete parameters list
public/mod/certifygen/classes/plugininfo/certifygenreport.php: (#82) Phpdocs for function certifygenreport::load_settings has incomplete parameters list
public/mod/certifygen/classes/plugininfo/certifygenrepository.php: (#68) Phpdocs for function certifygenrepository::load_settings has incomplete parameters list
public/mod/certifygen/classes/plugininfo/certifygenvalidation.php: (#82) Phpdocs for function certifygenvalidation::load_settings has incomplete parameters list
public/mod/certifygen/classes/tables/activityteacher_table.php: (#166) Phpdocs for function activityteacher_table::col_revoke has incomplete parameters list; (#204) Phpdocs for function activityteacher_table::col_status has incomplete parameters list; (#228) Phpdocs for function activityteacher_table::col_dateissued has incomplete parameters list; (#243) Phpdocs for function activityteacher_table::col_download has incomplete parameters list; (#264) Phpdocs for function activityteacher_table::col_emit has incomplete parameters list
public/mod/certifygen/classes/tables/modellist_table.php: (#97) Phpdocs for function modellist_table::col_type has incomplete parameters list; (#108) Phpdocs for function modellist_table::col_modelname has incomplete parameters list; (#125) Phpdocs for function modellist_table::col_template has incomplete parameters list; (#142) Phpdocs for function modellist_table::col_lastupdate has incomplete parameters list; (#151) Phpdocs for function modellist_table::col_deletemodel has incomplete parameters list; (#163) Phpdocs for function modellist_table::col_editmodel has incomplete parameters list; (#174) Phpdocs for function modellist_table::col_associatecontexts has incomplete parameters list
public/mod/certifygen/classes/tables/showerrors_table.php: (#114) Phpdocs for function showerrors_table::col_user has incomplete parameters list; (#139) Phpdocs for function showerrors_table::col_download has incomplete parameters list; (#179) Phpdocs for function showerrors_table::col_type has incomplete parameters list; (#188) Phpdocs for function showerrors_table::col_validation has incomplete parameters list; (#197) Phpdocs for function showerrors_table::col_report has incomplete parameters list; (#209) Phpdocs for function showerrors_table::col_repository has incomplete parameters list; (#222) Phpdocs for function showerrors_table::col_name has incomplete parameters list; (#234) Phpdocs for function showerrors_table::col_status has incomplete parameters list; (#244) Phpdocs for function showerrors_table::col_message has incomplete parameters list; (#252) Phpdocs for function showerrors_table::col_model has incomplete parameters list; (#260) Phpdocs for function showerrors_table::col_validationid has incomplete parameters list; (#268) Phpdocs for function showerrors_table::col_timecreated has incomplete parameters list
public/mod/certifygen/classes/template.php: (#250) Phpdocs for function template::issue_certificate has incomplete parameters list
public/mod/certifygen/lib.php: (#102) Phpdocs for function certifygen_update_instance has incomplete parameters list; (#308) Phpdocs for function mod_certifygen_myprofile_navigation has incomplete parameters list; (#337) Phpdocs for function mod_certifygen_pluginfile has incomplete parameters list
public/mod/certifygen/mod_form.php: (#134) Phpdocs for function mod_certifygen_mod_form::completion_rule_enabled has incomplete parameters list; (#143) Phpdocs for function mod_certifygen_mod_form::data_preprocessing has incomplete parameters list
public/mod/certifygen/report/basic/classes/certifygenpdf.php: (#53) Phpdocs for function certifygenpdf::set_footer_text has incomplete parameters list
public/mod/certifygen/report/basic/lib.php: (#34) Phpdocs for function certifygenreport_basic_pluginfile has incomplete parameters list
public/mod/certifygen/repository/csv/classes/certifygenrepository_csv.php: (#135) Phpdocs for function certifygenrepository_csv::get_file_content has incomplete parameters list
public/mod/certifygen/repository/localrepository/classes/certifygenrepository_localrepository.php: (#182) Phpdocs for function certifygenrepository_localrepository::get_file_content has incomplete parameters list
public/mod/certifygen/repository/onedrive/classes/onedriveconnection.php: (#116) Phpdocs for function onedriveconnection::upload_file has incomplete parameters list; (#205) Phpdocs for function onedriveconnection::set_file_sharing_anyone_with_link_can_read has incomplete parameters list; (#333) Phpdocs for function onedriveconnection::delete_file_by_path has incomplete parameters list; (#371) Phpdocs for function onedriveconnection::get_file has incomplete parameters list
public/mod/certifygen/repository/url/classes/certifygenrepository_url.php: (#148) Phpdocs for function certifygenrepository_url::get_file_content has incomplete parameters list
public/mod/certifygen/validation/csv/classes/certifygenvalidation_csv.php: (#350) Phpdocs for function certifygenvalidation_csv::get_file_url_from_external_service has incomplete parameters list; (#433) Phpdocs for function certifygenvalidation_csv::create_file_from_content has incomplete parameters list
public/mod/certifygen/validation/webservice/classes/external/change_status_external.php: (#80) Phpdocs for function change_status_external::change_status has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(4 errors, 5 warnings)

This section shows problems detected in mustache templates [More info]

public/mod/certifygen/report/basic/templates/report.mustache: (#1) HTML Validation error, line 3: Bad value “” for attribute “src” on element “img”: Must be non-empty. ( <img src="" alt="((+configurated_logo%2C+mod_certifygen+))" width="100" height="100"/> ); (#1) HTML Validation info, line 3: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ( <img src="" alt="((+configurated_logo%2C+mod_certifygen+))" width="100" height="100"/> ); (#1) HTML Validation error, line 10: Element “style” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) ( </div><style> )
public/mod/certifygen/templates/activity.mustache: (#1) HTML Validation error, line 12: Element “style” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (</div><style> ); (#1) ESLint did not run
public/mod/certifygen/templates/associatemodelcontexts.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
public/mod/certifygen/templates/course_list_request.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
public/mod/certifygen/templates/form_category_selector_suggestion.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
public/mod/certifygen/templates/model_list.mustache: (#1) HTML Validation error, line 11: Element “style” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (></div><style> [); (#1) HTML Validation error, line 18: CSS: Parse Error. ( } }</st); (#1) ESLint did not run
public/mod/certifygen/templates/model_list_table.mustache: (#1) ESLint did not run
public/mod/certifygen/templates/profile_my_certificates.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]