PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(0 errors, 59 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- mod/bigbluebuttonbn/backup/moodle2/backup_bigbluebuttonbn_stepslib.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/backup/moodle2/restore_bigbluebuttonbn_stepslib.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/bbb_broker.php
- (#27) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- mod/bigbluebuttonbn/brokerlib.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/analytics/indicator/activity_base.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/analytics/indicator/cognitive_depth.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/analytics/indicator/social_breadth.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/activity_viewed.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/base.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/bigbluebuttonbn_activity_management_viewed.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/live_session_event.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/meeting_created.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/meeting_ended.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/meeting_joined.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/meeting_left.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/recording_deleted.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/recording_edited.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/recording_imported.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/recording_protected.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/recording_published.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/recording_unprotected.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/recording_unpublished.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/event/recording_viewed.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/output/renderer.php
- (#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/plugin.php
- (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/privacy/provider.php
- (#68) Duplicate interface name "mod_bigbluebuttonbn\privacy\core_userlist_provider" found; first defined in /var/lib/jenkins/git_repositories/prechecker/mod/bigbluebuttonbn/classes/privacy/provider.php on line 52
- (#100) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility
- (#137) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility
- (#172) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility
- (#181) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility
- (#197) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility
- (#218) Method name "_export_user_data_bigbliebuttonbn_logs" should not be prefixed with an underscore to indicate visibility
- mod/bigbluebuttonbn/classes/search/activity.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/classes/search/tags.php
- (#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/config-dist.php
- (#491) This comment is 44% valid code; is this commented out code?
- mod/bigbluebuttonbn/db/uninstall.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/lib.php
- (#525) This comment is 43% valid code; is this commented out code?
- mod/bigbluebuttonbn/tests/generator/behat_mod_bigbluebuttonbn_generator.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- mod/bigbluebuttonbn/tests/lib_test.php
- (#39) PHPUnit testcase name "mod_bigbluebuttonbn_lib_test" does not match file name "lib_test"
- (#39) PHPUnit class "mod_bigbluebuttonbn_lib_test" does not have any namespace. It is recommended to add it to the "mod_bigbluebuttonbn" namespace, using more levels if needed, in order to match the code being tested
- (#498) This comment is 50% valid code; is this commented out code?
- (#549) This comment is 75% valid code; is this commented out code?
- (#759) This comment is 71% valid code; is this commented out code?
- (#912) Line exceeds 132 characters; contains 149 characters
- mod/bigbluebuttonbn/tests/locallib_test.php
- (#39) PHPUnit testcase name "mod_bigbluebuttonbn_locallib_test" does not match file name "locallib_test"
- (#39) PHPUnit class "mod_bigbluebuttonbn_locallib_test" does not have any namespace. It is recommended to add it to the "mod_bigbluebuttonbn" namespace, using more levels if needed, in order to match the code being tested
- mod/bigbluebuttonbn/tests/privacy_provider_test.php
- (#51) PHPUnit testcase name "mod_bigbluebuttonbn_privacy_provider_testcase" does not match file name "privacy_provider_test"
- (#51) PHPUnit class "mod_bigbluebuttonbn_privacy_provider_testcase" does not have any namespace. It is recommended to add it to the "mod_bigbluebuttonbn" namespace, using more levels if needed, in order to match the code being tested
- (#70) Test method test_get_metadata() is missing any coverage information, own or at class level
- (#108) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
- (#136) Test method test_export_for_context_logs() is missing any coverage information, own or at class level
- (#167) Test method test_get_users_in_context() is missing any coverage information, own or at class level
- (#205) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
- (#228) Test method test_delete_data_for_user() is missing any coverage information, own or at class level
- (#255) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
- mod/bigbluebuttonbn/tests/recordings_test.php
- (#40) PHPUnit testcase name "mod_bigbluebuttonbn_recordings_test" does not match file name "recordings_test"
- (#40) PHPUnit class "mod_bigbluebuttonbn_recordings_test" does not have any namespace. It is recommended to add it to the "mod_bigbluebuttonbn" namespace, using more levels if needed, in order to match the code being tested
- (#73) This comment is 50% valid code; is this commented out code?
- mod/bigbluebuttonbn/viewlib.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
Javascript coding style problems
(0 errors, 22 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
- mod/bigbluebuttonbn/mobile.notification.js
- (#31) Unexpected space before function parentheses. (space-before-function-paren)
- (#35) Unexpected space before function parentheses. (space-before-function-paren)
- mod/bigbluebuttonbn/yui/src/broker/js/broker.js
- (#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
- mod/bigbluebuttonbn/yui/src/imports/js/imports.js
- (#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
- mod/bigbluebuttonbn/yui/src/modform/js/modform.js
- (#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
- mod/bigbluebuttonbn/yui/src/recordings/js/helpers.js
- (#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
- (#176) ["import"] is better written in dot notation. (dot-notation)
- (#177) ["delete"] is better written in dot notation. (dot-notation)
- (#189) ["import"] is better written in dot notation. (dot-notation)
- (#190) ["delete"] is better written in dot notation. (dot-notation)
- (#202) ["import"] is better written in dot notation. (dot-notation)
- (#203) ["delete"] is better written in dot notation. (dot-notation)
- mod/bigbluebuttonbn/yui/src/recordings/js/recordings.js
- (#21) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
- (#48) Unexpected space before function parentheses. (space-before-function-paren)
- (#110) There should be no space after this paren. (space-in-parens)
- (#110) Unnecessary escape character: \-. (no-useless-escape)
- (#110) Unnecessary escape character: \[. (no-useless-escape)
- (#110) Unnecessary escape character: \^. (no-useless-escape)
- (#110) There should be no space before this paren. (space-in-parens)
- (#135) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
- (#191) Unexpected space before function parentheses. (space-before-function-paren)
- mod/bigbluebuttonbn/yui/src/rooms/js/rooms.js
- (#20) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
CSS problems
(0 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
PHPDocs style problems
(1 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- mod/bigbluebuttonbn/tests/behat/behat_mod_bigbluebuttonbn.php
- (#43) Invalid phpdocs tag @BeforeScenario used
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
Missing changes in external functions or backup support for new detected tables or columns
(0 errors, 2 warnings)
This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]
- mod/bigbluebuttonbn/db/upgrade.php
- Database modifications (new tables or columns) detected in the patch without any change to some important areas.
- No changes detected to external functions, that may affect apps and other web service integrations, please verify!
grunt changes
(0 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 6 warnings)
This section shows problems detected in mustache templates [More info]
- mod/bigbluebuttonbn/templates/mobile_view_notification.mustache
- (#1) HTML Validation info, line 21: Attribute “[params]” is not serializable as XML 1.0. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
- (#1) HTML Validation info, line 21: Attribute “(onsuccess)” is not serializable as XML 1.0. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
- (#1) HTML Validation error, line 21: Attribute “core-site-plugins-call-ws-on-load” not allowed on element “span” at this point. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
- (#1) HTML Validation error, line 21: Attribute “name” not allowed on element “span” at this point. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
- (#1) HTML Validation error, line 21: Attribute “[params]” not allowed on element “span” at this point. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
- (#1) HTML Validation error, line 21: Attribute “(onsuccess)” not allowed on element “span” at this point. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]