PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(0 errors, 111 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/bigbluebuttonbn/backup/moodle2/backup_bigbluebuttonbn_stepslib.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/backup/moodle2/restore_bigbluebuttonbn_stepslib.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/bbb_broker.php: (#27) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
mod/bigbluebuttonbn/brokerlib.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/analytics/indicator/activity_base.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/analytics/indicator/cognitive_depth.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/analytics/indicator/social_breadth.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/activity_viewed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/base.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/bigbluebuttonbn_activity_management_viewed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/live_session_event.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/meeting_created.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/meeting_ended.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/meeting_joined.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/meeting_left.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/recording_deleted.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/recording_edited.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/recording_imported.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/recording_protected.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/recording_published.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/recording_unprotected.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/recording_unpublished.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/event/recording_viewed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/output/renderer.php: (#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/plugin.php: (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/privacy/provider.php: (#68) Duplicate interface name "mod_bigbluebuttonbn\privacy\core_userlist_provider" found; first defined in /var/lib/jenkins/git_repositories/prechecker/mod/bigbluebuttonbn/classes/privacy/provider.php on line 52; (#100) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility; (#137) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility; (#172) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility; (#181) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility; (#197) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility; (#218) Method name "_export_user_data_bigbliebuttonbn_logs" should not be prefixed with an underscore to indicate visibility
mod/bigbluebuttonbn/classes/search/activity.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/classes/search/tags.php: (#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/config-dist.php: (#491) This comment is 44% valid code; is this commented out code?
mod/bigbluebuttonbn/db/uninstall.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/lib.php: (#525) This comment is 43% valid code; is this commented out code?
mod/bigbluebuttonbn/tests/generator/behat_mod_bigbluebuttonbn_generator.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
mod/bigbluebuttonbn/tests/lib_test.php: (#39) PHPUnit testcase name "mod_bigbluebuttonbn_lib_testcase" does not match file name "lib_test"; (#39) PHPUnit class "mod_bigbluebuttonbn_lib_testcase" does not have any namespace. It is recommended to add it to the "mod_bigbluebuttonbn" namespace, using more levels if needed, in order to match the code being tested; (#120) Test method test_bigbluebuttonbn_supports() is missing any coverage information, own or at class level; (#127) Test method test_bigbluebuttonbn_get_completion_state() is missing any coverage information, own or at class level; (#148) Test method test_bigbluebuttonbn_add_instance() is missing any coverage information, own or at class level; (#156) Test method test_bigbluebuttonbn_update_instance() is missing any coverage information, own or at class level; (#164) Test method test_bigbluebuttonbn_delete_instance() is missing any coverage information, own or at class level; (#171) Test method test_bigbluebuttonbn_delete_instance_log() is missing any coverage information, own or at class level; (#180) Test method test_bigbluebuttonbn_user_outline() is missing any coverage information, own or at class level; (#201) Test method test_bigbluebuttonbn_user_complete() is missing any coverage information, own or at class level; (#214) Test method test_bigbluebuttonbn_get_extra_capabilities() is missing any coverage information, own or at class level; (#219) Test method test_bigbluebuttonbn_reset_course_items() is missing any coverage information, own or at class level; (#230) Test method test_bigbluebuttonbn_reset_course_form_definition() is missing any coverage information, own or at class level; (#253) Test method test_bigbluebuttonbn_reset_course_form_defaults() is missing any coverage information, own or at class level; (#265) Test method test_bigbluebuttonbn_reset_userdata() is missing any coverage information, own or at class level; (#282) Test method test_bigbluebuttonbn_reset_getstatus() is missing any coverage information, own or at class level; (#292) Test method test_bigbluebuttonbn_reset_events() is missing any coverage information, own or at class level; (#311) Test method test_bigbluebuttonbn_reset_tags() is missing any coverage information, own or at class level; (#325) Test method test_bigbluebuttonbn_reset_logs() is missing any coverage information, own or at class level; (#344) Test method test_bigbluebuttonbn_reset_recordings() is missing any coverage information, own or at class level; (#352) Test method test_bigbluebuttonbn_get_view_actions() is missing any coverage information, own or at class level; (#357) Test method test_bigbluebuttonbn_get_post_actions() is missing any coverage information, own or at class level; (#362) Test method test_bigbluebuttonbn_print_overview() is missing any coverage information, own or at class level; (#385) Test method test_bigbluebuttonbn_print_overview_element() is missing any coverage information, own or at class level; (#389) This comment is 50% valid code; is this commented out code?; (#400) Test method test_bigbluebuttonbn_get_coursemodule_info() is missing any coverage information, own or at class level; (#407) Test method test_mod_bigbluebuttonbn_get_completion_active_rule_descriptions() is missing any coverage information, own or at class level; (#430) This comment is 75% valid code; is this commented out code?; (#440) Test method test_bigbluebuttonbn_process_pre_save() is missing any coverage information, own or at class level; (#451) Test method test_bigbluebuttonbn_process_pre_save_instance() is missing any coverage information, own or at class level; (#461) Test method test_bigbluebuttonbn_process_pre_save_checkboxes() is missing any coverage information, own or at class level; (#472) Test method test_bigbluebuttonbn_process_pre_save_common() is missing any coverage information, own or at class level; (#486) Test method test_bigbluebuttonbn_process_post_save() is missing any coverage information, own or at class level; (#510) Test method test_bigbluebuttonbn_process_post_save_notification() is missing any coverage information, own or at class level; (#532) Test method test_bigbluebuttonbn_process_post_save_event() is missing any coverage information, own or at class level; (#543) Test method test_bigbluebuttonbn_process_post_save_completion() is missing any coverage information, own or at class level; (#554) Test method test_bigbluebuttonbn_get_media_file() is missing any coverage information, own or at class level; (#584) Test method test_bigbluebuttonbn_pluginfile() is missing any coverage information, own or at class level; (#590) This comment is 71% valid code; is this commented out code?; (#597) Test method test_bigbluebuttonbn_pluginfile_valid() is missing any coverage information, own or at class level; (#604) Test method test_bigbluebuttonbn_pluginfile_file() is missing any coverage information, own or at class level; (#635) Test method test_bigbluebuttonbn_default_presentation_get_file() is missing any coverage information, own or at class level; (#651) Test method test_bigbluebuttonbn_pluginfile_filename() is missing any coverage information, own or at class level; (#665) Test method test_bigbluebuttonbn_get_file_areas() is missing any coverage information, own or at class level; (#673) Test method test_bigbluebuttonbn_view() is missing any coverage information, own or at class level; (#703) Test method test_bigbluebuttonbn_check_updates_since() is missing any coverage information, own or at class level; (#708) Line exceeds 132 characters; contains 149 characters; (#713) Test method test_mod_bigbluebuttonbn_get_fontawesome_icon_map() is missing any coverage information, own or at class level; (#719) Test method test_mod_bigbluebuttonbn_core_calendar_provide_event_action() is missing any coverage information, own or at class level; (#765) Test method test_bigbluebuttonbn_log() is missing any coverage information, own or at class level; (#773) Test method test_bigbluebuttonbn_extend_settings_navigation_admin() is missing any coverage information, own or at class level; (#790) Test method test_bigbluebuttonbn_extend_settings_navigation_user() is missing any coverage information, own or at class level
mod/bigbluebuttonbn/tests/locallib_test.php: (#39) PHPUnit testcase name "mod_bigbluebuttonbn_locallib_testcase" does not match file name "locallib_test"; (#39) PHPUnit class "mod_bigbluebuttonbn_locallib_testcase" does not have any namespace. It is recommended to add it to the "mod_bigbluebuttonbn" namespace, using more levels if needed, in order to match the code being tested; (#54) Test method test_bigbluebuttonbn_get_recording_type_text() is missing any coverage information, own or at class level; (#63) Test method test_bigbluebuttonbn_get_users_select_ordered() is missing any coverage information, own or at class level; (#94) Test method test_bigbluebuttonbn_get_users_select_separate_groups_prevent_all() is missing any coverage information, own or at class level; (#125) Test method test_bigbluebuttonbn_get_users_select_separate_groups() is missing any coverage information, own or at class level; (#147) Test method test_bigbluebuttonbn_get_role() is missing any coverage information, own or at class level
mod/bigbluebuttonbn/tests/privacy_provider_test.php: (#51) PHPUnit testcase name "mod_bigbluebuttonbn_privacy_provider_testcase" does not match file name "privacy_provider_test"; (#51) PHPUnit class "mod_bigbluebuttonbn_privacy_provider_testcase" does not have any namespace. It is recommended to add it to the "mod_bigbluebuttonbn" namespace, using more levels if needed, in order to match the code being tested; (#70) Test method test_get_metadata() is missing any coverage information, own or at class level; (#108) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level; (#136) Test method test_export_for_context_logs() is missing any coverage information, own or at class level; (#167) Test method test_get_users_in_context() is missing any coverage information, own or at class level; (#205) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level; (#228) Test method test_delete_data_for_user() is missing any coverage information, own or at class level; (#255) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
mod/bigbluebuttonbn/tests/recordings_test.php: (#40) PHPUnit testcase name "mod_bigbluebuttonbn_recordings_testcase" does not match file name "recordings_test"; (#40) PHPUnit class "mod_bigbluebuttonbn_recordings_testcase" does not have any namespace. It is recommended to add it to the "mod_bigbluebuttonbn" namespace, using more levels if needed, in order to match the code being tested; (#73) This comment is 50% valid code; is this commented out code?; (#105) Test method test_bigbluebuttonbn_get_allrecordings() is missing any coverage information, own or at class level
mod/bigbluebuttonbn/viewlib.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.

Javascript coding style problems

(0 errors, 22 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/bigbluebuttonbn/mobile.notification.js: (#31) Unexpected space before function parentheses. (space-before-function-paren); (#35) Unexpected space before function parentheses. (space-before-function-paren)
mod/bigbluebuttonbn/yui/src/broker/js/broker.js: (#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
mod/bigbluebuttonbn/yui/src/imports/js/imports.js: (#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
mod/bigbluebuttonbn/yui/src/modform/js/modform.js: (#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
mod/bigbluebuttonbn/yui/src/recordings/js/helpers.js: (#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase); (#176) ["import"] is better written in dot notation. (dot-notation); (#177) ["delete"] is better written in dot notation. (dot-notation); (#189) ["import"] is better written in dot notation. (dot-notation); (#190) ["delete"] is better written in dot notation. (dot-notation); (#202) ["import"] is better written in dot notation. (dot-notation); (#203) ["delete"] is better written in dot notation. (dot-notation)
mod/bigbluebuttonbn/yui/src/recordings/js/recordings.js: (#21) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase); (#48) Unexpected space before function parentheses. (space-before-function-paren); (#110) There should be no space after this paren. (space-in-parens); (#110) Unnecessary escape character: \-. (no-useless-escape); (#110) Unnecessary escape character: \[. (no-useless-escape); (#110) Unnecessary escape character: \^. (no-useless-escape); (#110) There should be no space before this paren. (space-in-parens); (#135) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap); (#191) Unexpected space before function parentheses. (space-before-function-paren)
mod/bigbluebuttonbn/yui/src/rooms/js/rooms.js: (#20) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

PHPDocs style problems

(2 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/bigbluebuttonbn/classes/locallib/bigbluebutton.php: (#300) Phpdocs for function bigbluebutton::user_can_access_groups has incomplete parameters list
mod/bigbluebuttonbn/tests/behat/behat_mod_bigbluebuttonbn.php: (#43) Invalid phpdocs tag @BeforeScenario used

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 2 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

mod/bigbluebuttonbn/db/upgrade.php: Database modifications (new tables or columns) detected in the patch without any change to some important areas.; No changes detected to external functions, that may affect apps and other web service integrations, please verify!

grunt changes

(5 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-broker/moodle-mod_bigbluebuttonbn-broker-min.js: Uncommitted change detected.
mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-imports/moodle-mod_bigbluebuttonbn-imports-min.js: Uncommitted change detected.
mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-modform/moodle-mod_bigbluebuttonbn-modform-min.js: Uncommitted change detected.
mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-recordings/moodle-mod_bigbluebuttonbn-recordings-min.js: Uncommitted change detected.
mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-rooms/moodle-mod_bigbluebuttonbn-rooms-min.js: Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 6 warnings)

This section shows problems detected in mustache templates [More info]

mod/bigbluebuttonbn/templates/mobile_view_notification.mustache: (#1) HTML Validation info, line 21: Attribute “[params]” is not serializable as XML 1.0. (> </span); (#1) HTML Validation info, line 21: Attribute “(onsuccess)” is not serializable as XML 1.0. (> </span); (#1) HTML Validation error, line 21: Attribute “core-site-plugins-call-ws-on-load” not allowed on element “span” at this point. (> </span); (#1) HTML Validation error, line 21: Attribute “name” not allowed on element “span” at this point. (> </span); (#1) HTML Validation error, line 21: Attribute “[params]” not allowed on element “span” at this point. (> </span); (#1) HTML Validation error, line 21: Attribute “(onsuccess)” not allowed on element “span” at this point. (> </span)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]