Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 39 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/bigbluebuttonbn/bbb_broker.php
(#27) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
mod/bigbluebuttonbn/bbb_view.php
(#47) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#67) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#72) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#76) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#108) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#156) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#187) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#192) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#196) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#203) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#207) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#211) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#459) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/bigbluebuttonbn/classes/output/index.php
(#129) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#133) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/bigbluebuttonbn/classes/privacy/provider.php
(#68) Duplicate interface name "mod_bigbluebuttonbn\privacy\core_userlist_provider" found; first defined in /var/lib/jenkins/git_repositories/prechecker/mod/bigbluebuttonbn/classes/privacy/provider.php on line 52
(#100) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility
(#137) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility
(#172) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility
(#181) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility
(#197) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility
(#218) Method name "_export_user_data_bigbliebuttonbn_logs" should not be prefixed with an underscore to indicate visibility
mod/bigbluebuttonbn/config-dist.php
(#521) This comment is 44% valid code; is this commented out code?
mod/bigbluebuttonbn/import_view.php
(#37) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#47) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#51) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/bigbluebuttonbn/index.php
(#40) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#58) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/bigbluebuttonbn/lib.php
(#525) This comment is 43% valid code; is this commented out code?
mod/bigbluebuttonbn/mod_form.php
(#52) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#82) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
mod/bigbluebuttonbn/tests/lib_test.php
(#389) This comment is 50% valid code; is this commented out code?
(#430) This comment is 75% valid code; is this commented out code?
(#590) This comment is 71% valid code; is this commented out code?
(#708) Line exceeds 132 characters; contains 149 characters
mod/bigbluebuttonbn/tests/recordings_test.php
(#73) This comment is 50% valid code; is this commented out code?
mod/bigbluebuttonbn/view.php
(#40) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#73) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead

Javascript coding style problems

(0 errors, 22 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

mod/bigbluebuttonbn/mobile.notification.js
(#31) Unexpected space before function parentheses. (space-before-function-paren)
(#35) Unexpected space before function parentheses. (space-before-function-paren)
mod/bigbluebuttonbn/yui/src/broker/js/broker.js
(#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
mod/bigbluebuttonbn/yui/src/imports/js/imports.js
(#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
mod/bigbluebuttonbn/yui/src/modform/js/modform.js
(#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
mod/bigbluebuttonbn/yui/src/recordings/js/helpers.js
(#19) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
(#176) ["import"] is better written in dot notation. (dot-notation)
(#177) ["delete"] is better written in dot notation. (dot-notation)
(#189) ["import"] is better written in dot notation. (dot-notation)
(#190) ["delete"] is better written in dot notation. (dot-notation)
(#202) ["import"] is better written in dot notation. (dot-notation)
(#203) ["delete"] is better written in dot notation. (dot-notation)
mod/bigbluebuttonbn/yui/src/recordings/js/recordings.js
(#21) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)
(#47) Unexpected space before function parentheses. (space-before-function-paren)
(#109) There should be no space after this paren. (space-in-parens)
(#109) Unnecessary escape character: \-. (no-useless-escape)
(#109) Unnecessary escape character: \[. (no-useless-escape)
(#109) Unnecessary escape character: \^. (no-useless-escape)
(#109) There should be no space before this paren. (space-in-parens)
(#134) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#190) Unexpected space before function parentheses. (space-before-function-paren)
mod/bigbluebuttonbn/yui/src/rooms/js/rooms.js
(#20) Identifier 'mod_bigbluebuttonbn' is not in camel case. (camelcase)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(1 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/bigbluebuttonbn/classes/locallib/bigbluebutton.php
(#298) Phpdocs for function bigbluebutton::user_can_access_groups has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(5 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-broker/moodle-mod_bigbluebuttonbn-broker-min.js
Uncommitted change detected.
mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-imports/moodle-mod_bigbluebuttonbn-imports-min.js
Uncommitted change detected.
mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-modform/moodle-mod_bigbluebuttonbn-modform-min.js
Uncommitted change detected.
mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-recordings/moodle-mod_bigbluebuttonbn-recordings-min.js
Uncommitted change detected.
mod/bigbluebuttonbn/yui/build/moodle-mod_bigbluebuttonbn-rooms/moodle-mod_bigbluebuttonbn-rooms-min.js
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 6 warnings)

This section shows problems detected in mustache templates [More info]

mod/bigbluebuttonbn/templates/mobile_view_notification.mustache
(#1) HTML Validation info, line 17: Attribute “[params]” is not serializable as XML 1.0. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
(#1) HTML Validation info, line 17: Attribute “(onsuccess)” is not serializable as XML 1.0. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
(#1) HTML Validation error, line 17: Attribute “core-site-plugins-call-ws-on-load” not allowed on element “span” at this point. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
(#1) HTML Validation error, line 17: Attribute “name” not allowed on element “span” at this point. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
(#1) HTML Validation error, line 17: Attribute “[params]” not allowed on element “span” at this point. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)
(#1) HTML Validation error, line 17: Attribute “(onsuccess)” not allowed on element “span” at this point. (> <span core-site-plugins-call-ws-on-load name="mod_bigbluebuttonbn_can_join" [params]="{cmid: 3}" (onSuccess)="onCanJoinReturns($event)"></span)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]