Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(177 errors, 93 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

mod/advurl/backup/moodle2/backup_advurl_activity_task.class.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#3) Line 2 of the opening comment must start "//".
(#8) Line 7 of the opening comment must start "//".
(#13) Line 12 of the opening comment must start "//".
(#37) Opening brace must not be followed by a blank line
(#60) The static declaration must come after the visibility declaration
mod/advurl/backup/moodle2/backup_advurl_stepslib.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#3) Line 2 of the opening comment must start "//".
(#8) Line 7 of the opening comment must start "//".
(#13) Line 12 of the opening comment must start "//".
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) Opening brace must not be followed by a blank line
(#47) Short array syntax must be used to define arrays
(#47) Short array syntax must be used to define arrays
(#48) Whitespace found at end of line
(#52) Short array syntax must be used to define arrays
(#64) Short array syntax must be used to define arrays
(#64) Short array syntax must be used to define arrays
(#65) Whitespace found at end of line
(#71) Short array syntax must be used to define arrays
mod/advurl/classes/event/course_module_instance_list_viewed.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#3) Line 2 of the opening comment must start "//".
(#8) Line 7 of the opening comment must start "//".
(#13) Line 12 of the opening comment must start "//".
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#36) Opening brace must not be followed by a blank line
mod/advurl/classes/event/course_module_viewed.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#3) Line 2 of the opening comment must start "//".
(#8) Line 7 of the opening comment must start "//".
(#13) Line 12 of the opening comment must start "//".
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#36) Opening brace must not be followed by a blank line
mod/advurl/classes/privacy/provider.php
(#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) Expected 4 spaces before interface name; 8 found
(#39) Expected 4 spaces before interface name; 8 found
(#39) Opening brace must not be followed by a blank line
(#47) There must not be a space before the colon in a return type declaration
(#62) There must not be a space before the colon in a return type declaration
(#128) Expected 1 newline at end of file; 0 found
mod/advurl/dashboard.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#3) Line 2 of the opening comment must start "//".
(#8) Line 7 of the opening comment must start "//".
(#13) Line 12 of the opening comment must start "//".
(#26) Expected at least 1 space before "."; 0 found
(#26) Expected at least 1 space after "."; 0 found
(#41) Inline comments must end in full-stops, exclamation marks, or question marks
(#44) Whitespace found at end of line
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Whitespace found at end of line
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#58) Inline comments must end in full-stops, exclamation marks, or question marks
(#65) Whitespace found at end of line
(#70) Inline comments must end in full-stops, exclamation marks, or question marks
(#76) Whitespace found at end of line
(#81) Whitespace found at end of line
(#95) Whitespace found at end of line
(#103) Inline comments must end in full-stops, exclamation marks, or question marks
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
(#117) Inline comments must end in full-stops, exclamation marks, or question marks
(#123) Inline comments must end in full-stops, exclamation marks, or question marks
(#127) Inline comments must end in full-stops, exclamation marks, or question marks
(#134) There should be a comma after the last array item in a multi-line array.
(#143) Inline comments must end in full-stops, exclamation marks, or question marks
(#146) There should be a comma after the last array item in a multi-line array.
(#153) Inline comments must end in full-stops, exclamation marks, or question marks
(#157) Inline comments must end in full-stops, exclamation marks, or question marks
(#158) Whitespace found at end of line within string
(#159) Whitespace found at end of line within string
(#160) Whitespace found at end of line within string
(#161) Whitespace found at end of line within string
(#162) Whitespace found at end of line within string
(#163) Whitespace found at end of line within string
(#164) Whitespace found at end of line within string
(#170) Inline comments must end in full-stops, exclamation marks, or question marks
(#178) There should be a comma after the last array item in a multi-line array.
(#184) Inline comments must end in full-stops, exclamation marks, or question marks
(#203) Inline comments must end in full-stops, exclamation marks, or question marks
(#210) There should be a comma after the last array item in a multi-line array.
(#216) There should be a comma after the last array item in a multi-line array.
(#218) Whitespace found at end of line
(#219) Opening parenthesis of a multi-line function call must be the last content on the line
(#219) Only one argument is allowed per line in a multi-line function call
(#219) Whitespace found at end of line
(#220) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#220) Closing parenthesis of a multi-line function call must be on a line by itself
(#221) Opening parenthesis of a multi-line function call must be the last content on the line
(#221) Only one argument is allowed per line in a multi-line function call
(#221) Whitespace found at end of line
(#222) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#222) Closing parenthesis of a multi-line function call must be on a line by itself
(#228) There should be a comma after the last array item in a multi-line array.
(#230) Opening parenthesis of a multi-line function call must be the last content on the line
(#230) Only one argument is allowed per line in a multi-line function call
(#230) Whitespace found at end of line
(#231) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#231) Closing parenthesis of a multi-line function call must be on a line by itself
(#240) There should be a comma after the last array item in a multi-line array.
mod/advurl/db/access.php
(#71) Expected 1 newline at end of file; 0 found
mod/advurl/db/upgrade.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#83) Inline comments must end in full-stops, exclamation marks, or question marks
(#88) Whitespace found at end of line
(#89) Inline comments must end in full-stops, exclamation marks, or question marks
(#90) Short array syntax must be used to define arrays
(#91) Short array syntax must be used to define arrays
(#91) Short array syntax must be used to define arrays
(#92) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) Whitespace found at end of line
(#103) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Whitespace found at end of line
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
(#110) Short array syntax must be used to define arrays
(#111) Short array syntax must be used to define arrays
(#111) Short array syntax must be used to define arrays
(#112) Inline comments must end in full-stops, exclamation marks, or question marks
(#113) Whitespace found at end of line
(#211) Expected 1 newline at end of file; 0 found
mod/advurl/index.php
(#26) Expected at least 1 space before "."; 0 found
(#26) Expected at least 1 space after "."; 0 found
(#36) There should be a comma after the last array item in a multi-line array.
(#52) Whitespace found at end of line
(#65) Opening parenthesis of a multi-line function call must be the last content on the line
(#66) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#66) Closing parenthesis of a multi-line function call must be on a line by itself
(#71) Expected 1 newline at end of file; 0 found
mod/advurl/lang/en/advurl.php
(#17) Missing @copyright tag
(#27) The string key "modulename" is not in the correct order, it should be before "pluginname"
(#29) The string key "advurl:addinstance" is not in the correct order, it should be before "modulenameplural"
(#31) The string key "advurl:reportbroken" is not in the correct order, it should be before "advurl:view"
(#36) Unexpected comment found. Auto-fixing will not work after this comment
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#39) The string key "leavewarning" is not in the correct order, it should be before "showleave_help"
(#41) The string key "continue" is not in the correct order, it should be before "leavewarning_desc"
(#44) The string key "brokenlinkdialog" is not in the correct order, it should be before "reportthankyou"
(#48) Unexpected comment found. Auto-fixing will not work after this comment
(#48) Inline comments must end in full-stops, exclamation marks, or question marks
(#53) The string key "openinnewtab" is not in the correct order, it should be before "privacy:metadata:advurl_reports:status"
(#54) Unexpected comment found. Auto-fixing will not work after this comment
(#55) Unexpected comment found. Auto-fixing will not work after this comment
(#56) Unexpected comment found. Auto-fixing will not work after this comment
(#56) Inline comments must end in full-stops, exclamation marks, or question marks
(#58) Unexpected comment found. Auto-fixing will not work after this comment
(#59) The string key "advurlcopyright" is not in the correct order, it should be before "openinnewtab"
(#61) Unexpected comment found. Auto-fixing will not work after this comment
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#68) The string key "invalidemail" is not in the correct order, it should be before "settingssaved"
(#70) Unexpected comment found. Auto-fixing will not work after this comment
(#70) Inline comments must end in full-stops, exclamation marks, or question marks
(#71) The string key "externalurl_required" is not in the correct order, it should be before "invalidemail"
(#73) Unexpected comment found. Auto-fixing will not work after this comment
(#73) Inline comments must end in full-stops, exclamation marks, or question marks
(#76) The string key "activity" is not in the correct order, it should be before "reports_help"
(#78) The string key "reportedby" is not in the correct order, it should be before "reportedurl"
(#79) The string key "reportdate" is not in the correct order, it should be before "reportedby"
(#81) The string key "actions" is not in the correct order, it should be before "status"
(#84) The string key "status_false_positive" is not in the correct order, it should be before "status_resolved"
(#85) The string key "mark_resolved" is not in the correct order, it should be before "status_false_positive"
(#86) The string key "mark_false_positive" is not in the correct order, it should be before "mark_resolved"
(#88) The string key "no_reports" is not in the correct order, it should be before "reopen_report"
(#90) The string key "confirm_status_change" is not in the correct order, it should be before "status_updated"
(#92) Unexpected comment found. Auto-fixing will not work after this comment
(#92) Inline comments must end in full-stops, exclamation marks, or question marks
(#97) Unexpected string end, it should be a line feed after a semicolon
(#97) Expected 1 newline at end of file; 0 found
mod/advurl/lib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#29) Inline doc block comments are not allowed; use "// Comment." instead
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#38) Missing docblock for function advurl_add_instance
(#43) Missing docblock for function mod_advurl_add_instance
(#53) Inline doc block comments are not allowed; use "// Comment." instead
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#62) Missing docblock for function advurl_update_instance
(#67) Missing docblock for function mod_advurl_update_instance
(#76) Inline doc block comments are not allowed; use "// Comment." instead
(#82) Inline comments must end in full-stops, exclamation marks, or question marks
(#84) Missing docblock for function advurl_delete_instance
(#89) Missing docblock for function mod_advurl_delete_instance
(#101) Inline doc block comments are not allowed; use "// Comment." instead
(#108) Inline comments must end in full-stops, exclamation marks, or question marks
(#110) Missing docblock for function advurl_get_coursemodule_info
(#115) Missing docblock for function mod_advurl_get_coursemodule_info
(#134) Inline doc block comments are not allowed; use "// Comment." instead
(#140) Inline comments must end in full-stops, exclamation marks, or question marks
(#142) Missing docblock for function advurl_supports
(#147) Missing docblock for function mod_advurl_supports
(#190) Whitespace found at end of line
(#191) Inline comments must end in full-stops, exclamation marks, or question marks
(#205) Inline comments must end in full-stops, exclamation marks, or question marks
(#218) There should be a comma after the last array item in a multi-line array.
(#220) Whitespace found at end of line
(#226) There should be a comma after the last array item in a multi-line array.
(#230) Whitespace found at end of line
(#241) Variable "video_id" must not contain underscores.
(#242) Inline comments must end in full-stops, exclamation marks, or question marks
(#243) Variable "embed_url" must not contain underscores.
(#243) Variable "video_id" must not contain underscores.
(#244) Variable "title_attr" must not contain underscores.
(#245) Whitespace found at end of line
(#246) Inline comments must end in full-stops, exclamation marks, or question marks
(#250) The use of backticks in strings is not recommended
(#278) The use of backticks in strings is not recommended
(#281) Whitespace found at end of line
(#284) Variable "embed_url" must not contain underscores.
(#291) There should be a comma after the last array item in a multi-line array.
(#295) Expected 1 newline at end of file; 0 found
mod/advurl/mod_form.php
(#27) Expected at least 1 space before "."; 0 found
(#27) Expected at least 1 space after "."; 0 found
(#29) Missing docblock for class mod_advurl_mod_form
(#29) Opening brace must not be followed by a blank line
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#90) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) Inline comments must end in full-stops, exclamation marks, or question marks
(#112) Expected 1 newline at end of file; 0 found
mod/advurl/report.php
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) Variable "email_sent" must not contain underscores.
(#57) Inline comments must end in full-stops, exclamation marks, or question marks
(#76) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) Variable "email_sent" must not contain underscores.
(#100) Expected 1 newline at end of file; 0 found
mod/advurl/restore/moodle2/restore_advurl_activity_task.class.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#3) Line 2 of the opening comment must start "//".
(#8) Line 7 of the opening comment must start "//".
(#13) Line 12 of the opening comment must start "//".
(#37) Opening brace must not be followed by a blank line
(#58) The static declaration must come after the visibility declaration
(#59) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#70) The static declaration must come after the visibility declaration
(#71) Short array syntax must be used to define arrays
(#85) The static declaration must come after the visibility declaration
(#86) Short array syntax must be used to define arrays
(#101) The static declaration must come after the visibility declaration
(#102) Short array syntax must be used to define arrays
mod/advurl/restore/moodle2/restore_advurl_stepslib.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#3) Line 2 of the opening comment must start "//".
(#8) Line 7 of the opening comment must start "//".
(#13) Line 12 of the opening comment must start "//".
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) Opening brace must not be followed by a blank line
(#43) Short array syntax must be used to define arrays
(#47) Whitespace found at end of line
mod/advurl/version.php
(#36) Expected 1 newline at end of file; 0 found
mod/advurl/view.php
(#26) Expected at least 1 space before "."; 0 found
(#26) Expected at least 1 space after "."; 0 found
(#51) There should be a comma after the last array item in a multi-line array.
(#76) Inline comments must end in full-stops, exclamation marks, or question marks
(#77) Variable "youtube_info" must not contain underscores.
(#78) Variable "is_youtube_embedded" must not contain underscores.
(#81) Variable "youtube_info" must not contain underscores.
(#82) Variable "youtube_info" must not contain underscores.
(#83) Variable "is_youtube_embedded" must not contain underscores.
(#89) Inline comments must end in full-stops, exclamation marks, or question marks
(#91) Whitespace found at end of line
(#92) Variable "is_youtube_embedded" must not contain underscores.
(#93) Inline comments must end in full-stops, exclamation marks, or question marks
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
(#102) Inline comments must end in full-stops, exclamation marks, or question marks
(#105) Inline comments must end in full-stops, exclamation marks, or question marks
(#111) There should be a comma after the last array item in a multi-line array.
(#115) Inline comments must end in full-stops, exclamation marks, or question marks
(#116) Line indented incorrectly; expected 0 spaces, found 12
(#121) There should be a comma after the last array item in a multi-line array.
(#124) Line indented incorrectly; expected 0 spaces, found 12
(#128) Inline comments must end in full-stops, exclamation marks, or question marks
(#129) Variable "is_youtube_embedded" must not contain underscores.
(#130) Inline comments must end in full-stops, exclamation marks, or question marks
(#132) Variable "youtube_info" must not contain underscores.
(#134) Empty ELSE statement detected
(#136) Inline comments must end in full-stops, exclamation marks, or question marks
(#143) Expected 1 newline at end of file; 0 found

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(7 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

mod/advurl/classes/privacy/provider.php
(#104) Phpdocs for function provider::delete_data_for_all_users_in_context has incomplete parameters list
mod/advurl/lib.php
(#171) Phpdocs for function mod_advurl_pluginfile has incomplete parameters list
(#184) Phpdocs for function mod_advurl_extend_navigation_course has incomplete parameters list
mod/advurl/restore/moodle2/restore_advurl_activity_task.class.php
(#81) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#83) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#97) Inline phpdocs tag {@link restore_logs_processor} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#99) Inline phpdocs tag {@link restore_log_rule} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]