Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(102 errors, 16 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

message/output/appcrue/classes/privacy/provider.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#41) There must not be a space before the colon in a return type declaration
message/output/appcrue/classes/task/sendbuffered.php
(#48) There must be a blank line following the last trait import statement
(#71) Opening parenthesis of a multi-line function call must be the last content on the line
(#72) Multi-line function call not indented correctly; expected 12 spaces but found 24
(#73) Multi-line function call not indented correctly; expected 12 spaces but found 24
(#73) Only one argument is allowed per line in a multi-line function call
(#74) Multi-line function call not indented correctly; expected 8 spaces but found 24
(#74) Only one argument is allowed per line in a multi-line function call
(#74) Closing parenthesis of a multi-line function call must be on a line by itself
(#100) Space after opening parenthesis of function call prohibited
(#149) Closing brace must not be followed by any comment or statement on the same line
message/output/appcrue/classes/twinpush_client.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#32) Missing docblock for class twinpush_client
(#34) There must be a blank line following the last trait import statement
(#63) Incorrect spacing between argument "$url" and equals sign; expected 1 but found 0
(#63) Incorrect spacing between default value and equals sign for argument "$url"; expected 1 but found 0
(#68) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#85) Short array syntax must be used to define arrays
(#88) There should be a comma after the last array item in a multi-line array.
(#91) Opening parenthesis of a multi-line function call must be the last content on the line
(#93) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#93) Closing parenthesis of a multi-line function call must be on a line by itself
(#124) Expected at least 1 space before "."; 0 found
(#124) Space found before comma in argument list
(#124) Expected no space between "$response" and the comma. Found: 1 space
(#131) No one-line description found in phpdocs for docblock of function trim_alert_text
(#139) Missing docblock for function log_no_ajax
message/output/appcrue/db/install.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
message/output/appcrue/db/tasks.php
(#43) There should be a comma after the last array item in a multi-line array.
message/output/appcrue/db/upgrade.php
(#61) Blank line found at start of control structure
message/output/appcrue/lang/en/message_appcrue.php
(#30) The string key "api_key" is not in the correct order, it should be before "pluginname"
(#40) The string key "match_user_by" is not in the correct order, it should be before "only_news_forum_help"
(#43) The string key "preserveundeliverable" is not in the correct order, it should be before "privacy:metadata"
(#45) The string key "enable_push" is not in the correct order, it should be before "preserveundeliverable_help"
(#47) The string key "url_pattern" is not in the correct order, it should be before "url_pattern_help"
(#48) The string key "sendbufferedtask" is not in the correct order, it should be before "url_pattern"
message/output/appcrue/message_output_appcrue.php
(#32) Expected at least 1 space before "."; 0 found
(#32) Expected at least 1 space after "."; 0 found
(#39) There must be a blank line following the last trait import statement
(#49) Member variable "apiClient" must be all lower-case
(#69) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#71) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#75) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#76) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#138) Blank line found at end of control structure
(#163) This comment is 45% valid code; is this commented out code?
(#165) Expected 1 space before comment text but found 5; use block comment if you need indentation
(#166) Inline comments must end in full-stops, exclamation marks, or question marks
(#244) Incorrect spacing between argument "$url" and equals sign; expected 1 but found 0
(#244) Incorrect spacing between default value and equals sign for argument "$url"; expected 1 but found 0
(#253) Expected 1 space after FUNCTION keyword; 0 found
(#287) Incorrect spacing between argument "$url" and equals sign; expected 1 but found 0
(#287) Incorrect spacing between default value and equals sign for argument "$url"; expected 1 but found 0
(#309) Expected at least 1 space before "."; 0 found
(#309) Expected at least 1 space after "."; 0 found
(#314) Expected at least 1 space before "."; 0 found
(#314) Expected at least 1 space after "."; 0 found
(#314) Expected at least 1 space before "."; 0 found
(#314) Expected at least 1 space after "."; 0 found
(#315) Opening parenthesis of a multi-line function call must be the last content on the line
(#317) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#317) Closing parenthesis of a multi-line function call must be on a line by itself
(#333) Expected at least 1 space before "."; 0 found
(#333) Space found before comma in argument list
(#333) Expected no space between "$response" and the comma. Found: 1 space
(#417) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#420) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#420) Blank line found at start of control structure
(#444) Expected 0 spaces after opening bracket; 1 found
(#444) Expected 0 spaces before closing bracket; 1 found
message/output/appcrue/settings.php
(#45) Inline doc block comments are not allowed; use "// Comment." instead
(#50) Only one argument is allowed per line in a multi-line function call
(#54) Opening parenthesis of a multi-line function call must be the last content on the line
(#54) Only one argument is allowed per line in a multi-line function call
(#55) Multi-line function call not indented correctly; expected 4 spaces but found 48
(#55) Only one argument is allowed per line in a multi-line function call
(#55) Only one argument is allowed per line in a multi-line function call
(#55) Closing parenthesis of a multi-line function call must be on a line by itself
(#56) Opening parenthesis of a multi-line function call must be the last content on the line
(#56) Only one argument is allowed per line in a multi-line function call
(#57) Multi-line function call not indented correctly; expected 4 spaces but found 48
(#57) Only one argument is allowed per line in a multi-line function call
(#57) Only one argument is allowed per line in a multi-line function call
(#57) Closing parenthesis of a multi-line function call must be on a line by itself
(#58) Opening parenthesis of a multi-line function call must be the last content on the line
(#58) Only one argument is allowed per line in a multi-line function call
(#59) Multi-line function call not indented correctly; expected 4 spaces but found 48
(#59) Only one argument is allowed per line in a multi-line function call
(#59) Only one argument is allowed per line in a multi-line function call
(#59) Closing parenthesis of a multi-line function call must be on a line by itself
(#60) Opening parenthesis of a multi-line function call must be the last content on the line
(#61) Multi-line function call not indented correctly; expected 8 spaces but found 48
(#62) Multi-line function call not indented correctly; expected 4 spaces but found 48
(#62) Only one argument is allowed per line in a multi-line function call
(#62) Closing parenthesis of a multi-line function call must be on a line by itself
(#73) Opening parenthesis of a multi-line function call must be the last content on the line
(#73) Only one argument is allowed per line in a multi-line function call
(#74) Only one argument is allowed per line in a multi-line function call
(#74) Only one argument is allowed per line in a multi-line function call
(#74) Only one argument is allowed per line in a multi-line function call
(#74) Closing parenthesis of a multi-line function call must be on a line by itself
(#79) Only one argument is allowed per line in a multi-line function call
(#85) Only one argument is allowed per line in a multi-line function call
message/output/appcrue/tests/send_message_test.php
(#34) PHPUnit class "message_appcrue\tests\send_message_test", with namespace "message_appcrue\tests", currently located at "tests/" directory, does not match its expected location at "tests/tests"
(#41) Unit test send_message_test should be declared as final.
(#41) Opening brace must not be followed by a blank line
(#43) The first trait import statement must be declared on the first non-comment line after the class opening brace
(#43) There must be a blank line following the last trait import statement
(#44) Missing member variable doc comment
(#45) Missing member variable doc comment
(#55) Whitespace found at end of line
(#56) Inline comments must end in full-stops, exclamation marks, or question marks
(#59) Whitespace found at end of line
(#68) Data provider method "launched_provider" not found.
(#73) Test method test_send_instant_message_to_single_user() is missing any coverage information, own or at class level
(#73) Test method test_send_instant_message_to_single_user() is missing a return type
(#87) Functions must not contain multiple empty lines in a row; found 2 empty lines

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(5 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

message/output/appcrue/classes/twinpush_client.php
(#47) Phpdocs for function twinpush_client::__construct has incomplete parameters list
(#130) Phpdocs for function twinpush_client::trim_alert_text has incomplete parameters list
message/output/appcrue/message_output_appcrue.php
(#174) Phpdocs for function message_output_appcrue::get_target_url has incomplete parameters list
(#193) Phpdocs for function message_output_appcrue::buffer_message has incomplete parameters list
(#352) Phpdocs for function message_output_appcrue::get_nick_name has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]