Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(44 errors, 110 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

admin/tool/log/store/lanalytics/classes/devices.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) Inline comments must end in full-stops, exclamation marks, or question marks
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#73) Whitespace found at end of line
(#78) Variable "user_agent" must not contain underscores.
(#80) Variable "browser_array" must not contain underscores.
(#91) Variable "browser_array" must not contain underscores.
(#92) Variable "user_agent" must not contain underscores.
(#102) Variable "user_agent" must not contain underscores.
(#104) Variable "os_array" must not contain underscores.
(#124) Variable "os_platform" must not contain underscores.
(#125) Variable "os_array" must not contain underscores.
(#126) Variable "user_agent" must not contain underscores.
(#127) Variable "os_platform" must not contain underscores.
(#132) Variable "os_platform" must not contain underscores.
(#141) Public method name "devices::browserIdToString" must be in lower-case letters only
(#149) Public method name "devices::osIdToString" must be in lower-case letters only
(#156) File must end with a newline character
admin/tool/log/store/lanalytics/classes/log/store.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#42) Inline comments must start with a capital letter, digit or 3-dots sequence
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
(#60) Inline comments must start with a capital letter, digit or 3-dots sequence
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#68) Inline comments must start with a capital letter, digit or 3-dots sequence
(#68) Inline comments must end in full-stops, exclamation marks, or question marks
(#69) Variable "GLOBALS" must be all lower-case
(#70) Inline comments must start with a capital letter, digit or 3-dots sequence
(#70) This comment is 53% valid code; is this commented out code?
(#71) Line exceeds 132 characters; contains 138 characters
(#71) Inline comments must start with a capital letter, digit or 3-dots sequence
(#71) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) Inline comments must start with a capital letter, digit or 3-dots sequence
(#93) This comment is 72% valid code; is this commented out code?
(#120) Variable "eventsToTrack" must be all lower-case
(#122) Inline comments must start with a capital letter, digit or 3-dots sequence
(#122) Inline comments must end in full-stops, exclamation marks, or question marks
(#130) Inline comments must start with a capital letter, digit or 3-dots sequence
(#133) Line exceeds 132 characters; contains 135 characters
(#133) Inline comments must start with a capital letter, digit or 3-dots sequence
(#133) Inline comments must end in full-stops, exclamation marks, or question marks
(#138) Inline comments must start with a capital letter, digit or 3-dots sequence
(#138) Inline comments must end in full-stops, exclamation marks, or question marks
(#141) Inline comments must start with a capital letter, digit or 3-dots sequence
(#141) Inline comments must end in full-stops, exclamation marks, or question marks
(#145) Inline comments must start with a capital letter, digit or 3-dots sequence
(#145) Inline comments must end in full-stops, exclamation marks, or question marks
(#149) Inline comments must start with a capital letter, digit or 3-dots sequence
(#149) Inline comments must end in full-stops, exclamation marks, or question marks
(#158) Inline comments must start with a capital letter, digit or 3-dots sequence
(#158) Inline comments must end in full-stops, exclamation marks, or question marks
(#166) Variable "eventsToTrack" must be all lower-case
(#188) Inline comments must end in full-stops, exclamation marks, or question marks
(#195) Variable "loggerClass" must be all lower-case
(#196) Variable "loggerClass" must be all lower-case
(#196) Variable "eventsToTrack" must be all lower-case
admin/tool/log/store/lanalytics/classes/privacy/provider.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/log/store/lanalytics/classes/task/cleanup_task.php
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
admin/tool/log/store/lanalytics/cli/apply.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#3) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#15) The use of backticks in strings is not recommended
(#17) Whitespace found at end of line within string
(#43) Inline comments must start with a capital letter, digit or 3-dots sequence
(#65) Inline comments must start with a capital letter, digit or 3-dots sequence
(#65) Inline comments must end in full-stops, exclamation marks, or question marks
(#80) Inline comments must start with a capital letter, digit or 3-dots sequence
(#80) Inline comments must end in full-stops, exclamation marks, or question marks
(#88) Whitespace found at end of line
(#96) Variable "loggersCount" must be all lower-case
(#97) Variable "loggersCount" must be all lower-case
admin/tool/log/store/lanalytics/cli/import.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#3) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#16) The use of backticks in strings is not recommended
(#20) The use of backticks in strings is not recommended
(#22) The use of backticks in strings is not recommended
(#54) Inline comments must start with a capital letter, digit or 3-dots sequence
(#86) Inline comments must start with a capital letter, digit or 3-dots sequence
(#86) Inline comments must end in full-stops, exclamation marks, or question marks
(#96) Inline comments must start with a capital letter, digit or 3-dots sequence
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
(#106) Whitespace found at end of line
(#107) Inline comments must start with a capital letter, digit or 3-dots sequence
(#107) Inline comments must end in full-stops, exclamation marks, or question marks
(#114) Whitespace found at end of line
(#142) The use of backticks in strings is not recommended
admin/tool/log/store/lanalytics/cli/test-devices.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#4) Inline comments must end in full-stops, exclamation marks, or question marks
(#8) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#15) Inline comments must start with a capital letter, digit or 3-dots sequence
(#15) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) Line exceeds 132 characters; contains 166 characters
(#37) Line exceeds 132 characters; contains 157 characters
(#38) Line exceeds 132 characters; contains 169 characters
(#44) Line exceeds 132 characters; contains 148 characters
(#45) Line exceeds 132 characters; contains 143 characters
(#46) Line exceeds 132 characters; contains 148 characters
(#47) Line exceeds 132 characters; contains 136 characters
(#48) Line exceeds 132 characters; contains 149 characters
(#49) Line exceeds 132 characters; contains 149 characters
(#50) Line exceeds 132 characters; contains 133 characters
(#51) Line exceeds 132 characters; contains 168 characters
(#52) Line exceeds 132 characters; contains 159 characters
(#53) Line exceeds 132 characters; contains 166 characters
(#54) Line exceeds 132 characters; contains 142 characters
(#55) Line exceeds 132 characters; contains 152 characters
(#56) Line exceeds 132 characters; contains 151 characters
(#57) Line exceeds 132 characters; contains 156 characters
(#59) Line exceeds 132 characters; contains 151 characters
(#60) Line exceeds 132 characters; contains 146 characters
(#61) Line exceeds 132 characters; contains 161 characters
(#62) Line exceeds 132 characters; contains 161 characters
(#63) Line exceeds 132 characters; contains 152 characters
(#64) Line exceeds 132 characters; contains 172 characters
(#66) Line exceeds 132 characters; contains 160 characters
(#67) Line exceeds 132 characters; contains 162 characters
(#68) Line exceeds 132 characters; contains 163 characters
(#69) Line exceeds 132 characters; contains 165 characters
(#70) Line exceeds 132 characters; contains 167 characters
(#71) Line exceeds 132 characters; contains 169 characters
(#72) Line exceeds 132 characters; contains 172 characters
(#73) Line exceeds 132 characters; contains 179 characters
(#74) Inline comments must end in full-stops, exclamation marks, or question marks
(#74) Line exceeds maximum limit of 180 characters; contains 216 characters
(#76) Line exceeds 132 characters; contains 165 characters
(#77) Line exceeds 132 characters; contains 159 characters
(#78) Line exceeds 132 characters; contains 164 characters
(#80) Line exceeds 132 characters; contains 165 characters
(#81) Line exceeds 132 characters; contains 149 characters
(#82) Line exceeds 132 characters; contains 164 characters
(#83) Line exceeds 132 characters; contains 165 characters
(#84) Line exceeds 132 characters; contains 165 characters
(#85) Line exceeds 132 characters; contains 162 characters
(#90) Variable "VERBOSE" must be all lower-case
(#102) Whitespace found at end of line
(#111) Variable "VERBOSE" must be all lower-case
admin/tool/log/store/lanalytics/db/tasks.php
(#37) File must end with a newline character
admin/tool/log/store/lanalytics/db/upgrade.php
(#28) Spaces must be used to indent lines; tabs are not allowed
(#28) Tab found within whitespace
(#28) Line indented incorrectly; expected at least 4 spaces, found 1
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
admin/tool/log/store/lanalytics/lang/en/logstore_lanalytics.php
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) File must end with a newline character
admin/tool/log/store/lanalytics/settings.php
(#32) Inline comments must start with a capital letter, digit or 3-dots sequence
(#32) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) Inline comments must start with a capital letter, digit or 3-dots sequence
(#55) Inline comments must end in full-stops, exclamation marks, or question marks
(#63) Inline comments must start with a capital letter, digit or 3-dots sequence
(#63) Inline comments must end in full-stops, exclamation marks, or question marks
admin/tool/log/store/lanalytics/version.php
(#33) File must end with a newline character

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(42 errors, 3 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

admin/tool/log/store/lanalytics/classes/devices.php
(#40) Class devices is not documented
(#77) Function devices::get_browser is not documented
(#101) Function devices::get_os is not documented
(#135) Function devices::get_device is not documented
(#141) Function devices::browserIdToString is not documented
(#149) Function devices::osIdToString is not documented
(#36) Constant OS_MULTIPLIER is not documented
(#41) Constant devices::BROWSER is not documented
(#55) Constant devices::OS is not documented
admin/tool/log/store/lanalytics/classes/log/store.php
(#39) Class store is not documented
(#44) Function store::__construct is not documented
(#48) Function store::is_event_ignored is not documented
(#59) Function store::write is not documented
(#89) Function store::insert_event_entries is not documented
(#37) Constant MOODLE_API is not documented
admin/tool/log/store/lanalytics/classes/privacy/provider.php
(#29) Class provider is not documented
(#30) Function provider::get_reason is not documented
(#17) No one-line description found in phpdocs for file
admin/tool/log/store/lanalytics/classes/task/cleanup_task.php
(#20) Package local_learning_analytics is not valid
(#31) Class cleanup_task is not documented
admin/tool/log/store/lanalytics/cli/apply.php
(#51) Package is not specified for function load_lalog_plugins. It is also not specified in file-level phpdocs
(#66) Package is not specified for function check_for_rows. It is also not specified in file-level phpdocs
(#72) Package is not specified for function log_rows. It is also not specified in file-level phpdocs
(#77) Package is not specified for function apply_events. It is also not specified in file-level phpdocs
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
(#51) Function load_lalog_plugins is not documented
(#66) Function check_for_rows is not documented
(#72) Function log_rows is not documented
(#77) Function apply_events is not documented
admin/tool/log/store/lanalytics/cli/import.php
(#81) Package is not specified for function truncate_logs. It is also not specified in file-level phpdocs
(#87) Package is not specified for function check_for_rows. It is also not specified in file-level phpdocs
(#93) Package is not specified for function identify_events. It is also not specified in file-level phpdocs
(#112) Package is not specified for function copy_rows. It is also not specified in file-level phpdocs
(#133) Package is not specified for function log_rows. It is also not specified in file-level phpdocs
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
(#81) Function truncate_logs is not documented
(#87) Function check_for_rows is not documented
(#93) Function identify_events is not documented
(#112) Function copy_rows is not documented
(#133) Function log_rows is not documented
admin/tool/log/store/lanalytics/cli/test-devices.php
(#2) Empty line found after PHP open tag
(#6) File-level phpdocs block is not found
admin/tool/log/store/lanalytics/db/upgrade.php
(#25) Function xmldb_logstore_lanalytics_upgrade is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 3 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

admin/tool/log/store/lanalytics/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!
No changes detected to backup and restore, that may affect storage and transportability, please verify!

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]