Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(67 errors, 97 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/wswizard/ajax.php
(#21) Incorrect @package tag for file ajax.php. Expected local_wswizard, found local **.
(#23) Docblock tag "@name" is not recommended.
(#47) Short array syntax must be used to define arrays
(#51) Short array syntax must be used to define arrays
(#54) Short array syntax must be used to define arrays
(#58) There should be a comma after the last array item in a multi-line array.
(#71) Short array syntax must be used to define arrays
(#74) Short array syntax must be used to define arrays
(#78) There should be a comma after the last array item in a multi-line array.
(#90) Short array syntax must be used to define arrays
(#91) Short array syntax must be used to define arrays
(#92) Short array syntax must be used to define arrays
(#93) Short array syntax must be used to define arrays
(#96) Short array syntax must be used to define arrays
(#100) There should be a comma after the last array item in a multi-line array.
(#107) Short array syntax must be used to define arrays
(#111) There should be a comma after the last array item in a multi-line array.
(#120) Short array syntax must be used to define arrays
(#132) Short array syntax must be used to define arrays
(#136) There should be a comma after the last array item in a multi-line array.
(#147) Short array syntax must be used to define arrays
(#160) Short array syntax must be used to define arrays
(#164) There should be a comma after the last array item in a multi-line array.
(#175) Short array syntax must be used to define arrays
(#186) Short array syntax must be used to define arrays
(#190) There should be a comma after the last array item in a multi-line array.
local/wswizard/classes/Base.php
(#21) Incorrect @package tag for file Base.php. Expected local_wswizard, found local_wswizard **.
(#22) Docblock tag "@name" is not recommended.
(#38) Missing docblock for class Base
(#49) Docblock tag "@global" is not recommended.
(#50) Docblock tag "@global" is not recommended.
(#51) Docblock tag "@global" is not recommended.
(#52) Docblock tag "@global" is not recommended.
(#76) Short array syntax must be used to define arrays
(#92) Short array syntax must be used to define arrays
(#93) Short array syntax must be used to define arrays
(#184) Short array syntax must be used to define arrays
(#188) Short array syntax must be used to define arrays
(#192) Short array syntax must be used to define arrays
(#205) Short array syntax must be used to define arrays
local/wswizard/classes/Logs.php
(#21) Incorrect @package tag for file Logs.php. Expected local_wswizard, found local_wswizard **.
(#22) Docblock tag "@name" is not recommended.
(#68) Docblock tag "@global" is not recommended.
(#76) Short array syntax must be used to define arrays
(#82) Short array syntax must be used to define arrays
(#92) Docblock tag "@global" is not recommended.
local/wswizard/classes/forms/add_functions_to_webservice_form.php
(#21) Incorrect @package tag for file add_functions_to_webservice_form.php. Expected local_wswizard, found local_wswizard **.
(#22) Docblock tag "@name" is not recommended.
(#42) Missing docblock for function definition
(#51) Short array syntax must be used to define arrays
(#92) Short array syntax must be used to define arrays
(#158) Short array syntax must be used to define arrays
(#174) Short array syntax must be used to define arrays
(#182) Expected 1 space after "="; 2 found
(#219) Short array syntax must be used to define arrays
(#251) Short array syntax must be used to define arrays
(#262) Short array syntax must be used to define arrays
(#266) There should be a comma after the last array item in a multi-line array.
local/wswizard/classes/forms/add_token_to_webservice_form.php
(#21) Incorrect @package tag for file add_token_to_webservice_form.php. Expected local_wswizard, found local_wswizard **.
(#22) Docblock tag "@name" is not recommended.
(#55) Short array syntax must be used to define arrays
(#57) Expected 1 space after "=>"; 2 found
(#104) Short array syntax must be used to define arrays
(#142) Short array syntax must be used to define arrays
(#145) Short array syntax must be used to define arrays
(#150) There should be a comma after the last array item in a multi-line array.
(#173) Short array syntax must be used to define arrays
(#209) Short array syntax must be used to define arrays
local/wswizard/classes/forms/ws_form.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#20) Incorrect @package tag for file ws_form.php. Expected local_wswizard, found local_wswizard **.
(#21) Docblock tag "@name" is not recommended.
(#81) Short array syntax must be used to define arrays
(#95) Short array syntax must be used to define arrays
(#97) Expected 1 space after "=>"; 2 found
(#127) Short array syntax must be used to define arrays
(#141) Short array syntax must be used to define arrays
(#143) Short array syntax must be used to define arrays
(#184) Short array syntax must be used to define arrays
(#203) Short array syntax must be used to define arrays
(#207) Short array syntax must be used to define arrays
(#211) Short array syntax must be used to define arrays
local/wswizard/classes/privacy/provider.php
(#21) Incorrect @package tag for file provider.php. Expected local_wswizard, found local **.
(#23) Docblock tag "@name" is not recommended.
(#42) Missing docblock for interface my_userlist
(#45) Duplicate interface name "local_wswizard\privacy\my_userlist" found; first defined in /var/lib/jenkins/git_repositories/prechecker/local/wswizard/classes/privacy/provider.php on line 42
(#45) Missing docblock for interface my_userlist
(#49) Missing docblock for class provider
(#52) Missing docblock for function get_metadata
(#59) There should be a comma after the last array item in a multi-line array.
local/wswizard/classes/task/archive_logs.php
(#21) Incorrect @package tag for file archive_logs.php. Expected local_wswizard, found local **.
(#23) Docblock tag "@name" is not recommended.
(#38) Missing docblock for class archive_logs
local/wswizard/classes/web_service_data.php
(#21) Incorrect @package tag for file web_service_data.php. Expected local_wswizard, found local_wswizard **.
(#22) Docblock tag "@name" is not recommended.
(#83) There should be a comma after the last array item in a multi-line array.
(#88) Short array syntax must be used to define arrays
(#92) There should be a comma after the last array item in a multi-line array.
(#112) Short array syntax must be used to define arrays
(#139) Short array syntax must be used to define arrays
(#143) There should be a comma after the last array item in a multi-line array.
(#180) Short array syntax must be used to define arrays
(#184) There should be a comma after the last array item in a multi-line array.
(#224) Short array syntax must be used to define arrays
(#228) There should be a comma after the last array item in a multi-line array.
(#236) Short array syntax must be used to define arrays
(#240) There should be a comma after the last array item in a multi-line array.
(#280) There should be a comma after the last array item in a multi-line array.
(#284) There should be a comma after the last array item in a multi-line array.
(#288) Short array syntax must be used to define arrays
(#292) There should be a comma after the last array item in a multi-line array.
(#323) There should be a comma after the last array item in a multi-line array.
(#329) There should be a comma after the last array item in a multi-line array.
(#344) Short array syntax must be used to define arrays
(#347) Short array syntax must be used to define arrays
(#352) There should be a comma after the last array item in a multi-line array.
(#374) Short array syntax must be used to define arrays
(#382) Short array syntax must be used to define arrays
(#386) There should be a comma after the last array item in a multi-line array.
local/wswizard/classes/web_service_wizard.php
(#21) Incorrect @package tag for file web_service_wizard.php. Expected local_wswizard, found local_wswizard **.
(#22) Docblock tag "@name" is not recommended.
(#237) Short array syntax must be used to define arrays
(#259) Short array syntax must be used to define arrays
(#300) Short array syntax must be used to define arrays
(#303) Short array syntax must be used to define arrays
(#331) Short array syntax must be used to define arrays
(#342) Short array syntax must be used to define arrays
(#354) Short array syntax must be used to define arrays
(#424) Short array syntax must be used to define arrays
local/wswizard/dashboard.php
(#21) Incorrect @package tag for file dashboard.php. Expected local_wswizard, found local **.
(#23) Docblock tag "@name" is not recommended.
(#106) There should be a comma after the last array item in a multi-line array.
local/wswizard/db/upgrade.php
(#21) Incorrect @package tag for file upgrade.php. Expected local_wswizard, found local **.
(#23) Docblock tag "@name" is not recommended.
(#32) Missing docblock for function xmldb_local_wswizard_upgrade
local/wswizard/lang/en/local_wswizard.php
(#21) Incorrect @package tag for file local_wswizard.php. Expected local_wswizard, found local **.
(#23) Docblock tag "@name" is not recommended.
local/wswizard/lib.php
(#21) Incorrect @package tag for file lib.php. Expected local_wswizard, found local_wswizard **.
(#22) Docblock tag "@name" is not recommended.
(#36) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/wswizard/logs.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#20) Incorrect @package tag for file logs.php. Expected local_wswizard, found local **.
(#22) Docblock tag "@name" is not recommended.
(#65) There should be a comma after the last array item in a multi-line array.
local/wswizard/settings.php
(#21) Incorrect @package tag for file settings.php. Expected local_wswizard, found local **.
(#23) Docblock tag "@name" is not recommended.
local/wswizard/version.php
(#21) Incorrect @package tag for file version.php. Expected local_wswizard, found local **.
(#23) Docblock tag "@name" is not recommended.
local/wswizard/ws.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file ws.php
(#22) Docblock tag "@name" is not recommended.
local/wswizard/ws_edit.php
(#21) Incorrect @package tag for file ws_edit.php. Expected local_wswizard, found local_wswizard **.
(#22) Docblock tag "@name" is not recommended.
(#111) Line exceeds 132 characters; contains 138 characters
(#113) Variable "existingRoleLinks" must be all lower-case
(#114) Line indented incorrectly; expected 8 spaces, found 12
(#114) Variable "existingRoleLinks" must be all lower-case
(#116) Line indented incorrectly; expected 8 spaces, found 12
(#122) Line exceeds maximum limit of 180 characters; contains 206 characters
(#138) Short array syntax must be used to define arrays
(#143) Closing brace must be on a line by itself
(#144) Closing brace must be on a line by itself
(#147) There should be a comma after the last array item in a multi-line array.
(#152) Line exceeds 132 characters; contains 168 characters

Javascript coding style problems

(33 errors, 13 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/wswizard/amd/src/dashboardModal.js
(#2) Missing space before opening brace. (space-before-blocks)
(#34) ["tokenid"] is better written in dot notation. (dot-notation)
(#34) Trailing spaces not allowed. (no-trailing-spaces)
(#35) Unexpected tab character. (no-tabs)
(#35) Mixed spaces and tabs. (no-mixed-spaces-and-tabs)
(#71) ["functionid"] is better written in dot notation. (dot-notation)
(#71) ["functionname"] is better written in dot notation. (dot-notation)
(#71) Trailing spaces not allowed. (no-trailing-spaces)
(#72) Unexpected tab character. (no-tabs)
(#72) Mixed spaces and tabs. (no-mixed-spaces-and-tabs)
(#103) ["webserviceid"] is better written in dot notation. (dot-notation)
(#103) Trailing spaces not allowed. (no-trailing-spaces)
(#104) Unexpected tab character. (no-tabs)
(#104) Mixed spaces and tabs. (no-mixed-spaces-and-tabs)
(#106) 'resultData' is defined but never used. (no-unused-vars)
(#114) A space is required after ','. (comma-spacing)
(#122) Unexpected empty method 'success'. (no-empty-function)
(#127) A space is required after ','. (comma-spacing)
(#135) Unexpected empty method 'success'. (no-empty-function)
(#141) A space is required after ','. (comma-spacing)
(#149) Unexpected empty method 'success'. (no-empty-function)
local/wswizard/js/copytext.js
(#1) 'copyTextFromElement' is defined but never used. (no-unused-vars)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before opening brace. (space-before-blocks)
local/wswizard/js/wswizard.js
(#1) '$' is not defined. (no-undef)
(#2) '$' is not defined. (no-undef)
(#5) '$' is not defined. (no-undef)
(#7) '$' is not defined. (no-undef)
(#8) '$' is not defined. (no-undef)
(#9) '$' is not defined. (no-undef)
(#10) '$' is not defined. (no-undef)
(#11) '$' is not defined. (no-undef)
(#14) '$' is not defined. (no-undef)
(#15) '$' is not defined. (no-undef)
(#16) '$' is not defined. (no-undef)
(#17) '$' is not defined. (no-undef)
(#18) '$' is not defined. (no-undef)
(#22) '$' is not defined. (no-undef)
(#24) '$' is not defined. (no-undef)
(#25) '$' is not defined. (no-undef)
(#26) '$' is not defined. (no-undef)
(#27) '$' is not defined. (no-undef)
(#30) '$' is not defined. (no-undef)
(#31) '$' is not defined. (no-undef)
(#32) '$' is not defined. (no-undef)
(#33) '$' is not defined. (no-undef)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(23 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/wswizard/classes/Base.php
(#174) Phpdocs for function Base::get_user_record has incomplete parameters list
(#199) Phpdocs for function Base::get_user_name_by_userid has incomplete parameters list
local/wswizard/classes/Logs.php
(#66) Phpdocs for function Logs::insert has incomplete parameters list
(#89) Phpdocs for function Logs::get_all has incomplete parameters list
(#127) Phpdocs for function Logs::format_logs has incomplete parameters list
local/wswizard/classes/forms/add_functions_to_webservice_form.php
(#236) Phpdocs for function add_functions_to_webservice_form::assign_functions_to_webservice has incomplete parameters list
local/wswizard/classes/forms/add_token_to_webservice_form.php
(#203) Phpdocs for function add_token_to_webservice_form::validation has incomplete parameters list
local/wswizard/classes/forms/ws_form.php
(#176) Phpdocs for function ws_form::validation has incomplete parameters list
local/wswizard/classes/privacy/provider.php
(#102) Phpdocs for function provider::export_user_data has incomplete parameters list
local/wswizard/classes/web_service_data.php
(#197) Phpdocs for function web_service_data::edit_or_create_webservice_object has incomplete parameters list
(#254) Phpdocs for function web_service_data::assign_functions_to_webservice has incomplete parameters list
(#304) Phpdocs for function web_service_data::create_webservice_token has incomplete parameters list
(#366) Phpdocs for function web_service_data::set_webservice_role has incomplete parameters list
local/wswizard/classes/web_service_wizard.php
(#103) Phpdocs for function web_service_wizard::__construct has incomplete parameters list
(#231) Phpdocs for function web_service_wizard::get_service_by_id has incomplete parameters list
(#253) Phpdocs for function web_service_wizard::get_tokens_from_webservice_id has incomplete parameters list
(#279) Phpdocs for function web_service_wizard::get_functions_from_webservice_id has incomplete parameters list
(#325) Phpdocs for function web_service_wizard::get_user_by_id has incomplete parameters list
(#336) Phpdocs for function web_service_wizard::get_username_from_id has incomplete parameters list
(#347) Phpdocs for function web_service_wizard::get_authorised_users_from_ws_id has incomplete parameters list
(#384) Phpdocs for function web_service_wizard::get_role_name_from_id has incomplete parameters list
(#401) Phpdocs for function web_service_wizard::get_webservice_role has incomplete parameters list
(#418) Phpdocs for function web_service_wizard::get_webservice_protocols_from_webservice has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 4 warnings)

This section shows problems detected in mustache templates [More info]

local/wswizard/templates/dashboard.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 6: Bad value “” for attribute “aria-selected” on element “a”. ( <a class="nav-link" id="nav-createnew-tab" href="" aria-selected=""><i )
(#1) HTML Validation error, line 6: Element “a” is missing one or more of the following attributes: “aria-checked”, “role”. ( <a class="nav-link" id="nav-createnew-tab" href="" aria-selected=""><i )
local/wswizard/templates/logs_report.mustache
(#1) Example context missing (@template section not found.)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]