Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(67 errors, 91 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/ws_enrolcohort/classes/exceptions/cohort_enrol_instance_already_synced_with_role_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#42) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/cohort_enrol_instance_not_found_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/cohort_enrol_method_not_available_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#37) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/cohort_not_available_at_context_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/cohort_not_found_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/course_is_site_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#37) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/course_not_found_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/group_not_found_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/invalid_course_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#37) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/invalid_status_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/not_available_at_context_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#42) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/object_not_found_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/role_not_assignable_at_context_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) File must end with a newline character
local/ws_enrolcohort/classes/exceptions/role_not_found_exception.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) File must end with a newline character
local/ws_enrolcohort/classes/privacy/provider.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/ws_enrolcohort/classes/responses/base.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#43) File must end with a newline character
local/ws_enrolcohort/classes/responses/cohort.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#67) File must end with a newline character
local/ws_enrolcohort/classes/responses/course.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#79) File must end with a newline character
local/ws_enrolcohort/classes/responses/enrol.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#130) File must end with a newline character
local/ws_enrolcohort/classes/responses/error.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#55) File must end with a newline character
local/ws_enrolcohort/classes/responses/group.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#69) File must end with a newline character
local/ws_enrolcohort/classes/responses/response.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#68) File must end with a newline character
local/ws_enrolcohort/classes/responses/role.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#52) File must end with a newline character
local/ws_enrolcohort/classes/tools.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#73) File must end with a newline character
local/ws_enrolcohort/cli/upgrade.php
(#138) File must end with a newline character
local/ws_enrolcohort/externallib.php
(#77) Inline comments must start with a capital letter, digit or 3-dots sequence
(#77) 3 slashes comments are not allowed; use "// Comment." instead
(#214) Inline comments must start with a capital letter, digit or 3-dots sequence
(#214) 3 slashes comments are not allowed; use "// Comment." instead
(#216) Inline comments must start with a capital letter, digit or 3-dots sequence
(#216) 3 slashes comments are not allowed; use "// Comment." instead
(#317) Inline comments must end in full-stops, exclamation marks, or question marks
(#494) Inline comments must start with a capital letter, digit or 3-dots sequence
(#494) 3 slashes comments are not allowed; use "// Comment." instead
(#496) Inline comments must start with a capital letter, digit or 3-dots sequence
(#496) 3 slashes comments are not allowed; use "// Comment." instead
(#668) Inline comments must end in full-stops, exclamation marks, or question marks
(#725) Inline comments must start with a capital letter, digit or 3-dots sequence
(#725) 3 slashes comments are not allowed; use "// Comment." instead
(#727) Inline comments must start with a capital letter, digit or 3-dots sequence
(#727) 3 slashes comments are not allowed; use "// Comment." instead
(#819) Inline comments must start with a capital letter, digit or 3-dots sequence
(#819) 3 slashes comments are not allowed; use "// Comment." instead
(#821) Inline comments must start with a capital letter, digit or 3-dots sequence
(#821) 3 slashes comments are not allowed; use "// Comment." instead
(#958) Inline comments must start with a capital letter, digit or 3-dots sequence
(#958) 3 slashes comments are not allowed; use "// Comment." instead
local/ws_enrolcohort/lang/en/local_ws_enrolcohort.php
(#99) File must end with a newline character
local/ws_enrolcohort/tests/externallib_test.php
(#36) PHPUnit testcase name "local_ws_enrolcohort_externallib_testcase" does not match file name "externallib_test"
(#36) PHPUnit class "local_ws_enrolcohort_externallib_testcase" does not have any namespace. It is recommended to add it to the "local_ws_enrolcohort" namespace, using more levels if needed, in order to match the code being tested
(#43) Inline comments must start with a capital letter, digit or 3-dots sequence
(#43) 3 slashes comments are not allowed; use "// Comment." instead
(#45) Test method test_get_instances() is missing any coverage information, own or at class level
(#122) Inline comments must start with a capital letter, digit or 3-dots sequence
(#122) 3 slashes comments are not allowed; use "// Comment." instead
(#124) Inline comments must start with a capital letter, digit or 3-dots sequence
(#124) 3 slashes comments are not allowed; use "// Comment." instead
(#126) Test method test_delete_instance() is missing any coverage information, own or at class level
(#194) Inline comments must start with a capital letter, digit or 3-dots sequence
(#194) 3 slashes comments are not allowed; use "// Comment." instead
(#196) Inline comments must start with a capital letter, digit or 3-dots sequence
(#196) 3 slashes comments are not allowed; use "// Comment." instead
(#198) Inline comments must start with a capital letter, digit or 3-dots sequence
(#198) 3 slashes comments are not allowed; use "// Comment." instead
(#200) Test method test_update_instance_enrol_instance_id_not_found() is missing any coverage information, own or at class level
(#218) Test method test_update_instance_invalid_status() is missing any coverage information, own or at class level
(#267) Test method test_update_instance_role_not_found() is missing any coverage information, own or at class level
(#315) Test method test_update_instance_role_not_assignable() is missing any coverage information, own or at class level
(#365) Test method test_update_instance_group_not_found() is missing any coverage information, own or at class level
(#413) Inline comments must start with a capital letter, digit or 3-dots sequence
(#413) 3 slashes comments are not allowed; use "// Comment." instead
(#415) Inline comments must start with a capital letter, digit or 3-dots sequence
(#415) 3 slashes comments are not allowed; use "// Comment." instead
(#417) Test method test_update_instance_nochange() is missing any coverage information, own or at class level
(#474) Test method test_update_instance() is missing any coverage information, own or at class level
(#606) Inline comments must start with a capital letter, digit or 3-dots sequence
(#606) 3 slashes comments are not allowed; use "// Comment." instead
(#608) Inline comments must start with a capital letter, digit or 3-dots sequence
(#608) 3 slashes comments are not allowed; use "// Comment." instead
(#610) Inline comments must start with a capital letter, digit or 3-dots sequence
(#610) 3 slashes comments are not allowed; use "// Comment." instead
(#612) Inline comments must start with a capital letter, digit or 3-dots sequence
(#612) 3 slashes comments are not allowed; use "// Comment." instead
(#614) Test method test_add_instance_success_without_group() is missing any coverage information, own or at class level
(#675) Test method test_add_instance_success_with_group_new() is missing any coverage information, own or at class level
(#739) Test method test_add_instance_success_with_group_existing() is missing any coverage information, own or at class level
(#804) Inline comments must start with a capital letter, digit or 3-dots sequence
(#804) 3 slashes comments are not allowed; use "// Comment." instead
(#806) Inline comments must start with a capital letter, digit or 3-dots sequence
(#806) 3 slashes comments are not allowed; use "// Comment." instead
(#808) Inline comments must start with a capital letter, digit or 3-dots sequence
(#808) 3 slashes comments are not allowed; use "// Comment." instead
(#810) Test method test_add_instance_success_with_group_existing_invalid_course() is missing any coverage information, own or at class level
(#842) Inline comments must start with a capital letter, digit or 3-dots sequence
(#842) 3 slashes comments are not allowed; use "// Comment." instead
(#844) Inline comments must start with a capital letter, digit or 3-dots sequence
(#844) 3 slashes comments are not allowed; use "// Comment." instead
(#846) Test method test_add_instance_enrol_instance_already_synced_with_role() is missing any coverage information, own or at class level
(#881) Inline comments must start with a capital letter, digit or 3-dots sequence
(#881) 3 slashes comments are not allowed; use "// Comment." instead
(#883) Inline comments must start with a capital letter, digit or 3-dots sequence
(#883) 3 slashes comments are not allowed; use "// Comment." instead
(#885) Test method test_add_instance_invalid_status() is missing any coverage information, own or at class level
(#918) Inline comments must start with a capital letter, digit or 3-dots sequence
(#918) 3 slashes comments are not allowed; use "// Comment." instead
(#920) Inline comments must start with a capital letter, digit or 3-dots sequence
(#920) 3 slashes comments are not allowed; use "// Comment." instead
(#925) Test method test_add_instance_missing_required_params() is missing any coverage information, own or at class level
(#988) Inline comments must start with a capital letter, digit or 3-dots sequence
(#988) 3 slashes comments are not allowed; use "// Comment." instead
(#990) Inline comments must start with a capital letter, digit or 3-dots sequence
(#990) 3 slashes comments are not allowed; use "// Comment." instead
(#992) Test method test_add_instance_course_not_found() is missing any coverage information, own or at class level
(#1009) Test method test_add_instance_cohort_not_found() is missing any coverage information, own or at class level
(#1032) Test method test_add_instance_role_not_found() is missing any coverage information, own or at class level
(#1059) Test method test_add_instance_group_not_found() is missing any coverage information, own or at class level
(#1093) Inline comments must start with a capital letter, digit or 3-dots sequence
(#1093) 3 slashes comments are not allowed; use "// Comment." instead
(#1095) Inline comments must start with a capital letter, digit or 3-dots sequence
(#1095) 3 slashes comments are not allowed; use "// Comment." instead
(#1097) Test method test_add_instance_site_course() is missing any coverage information, own or at class level
(#1122) Inline comments must start with a capital letter, digit or 3-dots sequence
(#1122) 3 slashes comments are not allowed; use "// Comment." instead
(#1124) Inline comments must start with a capital letter, digit or 3-dots sequence
(#1124) 3 slashes comments are not allowed; use "// Comment." instead
(#1126) Test method test_add_instance_cohort_unavailable() is missing any coverage information, own or at class level
(#1158) Test method test_add_instance_role_unassignable() is missing any coverage information, own or at class level
(#1190) Inline comments must start with a capital letter, digit or 3-dots sequence
(#1190) 3 slashes comments are not allowed; use "// Comment." instead
(#1192) Inline comments must start with a capital letter, digit or 3-dots sequence
(#1192) 3 slashes comments are not allowed; use "// Comment." instead
(#1194) Inline comments must start with a capital letter, digit or 3-dots sequence
(#1194) 3 slashes comments are not allowed; use "// Comment." instead
(#1195) File must end with a newline character
local/ws_enrolcohort/version.php
(#38) File must end with a newline character

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(94 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/ws_enrolcohort/classes/exceptions/cohort_enrol_instance_already_synced_with_role_exception.php
(#33) Class cohort_enrol_instance_already_synced_with_role_exception is not documented
(#34) Function cohort_enrol_instance_already_synced_with_role_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/cohort_enrol_instance_not_found_exception.php
(#31) Class cohort_enrol_instance_not_found_exception is not documented
(#32) Function cohort_enrol_instance_not_found_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/cohort_enrol_method_not_available_exception.php
(#33) Class cohort_enrol_method_not_available_exception is not documented
(#34) Function cohort_enrol_method_not_available_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/cohort_not_available_at_context_exception.php
(#31) Class cohort_not_available_at_context_exception is not documented
(#32) Function cohort_not_available_at_context_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/cohort_not_found_exception.php
(#31) Class cohort_not_found_exception is not documented
(#32) Function cohort_not_found_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/course_is_site_exception.php
(#33) Class course_is_site_exception is not documented
(#34) Function course_is_site_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/course_not_found_exception.php
(#31) Class course_not_found_exception is not documented
(#32) Function course_not_found_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/group_not_found_exception.php
(#31) Class group_not_found_exception is not documented
(#32) Function group_not_found_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/invalid_course_exception.php
(#33) Class invalid_course_exception is not documented
(#34) Function invalid_course_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/invalid_status_exception.php
(#33) Class invalid_status_exception is not documented
(#34) Function invalid_status_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/not_available_at_context_exception.php
(#33) Class not_available_at_context_exception is not documented
(#34) Function not_available_at_context_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/object_not_found_exception.php
(#33) Class object_not_found_exception is not documented
(#34) Function object_not_found_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/role_not_assignable_at_context_exception.php
(#31) Class role_not_assignable_at_context_exception is not documented
(#32) Function role_not_assignable_at_context_exception::__construct is not documented
local/ws_enrolcohort/classes/exceptions/role_not_found_exception.php
(#31) Class role_not_found_exception is not documented
(#32) Function role_not_found_exception::__construct is not documented
local/ws_enrolcohort/classes/privacy/provider.php
(#33) Class provider is not documented
local/ws_enrolcohort/classes/responses/cohort.php
(#31) Class cohort is not documented
local/ws_enrolcohort/classes/responses/course.php
(#31) Class course is not documented
local/ws_enrolcohort/classes/responses/enrol.php
(#31) Class enrol is not documented
(#82) Function enrol::__construct is not documented
(#98) Phpdocs for function enrol::set_course has incomplete parameters list
(#107) Phpdocs for function enrol::set_cohort has incomplete parameters list
(#116) Phpdocs for function enrol::set_role has incomplete parameters list
(#125) Phpdocs for function enrol::set_group has incomplete parameters list
local/ws_enrolcohort/classes/responses/error.php
(#33) Class error is not documented
local/ws_enrolcohort/classes/responses/group.php
(#33) Class group is not documented
local/ws_enrolcohort/classes/responses/response.php
(#31) Class response is not documented
local/ws_enrolcohort/classes/responses/role.php
(#31) Class role is not documented
local/ws_enrolcohort/classes/tools.php
(#31) Class tools is not documented
(#37) There is no description in phpdocs for function get_string
local/ws_enrolcohort/db/services.php
(#20) Package ws_enrolcohort is not valid
local/ws_enrolcohort/externallib.php
(#47) Class local_ws_enrolcohort_external is not documented
(#53) Constant local_ws_enrolcohort_external::QUERYSTRING_COURSE is not documented
(#59) Constant local_ws_enrolcohort_external::COHORT_GROUP_CREATE_NEW is not documented
(#70) Constant local_ws_enrolcohort_external::FIELD_COHORT is not documented
(#77) Found comment starting with three or more slashes
(#214) Found comment starting with three or more slashes
(#216) Found comment starting with three or more slashes
(#494) Found comment starting with three or more slashes
(#496) Found comment starting with three or more slashes
(#725) Found comment starting with three or more slashes
(#727) Found comment starting with three or more slashes
(#819) Found comment starting with three or more slashes
(#821) Found comment starting with three or more slashes
(#958) Found comment starting with three or more slashes
(#283) Phpdocs for function local_ws_enrolcohort_external::add_instance has incomplete parameters list
(#538) Phpdocs for function local_ws_enrolcohort_external::update_instance has incomplete parameters list
(#754) Phpdocs for function local_ws_enrolcohort_external::delete_instance has incomplete parameters list
(#848) Phpdocs for function local_ws_enrolcohort_external::get_instances has incomplete parameters list
local/ws_enrolcohort/tests/externallib_test.php
(#36) Class local_ws_enrolcohort_externallib_testcase is not documented
(#37) Function local_ws_enrolcohort_externallib_testcase::create_cohorts is not documented
(#43) Found comment starting with three or more slashes
(#122) Found comment starting with three or more slashes
(#124) Found comment starting with three or more slashes
(#194) Found comment starting with three or more slashes
(#196) Found comment starting with three or more slashes
(#198) Found comment starting with three or more slashes
(#413) Found comment starting with three or more slashes
(#415) Found comment starting with three or more slashes
(#606) Found comment starting with three or more slashes
(#608) Found comment starting with three or more slashes
(#610) Found comment starting with three or more slashes
(#612) Found comment starting with three or more slashes
(#804) Found comment starting with three or more slashes
(#806) Found comment starting with three or more slashes
(#808) Found comment starting with three or more slashes
(#842) Found comment starting with three or more slashes
(#844) Found comment starting with three or more slashes
(#881) Found comment starting with three or more slashes
(#883) Found comment starting with three or more slashes
(#918) Found comment starting with three or more slashes
(#920) Found comment starting with three or more slashes
(#988) Found comment starting with three or more slashes
(#990) Found comment starting with three or more slashes
(#1093) Found comment starting with three or more slashes
(#1095) Found comment starting with three or more slashes
(#1122) Found comment starting with three or more slashes
(#1124) Found comment starting with three or more slashes
(#1190) Found comment starting with three or more slashes
(#1192) Found comment starting with three or more slashes
(#1194) Found comment starting with three or more slashes

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]