Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(60 errors, 5 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/webmonetization/classes/contextpaymentpointerform.php
(#44) Line exceeds 132 characters; contains 169 characters
local/webmonetization/classes/privacy/provider.php
(#40) File must end with a newline character
local/webmonetization/classes/receiptverifier.php
(#36) The abstract declaration must precede the visibility declaration
(#76) The abstract declaration must precede the visibility declaration
local/webmonetization/db/caches.php
(#2) Line 1 of the opening comment must start "// This file is part of".
(#3) Line 2 of the opening comment must start "//".
(#4) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#5) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#6) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#7) Line 6 of the opening comment must start "// (at your option) any later version.".
(#8) Line 7 of the opening comment must start "//".
(#9) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#10) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#12) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#13) Line 12 of the opening comment must start "//".
(#14) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#23) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/webmonetization/db/services.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/webmonetization/editcontextpaymentpointer.php
(#29) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/webmonetization/failed.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#3) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/webmonetization/handlers/receiptverifierproxy.php
(#2) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#2) Line 1 of the opening comment must start "// This file is part of".
(#2) Line 2 of the opening comment must start "//".
(#2) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#2) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#2) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#2) Line 6 of the opening comment must start "// (at your option) any later version.".
(#2) Line 7 of the opening comment must start "//".
(#2) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#2) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#2) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#3) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#3) Line 12 of the opening comment must start "//".
(#3) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#3) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
local/webmonetization/interstitial.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#6) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/webmonetization/lib.php
(#121) Variable "navigation_node" must not contain underscores.
(#124) Variable "navigation_node" must not contain underscores.
(#127) Variable "navigation_node" must not contain underscores.
(#131) Variable "navigation_node" must not contain underscores.
(#135) Variable "navigation_node" must not contain underscores.
local/webmonetization/lib/interledgerphp/autoload.php
(#2) Line 1 of the opening comment must start "// This file is part of".
(#2) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#2) Line 2 of the opening comment must start "//".
(#2) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#2) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#2) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#2) Line 6 of the opening comment must start "// (at your option) any later version.".
(#2) Line 7 of the opening comment must start "//".
(#2) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#2) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#2) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#3) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#3) Line 12 of the opening comment must start "//".
(#3) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#3) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
local/webmonetization/lib/interledgerphp/receipt.php
(#2) The opening <?php tag must be followed by exactly one newline.
local/webmonetization/lib/interledgerphp/receiptexception.php
(#2) The opening <?php tag must be followed by exactly one newline.
local/webmonetization/lib/interledgerphp/receipthandler.php
(#2) The opening <?php tag must be followed by exactly one newline.
local/webmonetization/settings.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#37) "require_once" must be immediately followed by an open parenthesis

Javascript coding style problems

(3 errors, 4 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/webmonetization/amd/src/handlereceipts.js
(#17) @package should be empty. (jsdoc/empty-tags)
(#26) Unexpected space before function parentheses. (space-before-function-paren)
(#28) Missing JSDoc @param "requiremonetization" declaration. (jsdoc/require-param)
(#28) Missing JSDoc @param "wantsurl" declaration. (jsdoc/require-param)
(#34) Unexpected space before function parentheses. (space-before-function-paren)
(#48) Unexpected space before function parentheses. (space-before-function-paren)
(#54) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(63 errors, 5 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/webmonetization/classes/contextpaymentpointer.php
(#34) Class contextpaymentpointer is not documented
(#37) Function contextpaymentpointer::define_properties is not documented
(#35) Constant contextpaymentpointer::TABLE is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/classes/contextpaymentpointerform.php
(#33) Class contextpaymentpointerform is not documented
(#38) Function contextpaymentpointerform::definition is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/classes/external.php
(#37) Class external is not documented
(#38) Function external::handlereceipt_parameters is not documented
(#54) Function external::handlereceipt is not documented
(#67) Function external::handlereceipt_returns is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/classes/privacy/provider.php
(#33) Class provider is not documented
(#17) No one-line description found in phpdocs for file
(#34) There is no description in phpdocs for function get_reason
local/webmonetization/classes/receiptverifier.php
(#33) Class receiptverifier is not documented
(#36) Function receiptverifier::verifyhmac is not documented
(#38) Function receiptverifier::verify is not documented
(#76) Function receiptverifier::gethandler is not documented
(#78) Function receiptverifier::get_lastsessionverificationresult is not documented
(#88) Function receiptverifier::set_lastsessionverificationresult is not documented
(#93) Function receiptverifier::get_receiptverifier is not documented
(#34) Constant receiptverifier::LASTSESSIONVERIFICATIONRESULTPROPERTYNAME is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/classes/verifiers/external.php
(#34) Class external is not documented
(#35) Function external::verifyhmac is not documented
(#60) Function external::gethandler is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/classes/verifiers/internal.php
(#34) Class internal is not documented
(#35) Function internal::verifyhmac is not documented
(#46) Function internal::gethandler is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/db/access.php
(#17) No one-line description found in phpdocs for file
local/webmonetization/db/caches.php
(#20) Package local_reportbuilder is not valid
(#23) File-level phpdocs block is not found
local/webmonetization/db/install.php
(#29) Function xmldb_local_webmonetization_install is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/db/services.php
(#17) No one-line description found in phpdocs for file
local/webmonetization/db/upgrade.php
(#27) Function xmldb_local_webmonetization_upgrade is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/editcontextpaymentpointer.php
(#17) No one-line description found in phpdocs for file
local/webmonetization/failed.php
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
local/webmonetization/handlers/receiptverifierproxy.php
(#2) File-level phpdocs block is not found
local/webmonetization/interstitial.php
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
local/webmonetization/lang/en/local_webmonetization.php
(#17) No one-line description found in phpdocs for file
local/webmonetization/lib.php
(#32) Function local_webmonetization_before_standard_html_head is not documented
(#83) Function local_webmonetization_update_systempaymentpointer is not documented
(#17) No one-line description found in phpdocs for file
local/webmonetization/lib/interledgerphp/autoload.php
(#2) File-level phpdocs block is not found
local/webmonetization/lib/interledgerphp/receipt.php
(#4) Package interledgerphp is not valid
(#19) Package interledgerphp is not valid
(#2) Empty line found after PHP open tag
(#3) No one-line description found in phpdocs for file
local/webmonetization/lib/interledgerphp/receiptexception.php
(#4) Package interledgerphp is not valid
(#19) Package interledgerphp is not valid
(#2) Empty line found after PHP open tag
(#3) No one-line description found in phpdocs for file
local/webmonetization/lib/interledgerphp/receipthandler.php
(#4) Package interledgerphp is not valid
(#19) Package interledgerphp is not valid
(#2) Empty line found after PHP open tag
(#32) Function receipthandler::__construct is not documented
(#36) Function receipthandler::generate_receipt_nonce is not documented
(#40) Function receipthandler::generate_receipt_secret is not documented
(#3) No one-line description found in phpdocs for file
local/webmonetization/settings.php
(#17) No one-line description found in phpdocs for file
local/webmonetization/version.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(1 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

local/webmonetization/db/upgrade.php
'return true;' not found

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 3 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

local/webmonetization/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!
No changes detected to backup and restore, that may affect storage and transportability, please verify!

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]