Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(307 errors, 19 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/usertours/classes/configuration.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
(#64) This comment is 60% valid code; is this commented out code?
(#88) This comment is 60% valid code; is this commented out code?
local/usertours/classes/external/target.php
(#39) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/external/tour.php
(#40) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/helper.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/manager.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
(#246) Line indented incorrectly; expected 8 spaces, found 12
(#258) Line indented incorrectly; expected 8 spaces, found 12
(#320) Space found before object operator
(#321) Space found before object operator
(#322) Space found before object operator
(#323) Space found before object operator
(#324) Space found before semicolon; expected ");" but found ") ;"
(#620) Space found before object operator
(#621) Space found before object operator
(#622) Space found before semicolon; expected ");" but found ") ;"
(#671) Space found before object operator
(#672) Space found before object operator
(#673) Space found before semicolon; expected ");" but found ") ;"
(#677) Space found before object operator
(#678) Space found before object operator
(#679) Space found before semicolon; expected ");" but found ") ;"
(#682) Space found before object operator
(#683) Space found before semicolon; expected ");" but found ") ;"
(#707) Space found before object operator
(#708) Space found before object operator
(#709) Space found before semicolon; expected ");" but found ") ;"
(#713) Space found before object operator
(#714) Space found before object operator
(#715) Space found before semicolon; expected ");" but found ") ;"
(#718) Space found before object operator
(#719) Space found before semicolon; expected ");" but found ") ;"
local/usertours/classes/output/renderer.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/output/step.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
(#60) Expected 1 space after "="; 2 found
local/usertours/classes/output/tour.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
(#57) Expected 1 space after "="; 2 found
local/usertours/classes/step.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
(#606) Space found before object operator
(#607) Space found before object operator
(#608) Space found before object operator
(#609) Space found before object operator
(#610) Space found before semicolon; expected ");" but found ") ;"
local/usertours/classes/target.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/target/base.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/target/block.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/target/selector.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/target/unattached.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
local/usertours/classes/tour.php
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
(#587) Space found before object operator
(#588) Space found before object operator
(#589) Space found before semicolon; expected ");" but found ") ;"
local/usertours/configure.php
(#25) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
local/usertours/db/services.php
(#23) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/usertours/tests/manager_test.php
(#42) Member variable "DB" must be all lower-case
(#71) Space found before object operator
(#72) Space found before semicolon; expected ");" but found ") ;"
local/usertours/tests/step_output_test.php
(#1) The first thing in a PHP file must be the <?php tag.
(#2) Additional whitespace found at start of file
local/usertours/tests/step_test.php
(#42) Member variable "DB" must be all lower-case
(#71) Space found before object operator
(#72) Space found before semicolon; expected ");" but found ") ;"
(#120) Space found before object operator
(#121) Space found before object operator
(#122) Space found before semicolon; expected ");" but found ") ;"
(#127) Space found before object operator
(#128) Space found before semicolon; expected ");" but found ") ;"
(#132) Space found before object operator
(#133) Space found before object operator
(#134) Space found before object operator
(#135) Space found before semicolon; expected ");" but found ") ;"
(#186) Space found before object operator
(#187) Space found before object operator
(#190) Space found before object operator
(#191) Space found before object operator
(#192) Space found before semicolon; expected ");" but found ") ;"
(#208) Space found before object operator
(#209) Space found before object operator
(#212) Space found before object operator
(#213) Space found before object operator
(#216) Space found before object operator
(#217) Space found before object operator
(#218) Space found before semicolon; expected ");" but found ") ;"
(#221) Space found before object operator
(#222) Space found before object operator
(#223) Space found before semicolon; expected ");" but found ") ;"
(#226) Space found before object operator
(#227) Space found before object operator
(#228) Space found before semicolon; expected ");" but found ") ;"
(#360) Space found before object operator
(#361) Space found before object operator
(#369) Space found before object operator
(#370) Space found before object operator
(#371) Space found before semicolon; expected ");" but found ") ;"
(#374) Space found before object operator
(#375) Space found before object operator
(#376) Space found before semicolon; expected ");" but found ") ;"
(#379) Space found before object operator
(#380) Space found before object operator
(#381) Space found before object operator
(#382) Space found before semicolon; expected ");" but found ") ;"
(#385) Space found before object operator
(#386) Space found before object operator
(#387) Space found before semicolon; expected ");" but found ") ;"
(#390) Space found before object operator
(#391) Space found before semicolon; expected ");" but found ") ;"
(#394) Space found before object operator
(#395) Space found before object operator
(#396) Space found before semicolon; expected ");" but found ") ;"
(#397) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#400) Space found before object operator
(#401) Space found before object operator
(#402) Space found before semicolon; expected ");" but found ") ;"
(#465) Space found before object operator
(#466) Space found before object operator
(#467) Space found before semicolon; expected ");" but found ") ;"
(#470) Space found before object operator
(#471) Space found before object operator
(#472) Space found before semicolon; expected ");" but found ") ;"
(#484) Space found before object operator
(#488) Space found before object operator
(#489) Space found before semicolon; expected ");" but found ") ;"
(#492) Space found before object operator
(#493) Space found before semicolon; expected ");" but found ") ;"
(#496) Space found before object operator
(#497) Space found before semicolon; expected ");" but found ") ;"
(#509) Space found before object operator
(#510) Space found before object operator
(#511) Space found before semicolon; expected ");" but found ") ;"
(#515) Space found before object operator
(#520) Space found before object operator
(#521) Space found before semicolon; expected ");" but found ") ;"
(#524) Space found before object operator
(#525) Space found before object operator
(#529) Space found before object operator
(#530) Space found before semicolon; expected ");" but found ") ;"
(#533) Space found before object operator
(#534) Space found before semicolon; expected ");" but found ") ;"
(#553) Space found before object operator
(#554) Space found before object operator
(#555) Space found before semicolon; expected ");" but found ") ;"
(#559) Space found before object operator
(#564) Space found before object operator
(#565) Space found before semicolon; expected ");" but found ") ;"
(#568) Space found before object operator
(#569) Space found before object operator
(#573) Space found before object operator
(#574) Space found before semicolon; expected ");" but found ") ;"
(#577) Space found before object operator
(#578) Space found before semicolon; expected ");" but found ") ;"
(#590) Space found before object operator
(#591) Space found before semicolon; expected ");" but found ") ;"
(#595) Space found before object operator
(#600) Space found before object operator
(#601) Space found before semicolon; expected ");" but found ") ;"
(#604) Space found before object operator
(#605) Space found before object operator
(#609) Space found before object operator
(#610) Space found before semicolon; expected ");" but found ") ;"
(#613) Space found before object operator
(#614) Space found before semicolon; expected ");" but found ") ;"
(#637) Space found before object operator
(#638) Space found before semicolon; expected ");" but found ") ;"
(#642) Space found before object operator
(#647) Space found before object operator
(#648) Space found before semicolon; expected ");" but found ") ;"
(#651) Space found before object operator
(#652) Space found before object operator
(#656) Space found before object operator
(#657) Space found before semicolon; expected ");" but found ") ;"
(#660) Space found before object operator
(#661) Space found before semicolon; expected ");" but found ") ;"
(#676) Space found before object operator
(#677) Space found before object operator
(#678) Space found before semicolon; expected ");" but found ") ;"
(#683) Space found before object operator
(#684) Space found before semicolon; expected ");" but found ") ;"
(#696) Space found before object operator
(#699) Space found before object operator
(#700) Space found before semicolon; expected ");" but found ") ;"
(#703) Space found before object operator
(#704) Space found before semicolon; expected ");" but found ") ;"
(#707) Space found before object operator
(#710) Space found before object operator
(#711) Space found before semicolon; expected ");" but found ") ;"
(#714) Space found before object operator
(#715) Space found before object operator
(#716) Space found before semicolon; expected ");" but found ") ;"
(#721) Space found before object operator
(#722) Space found before object operator
(#723) Space found before semicolon; expected ");" but found ") ;"
local/usertours/tests/tour_test.php
(#42) Member variable "DB" must be all lower-case
(#71) Space found before object operator
(#72) Space found before semicolon; expected ");" but found ") ;"
(#190) Space found before object operator
(#191) Space found before object operator
(#192) Space found before semicolon; expected ");" but found ") ;"
(#195) Space found before object operator
(#196) Space found before semicolon; expected ");" but found ") ;"
(#209) Space found before object operator
(#210) Space found before semicolon; expected ");" but found ") ;"
(#214) Space found before object operator
(#215) Space found before object operator
(#216) Space found before semicolon; expected ");" but found ") ;"
(#220) Space found before object operator
(#224) Space found before object operator
(#225) Space found before semicolon; expected ");" but found ") ;"
(#228) Space found before object operator
(#229) Space found before semicolon; expected ");" but found ") ;"
(#232) Space found before object operator
(#233) Space found before semicolon; expected ");" but found ") ;"
(#258) Space found before object operator
(#259) Space found before semicolon; expected ");" but found ") ;"
(#263) Space found before object operator
(#264) Space found before object operator
(#265) Space found before semicolon; expected ");" but found ") ;"
(#269) Space found before object operator
(#273) Space found before object operator
(#274) Space found before semicolon; expected ");" but found ") ;"
(#277) Space found before object operator
(#278) Space found before semicolon; expected ");" but found ") ;"
(#281) Space found before object operator
(#282) Space found before semicolon; expected ");" but found ") ;"
(#299) Space found before object operator
(#300) Space found before object operator
(#301) Space found before semicolon; expected ");" but found ") ;"
(#304) Space found before object operator
(#305) Space found before semicolon; expected ");" but found ") ;"
(#309) Space found before object operator
(#313) Space found before object operator
(#314) Space found before semicolon; expected ");" but found ") ;"
(#317) Space found before object operator
(#318) Space found before semicolon; expected ");" but found ") ;"
(#321) Space found before object operator
(#322) Space found before semicolon; expected ");" but found ") ;"
(#347) Space found before object operator
(#348) Space found before object operator
(#349) Space found before semicolon; expected ");" but found ") ;"
(#352) Space found before object operator
(#353) Space found before semicolon; expected ");" but found ") ;"
(#357) Space found before object operator
(#361) Space found before object operator
(#362) Space found before semicolon; expected ");" but found ") ;"
(#365) Space found before object operator
(#366) Space found before semicolon; expected ");" but found ") ;"
(#369) Space found before object operator
(#370) Space found before semicolon; expected ");" but found ") ;"
(#515) Space found before object operator
(#518) Space found before object operator
(#519) Space found before semicolon; expected ");" but found ") ;"
(#522) Space found before object operator
(#523) Space found before semicolon; expected ");" but found ") ;"
(#528) Space found before object operator
(#529) Space found before semicolon; expected ");" but found ") ;"
(#541) Space found before object operator
(#544) Space found before object operator
(#545) Space found before semicolon; expected ");" but found ") ;"
(#553) Space found before object operator
(#556) Space found before object operator
(#557) Space found before semicolon; expected ");" but found ") ;"
(#560) Space found before object operator
(#561) Space found before object operator
(#562) Space found before semicolon; expected ");" but found ") ;"
(#563) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#568) Space found before object operator
(#569) Space found before object operator
(#570) Space found before object operator
(#571) Space found before semicolon; expected ");" but found ") ;"
(#574) Space found before object operator
(#575) Space found before object operator
(#576) Space found before object operator
(#577) Space found before semicolon; expected ");" but found ") ;"
(#598) Space found before object operator
(#599) Space found before object operator
(#600) Space found before semicolon; expected ");" but found ") ;"
(#603) Space found before object operator
(#604) Space found before semicolon; expected ");" but found ") ;"
(#672) Space found before object operator
(#677) Space found before object operator
(#678) Space found before semicolon; expected ");" but found ") ;"
(#681) Space found before object operator
(#682) Space found before semicolon; expected ");" but found ") ;"
(#686) Space found before object operator
(#687) Space found before semicolon; expected ");" but found ") ;"
(#699) Space found before object operator
(#700) Space found before object operator
(#701) Space found before semicolon; expected ");" but found ") ;"
(#764) Space found before object operator
(#770) Space found before object operator
(#771) Space found before semicolon; expected ");" but found ") ;"
(#775) Space found before object operator
(#776) Space found before object operator
(#777) Space found before semicolon; expected ");" but found ") ;"
(#782) Space found before object operator
(#783) Space found before object operator
(#784) Space found before object operator
(#785) Space found before semicolon; expected ");" but found ") ;"
(#788) Space found before object operator
(#789) Space found before semicolon; expected ");" but found ") ;"
(#794) Space found before object operator
(#795) Space found before semicolon; expected ");" but found ") ;"
(#798) Space found before object operator
(#799) Space found before semicolon; expected ");" but found ") ;"
(#803) Space found before object operator
(#804) Space found before object operator
(#805) Space found before semicolon; expected ");" but found ") ;"
(#822) Space found before object operator
(#825) Space found before object operator
(#826) Space found before semicolon; expected ");" but found ") ;"
(#832) Space found before object operator
(#833) Space found before object operator
(#834) Space found before semicolon; expected ");" but found ") ;"
(#846) Space found before object operator
(#849) Space found before object operator
(#850) Space found before semicolon; expected ");" but found ") ;"
(#856) Space found before object operator
(#857) Space found before object operator
(#858) Space found before semicolon; expected ");" but found ") ;"
(#932) Space found before object operator
(#933) Space found before object operator
(#934) Space found before semicolon; expected ");" but found ") ;"
(#955) Space found before object operator
(#956) Space found before object operator
(#957) Space found before semicolon; expected ");" but found ") ;"
local/usertours/version.php
(#29) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 10 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/usertours/amd/src/managesteps.js
(#87) Expected to return a value in this function. (array-callback-return)
local/usertours/amd/src/usertours.js
(#42) Missing JSDoc parameter type for 'int'. (valid-jsdoc)
(#42) Expected JSDoc for 'tourId' but found 'int'. (valid-jsdoc)
(#90) Missing JSDoc parameter type for 'int'. (valid-jsdoc)
(#90) Missing JSDoc parameter type for 'object'. (valid-jsdoc)
(#90) Expected JSDoc for 'tourId' but found 'int'. (valid-jsdoc)
(#90) Expected JSDoc for 'template' but found 'object'. (valid-jsdoc)
(#90) Missing JSDoc for parameter 'tourConfig'. (valid-jsdoc)
(#113) Missing JSDoc parameter type for 'int'. (valid-jsdoc)
(#129) Missing JSDoc for parameter 'tourId'. (valid-jsdoc)

CSS problems

(0 errors, 1 warnings)

This section shows CSS problems detected by csslint [More info]

local/usertours/styles.css
(#46) Use of !important

PHPDocs style problems

(51 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/usertours/classes/manager.php
(#496) Phpdocs for function manager::get_current_tour has incomplete parameters list
local/usertours/classes/output/step.php
(#44) Phpdocs for function step::__construct has incomplete parameters list
local/usertours/classes/output/tour.php
(#44) Phpdocs for function tour::__construct has incomplete parameters list
local/usertours/classes/target/block.php
(#35) There is no description in phpdocs for function convert_to_css
(#44) There is no description in phpdocs for function get_displayname
(#68) There is no description in phpdocs for function add_config_to_form
(#68) Phpdocs for function block::add_config_to_form has incomplete parameters list
(#36) Invalid phpdocs tag @inheritdoc used
(#45) Invalid phpdocs tag @inheritdoc used
(#69) Invalid phpdocs tag @inheritdoc used
local/usertours/classes/target/selector.php
(#35) There is no description in phpdocs for function convert_to_css
(#42) There is no description in phpdocs for function get_displayname
(#49) There is no description in phpdocs for function get_default_title
(#56) There is no description in phpdocs for function get_default_content
(#63) There is no description in phpdocs for function add_config_to_form
(#63) Phpdocs for function selector::add_config_to_form has incomplete parameters list
(#36) Invalid phpdocs tag @inheritdoc used
(#43) Invalid phpdocs tag @inheritdoc used
(#50) Invalid phpdocs tag @inheritdoc used
(#57) Invalid phpdocs tag @inheritdoc used
(#64) Invalid phpdocs tag @inheritdoc used
local/usertours/classes/target/unattached.php
(#44) There is no description in phpdocs for function convert_to_css
(#51) There is no description in phpdocs for function get_displayname
(#58) There is no description in phpdocs for function add_config_to_form
(#58) Phpdocs for function unattached::add_config_to_form has incomplete parameters list
(#45) Invalid phpdocs tag @inheritdoc used
(#52) Invalid phpdocs tag @inheritdoc used
(#59) Invalid phpdocs tag @inheritdoc used
local/usertours/classes/tour.php
(#381) Phpdocs for function tour::is_last_tour has incomplete parameters list
local/usertours/db/services.php
(#17) No one-line description found in phpdocs for file
local/usertours/lib.php
(#29) Function local_usertours_extend_navigation is not documented
local/usertours/tests/manager_test.php
(#122) Function manager_testcase::get_matching_tours_provider is not documented
(#225) There is no description in phpdocs for function test_get_matching_tours
(#246) There is no description in phpdocs for function test_get_matching_tours_requires_upgrade
(#106) Phpdocs for function manager_testcase::test_sesskey_required has incomplete parameters list
(#225) Phpdocs for function manager_testcase::test_get_matching_tours has incomplete parameters list
(#246) Phpdocs for function manager_testcase::test_get_matching_tours_requires_upgrade has incomplete parameters list
local/usertours/tests/step_output_test.php
(#2) Empty line found after PHP open tag
(#1) File-level phpdocs block is not found
(#37) Function step_output_testcase::get_string_from_input_provider is not documented
(#66) Phpdocs for function step_output_testcase::test_get_string_from_input has incomplete parameters list
local/usertours/tests/step_test.php
(#145) Phpdocs for function step_testcase::test_dirty_values has incomplete parameters list
(#353) Phpdocs for function step_testcase::test_get_config_valid_keys has incomplete parameters list
(#451) Phpdocs for function step_testcase::test_set_config has incomplete parameters list
(#772) Phpdocs for function step_testcase::test_getters has incomplete parameters list
local/usertours/tests/tour_test.php
(#111) Phpdocs for function tour_testcase::test_dirty_values has incomplete parameters list
(#166) Phpdocs for function tour_testcase::test_getters has incomplete parameters list
(#661) Phpdocs for function tour_testcase::test_should_show_for_user has incomplete parameters list
(#753) Phpdocs for function tour_testcase::test_get_tour_key has incomplete parameters list
(#900) Phpdocs for function tour_testcase::test_is_first_tour has incomplete parameters list
(#916) Phpdocs for function tour_testcase::test_is_last_tour_calculated has incomplete parameters list
(#938) Phpdocs for function tour_testcase::test_is_last_tour_provided has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(1 errors, 1 warnings)

This section shows problems detected in mustache templates [More info]

local/usertours/templates/selecttarget.mustache
(#1) Mustache syntax exception: Example context JSON is unparsable, fails with: quoted object property name expected
local/usertours/templates/tourstep.mustache
(#1) HTML Validation info, line 4: Empty heading. (/div> <h3 class="popover-title"></h3>)