Comments

• 

  Anthony Borrow

  Fri, 12 Apr 2013, 9:24 AM

  Eric - Many thanks for sharing this plugin with the Moodle community. Since MDL-32791 has been resolved as fixed, does this plugin provide any utility to users that upgrading their code to the latest version does not? What advantages would installing this plugin provide a site administrator? Peace - Anthony
• 

  Eric Villard

  Fri, 12 Apr 2013, 4:54 PM

  Hi Anthony,
  
  thank you for taking time to review this plugin.
  
  Regarding your first question, my answer is simply yes.
  The fix provided in the MDL-32791 is only applied when upgrading the plugin version during a Moodle upgrade for example.
  If you import, and this was my case, a buggy quiz in your Moodle site, the problem is still there.
  This plugin permits to apply the fix manually.
  
  The main advantage for a site administrator is to easily create his own fix.
  This plugin presents an API, the SanityChecker interface that everyone interested by solving an issue can implement, and a kind of service provider process to automatically load the implementation. (please refer to the README.md : https://github.com/eviweb/moodle-local_sanitychecker)
  This latter feature is not in a final step and will evolved, but this evolution will be completly imperceptible to the end user.
  
  best regards
  
  Eric
  
• 

  Anthony Borrow

  Sat, 13 Apr 2013, 12:22 PM

  Eric - I had not considered restoring a backup and how that might corrupt data. I can see that this could be of use and provides a framework for any similar issues. It might be helpful to add to the description the tracker issue number. If further issues come up would you be willing to add the checks and fixes to this plugin and keep them all united? I'm going to go ahead and approve this plugin and thanks for your work on it. Peace - Anthony
• 

  Eric Villard

  Mon, 15 Apr 2013, 5:03 PM

  Hi Anthony,
  
  thanks for your help.
  
  I fixed the string concatenation issue, but I'm not aware of how checking only the updated file using AMOS.
  
  Regarding the provided sniffers, I created a list on github available here : https://github.com/eviweb/moodle-local_sanitychecker/wiki
  The README.md file is up to date with this link.
  I mentioned the reference of the issue actually solved in the related class and in its displayable description.
  
  And sure I am ok to integrate all checks and fixes that could be.
  Interested people just have to create a pull request on github.
  I have not enough time now, but it is planned to add unit tests and I am thinking about adding a compatibility test kit to check if provided implementations are correct or not.
  
  I have updated the plugin version, but let the status to ALPHA.
  How the downloadable version available here is kept up to date with the one available at github ?
  
  thanks for all
  
  Eric
• 

  Aparup Banerjee

  Wed, 17 Apr 2013, 11:32 AM

  Hi Eric,
  At the moment the plugin version zips here are not linked or updated automatically to any changes in github. You will have to upload (or use the github repository to browse) a newer version when its ready by creating a new version.
• 

  Eric Villard

  Thu, 18 Apr 2013, 5:15 PM

  Hi Aparup,
  
  thanks a lot for that precision. As my navigation block was extended, I missed the "Add a new version" link from the setting block
  
  Regarding version management, I've only seen an option to hide previous versions, but is there a way to completely delete obsolete ones ?
  
  best regards
  
  Eric
• 

  Aparup Banerjee

  Fri, 19 Apr 2013, 12:48 PM

  Yes i can delete them if you want. but we've the space for now. Atm there are some dependencies like reviews etc that may be unhandled by just deleting them.
• 

  Eric Villard

  Fri, 19 Apr 2013, 3:51 PM

  So I will hide them for now, thanks.
  
  Eric
• 

  Anthony Borrow

  Mon, 22 Apr 2013, 12:45 PM

  Eric - I am also pointing out to folks who use Github that Moodle has a file repository called Github that allows you to grab the zip file from github.com rather than having to download and upload it yourself. Simply make sure under advanced that you allow the system to rename the root folder. It is pretty slick and a real time saver. Peace - Anthony
• 

  Anthony Borrow

  Mon, 22 Apr 2013, 12:46 PM

  Eric - I am also pointing out to folks who use Github that Moodle has a file repository called Github that allows you to grab the zip file from github.com rather than having to download and upload it yourself. Simply make sure under advanced that you allow the system to rename the root folder. It is pretty slick and a real time saver. Peace - Anthony
• 

  Eric Villard

  Mon, 22 Apr 2013, 3:41 PM

  Hi Anthony,
  
  thanks for the trick.
  This was the way I used to upload previous versions.
  It is very handy ;)
  
  Best regards
  
  Eric
• 

  Germán Valero

  Thu, 5 Sep 2013, 11:45 PM

  Hi Eric,
  I just found about your Moodle sanity check add-on and I like it a lot.
  
  I created a Moodle documentation page at http://docs.moodle.org/25/en/local/sanitychecker/view , so that this page will pop when a user clicks on 'Moodle docs for this page' while using the plugin. Please feel free to add or correct whatever you think is necessary.
  
  Thanks for this nice plugin.
• 

  Eric Villard

  Fri, 6 Sep 2013, 3:41 PM

  Hi German,
  
  it's very nice of you, thanks.
  Feel free to give me your feedback or to ask for new fixes, if you are aware of some that could be added.
  
  Best regards
  
  Eric