Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(23 errors, 45 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/openlms/classes/dialog_form_trait.php
(#32) Line exceeds 132 characters; contains 167 characters
(#59) Line exceeds 132 characters; contains 144 characters
local/openlms/classes/external/form_autocomplete_field.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#107) Line exceeds 132 characters; contains 166 characters
local/openlms/classes/form/hook_callback_override.php
(#46) Line exceeds 132 characters; contains 133 characters
local/openlms/classes/form/hook_callback_reset.php
(#46) Line exceeds 132 characters; contains 133 characters
local/openlms/classes/form/notification_update.php
(#55) Inline comments must end in full-stops, exclamation marks, or question marks
local/openlms/classes/hook/manager.php
(#97) Line exceeds 132 characters; contains 148 characters
(#177) Line exceeds 132 characters; contains 135 characters
(#286) Line exceeds 132 characters; contains 141 characters
(#356) Line exceeds 132 characters; contains 142 characters
local/openlms/classes/notification/manager.php
(#175) Line exceeds 132 characters; contains 141 characters
(#180) Line exceeds 132 characters; contains 139 characters
(#189) Line exceeds 132 characters; contains 135 characters
(#190) Line exceeds 132 characters; contains 133 characters
local/openlms/classes/notification/util.php
(#91) Inline comments must end in full-stops, exclamation marks, or question marks
(#143) Inline comments must end in full-stops, exclamation marks, or question marks
local/openlms/classes/privacy/provider.php
(#62) Inline comments must end in full-stops, exclamation marks, or question marks
(#72) Inline comments must end in full-stops, exclamation marks, or question marks
(#81) Inline comments must end in full-stops, exclamation marks, or question marks
(#90) Inline comments must end in full-stops, exclamation marks, or question marks
(#99) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Inline comments must end in full-stops, exclamation marks, or question marks
local/openlms/db/caches.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/openlms/db/upgrade.php
(#64) Line exceeds 132 characters; contains 136 characters
local/openlms/notification/create.php
(#28) Inline doc block type-hinting for '$DB' does not match next code line 'if...'
(#29) Inline doc block type-hinting for '$PAGE' does not match next code line 'if...'
(#30) Inline doc block type-hinting for '$OUTPUT' does not match next code line 'if...'
(#31) Inline doc block type-hinting for '$CFG' does not match next code line 'if...'
(#33) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/openlms/notification/delete.php
(#28) Inline doc block type-hinting for '$DB' does not match next code line 'if...'
(#29) Inline doc block type-hinting for '$PAGE' does not match next code line 'if...'
(#30) Inline doc block type-hinting for '$OUTPUT' does not match next code line 'if...'
(#31) Inline doc block type-hinting for '$CFG' does not match next code line 'if...'
(#33) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/openlms/notification/update.php
(#28) Inline doc block type-hinting for '$DB' does not match next code line 'if...'
(#29) Inline doc block type-hinting for '$PAGE' does not match next code line 'if...'
(#30) Inline doc block type-hinting for '$OUTPUT' does not match next code line 'if...'
(#31) Inline doc block type-hinting for '$CFG' does not match next code line 'if...'
(#33) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/openlms/notification/view.php
(#28) Inline doc block type-hinting for '$DB' does not match next code line 'if...'
(#29) Inline doc block type-hinting for '$PAGE' does not match next code line 'if...'
(#30) Inline doc block type-hinting for '$OUTPUT' does not match next code line 'if...'
(#31) Inline doc block type-hinting for '$CFG' does not match next code line 'if...'
(#33) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#82) Line exceeds 132 characters; contains 136 characters
local/openlms/settings.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#28) Line exceeds 132 characters; contains 160 characters
local/openlms/tests/behat/behat_local_openlms.php
(#85) Line exceeds 132 characters; contains 147 characters
(#112) Line exceeds 132 characters; contains 136 characters
(#172) Line exceeds 132 characters; contains 173 characters
local/openlms/tests/hook/manager_test.php
(#35) Inline comments must end in full-stops, exclamation marks, or question marks
(#130) Line exceeds 132 characters; contains 156 characters
(#164) Line exceeds 132 characters; contains 162 characters
(#190) Line exceeds 132 characters; contains 156 characters
local/openlms/tests/notification/manager_test.php
(#36) Test method test_get_component() is missing any coverage information, own or at class level
local/openlms/tests/notification/notificationtype_test.php
(#36) Test method test_get_component() is missing any coverage information, own or at class level
(#40) Test method test_get_classname() is missing any coverage information, own or at class level
(#44) Test method test_format_subject() is missing any coverage information, own or at class level
(#59) Test method test_format_body() is missing any coverage information, own or at class level
local/openlms/tests/notification/util_test.php
(#36) Test method test_get_manager_classname() is missing any coverage information, own or at class level
(#43) Test method test_notification_create() is missing any coverage information, own or at class level
(#110) Test method test_notification_update() is missing any coverage information, own or at class level
(#192) Test method test_notification_delete() is missing any coverage information, own or at class level
(#225) Test method test_replace_placeholders() is missing any coverage information, own or at class level
(#235) Test method test_filter_multilang() is missing any coverage information, own or at class level
(#258) Test method test_filter_multilang2() is missing any coverage information, own or at class level
local/openlms/version.php
(#31) This comment is 50% valid code; is this commented out code?

Javascript coding style problems

(0 errors, 3 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/openlms/amd/src/dialog_form.js
(#169) The function binding is unnecessary. (no-extra-bind)
(#172) The function binding is unnecessary. (no-extra-bind)
(#355) The function binding is unnecessary. (no-extra-bind)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(11 errors, 28 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/openlms/classes/dialog_form_trait.php
(#32) Function dialog_form_trait::__construct is not documented
(#81) Function dialog_form_trait::render is not documented
(#54) Phpdocs for function dialog_form_trait::redirect_submitted has incomplete parameters list
local/openlms/classes/form/notification_create.php
(#28) Function notification_create::definition is not documented
(#59) Function notification_create::validation is not documented
local/openlms/classes/form/notification_delete.php
(#28) Function notification_delete::definition is not documented
(#56) Function notification_delete::validation is not documented
local/openlms/classes/form/notification_update.php
(#28) Function notification_update::definition is not documented
(#89) Function notification_update::validation is not documented
local/openlms/classes/notification/manager.php
(#44) Phpdocs for function manager::get_candidate_types has incomplete parameters list
(#84) Inline phpdocs tag not enclosed with curly brackets @link found
local/openlms/classes/output/dialog_form/action.php
(#48) Function action::__construct is not documented
(#54) Function action::set_after_submit is not documented
(#58) Function action::get_after_submit is not documented
(#62) Function action::get_form_url is not documented
(#66) Function action::get_title is not documented
(#70) Function action::set_dialog_name is not documented
(#74) Function action::get_dialog_name is not documented
(#78) Function action::is_disabled is not documented
(#82) Function action::set_disabled is not documented
local/openlms/classes/output/dialog_form/button.php
(#37) Function button::__construct is not documented
(#42) Function button::is_primary is not documented
(#46) Function button::set_primary is not documented
(#50) Function button::set_class is not documented
(#54) Function button::get_class is not documented
(#58) Function button::set_icon is not documented
(#62) Function button::get_icon is not documented
local/openlms/classes/output/dialog_form/icon.php
(#34) Function icon::__construct is not documented
(#39) Function icon::get_icon is not documented
(#43) Function icon::set_class is not documented
(#47) Function icon::get_class is not documented
local/openlms/classes/output/dialog_form/renderer.php
(#28) Function renderer::render_icon is not documented
(#54) Function renderer::render_button is not documented
local/openlms/db/install.php
(#17) File-level phpdocs block is not found
local/openlms/tests/behat/behat_local_openlms.php
(#107) There is no description in phpdocs for function skip_if_plugin_missing
(#60) Phpdocs for function behat_local_openlms::execute_scheduled_task has incomplete parameters list
(#107) Phpdocs for function behat_local_openlms::skip_if_plugin_missing has incomplete parameters list
(#121) Phpdocs for function behat_local_openlms::list_term_contains_text has incomplete parameters list
(#186) Phpdocs for function behat_local_openlms::list_term_note_contains_text has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 7 warnings)

This section shows problems detected in mustache templates [More info]

local/openlms/templates/dialog_form/button.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 3: Bad value “” for attribute “action” on element “form”: Must be non-empty. (<noscript><form method="get" action=""><butto)
local/openlms/templates/dialog_form/button_disabled.mustache
(#1) Example context missing (@template section not found.)
local/openlms/templates/dialog_form/button_legacy.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 3: Bad value “” for attribute “action” on element “form”: Must be non-empty. (d><body><form method="post" action=""><butt)
local/openlms/templates/dialog_form/icon.mustache
(#1) Example context missing (@template section not found.)
local/openlms/templates/dialog_form/icon_disabled.mustache
(#1) Example context missing (@template section not found.)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]