Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(422 errors, 199 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/o365/classes/adminsetting/tabs.php: (#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#139) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $url.
local/o365/classes/adminsetting/usersynccreationrestriction.php: (#75) Line exceeds 132 characters; contains 134 characters
local/o365/classes/adminsetting/usersyncoptions.php: (#86) Logical operator "or" is prohibited; use "||" instead; (#91) Short array syntax must be used to define arrays; (#94) Short array syntax must be used to define arrays; (#96) Short array syntax must be used to define arrays; (#97) Short array syntax must be used to define arrays
local/o365/classes/adminsetting/verifysetup.php: (#91) There should be a comma after the last array item in a multi-line array.; (#96) There should be a comma after the last array item in a multi-line array.
local/o365/classes/event/api_call_failed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/event/calendar_subscribed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/event/calendar_unsubscribed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/feature/calsync/form/element/calendar.php: (#59) Variable "elementName" must be all lower-case; (#59) Variable "elementLabel" must be all lower-case; (#61) Variable "elementName" must be all lower-case; (#61) Variable "elementLabel" must be all lower-case; (#75) Variable "elementName" must be all lower-case; (#75) Variable "elementLabel" must be all lower-case; (#76) Variable "elementName" must be all lower-case; (#76) Variable "elementLabel" must be all lower-case; (#98) Public method name "calendar::setValue" must be in lower-case letters only; (#115) Visibility must be declared on method "getHelpButton"; (#115) method name "calendar::getHelpButton" must be in lower-case letters only; (#115) Expected 1 space before opening brace; found 0; (#126) Public method name "calendar::exportValue" must be in lower-case letters only; (#126) Variable "submitValues" must be all lower-case; (#127) Variable "submitValues" must be all lower-case; (#136) Public method name "calendar::toHtml" must be in lower-case letters only
local/o365/classes/feature/calsync/form/subscriptions.php: (#115) There should be a comma after the last array item in a multi-line array.; (#119) Short array syntax must be used to define arrays; (#179) There should be a comma after the last array item in a multi-line array.; (#205) There should be a comma after the last array item in a multi-line array.; (#211) There should be a comma after the last array item in a multi-line array.; (#225) There should be a comma after the last array item in a multi-line array.; (#244) Short array syntax must be used to define arrays; (#250) There should be a comma after the last array item in a multi-line array.; (#276) There should be a comma after the last array item in a multi-line array.; (#300) There should be a comma after the last array item in a multi-line array.
local/o365/classes/feature/calsync/main.php: (#35) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#57) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $clientdata.; (#57) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $httpclient.; (#296) There should be a comma after the last array item in a multi-line array.; (#314) Empty CATCH statement detected; (#480) Empty CATCH statement detected; (#551) Short array syntax must be used to define arrays; (#557) Short array syntax must be used to define arrays; (#563) Short array syntax must be used to define arrays
local/o365/classes/feature/calsync/observers.php: (#78) There should be a comma after the last array item in a multi-line array.; (#79) There should be a comma after the last array item in a multi-line array.
local/o365/classes/feature/calsync/task/importfromoutlook.php: (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#114) Short array syntax must be used to define arrays; (#140) There should be a comma after the last array item in a multi-line array.
local/o365/classes/feature/calsync/task/syncoldevents.php: (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#127) Empty CATCH statement detected; (#270) Empty CATCH statement detected
local/o365/classes/feature/cohortsync/main.php: (#63) No one-line description found in phpdocs for docblock of function get_grouplist; (#63) There must not be a space before the colon in a return type declaration; (#74) No one-line description found in phpdocs for docblock of function get_cohortlist; (#74) There must not be a space before the colon in a return type declaration; (#100) There must not be a space before the colon in a return type declaration; (#139) There must not be a space before the colon in a return type declaration; (#154) There must not be a space before the colon in a return type declaration; (#167) There must not be a space before the colon in a return type declaration; (#180) There must not be a space before the colon in a return type declaration; (#200) There must not be a space before the colon in a return type declaration; (#211) There must not be a space before the colon in a return type declaration; (#233) There must not be a space before the colon in a return type declaration; (#292) There must not be a space before the colon in a return type declaration; (#325) There must not be a space before the colon in a return type declaration; (#369) There must not be a space before the colon in a return type declaration; (#388) There must not be a space before the colon in a return type declaration
local/o365/classes/feature/courserequest/main.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#39) Missing docblock for class main; (#40) Missing docblock for constant main::COURSE_REQUEST_STATUS_PENDING; (#41) Missing docblock for constant main::COURSE_REQUEST_STATUS_APPROVED; (#42) Missing docblock for constant main::COURSE_REQUEST_STATUS_REJECTED; (#73) There must not be a space before the colon in a return type declaration; (#89) There must not be a space before the colon in a return type declaration; (#200) There must not be a space before the colon in a return type declaration; (#303) There must not be a space before the colon in a return type declaration
local/o365/classes/feature/coursesync/main.php: (#36) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#115) There must not be a space before the colon in a return type declaration; (#122) There must not be a space before the colon in a return type declaration; (#257) There must not be a space before the colon in a return type declaration; (#349) There must not be a space before the colon in a return type declaration; (#444) Using an unparenthesized expression containing a "." before a "+" or "-" has been deprecated in PHP 7.4 and removed in PHP 8.0; (#501) There must not be a space before the colon in a return type declaration; (#757) There must not be a space before the colon in a return type declaration; (#840) There must not be a space before the colon in a return type declaration; (#1002) There must not be a space before the colon in a return type declaration; (#1031) There must not be a space before the colon in a return type declaration; (#1187) There must not be a space before the colon in a return type declaration; (#1241) There must not be a space before the colon in a return type declaration; (#1480) There must not be a space before the colon in a return type declaration; (#1498) There must not be a space before the colon in a return type declaration; (#1514) There must not be a space before the colon in a return type declaration; (#1637) Empty CATCH statement detected; (#1645) Empty CATCH statement detected; (#1670) Empty CATCH statement detected; (#1678) Empty CATCH statement detected; (#1698) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $connectedusers.; (#1698) There must not be a space before the colon in a return type declaration; (#1788) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#1789) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#1812) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#1813) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#1845) There must not be a space before the colon in a return type declaration; (#1860) There must not be a space before the colon in a return type declaration; (#1878) There must not be a space before the colon in a return type declaration; (#1922) There must not be a space before the colon in a return type declaration; (#1983) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#1984) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#1996) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#1997) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#2028) There must not be a space before the colon in a return type declaration
local/o365/classes/feature/coursesync/observers.php: (#49) There must not be a space before the colon in a return type declaration; (#89) Empty CATCH statement detected
local/o365/classes/feature/coursesync/utils.php: (#49) There must not be a space before the colon in a return type declaration; (#106) There must not be a space before the colon in a return type declaration; (#173) There must not be a space before the colon in a return type declaration; (#270) There must not be a space before the colon in a return type declaration; (#323) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $group.; (#370) There must not be a space before the colon in a return type declaration; (#383) There must not be a space before the colon in a return type declaration; (#431) Expected "foreach (...) {\n"; found "foreach(...){\n"; (#446) There must not be a space before the colon in a return type declaration; (#462) There must not be a space before the colon in a return type declaration; (#543) There must not be a space before the colon in a return type declaration; (#559) There must not be a space before the colon in a return type declaration; (#579) There must not be a space before the colon in a return type declaration; (#597) There must not be a space before the colon in a return type declaration; (#617) There must not be a space before the colon in a return type declaration; (#687) Empty CATCH statement detected; (#701) There must not be a space before the colon in a return type declaration; (#740) There must not be a space before the colon in a return type declaration; (#780) Must use "self::" for local static member reference; (#781) Must use "self::" for local static member reference; (#838) There must not be a space before the colon in a return type declaration
local/o365/classes/feature/sds/task/sync.php: (#36) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#47) There must not be a space before the colon in a return type declaration; (#57) There must not be a space before the colon in a return type declaration; (#441) There must not be a space before the colon in a return type declaration; (#461) A comma after the last array item in a single-line array is not allowed.; (#461) Commas (,) must be followed by white space.; (#466) Commas (,) must be followed by white space.; (#479) There must not be a space before the colon in a return type declaration; (#497) A comma after the last array item in a single-line array is not allowed.; (#497) Commas (,) must be followed by white space.; (#507) Commas (,) must be followed by white space.; (#518) There must not be a space before the colon in a return type declaration; (#574) Empty CATCH statement detected
local/o365/classes/feature/sds/utils.php: (#46) There must not be a space before the colon in a return type declaration; (#72) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $apiclient.; (#72) There must not be a space before the colon in a return type declaration; (#115) There must not be a space before the colon in a return type declaration
local/o365/classes/feature/userconnections/filtering.php: (#86) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $params.; (#89) Short array syntax must be used to define arrays
local/o365/classes/feature/usersync/main.php: (#71) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $clientdata.; (#71) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $httpclient.; (#193) Short array syntax must be used to define arrays; (#237) Short array syntax must be used to define arrays; (#566) Line exceeds 132 characters; contains 135 characters; (#806) The use of goto labels is forbidden; (#1015) Short array syntax must be used to define arrays; (#1161) Line exceeds 132 characters; contains 136 characters; (#1261) Line exceeds 132 characters; contains 138 characters; (#1284) Line exceeds 132 characters; contains 148 characters; (#1324) Line exceeds 132 characters; contains 136 characters; (#1610) Line exceeds 132 characters; contains 154 characters
local/o365/classes/form/cohortsync.php: (#46) There must not be a space before the colon in a return type declaration
local/o365/classes/form/courserequestform.php: (#47) Visibility must be declared on method "definition"; (#111) Inline comments must end in full-stops, exclamation marks, or question marks; (#121) Inline comments must end in full-stops, exclamation marks, or question marks; (#151) There must not be a space before the colon in a return type declaration
local/o365/classes/form/teamstabconfiguration.php: (#55) Short array syntax must be used to define arrays; (#65) Short array syntax must be used to define arrays; (#87) Short array syntax must be used to define arrays
local/o365/classes/healthcheck/healthcheckinterface.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#34) Missing docblock for constant healthcheckinterface::SEVERITY_OK; (#35) Missing docblock for constant healthcheckinterface::SEVERITY_TRIVIAL; (#36) Missing docblock for constant healthcheckinterface::SEVERITY_WARNING; (#37) Missing docblock for constant healthcheckinterface::SEVERITY_FATAL
local/o365/classes/healthcheck/ratelimit.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/httpclient.php: (#94) Short array syntax must be used to define arrays; (#98) Short array syntax must be used to define arrays; (#123) Short array syntax must be used to define arrays; (#127) Short array syntax must be used to define arrays; (#152) Short array syntax must be used to define arrays; (#152) Short array syntax must be used to define arrays; (#172) Short array syntax must be used to define arrays; (#187) Short array syntax must be used to define arrays; (#188) Short array syntax must be used to define arrays
local/o365/classes/httpclientinterface.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#42) Short array syntax must be used to define arrays; (#52) Short array syntax must be used to define arrays; (#52) Short array syntax must be used to define arrays; (#62) Short array syntax must be used to define arrays; (#72) Short array syntax must be used to define arrays; (#72) Short array syntax must be used to define arrays
local/o365/classes/oauth2/apptoken.php: (#114) There should be a comma after the last array item in a multi-line array.; (#136) There should be a comma after the last array item in a multi-line array.; (#171) There should be a comma after the last array item in a multi-line array.
local/o365/classes/oauth2/clientdata.php: (#50) Expected "bool" but found "boolean" for @var tag in member variable comment
local/o365/classes/oauth2/token.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#210) There should be a comma after the last array item in a multi-line array.; (#263) There should be a comma after the last array item in a multi-line array.; (#285) There should be a comma after the last array item in a multi-line array.; (#415) There should be a comma after the last array item in a multi-line array.; (#439) There should be a comma after the last array item in a multi-line array.
local/o365/classes/obj/o365user.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/observers.php: (#84) There must not be a space before the colon in a return type declaration; (#147) Empty CATCH statement detected; (#175) There must not be a space before the colon in a return type declaration; (#272) There must not be a space before the colon in a return type declaration; (#300) There must not be a space before the colon in a return type declaration; (#324) There must not be a space before the colon in a return type declaration; (#344) There must not be a space before the colon in a return type declaration; (#420) There must not be a space before the colon in a return type declaration; (#445) There must not be a space before the colon in a return type declaration; (#508) Inline comments must end in full-stops, exclamation marks, or question marks; (#513) Inline comments must end in full-stops, exclamation marks, or question marks; (#517) Inline comments must end in full-stops, exclamation marks, or question marks; (#554) There must not be a space before the colon in a return type declaration; (#583) There must not be a space before the colon in a return type declaration; (#617) There must not be a space before the colon in a return type declaration; (#650) There must not be a space before the colon in a return type declaration; (#679) There must not be a space before the colon in a return type declaration; (#737) There must not be a space before the colon in a return type declaration; (#760) There must not be a space before the colon in a return type declaration; (#777) There must not be a space before the colon in a return type declaration; (#846) There must not be a space before the colon in a return type declaration
local/o365/classes/page/acp.php: (#123) Commas (,) must be followed by white space.; (#138) There must not be a space before the colon in a return type declaration; (#307) Commas (,) must be followed by white space.; (#601) A comma after the last array item in a single-line array is not allowed.; (#601) Commas (,) must be followed by white space.; (#630) A comma after the last array item in a single-line array is not allowed.; (#630) Commas (,) must be followed by white space.; (#710) Whitespace found at end of line within string; (#882) A comma after the last array item in a single-line array is not allowed.; (#882) Commas (,) must be followed by white space.; (#911) A comma after the last array item in a single-line array is not allowed.; (#911) Commas (,) must be followed by white space.; (#1016) A comma after the last array item in a single-line array is not allowed.; (#1016) Commas (,) must be followed by white space.; (#1731) Commas (,) must be followed by white space.; (#1754) There must not be a space before the colon in a return type declaration; (#1832) A comma after the last array item in a single-line array is not allowed.; (#1832) Commas (,) must be followed by white space.; (#1839) A comma after the last array item in a single-line array is not allowed.; (#1839) Commas (,) must be followed by white space.; (#1874) A comma after the last array item in a single-line array is not allowed.; (#1874) Commas (,) must be followed by white space.; (#1910) A comma after the last array item in a single-line array is not allowed.; (#1910) Commas (,) must be followed by white space.
local/o365/classes/page/ajax.php: (#39) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#364) Short array syntax must be used to define arrays; (#389) Short array syntax must be used to define arrays; (#390) There should be a comma after the last array item in a multi-line array.
local/o365/classes/page/base.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/privacy/provider.php: (#28) Import statements must not begin with a leading backslash; (#29) Import statements must not begin with a leading backslash; (#30) Import statements must not begin with a leading backslash; (#31) Import statements must not begin with a leading backslash; (#35) Missing docblock for interface local_o365_userlist; (#52) There must not be a space before the colon in a return type declaration; (#135) There must not be a space before the colon in a return type declaration; (#176) There should be a comma after the last array item in a multi-line array.; (#273) There must not be a space before the colon in a return type declaration
local/o365/classes/rest/o365api.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#347) A comma after the last array item in a single-line array is not allowed.; (#347) Commas (,) must be followed by white space.
local/o365/classes/rest/unified.php: (#56) There must not be a space before the colon in a return type declaration; (#66) There must not be a space before the colon in a return type declaration; (#95) There must not be a space before the colon in a return type declaration; (#208) Whitespace found at end of line; (#239) There must not be a space before the colon in a return type declaration; (#257) There must not be a space before the colon in a return type declaration; (#304) There must not be a space before the colon in a return type declaration; (#322) There must not be a space before the colon in a return type declaration; (#340) There must not be a space before the colon in a return type declaration; (#346) A comma after the last array item in a single-line array is not allowed.; (#346) Commas (,) must be followed by white space.; (#368) There must not be a space before the colon in a return type declaration; (#383) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $mailnickname.; (#383) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $extra.; (#383) There must not be a space before the colon in a return type declaration; (#446) There must not be a space before the colon in a return type declaration; (#477) There must not be a space before the colon in a return type declaration; (#490) There must not be a space before the colon in a return type declaration; (#514) Empty CATCH statement detected; (#556) There must not be a space before the colon in a return type declaration; (#583) There must not be a space before the colon in a return type declaration; (#596) There must not be a space before the colon in a return type declaration; (#608) There must not be a space before the colon in a return type declaration; (#621) There must not be a space before the colon in a return type declaration; (#636) There must not be a space before the colon in a return type declaration; (#667) There must not be a space before the colon in a return type declaration; (#681) There must not be a space before the colon in a return type declaration; (#695) There must not be a space before the colon in a return type declaration; (#736) There must not be a space before the colon in a return type declaration; (#753) There must not be a space before the colon in a return type declaration; (#771) There must not be a space before the colon in a return type declaration; (#791) There must not be a space before the colon in a return type declaration; (#811) There must not be a space before the colon in a return type declaration; (#835) There must not be a space before the colon in a return type declaration; (#853) There must not be a space before the colon in a return type declaration; (#867) There must not be a space before the colon in a return type declaration; (#872) Commas (,) must be followed by white space.; (#887) There must not be a space before the colon in a return type declaration; (#915) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $deltatoken.; (#915) There must not be a space before the colon in a return type declaration; (#964) There must not be a space before the colon in a return type declaration; (#983) There must not be a space before the colon in a return type declaration; (#995) There must not be a space before the colon in a return type declaration; (#1008) There must not be a space before the colon in a return type declaration; (#1021) There must not be a space before the colon in a return type declaration; (#1035) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $types.; (#1035) There must not be a space before the colon in a return type declaration; (#1053) There must not be a space before the colon in a return type declaration; (#1071) There must not be a space before the colon in a return type declaration; (#1084) There must not be a space before the colon in a return type declaration; (#1098) There must not be a space before the colon in a return type declaration; (#1112) There must not be a space before the colon in a return type declaration; (#1135) There must not be a space before the colon in a return type declaration; (#1164) There must not be a space before the colon in a return type declaration; (#1188) There should be a comma after the last array item in a multi-line array.; (#1241) There should be a comma after the last array item in a multi-line array.; (#1265) There must not be a space before the colon in a return type declaration; (#1290) There must not be a space before the colon in a return type declaration; (#1303) A comma after the last array item in a single-line array is not allowed.; (#1303) Commas (,) must be followed by white space.; (#1306) A comma after the last array item in a single-line array is not allowed.; (#1306) Commas (,) must be followed by white space.; (#1315) A comma after the last array item in a single-line array is not allowed.; (#1315) Commas (,) must be followed by white space.; (#1332) There must not be a space before the colon in a return type declaration; (#1351) There must not be a space before the colon in a return type declaration; (#1372) There must not be a space before the colon in a return type declaration; (#1404) There must not be a space before the colon in a return type declaration; (#1431) There must not be a space before the colon in a return type declaration; (#1443) There must not be a space before the colon in a return type declaration; (#1455) There must not be a space before the colon in a return type declaration; (#1468) There must not be a space before the colon in a return type declaration; (#1478) There must not be a space before the colon in a return type declaration; (#1492) There must not be a space before the colon in a return type declaration; (#1506) There must not be a space before the colon in a return type declaration; (#1523) There must not be a space before the colon in a return type declaration; (#1545) There must not be a space before the colon in a return type declaration; (#1562) There must not be a space before the colon in a return type declaration; (#1606) There must not be a space before the colon in a return type declaration; (#1628) There must not be a space before the colon in a return type declaration; (#1652) There must not be a space before the colon in a return type declaration; (#1666) There must not be a space before the colon in a return type declaration; (#1680) There must not be a space before the colon in a return type declaration; (#1732) There must not be a space before the colon in a return type declaration; (#1824) There must not be a space before the colon in a return type declaration; (#1839) There must not be a space before the colon in a return type declaration; (#1854) A comma after the last array item in a single-line array is not allowed.; (#1854) Commas (,) must be followed by white space.; (#1874) There must not be a space before the colon in a return type declaration; (#1876) A comma after the last array item in a single-line array is not allowed.; (#1876) Commas (,) must be followed by white space.; (#1895) There must not be a space before the colon in a return type declaration; (#1917) There must not be a space before the colon in a return type declaration; (#1941) There must not be a space before the colon in a return type declaration; (#1949) Commas (,) must be followed by white space.; (#1961) There must not be a space before the colon in a return type declaration; (#1964) A comma after the last array item in a single-line array is not allowed.; (#1964) Commas (,) must be followed by white space.; (#2010) There must not be a space before the colon in a return type declaration; (#2025) There must not be a space before the colon in a return type declaration; (#2038) There must not be a space before the colon in a return type declaration; (#2051) There must not be a space before the colon in a return type declaration; (#2064) There must not be a space before the colon in a return type declaration; (#2077) There must not be a space before the colon in a return type declaration; (#2088) There must not be a space before the colon in a return type declaration; (#2126) There must not be a space before the colon in a return type declaration; (#2201) There must not be a space before the colon in a return type declaration; (#2282) There must not be a space before the colon in a return type declaration
local/o365/classes/task/cohortsync.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#43) There must not be a space before the colon in a return type declaration; (#52) There must not be a space before the colon in a return type declaration; (#72) There must not be a space before the colon in a return type declaration
local/o365/classes/task/coursemembershipsync.php: (#48) There must not be a space before the colon in a return type declaration; (#57) There must not be a space before the colon in a return type declaration
local/o365/classes/task/coursesync.php: (#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/task/groupmembershipsync.php: (#70) File must end with a newline character
local/o365/classes/task/notifysecretexpiry.php: (#37) Missing docblock for class notifysecretexpiry; (#43) There must not be a space before the colon in a return type declaration; (#52) There must not be a space before the colon in a return type declaration; (#142) There must not be a space before the colon in a return type declaration; (#164) There must not be a space before the colon in a return type declaration
local/o365/classes/task/processcourserequestapproval.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#46) There must not be a space before the colon in a return type declaration
local/o365/classes/task/processmatchqueue.php: (#54) There must not be a space before the colon in a return type declaration; (#82) There must not be a space before the colon in a return type declaration
local/o365/classes/task/updatecourserequeststatus.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/task/usersync.php: (#34) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#181) Expected "if (...) {\n"; found "if(...) {\n"; (#189) Line exceeds 132 characters; contains 137 characters; (#195) Line exceeds 132 characters; contains 137 characters; (#279) Line exceeds 132 characters; contains 133 characters
local/o365/classes/tests/mockhttpclient.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#87) Short array syntax must be used to define arrays
local/o365/classes/utils.php: (#48) Missing docblock for constant utils::RESOURCE_NOT_EXIST_ERROR; (#79) Must use "self::" for local static member reference; (#161) There must not be a space before the colon in a return type declaration; (#253) The use of function print_r() is forbidden; (#255) The use of function print_r() is forbidden; (#290) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $userid.; (#496) There must not be a space before the colon in a return type declaration; (#508) Empty CATCH statement detected; (#532) Empty CATCH statement detected; (#557) There must not be a space before the colon in a return type declaration; (#577) There must not be a space before the colon in a return type declaration; (#649) There must not be a space before the colon in a return type declaration; (#680) Expected 1 space before opening brace; found 2; (#693) There must not be a space before the colon in a return type declaration
local/o365/classes/webservices/create_onenoteassignment.php: (#57) There should be a comma after the last array item in a multi-line array.; (#92) Duplicate array key found. The value will be overwritten. The string array key "grade" was first seen on line 84
local/o365/classes/webservices/delete_onenoteassignment.php: (#53) There should be a comma after the last array item in a multi-line array.
local/o365/classes/webservices/exception/assignnotfound.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/couldnotsavegrade.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/invalidassignment.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/modulenotfound.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/sectionnotfound.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/read_assignments.php: (#83) There should be a comma after the last array item in a multi-line array.; (#106) Short array syntax must be used to define arrays; (#110) There should be a comma after the last array item in a multi-line array.; (#115) Short array syntax must be used to define arrays; (#116) Short array syntax must be used to define arrays; (#134) Short array syntax must be used to define arrays; (#138) There should be a comma after the last array item in a multi-line array.; (#159) Short array syntax must be used to define arrays; (#163) There should be a comma after the last array item in a multi-line array.; (#196) Short array syntax must be used to define arrays; (#199) Short array syntax must be used to define arrays; (#214) Short array syntax must be used to define arrays; (#218) There should be a comma after the last array item in a multi-line array.; (#222) Short array syntax must be used to define arrays; (#223) Short array syntax must be used to define arrays; (#225) Short array syntax must be used to define arrays; (#231) There should be a comma after the last array item in a multi-line array.; (#236) Short array syntax must be used to define arrays; (#262) There should be a comma after the last array item in a multi-line array.; (#277) Short array syntax must be used to define arrays; (#281) Short array syntax must be used to define arrays; (#285) There should be a comma after the last array item in a multi-line array.; (#294) Short array syntax must be used to define arrays; (#299) There should be a comma after the last array item in a multi-line array.; (#303) Short array syntax must be used to define arrays; (#305) There should be a comma after the last array item in a multi-line array.; (#318) Short array syntax must be used to define arrays; (#350) Short array syntax must be used to define arrays; (#353) There should be a comma after the last array item in a multi-line array.; (#356) There should be a comma after the last array item in a multi-line array.; (#368) Short array syntax must be used to define arrays; (#374) There should be a comma after the last array item in a multi-line array.; (#387) Short array syntax must be used to define arrays; (#392) There should be a comma after the last array item in a multi-line array.; (#405) Short array syntax must be used to define arrays; (#409) There should be a comma after the last array item in a multi-line array.
local/o365/classes/webservices/read_courseusers.php: (#111) Empty IF statement detected
local/o365/classes/webservices/read_onenoteassignment.php: (#53) There should be a comma after the last array item in a multi-line array.
local/o365/classes/webservices/read_teachercourses.php: (#76) There should be a comma after the last array item in a multi-line array.; (#117) There should be a comma after the last array item in a multi-line array.
local/o365/classes/webservices/update_grade.php: (#56) Short array syntax must be used to define arrays; (#67) Short array syntax must be used to define arrays; (#73) Short array syntax must be used to define arrays; (#78) Short array syntax must be used to define arrays; (#80) There should be a comma after the last array item in a multi-line array.; (#89) Short array syntax must be used to define arrays; (#99) Short array syntax must be used to define arrays; (#101) Short array syntax must be used to define arrays; (#101) There should be a comma after the last array item in a multi-line array.; (#129) Short array syntax must be used to define arrays; (#130) Short array syntax must be used to define arrays; (#134) Short array syntax must be used to define arrays; (#159) Short array syntax must be used to define arrays; (#162) Short array syntax must be used to define arrays; (#189) There should be a comma after the last array item in a multi-line array.
local/o365/classes/webservices/update_onenoteassignment.php: (#58) There should be a comma after the last array item in a multi-line array.
local/o365/classes/webservices/utils.php: (#31) Import statements must not begin with a leading backslash; (#34) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/db/access.php: (#35) There should be a comma after the last array item in a multi-line array.
local/o365/db/caches.php: (#30) There should be a comma after the last array item in a multi-line array.
local/o365/db/services.php: (#106) There should be a comma after the last array item in a multi-line array.
local/o365/db/tasks.php: (#36) There should be a comma after the last array item in a multi-line array.; (#45) There should be a comma after the last array item in a multi-line array.; (#54) There should be a comma after the last array item in a multi-line array.; (#63) There should be a comma after the last array item in a multi-line array.; (#72) There should be a comma after the last array item in a multi-line array.; (#90) There should be a comma after the last array item in a multi-line array.; (#99) There should be a comma after the last array item in a multi-line array.
local/o365/db/upgrade.php: (#386) Short array syntax must be used to define arrays; (#409) Short array syntax must be used to define arrays; (#410) Short array syntax must be used to define arrays; (#486) Short array syntax must be used to define arrays; (#505) There should be a comma after the last array item in a multi-line array.; (#531) There should be a comma after the last array item in a multi-line array.; (#635) This comment is 67% valid code; is this commented out code?; (#646) This comment is 62% valid code; is this commented out code?; (#661) Inline comments must end in full-stops, exclamation marks, or question marks; (#1067) Empty CATCH statement detected; (#1216) Functions must not contain multiple empty lines in a row; found 2 empty lines
local/o365/export_manifest.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/lang/en/local_o365.php: (#170) Whitespace found at end of line within string; (#183) Whitespace found at end of line within string; (#196) Whitespace found at end of line within string; (#208) Whitespace found at end of line within string; (#1003) Whitespace found at end of line within string
local/o365/lib.php: (#36) Missing docblock for constant COURSE_SYNC_RESET_SITE_SETTING_DO_NOTHING; (#37) Missing docblock for constant COURSE_SYNC_RESET_SITE_SETTING_PER_COURSE; (#38) Missing docblock for constant COURSE_SYNC_RESET_SITE_SETTING_DISCONNECT_AND_CREATE_NEW; (#39) Missing docblock for constant COURSE_SYNC_RESET_SITE_SETTING_DISCONNECT_ONLY; (#42) Missing docblock for constant COURSE_SYNC_RESET_COURSE_SETTING_DO_NOTHING; (#43) Missing docblock for constant COURSE_SYNC_RESET_COURSE_SETTING_DISCONNECT_AND_CREATE_NEW; (#44) Missing docblock for constant COURSE_SYNC_RESET_COURSE_SETTING_DISCONNECT_ONLY; (#47) Missing docblock for constant MICROSOFT365_COURSE_SYNC_DISABLED; (#48) Missing docblock for constant MICROSOFT365_COURSE_SYNC_ENABLED; (#51) Missing docblock for constant LOCAL_O365_TAB_SETUP; (#52) Missing docblock for constant LOCAL_O365_TAB_SYNC; (#53) Missing docblock for constant LOCAL_O365_TAB_ADVANCED; (#54) Missing docblock for constant LOCAL_O365_TAB_SDS; (#55) Missing docblock for constant LOCAL_O365_TAB_TEAMS; (#56) Missing docblock for constant LOCAL_O365_TAB_MOODLE_APP; (#59) Missing docblock for constant MICROSOFT365_GROUP_ROLE_OWNER; (#60) Missing docblock for constant MICROSOFT365_GROUP_ROLE_MEMBER; (#63) Missing docblock for constant TEAM_LOCKED_STATUS_UNKNOWN; (#64) Missing docblock for constant TEAM_LOCKED; (#65) Missing docblock for constant TEAM_UNLOCKED; (#68) Missing docblock for constant EDUCATION_LICENSE_IDS; (#71) Missing docblock for constant SDS_SCHOOL_DISABLED_ACTION_KEEP_CONNECTED; (#72) Missing docblock for constant SDS_SCHOOL_DISABLED_ACTION_DISCONNECT; (#75) Missing docblock for constant COURSE_USER_SYNC_DIRECTION_MOODLE_TO_TEAMS; (#76) Missing docblock for constant COURSE_USER_SYNC_DIRECTION_TEAMS_TO_MOODLE; (#77) Missing docblock for constant COURSE_USER_SYNC_DIRECTION_BOTH; (#123) There must not be a space before the colon in a return type declaration; (#286) Whitespace found at end of line
local/o365/settings.php: (#300) Inline comments must end in full-stops, exclamation marks, or question marks
local/o365/sso_end.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/sso_login.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/sso_start.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/teams_tab.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#61) Short array syntax must be used to define arrays; (#64) Short array syntax must be used to define arrays
local/o365/teams_tab_configuration.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/teams_tab_redirect.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/tests/coursesyncutils_test.php: (#38) PHPUnit testcase name "local_o365_coursesyncutils_testcase" does not match file name "coursesyncutils_test"; (#38) PHPUnit class "local_o365_coursesyncutils_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested; (#42) There must not be a space before the colon in a return type declaration; (#50) Test method test_is_enabled() is missing any coverage information, own or at class level; (#75) Test method test_get_enabled_courses() is missing any coverage information, own or at class level; (#104) Test method test_course_is_group_enabled() is missing any coverage information, own or at class level
local/o365/tests/observers_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#35) PHPUnit testcase name "local_o365_observers_testcase" does not match file name "observers_test"; (#35) PHPUnit class "local_o365_observers_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested; (#39) There must not be a space before the colon in a return type declaration; (#47) Test method test_user_disconnected() is missing any coverage information, own or at class level; (#61) Test method test_user_deleted() is missing any coverage information, own or at class level
local/o365/tests/privacy_provider_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#28) Import statements must not begin with a leading backslash; (#38) PHPUnit testcase name "local_o365_privacy_testcase" does not match file name "privacy_provider_test"; (#38) PHPUnit class "local_o365_privacy_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested; (#42) There must not be a space before the colon in a return type declaration; (#50) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level; (#69) Test method test_get_users_in_context() is missing any coverage information, own or at class level; (#101) Test method test_export_user_data() is missing any coverage information, own or at class level; (#118) There should be a comma after the last array item in a multi-line array.; (#129) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level; (#166) Test method test_delete_data_for_user() is missing any coverage information, own or at class level; (#204) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
local/o365/tests/token_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#35) PHPUnit testcase name "local_o365_oauth2_token_testcase" does not match file name "token_test"; (#35) PHPUnit class "local_o365_oauth2_token_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested; (#39) There must not be a space before the colon in a return type declaration; (#47) Test method test_refresh() is missing any coverage information, own or at class level; (#67) There should be a comma after the last array item in a multi-line array.
local/o365/tests/usersync_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#35) PHPUnit testcase name "local_o365_usersync_testcase" does not match file name "usersync_test"; (#35) PHPUnit class "local_o365_usersync_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested; (#39) There must not be a space before the colon in a return type declaration; (#54) There should be a comma after the last array item in a multi-line array.; (#241) Test method test_create_user_from_entra_id_data() is missing any coverage information, own or at class level; (#261) Test method test_sync_users_create() is missing any coverage information, own or at class level; (#273) There should be a comma after the last array item in a multi-line array.
local/o365/tests/webservices_onenoteassignment_test.php: (#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#37) PHPUnit testcase name "local_o365_webservices_onenoteassignment_testcase" does not match file name "webservices_onenoteassignment_test"; (#37) PHPUnit class "local_o365_webservices_onenoteassignment_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested; (#40) Missing docblock for constant local_o365_webservices_onenoteassignment_testcase::DBSTATE; (#41) Missing docblock for constant local_o365_webservices_onenoteassignment_testcase::PARAMS; (#42) Missing docblock for constant local_o365_webservices_onenoteassignment_testcase::EXPECTEDRETURN; (#43) Missing docblock for constant local_o365_webservices_onenoteassignment_testcase::EXPECTEDEXCEPTION; (#48) There must not be a space before the colon in a return type declaration; (#56) Test method test_assignment_create_parameters() is missing any coverage information, own or at class level; (#98) Test method test_assignment_create() is missing any coverage information, own or at class level; (#133) Test method test_assignment_create_returns() is missing any coverage information, own or at class level; (#142) Test method test_assignment_read_parameters() is missing any coverage information, own or at class level; (#157) Short array syntax must be used to define arrays; (#276) Short array syntax must be used to define arrays; (#300) Test method test_assignment_read() is missing any coverage information, own or at class level; (#330) Test method test_assignment_read_returns() is missing any coverage information, own or at class level; (#339) Test method test_assignment_update_parameters() is missing any coverage information, own or at class level; (#357) Short array syntax must be used to define arrays; (#362) Short array syntax must be used to define arrays; (#365) Short array syntax must be used to define arrays; (#469) Test method test_assignment_update() is missing any coverage information, own or at class level; (#500) Test method test_assignment_update_returns() is missing any coverage information, own or at class level; (#509) Test method test_assignment_delete_parameters() is missing any coverage information, own or at class level; (#542) Test method test_assignment_delete() is missing any coverage information, own or at class level; (#570) Test method test_assignment_delete_returns() is missing any coverage information, own or at class level
local/o365/tests/webservices_utils_test.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#36) PHPUnit testcase name "local_o365_webservices_utils_testcase" does not match file name "webservices_utils_test"; (#36) PHPUnit class "local_o365_webservices_utils_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested; (#41) There must not be a space before the colon in a return type declaration; (#273) Test method test_get_assignment_info() is missing any coverage information, own or at class level; (#368) Test method test_verify_assignment() is missing any coverage information, own or at class level; (#421) Test method test_get_assignment_return_info_schema() is missing any coverage information, own or at class level; (#468) Test method test_get_assignment_return_info() is missing any coverage information, own or at class level

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

Overview

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems