Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(38 errors, 124 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/o365/classes/adminsetting/aadsyncoptions.php
(#86) Logical operator "or" is prohibited; use "||" instead
local/o365/classes/adminsetting/systemapiuser.php
(#101) Empty CATCH statement detected
local/o365/classes/adminsetting/tabs.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/botintent.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#58) Line exceeds 132 characters; contains 145 characters
(#64) Line exceeds 132 characters; contains 143 characters
(#68) Line exceeds 132 characters; contains 134 characters
(#78) Line exceeds 132 characters; contains 160 characters
(#95) Line exceeds 132 characters; contains 135 characters
(#98) Line indented incorrectly; expected 16 spaces, found 20
(#100) Line indented incorrectly; expected 16 spaces, found 20
(#102) Line indented incorrectly; expected 16 spaces, found 20
local/o365/classes/bot/intents/absentstudents.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/assignmentcomparison.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/dueassignments.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/o365/classes/bot/intents/help.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/incompleteassignments.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/intentinterface.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/laststudentlogin.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/latestgrades.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/lateststudents.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/recentstudents.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/event/api_call_failed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/event/calendar_subscribed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/event/calendar_unsubscribed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/feature/calsync/form/element/calendar.php
(#59) Variable "elementName" must be all lower-case
(#59) Variable "elementLabel" must be all lower-case
(#61) Variable "elementName" must be all lower-case
(#61) Variable "elementLabel" must be all lower-case
(#75) Variable "elementName" must be all lower-case
(#75) Variable "elementLabel" must be all lower-case
(#76) Variable "elementName" must be all lower-case
(#76) Variable "elementLabel" must be all lower-case
(#98) Public method name "calendar::setValue" must be in lower-case letters only
(#115) Visibility must be declared on method "getHelpButton"
(#115) method name "calendar::getHelpButton" must be in lower-case letters only
(#115) Expected 1 space before opening brace; found 0
(#126) Public method name "calendar::exportValue" must be in lower-case letters only
(#126) Variable "submitValues" must be all lower-case
(#127) Variable "submitValues" must be all lower-case
(#136) Public method name "calendar::toHtml" must be in lower-case letters only
local/o365/classes/feature/calsync/main.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/feature/calsync/task/importfromoutlook.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/feature/calsync/task/syncoldevents.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/feature/sds/task/sync.php
(#36) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#531) Commas (,) must be followed by white space.
(#536) Commas (,) must be followed by white space.
(#567) Commas (,) must be followed by white space.
(#577) Commas (,) must be followed by white space.
(#653) Empty CATCH statement detected
local/o365/classes/feature/sharepointcustom/utils.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/feature/usergroups/utils.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#136) Logical operator "and" is prohibited; use "&&" instead
(#263) Logical operator "and" is prohibited; use "&&" instead
(#486) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
local/o365/classes/form/groupedit.php
(#136) Logical operator "and" is prohibited; use "&&" instead
local/o365/classes/healthcheck/healthcheckinterface.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/healthcheck/ratelimit.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/healthcheck/systemapiuser.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/httpclientinterface.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/oauth2/apptoken.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/oauth2/clientdata.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/oauth2/systemapiusertoken.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/oauth2/systemtoken.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/oauth2/token.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#171) Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$userid" was used, and possibly changed (by reference), on line 158.
local/o365/classes/obj/o365user.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/observers.php
(#122) Empty CATCH statement detected
local/o365/classes/page/acp.php
(#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/page/ajax.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/page/base.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/page/groupcp.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#70) Logical operator "and" is prohibited; use "&&" instead
(#111) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#115) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#232) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#237) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#242) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#245) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#251) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#254) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#275) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#282) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#379) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#384) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#393) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
local/o365/classes/rest/azuread.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/botframework.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/calendar.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/discovery.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/o365api.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/onedrive.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/onenote.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/outlook.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/sharepoint.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#844) Empty CATCH statement detected
local/o365/classes/rest/unified.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#439) Empty CATCH statement detected
(#1033) Whitespace found at end of line
local/o365/classes/task/bot.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#93) Inline comments must start with a capital letter, digit or 3-dots sequence
local/o365/classes/task/groupcreate.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/task/refreshsystemrefreshtoken.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/task/sharepointaccesssync.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/task/sharepointinit.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#55) This comment is 43% valid code; is this commented out code?
(#157) Inline comments must start with a capital letter, digit or 3-dots sequence
local/o365/classes/task/usersync.php
(#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#219) Expected "if (...) {\n"; found "if(...) {\n"
local/o365/classes/tests/mockhttpclient.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/tests/mocksharepoint.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#42) Possible useless method overriding detected
local/o365/classes/utils.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#258) The use of function print_r() is forbidden
(#260) The use of function print_r() is forbidden
(#487) Empty CATCH statement detected
(#513) Empty CATCH statement detected
local/o365/classes/webservices/exception/assignnotfound.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/couldnotsavegrade.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/invalidassignment.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/modulenotfound.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/sectionnotfound.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/read_bot_message.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/read_courseusers.php
(#101) Empty IF statement detected
local/o365/classes/webservices/utils.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/export_manifest.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#45) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
local/o365/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#388) The use of backticks in strings is not recommended
(#458) Whitespace found at end of line within string
local/o365/sso_end.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/sso_login.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/sso_start.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/teams_tab.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/teams_tab_configuration.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/teams_tab_redirect.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#29) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
local/o365/tests/coursegroups_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) PHPUnit testcase name "local_o365_coursegroups_testcase" does not match file name "coursegroups_test"
(#34) PHPUnit class "local_o365_coursegroups_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
(#140) Commas (,) must be followed by white space.
local/o365/tests/observers_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) PHPUnit testcase name "local_o365_observers_testcase" does not match file name "observers_test"
(#35) PHPUnit class "local_o365_observers_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/privacy_provider_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) PHPUnit testcase name "local_o365_privacy_testcase" does not match file name "privacy_provider_test"
(#38) PHPUnit class "local_o365_privacy_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/token_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) PHPUnit testcase name "local_o365_oauth2_token_testcase" does not match file name "token_test"
(#35) PHPUnit class "local_o365_oauth2_token_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/usergroupsutils_test.php
(#38) PHPUnit testcase name "local_o365_usergroupsutils_testcase" does not match file name "usergroupsutils_test"
(#38) PHPUnit class "local_o365_usergroupsutils_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/usersync_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) PHPUnit testcase name "local_o365_usersync_testcase" does not match file name "usersync_test"
(#35) PHPUnit class "local_o365_usersync_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/webservices_onenoteassignment_test.php
(#38) PHPUnit testcase name "local_o365_webservices_onenoteassignment_testcase" does not match file name "webservices_onenoteassignment_test"
(#38) PHPUnit class "local_o365_webservices_onenoteassignment_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/webservices_utils_test.php
(#38) PHPUnit testcase name "local_o365_webservices_utils_testcase" does not match file name "webservices_utils_test"
(#38) PHPUnit class "local_o365_webservices_utils_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/token.php
(#94) Logical operator "and" is prohibited; use "&&" instead
(#109) Logical operator "and" is prohibited; use "&&" instead
(#140) Logical operator "and" is prohibited; use "&&" instead

Javascript coding style problems

(77 errors, 130 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/o365/classes/adminsetting/azuresetup.js
(#23) '$' is not defined. (no-undef)
(#25) '$' is not defined. (no-undef)
(#57) This line has a length of 156. Maximum allowed is 132. (max-len)
(#69) '$' is not defined. (no-undef)
(#76) '$' is not defined. (no-undef)
(#82) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#93) 'data' is defined but never used. (no-unused-vars)
(#97) Missing semicolon. (semi)
(#99) Missing JSDoc return type. (valid-jsdoc)
(#102) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#102) Expected JSDoc for 'content' but found 'string'. (valid-jsdoc)
(#106) '$' is not defined. (no-undef)
(#110) Missing semicolon. (semi)
(#112) Missing JSDoc return type. (valid-jsdoc)
(#115) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#115) Expected JSDoc for 'content' but found 'string'. (valid-jsdoc)
(#119) '$' is not defined. (no-undef)
(#123) Missing semicolon. (semi)
(#125) Missing JSDoc return type. (valid-jsdoc)
(#128) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#128) Expected JSDoc for 'content' but found 'string'. (valid-jsdoc)
(#132) '$' is not defined. (no-undef)
(#136) Missing semicolon. (semi)
(#141) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#141) Expected JSDoc for 'content' but found 'string'. (valid-jsdoc)
(#145) Missing semicolon. (semi)
(#147) Missing JSDoc return type. (valid-jsdoc)
(#150) Missing JSDoc parameter type for 'object'. (valid-jsdoc)
(#150) Expected JSDoc for 'data' but found 'object'. (valid-jsdoc)
(#153) Identifier 'rendersection_unifiedapi' is not in camel case. (camelcase)
(#154) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#158) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#160) '$' is not defined. (no-undef)
(#164) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#166) 'missingpermsbox' used outside of binding context. (block-scoped-var)
(#167) 'perm' used outside of binding context. (block-scoped-var)
(#168) 'missingpermsbox' used outside of binding context. (block-scoped-var)
(#168) 'perm' used outside of binding context. (block-scoped-var)
(#168) 'perm' used outside of binding context. (block-scoped-var)
(#170) 'missingpermsbox' used outside of binding context. (block-scoped-var)
(#171) 'missingpermsbox' used outside of binding context. (block-scoped-var)
(#179) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#181) 'missingpermsbox' is already defined. (no-redeclare)
(#181) 'missingpermsbox' used outside of binding context. (block-scoped-var)
(#182) 'perm' is already defined. (no-redeclare)
(#182) 'perm' used outside of binding context. (block-scoped-var)
(#183) 'missingpermsbox' used outside of binding context. (block-scoped-var)
(#183) 'perm' used outside of binding context. (block-scoped-var)
(#183) 'perm' used outside of binding context. (block-scoped-var)
(#185) 'missingpermsbox' used outside of binding context. (block-scoped-var)
(#186) 'missingpermsbox' used outside of binding context. (block-scoped-var)
(#197) Missing semicolon. (semi)
(#199) Missing JSDoc return type. (valid-jsdoc)
(#202) Missing JSDoc parameter type for 'object'. (valid-jsdoc)
(#202) Expected JSDoc for 'data' but found 'object'. (valid-jsdoc)
(#205) Identifier 'rendersection_legacyapi' is not in camel case. (camelcase)
(#206) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#210) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#221) 'content' is already defined. (no-redeclare)
(#224) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#225) '$' is not defined. (no-undef)
(#236) Missing semicolon. (semi)
(#238) Missing JSDoc @returns for function. (valid-jsdoc)
(#241) Missing JSDoc parameter type for 'object'. (valid-jsdoc)
(#241) Expected JSDoc for 'results' but found 'object'. (valid-jsdoc)
(#244) '$' is not defined. (no-undef)
(#250) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#251) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#253) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#254) '$' is not defined. (no-undef)
(#255) Operator '+' must be spaced. (space-infix-ops)
(#255) Operator '+' must be spaced. (space-infix-ops)
(#256) Operator '+' must be spaced. (space-infix-ops)
(#256) Operator '+' must be spaced. (space-infix-ops)
(#258) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#259) Blocks are nested too deeply (5). Maximum allowed is 4. (max-depth)
(#259) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#260) Blocks are nested too deeply (6). Maximum allowed is 4. (max-depth)
(#263) 'errstr' used outside of binding context. (block-scoped-var)
(#263) Operator '+' must be spaced. (space-infix-ops)
(#264) 'errstr' used outside of binding context. (block-scoped-var)
(#264) Operator '+' must be spaced. (space-infix-ops)
(#264) Operator '+' must be spaced. (space-infix-ops)
(#264) Operator '+' must be spaced. (space-infix-ops)
(#265) 'errstr' used outside of binding context. (block-scoped-var)
(#265) Operator '+' must be spaced. (space-infix-ops)
(#265) Operator '+' must be spaced. (space-infix-ops)
(#265) Operator '+' must be spaced. (space-infix-ops)
(#266) 'errstr' used outside of binding context. (block-scoped-var)
(#272) Blocks are nested too deeply (5). Maximum allowed is 4. (max-depth)
(#272) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#273) Blocks are nested too deeply (6). Maximum allowed is 4. (max-depth)
(#276) 'errstr' is already defined. (no-redeclare)
(#276) 'errstr' used outside of binding context. (block-scoped-var)
(#276) Operator '+' must be spaced. (space-infix-ops)
(#277) 'errstr' used outside of binding context. (block-scoped-var)
(#277) Operator '+' must be spaced. (space-infix-ops)
(#277) Operator '+' must be spaced. (space-infix-ops)
(#277) Operator '+' must be spaced. (space-infix-ops)
(#278) 'errstr' used outside of binding context. (block-scoped-var)
(#278) Operator '+' must be spaced. (space-infix-ops)
(#278) Operator '+' must be spaced. (space-infix-ops)
(#278) Operator '+' must be spaced. (space-infix-ops)
(#279) 'errstr' used outside of binding context. (block-scoped-var)
(#290) '$' is not defined. (no-undef)
(#293) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#301) '$' is not defined. (no-undef)
(#304) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#316) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#326) Missing semicolon. (semi)
(#330) '$' is not defined. (no-undef)
(#337) '$' is not defined. (no-undef)
(#342) '$' is not defined. (no-undef)
(#343) '$' is not defined. (no-undef)
(#356) Missing semicolon. (semi)
(#359) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#367) Missing semicolon. (semi)
(#369) Missing semicolon. (semi)
local/o365/classes/adminsetting/moodlesetup.js
(#23) '$' is not defined. (no-undef)
(#23) Unexpected space before function parentheses. (space-before-function-paren)
(#25) '$' is not defined. (no-undef)
(#25) Unexpected space before function parentheses. (space-before-function-paren)
(#38) '$' is not defined. (no-undef)
(#43) Missing JSDoc return type. (valid-jsdoc)
(#46) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#46) Expected JSDoc for 'content' but found 'string'. (valid-jsdoc)
(#49) Unexpected space before function parentheses. (space-before-function-paren)
(#50) '$' is not defined. (no-undef)
(#54) Missing semicolon. (semi)
(#56) Missing JSDoc return type. (valid-jsdoc)
(#59) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#59) Expected JSDoc for 'content' but found 'string'. (valid-jsdoc)
(#62) Unexpected space before function parentheses. (space-before-function-paren)
(#63) '$' is not defined. (no-undef)
(#67) Missing semicolon. (semi)
(#69) Missing JSDoc return type. (valid-jsdoc)
(#72) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#72) Expected JSDoc for 'content' but found 'string'. (valid-jsdoc)
(#75) Unexpected space before function parentheses. (space-before-function-paren)
(#76) '$' is not defined. (no-undef)
(#80) Missing semicolon. (semi)
(#85) Missing JSDoc parameter type for 'string'. (valid-jsdoc)
(#85) Expected JSDoc for 'content' but found 'string'. (valid-jsdoc)
(#87) Unexpected space before function parentheses. (space-before-function-paren)
(#89) Missing semicolon. (semi)
(#91) Missing JSDoc @returns for function. (valid-jsdoc)
(#94) Missing JSDoc parameter type for 'object'. (valid-jsdoc)
(#94) Expected JSDoc for 'results' but found 'object'. (valid-jsdoc)
(#96) Unexpected space before function parentheses. (space-before-function-paren)
(#97) '$' is not defined. (no-undef)
(#129) Missing semicolon. (semi)
(#131) Unexpected space before function parentheses. (space-before-function-paren)
(#133) '$' is not defined. (no-undef)
(#140) Unexpected space before function parentheses. (space-before-function-paren)
(#144) Unexpected space before function parentheses. (space-before-function-paren)
(#150) Missing semicolon. (semi)
(#152) Unexpected space before function parentheses. (space-before-function-paren)
(#156) Unexpected space before function parentheses. (space-before-function-paren)
(#161) Missing semicolon. (semi)
(#163) Missing semicolon. (semi)
local/o365/classes/adminsetting/serviceresource.js
(#23) '$' is not defined. (no-undef)
(#25) '$' is not defined. (no-undef)
(#38) '$' is not defined. (no-undef)
(#47) Use '===' to compare with null. (no-eq-null)
(#50) Statement inside of curly braces should be on next line. (brace-style)
(#50) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#52) Missing semicolon. (semi)
(#58) Missing semicolon. (semi)
(#62) '$' is not defined. (no-undef)
(#72) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#73) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#73) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#82) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#91) 'data' is defined but never used. (no-unused-vars)
(#95) Missing semicolon. (semi)
(#99) '$' is not defined. (no-undef)
(#109) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#110) This line has a length of 133. Maximum allowed is 132. (max-len)
(#110) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#110) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#116) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#125) 'data' is defined but never used. (no-unused-vars)
(#130) Missing semicolon. (semi)
(#133) This line has a length of 137. Maximum allowed is 132. (max-len)
(#136) Missing semicolon. (semi)
(#139) This line has a length of 137. Maximum allowed is 132. (max-len)
(#142) Missing semicolon. (semi)
(#144) 'e' is defined but never used. (no-unused-vars)
(#145) '$' is not defined. (no-undef)
(#153) Missing semicolon. (semi)
local/o365/classes/adminsetting/sharepointlink.js
(#23) '$' is not defined. (no-undef)
(#25) '$' is not defined. (no-undef)
(#29) '$' is not defined. (no-undef)
(#54) Missing semicolon. (semi)
(#58) Use '===' to compare with null. (no-eq-null)
(#61) Statement inside of curly braces should be on next line. (brace-style)
(#61) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#65) Missing semicolon. (semi)
(#69) '$' is not defined. (no-undef)
(#75) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#76) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#76) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#90) 'data' is defined but never used. (no-unused-vars)
(#94) Missing semicolon. (semi)
(#96) A space is required after ','. (comma-spacing)
(#97) '$' is not defined. (no-undef)
(#105) Missing semicolon. (semi)

CSS problems

(25 errors, 17 warnings)

This section shows CSS problems detected by stylelint [More info]

local/o365/styles.css
(#334) Unexpected empty block (block-no-empty)
(#318) Expected "#FFF" to be "#fff" (color-hex-case)
(#331) Expected "#FFF" to be "#fff" (color-hex-case)
(#260) Unexpected !important (declaration-no-important)
(#261) Unexpected !important (declaration-no-important)
(#303) Unexpected !important (declaration-no-important)
(#316) Unexpected !important (declaration-no-important)
(#317) Unexpected !important (declaration-no-important)
(#88) Unexpected unit (length-zero-no-unit)
(#227) Unexpected unit (length-zero-no-unit)
(#228) Unexpected unit (length-zero-no-unit)
(#260) Unexpected unit (length-zero-no-unit)
(#282) Unexpected unit (length-zero-no-unit)
(#343) Unexpected unit (length-zero-no-unit)
(#343) Unexpected unit (length-zero-no-unit)
(#347) Unexpected unit (length-zero-no-unit)
(#352) Unexpected unit (length-zero-no-unit)
(#375) Unexpected unit (length-zero-no-unit)
(#375) Unexpected unit (length-zero-no-unit)
(#96) Expected line length to be no more than 132 characters (max-line-length)
(#100) Expected line length to be no more than 132 characters (max-line-length)
(#104) Expected line length to be no more than 132 characters (max-line-length)
(#9) Expected newline after "," (selector-list-comma-newline-after)
(#13) Expected newline after "," (selector-list-comma-newline-after)
(#18) Expected newline after "," (selector-list-comma-newline-after)
(#22) Expected newline after "," (selector-list-comma-newline-after)
(#87) Expected newline after "," (selector-list-comma-newline-after)
(#96) Expected newline after "," (selector-list-comma-newline-after)
(#100) Expected newline after "," (selector-list-comma-newline-after)
(#104) Expected newline after "," (selector-list-comma-newline-after)
(#153) Expected newline after "," (selector-list-comma-newline-after)
(#158) Expected newline after "," (selector-list-comma-newline-after)
(#328) Expected newline after "," (selector-list-comma-newline-after)
(#334) Expected newline after "," (selector-list-comma-newline-after)
local/o365/sass/styles.scss
(#81) Unexpected unit (length-zero-no-unit)
(#8) Expected newline after "," (selector-list-comma-newline-after)
(#13) Expected newline after "," (selector-list-comma-newline-after)
(#80) Expected newline after "," (selector-list-comma-newline-after)
(#90) Expected newline after "," (selector-list-comma-newline-after)
(#94) Expected newline after "," (selector-list-comma-newline-after)
(#97) Expected newline after "," (selector-list-comma-newline-after)
(#144) Expected newline after "," (selector-list-comma-newline-after)

PHPDocs style problems

(20 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/o365/classes/bot/botintent.php
(#127) There is no description in phpdocs for function check_permission
(#127) Phpdocs for function botintent::check_permission has incomplete parameters list
local/o365/classes/healthcheck/healthcheckinterface.php
(#34) Constant SEVERITY_OK is not documented
(#35) Constant SEVERITY_TRIVIAL is not documented
(#36) Constant SEVERITY_WARNING is not documented
(#37) Constant SEVERITY_FATAL is not documented
local/o365/classes/rest/unified.php
(#1056) Phpdocs for function unified::get_calendars has incomplete parameters list
(#2603) Phpdocs for function unified::get_school_class_teachers has incomplete parameters list
local/o365/classes/tests/mockhttpclient.php
(#33) Invalid phpdocs tag @codeCoverageIgnore used
local/o365/classes/tests/mocksharepoint.php
(#33) Invalid phpdocs tag @codeCoverageIgnore used
local/o365/classes/utils.php
(#451) Phpdocs for function utils::deletelegacyadditionaltenant has incomplete parameters list
local/o365/lib.php
(#55) Constant SDS_SCHOOL_DISABLED_ACTION_KEEP_CONNECTED is not documented
(#56) Constant SDS_SCHOOL_DISABLED_ACTION_DISCONNECT is not documented
local/o365/tests/observers_test.php
(#33) Invalid phpdocs tag @codeCoverageIgnore used
local/o365/tests/token_test.php
(#33) Invalid phpdocs tag @codeCoverageIgnore used
local/o365/tests/usersync_test.php
(#33) Invalid phpdocs tag @codeCoverageIgnore used
local/o365/tests/webservices_onenoteassignment_test.php
(#41) Constant local_o365_webservices_onenoteassignment_testcase::DBSTATE is not documented
(#42) Constant local_o365_webservices_onenoteassignment_testcase::PARAMS is not documented
(#43) Constant local_o365_webservices_onenoteassignment_testcase::EXPECTEDRETURN is not documented
(#44) Constant local_o365_webservices_onenoteassignment_testcase::EXPECTEDEXCEPTION is not documented

Update savepoints problems

(47 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

local/o365/db/upgrade.php
Detected more 'if' blocks (58) than 'savepoint' calls (12)
version 2014111700 is missing corresponding savepoint call
version 2014111702 is missing corresponding savepoint call
version 2014111703 is missing corresponding savepoint call
version 2014111707 is missing corresponding savepoint call
version 2014111710 is missing corresponding savepoint call
version 2014111711 is missing corresponding savepoint call
version 2014111715 is missing corresponding savepoint call
version 2014111716 is missing corresponding savepoint call
version 2015012702 is missing corresponding savepoint call
version 2015012704 is missing corresponding savepoint call
version 2015012707 is missing corresponding savepoint call
version 2015012708 is missing corresponding savepoint call
version 2015012709 is missing corresponding savepoint call
version 2015012710 is missing corresponding savepoint call
version 2015012712 is missing corresponding savepoint call
version 2015012713 is missing corresponding savepoint call
version 2015012714 is missing corresponding savepoint call
version 2015012715 is missing corresponding savepoint call
version 2015060102 is missing corresponding savepoint call
version 2015060103 is missing corresponding savepoint call
version 2015060104 is missing corresponding savepoint call
version 2015060109 is missing corresponding savepoint call
version 2015060111 is missing corresponding savepoint call
version 2015111900.01 is missing corresponding savepoint call
version 2015111900.02 is missing corresponding savepoint call
version 2015111901.01 is missing corresponding savepoint call
version 2015111901.03 is missing corresponding savepoint call
version 2015111903 is missing corresponding savepoint call
version 2015111905 is missing corresponding savepoint call
version 2015111911.01 is missing corresponding savepoint call
version 2015111913 is missing corresponding savepoint call
version 2015111913.02 is missing corresponding savepoint call
version 2015111914.02 is missing corresponding savepoint call
version 2015111914.03 is missing corresponding savepoint call
version 2015111916.01 is missing corresponding savepoint call
version 2016062000.01 is missing corresponding savepoint call
version 2016062000.03 is missing corresponding savepoint call
version 2016062001.01 is missing corresponding savepoint call
version 2016062004.01 is missing corresponding savepoint call
version 2016120500.05 is missing corresponding savepoint call
version 2016120500.06 is missing corresponding savepoint call
version 2017111301 is missing corresponding savepoint call
version 2018051702 is missing corresponding savepoint call
version 2018051703 is missing corresponding savepoint call
version 2018051704 is missing corresponding savepoint call
version 2018051705 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:scss" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]