PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(197 errors, 85 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/o365/classes/adminsetting/aadsyncoptions.php: (#86) Logical operator "or" is prohibited; use "||" instead
local/o365/classes/adminsetting/systemapiuser.php: (#101) Empty CATCH statement detected
local/o365/classes/adminsetting/tabs.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#157) Expected 1 space before "="; 2 found; (#160) Expected 1 space before "=>"; 2 found; (#161) Expected 1 space before "=>"; 2 found
local/o365/classes/bot/botintent.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#58) Line exceeds 132 characters; contains 145 characters; (#64) Line exceeds 132 characters; contains 143 characters; (#68) Line exceeds 132 characters; contains 134 characters; (#78) Line exceeds 132 characters; contains 160 characters; (#95) Line exceeds 132 characters; contains 135 characters; (#98) Line indented incorrectly; expected 16 spaces, found 20; (#100) Line indented incorrectly; expected 16 spaces, found 20; (#102) Line indented incorrectly; expected 16 spaces, found 20
local/o365/classes/bot/intents/absentstudents.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/assignmentcomparison.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/dueassignments.php: (#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/o365/classes/bot/intents/help.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/incompleteassignments.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/intentinterface.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/laststudentlogin.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/latestgrades.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/lateststudents.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/bot/intents/recentstudents.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/event/api_call_failed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/event/calendar_subscribed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/event/calendar_unsubscribed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/feature/calsync/form/element/calendar.php: (#59) Variable "elementName" must be all lower-case; (#59) Variable "elementLabel" must be all lower-case; (#61) Variable "elementName" must be all lower-case; (#61) Variable "elementLabel" must be all lower-case; (#75) Variable "elementName" must be all lower-case; (#75) Variable "elementLabel" must be all lower-case; (#76) Variable "elementName" must be all lower-case; (#76) Variable "elementLabel" must be all lower-case; (#98) Public method name "calendar::setValue" must be in lower-case letters only; (#115) Visibility must be declared on method "getHelpButton"; (#115) method name "calendar::getHelpButton" must be in lower-case letters only; (#115) Expected 1 space before opening brace; found 0; (#126) Public method name "calendar::exportValue" must be in lower-case letters only; (#126) Variable "submitValues" must be all lower-case; (#127) Variable "submitValues" must be all lower-case; (#136) Public method name "calendar::toHtml" must be in lower-case letters only
local/o365/classes/feature/calsync/main.php: (#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#131) Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $other is optional, while parameter $calid is required.; (#298) Empty CATCH statement detected; (#483) Empty CATCH statement detected
local/o365/classes/feature/calsync/task/importfromoutlook.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/feature/calsync/task/syncoldevents.php: (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#127) Empty CATCH statement detected; (#266) Empty CATCH statement detected
local/o365/classes/feature/coursesync/main.php: (#34) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#1367) Empty CATCH statement detected; (#1375) Empty CATCH statement detected; (#1400) Empty CATCH statement detected; (#1408) Empty CATCH statement detected
local/o365/classes/feature/coursesync/observers.php: (#88) Empty CATCH statement detected
local/o365/classes/feature/coursesync/utils.php: (#388) Expected "foreach (...) {\n"; found "foreach(...){\n"; (#644) Empty CATCH statement detected; (#737) Must use "self::" for local static member reference; (#738) Must use "self::" for local static member reference
local/o365/classes/feature/sds/task/sync.php: (#36) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#530) Commas (,) must be followed by white space.; (#535) Commas (,) must be followed by white space.; (#566) Commas (,) must be followed by white space.; (#576) Commas (,) must be followed by white space.; (#652) Empty CATCH statement detected
local/o365/classes/healthcheck/healthcheckinterface.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/healthcheck/ratelimit.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/healthcheck/systemapiuser.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/httpclientinterface.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/oauth2/systemapiusertoken.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/oauth2/systemtoken.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/oauth2/token.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#171) Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$userid" was used, and possibly changed (by reference), on line 158.
local/o365/classes/obj/o365user.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/observers.php: (#159) Empty CATCH statement detected
local/o365/classes/page/acp.php: (#124) Commas (,) must be followed by white space.; (#142) Commas (,) must be followed by white space.; (#321) Commas (,) must be followed by white space.; (#616) Commas (,) must be followed by white space.; (#645) Commas (,) must be followed by white space.; (#725) Whitespace found at end of line within string; (#888) Commas (,) must be followed by white space.; (#917) Commas (,) must be followed by white space.; (#1022) Commas (,) must be followed by white space.; (#1724) Commas (,) must be followed by white space.; (#1822) Commas (,) must be followed by white space.; (#1829) Commas (,) must be followed by white space.; (#1864) Commas (,) must be followed by white space.; (#1900) Commas (,) must be followed by white space.
local/o365/classes/page/ajax.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/page/base.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/botframework.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/rest/o365api.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#333) Commas (,) must be followed by white space.
local/o365/classes/rest/unified.php: (#263) Commas (,) must be followed by white space.; (#434) Empty CATCH statement detected; (#825) Commas (,) must be followed by white space.; (#1356) Commas (,) must be followed by white space.; (#1359) Commas (,) must be followed by white space.; (#1368) Commas (,) must be followed by white space.; (#1878) Commas (,) must be followed by white space.; (#1933) Commas (,) must be followed by white space.; (#1949) Commas (,) must be followed by white space.; (#2021) Commas (,) must be followed by white space.; (#2036) Commas (,) must be followed by white space.
local/o365/classes/task/bot.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#93) Inline comments must start with a capital letter, digit or 3-dots sequence
local/o365/classes/task/coursesync.php: (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/task/groupmembershipsync.php: (#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#58) File must end with a newline character
local/o365/classes/task/refreshsystemrefreshtoken.php: (#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/task/usersync.php: (#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#219) Expected "if (...) {\n"; found "if(...) {\n"
local/o365/classes/tests/mockhttpclient.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/utils.php: (#67) Must use "self::" for local static member reference; (#264) The use of function print_r() is forbidden; (#266) The use of function print_r() is forbidden; (#475) Empty CATCH statement detected; (#499) Empty CATCH statement detected
local/o365/classes/webservices/exception/assignnotfound.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/couldnotsavegrade.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/invalidassignment.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/modulenotfound.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/exception/sectionnotfound.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/classes/webservices/read_assignments.php: (#62) Expected 1 space before "=>"; 2 found; (#275) Expected 1 space before "=>"; 2 found; (#344) Expected 1 space before "=>"; 2 found; (#398) Expected 1 space before "=>"; 2 found
local/o365/classes/webservices/read_bot_message.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#107) Expected 1 space before "=>"; 2 found
local/o365/classes/webservices/read_courseusers.php: (#101) Empty IF statement detected
local/o365/classes/webservices/update_grade.php: (#67) Expected 1 space before "="; 2 found
local/o365/classes/webservices/utils.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/o365/db/events.php: (#32) Expected 1 space before "=>"; 3 found; (#33) Expected 1 space before "=>"; 4 found; (#34) Expected 1 space before "=>"; 4 found; (#35) Expected 1 space before "=>"; 4 found; (#38) Expected 1 space before "=>"; 3 found; (#39) Expected 1 space before "=>"; 4 found; (#40) Expected 1 space before "=>"; 4 found; (#41) Expected 1 space before "=>"; 4 found; (#44) Expected 1 space before "=>"; 3 found; (#45) Expected 1 space before "=>"; 4 found; (#46) Expected 1 space before "=>"; 4 found; (#47) Expected 1 space before "=>"; 4 found; (#50) Expected 1 space before "=>"; 3 found; (#51) Expected 1 space before "=>"; 4 found; (#52) Expected 1 space before "=>"; 4 found; (#53) Expected 1 space before "=>"; 4 found; (#56) Expected 1 space before "=>"; 3 found; (#57) Expected 1 space before "=>"; 4 found; (#58) Expected 1 space before "=>"; 4 found; (#59) Expected 1 space before "=>"; 4 found; (#62) Expected 1 space before "=>"; 3 found; (#63) Expected 1 space before "=>"; 4 found; (#64) Expected 1 space before "=>"; 4 found; (#65) Expected 1 space before "=>"; 4 found; (#68) Expected 1 space before "=>"; 3 found; (#69) Expected 1 space before "=>"; 4 found; (#70) Expected 1 space before "=>"; 4 found; (#71) Expected 1 space before "=>"; 4 found; (#74) Expected 1 space before "=>"; 3 found; (#75) Expected 1 space before "=>"; 4 found; (#76) Expected 1 space before "=>"; 4 found; (#77) Expected 1 space before "=>"; 4 found; (#82) Expected 1 space before "=>"; 3 found; (#83) Expected 1 space before "=>"; 4 found; (#84) Expected 1 space before "=>"; 4 found; (#85) Expected 1 space before "=>"; 4 found; (#88) Expected 1 space before "=>"; 3 found; (#89) Expected 1 space before "=>"; 4 found; (#90) Expected 1 space before "=>"; 4 found; (#91) Expected 1 space before "=>"; 4 found; (#94) Expected 1 space before "=>"; 3 found; (#95) Expected 1 space before "=>"; 4 found; (#96) Expected 1 space before "=>"; 4 found; (#97) Expected 1 space before "=>"; 4 found; (#100) Expected 1 space before "=>"; 3 found; (#101) Expected 1 space before "=>"; 4 found; (#102) Expected 1 space before "=>"; 4 found; (#103) Expected 1 space before "=>"; 4 found; (#108) Expected 1 space before "=>"; 3 found; (#109) Expected 1 space before "=>"; 4 found; (#110) Expected 1 space before "=>"; 4 found; (#111) Expected 1 space before "=>"; 4 found; (#114) Expected 1 space before "=>"; 3 found; (#115) Expected 1 space before "=>"; 4 found; (#116) Expected 1 space before "=>"; 4 found; (#117) Expected 1 space before "=>"; 4 found; (#120) Expected 1 space before "=>"; 3 found; (#121) Expected 1 space before "=>"; 4 found; (#122) Expected 1 space before "=>"; 4 found; (#123) Expected 1 space before "=>"; 4 found; (#126) Expected 1 space before "=>"; 3 found; (#127) Expected 1 space before "=>"; 4 found; (#128) Expected 1 space before "=>"; 4 found; (#129) Expected 1 space before "=>"; 4 found; (#132) Expected 1 space before "=>"; 3 found; (#133) Expected 1 space before "=>"; 4 found; (#134) Expected 1 space before "=>"; 4 found; (#135) Expected 1 space before "=>"; 4 found; (#138) Expected 1 space before "=>"; 3 found; (#139) Expected 1 space before "=>"; 4 found; (#140) Expected 1 space before "=>"; 4 found; (#141) Expected 1 space before "=>"; 4 found; (#144) Expected 1 space before "=>"; 3 found; (#145) Expected 1 space before "=>"; 4 found; (#146) Expected 1 space before "=>"; 4 found; (#147) Expected 1 space before "=>"; 4 found; (#150) Expected 1 space before "=>"; 3 found; (#151) Expected 1 space before "=>"; 4 found; (#152) Expected 1 space before "=>"; 4 found; (#153) Expected 1 space before "=>"; 4 found; (#156) Expected 1 space before "=>"; 3 found; (#157) Expected 1 space before "=>"; 4 found; (#158) Expected 1 space before "=>"; 4 found; (#159) Expected 1 space before "=>"; 4 found; (#162) Expected 1 space before "=>"; 3 found; (#163) Expected 1 space before "=>"; 4 found; (#164) Expected 1 space before "=>"; 4 found; (#165) Expected 1 space before "=>"; 4 found; (#168) Expected 1 space before "=>"; 3 found; (#169) Expected 1 space before "=>"; 4 found; (#170) Expected 1 space before "=>"; 4 found; (#171) Expected 1 space before "=>"; 4 found; (#174) Expected 1 space before "=>"; 3 found; (#175) Expected 1 space before "=>"; 4 found; (#176) Expected 1 space before "=>"; 4 found; (#177) Expected 1 space before "=>"; 4 found; (#180) Expected 1 space before "=>"; 3 found; (#181) Expected 1 space before "=>"; 4 found; (#182) Expected 1 space before "=>"; 4 found; (#183) Expected 1 space before "=>"; 4 found; (#186) Expected 1 space before "=>"; 3 found; (#187) Expected 1 space before "=>"; 4 found; (#188) Expected 1 space before "=>"; 4 found; (#189) Expected 1 space before "=>"; 4 found; (#192) Expected 1 space before "=>"; 3 found; (#193) Expected 1 space before "=>"; 4 found; (#194) Expected 1 space before "=>"; 4 found; (#195) Expected 1 space before "=>"; 4 found; (#198) Expected 1 space before "=>"; 3 found; (#199) Expected 1 space before "=>"; 4 found; (#200) Expected 1 space before "=>"; 4 found; (#201) Expected 1 space before "=>"; 4 found
local/o365/export_manifest.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#45) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
local/o365/lang/en/local_o365.php: (#890) Whitespace found at end of line within string
local/o365/lib.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#354) The use of backticks in strings is not recommended; (#457) Whitespace found at end of line within string
local/o365/sso_end.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/sso_login.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/sso_start.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/teams_tab.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/teams_tab_configuration.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/o365/teams_tab_redirect.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#29) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
local/o365/tests/coursesyncutils_test.php: (#38) PHPUnit testcase name "local_o365_coursesyncutils_testcase" does not match file name "coursesyncutils_test"; (#38) PHPUnit class "local_o365_coursesyncutils_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/observers_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#35) PHPUnit testcase name "local_o365_observers_testcase" does not match file name "observers_test"; (#35) PHPUnit class "local_o365_observers_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/privacy_provider_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#38) PHPUnit testcase name "local_o365_privacy_testcase" does not match file name "privacy_provider_test"; (#38) PHPUnit class "local_o365_privacy_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/token_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#35) PHPUnit testcase name "local_o365_oauth2_token_testcase" does not match file name "token_test"; (#35) PHPUnit class "local_o365_oauth2_token_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/usersync_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#35) PHPUnit testcase name "local_o365_usersync_testcase" does not match file name "usersync_test"; (#35) PHPUnit class "local_o365_usersync_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/webservices_onenoteassignment_test.php: (#38) PHPUnit testcase name "local_o365_webservices_onenoteassignment_testcase" does not match file name "webservices_onenoteassignment_test"; (#38) PHPUnit class "local_o365_webservices_onenoteassignment_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/tests/webservices_utils_test.php: (#38) PHPUnit testcase name "local_o365_webservices_utils_testcase" does not match file name "webservices_utils_test"; (#38) PHPUnit class "local_o365_webservices_utils_testcase" does not have any namespace. It is recommended to add it to the "local_o365" namespace, using more levels if needed, in order to match the code being tested
local/o365/token.php: (#94) Logical operator "and" is prohibited; use "&&" instead; (#109) Logical operator "and" is prohibited; use "&&" instead; (#140) Logical operator "and" is prohibited; use "&&" instead

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems