Prechecker results: error


PHP lint problems

(3 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

local/moodlecheck/tests/fixtures/phpdoc_tags_general.php
(#257) PHP Parse error: syntax error, unexpected token "|", expecting variable in /local/moodlecheck/tests/fixtures/phpdoc_tags_general.php on line 257
local/moodlecheck/tests/fixtures/unfinished.php
(#31) PHP Parse error: Unterminated comment starting line 31 in /local/moodlecheck/tests/fixtures/unfinished.php on line 31
local/moodlecheck/tests/fixtures/uses.php
(#30) PHP Parse error: syntax error, unexpected token "{" in /local/moodlecheck/tests/fixtures/uses.php on line 30

PHP coding style problems

(78 errors, 8 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/moodlecheck/file.php
(#35) Missing docblock for constant local_moodlecheck_file::MODIFIERS
(#37) Missing member variable doc comment
(#38) Missing member variable doc comment
(#39) Missing member variable doc comment
(#40) Missing member variable doc comment
(#41) Missing member variable doc comment
(#42) Missing member variable doc comment
(#43) Missing member variable doc comment
(#44) Missing member variable doc comment
(#45) Missing member variable doc comment
(#46) Missing member variable doc comment
(#47) Missing member variable doc comment
(#54) Missing member variable doc comment
(#984) @link tag is not allowed in member variable comment
(#1064) Missing member variable doc comment
(#1064) Missing member variable doc comment
local/moodlecheck/locallib.php
(#37) Missing member variable doc comment
(#38) Missing member variable doc comment
(#39) Missing member variable doc comment
(#40) Missing member variable doc comment
(#41) Missing member variable doc comment
(#43) Missing docblock for function __construct
(#43) Missing member variable doc comment
(#47) Missing docblock for function set_callback
(#52) Missing docblock for function set_rulestring
(#57) Missing docblock for function set_errorstring
(#62) Missing docblock for function set_severity
(#67) Missing docblock for function get_name
(#77) Missing docblock for function get_error_message
(#98) Missing docblock for function validatefile
(#122) Missing member variable doc comment
(#123) Missing member variable doc comment
(#125) Missing docblock for function add_rule
(#131) Missing docblock for function get_registered_rules
(#135) Missing docblock for function enable_rule
(#149) Missing docblock for function get_enabled_rules
(#153) Missing docblock for function enable_all_rules
(#168) Missing member variable doc comment
(#169) Missing member variable doc comment
(#170) Missing member variable doc comment
(#171) Missing member variable doc comment
(#172) Missing member variable doc comment
(#173) Missing member variable doc comment
(#175) Missing docblock for function __construct
(#175) Missing member variable doc comment
(#175) Missing member variable doc comment
(#186) Missing docblock for function get_fullpath
(#195) Missing docblock for function validate
(#218) Missing docblock for function is_ignored
(#229) Missing docblock for function is_file
(#233) Missing docblock for function is_dir
(#237) Missing docblock for function get_path
(#241) Missing docblock for function get_file
(#245) Missing docblock for function get_subpaths
(#249) Missing docblock for function set_rootpath
(#253) Missing docblock for function is_rootpath
(#257) Missing docblock for function get_components
(#294) Missing docblock for function definition
local/moodlecheck/tests/fixtures/error_and_warning.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#11) Missing docblock for class someclass
(#12) Missing docblock for function somefunc
local/moodlecheck/tests/fixtures/nophp.php
(#1) No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
local/moodlecheck/tests/fixtures/phpdoc_constructor_property_promotion.php
(#40) Missing member variable doc comment
(#41) Missing member variable doc comment
(#42) Missing member variable doc comment
(#43) Missing member variable doc comment
(#44) Missing member variable doc comment
local/moodlecheck/tests/fixtures/phpdoc_constructor_property_promotion_readonly.php
(#29) Duplicate class name "local_moodlecheck\constructor_property_promotion" found; first defined in /var/lib/jenkins/git_repositories/prechecker/local/moodlecheck/tests/fixtures/phpdoc_constructor_property_promotion.php on line 29
(#40) Missing member variable doc comment
(#47) Missing member variable doc comment
local/moodlecheck/tests/fixtures/phpdoc_method_multiline.php
(#17) Missing @copyright tag
(#17) Missing @license tag
(#55) There must not be a space before the colon in a return type declaration
local/moodlecheck/tests/fixtures/phpdoc_tags_general.php
(#55) Invalid docblock tag "@covers".
(#56) Invalid docblock tag "@dataProvider".
(#57) Invalid docblock tag "@group".
(#58) Invalid docblock tag "@small".
(#59) Invalid docblock tag "@zzzing".
(#60) Invalid docblock tag "@inheritdoc".
(#202) Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $one is optional, while parameter $two is required.
(#202) Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $one is optional, while parameter $three is required.
local/moodlecheck/tests/fixtures/unfinished.php
(#31) Inline doc block comments are not allowed; use "// Comment." instead
local/moodlecheck/tests/fixtures/uses.php
(#17) Missing @copyright tag
(#35) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#35) A closing tag is not permitted at the end of a PHP file
local/moodlecheck/tests/phpdocs_basic_test.php
(#49) Missing docblock for function local_moodlecheck_normalise_function_type_provider in testcase

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(21 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/moodlecheck/file.php
(#1220) Inline phpdocs tag {@link self::$validtags} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
local/moodlecheck/rules/phpdocs_basic.php
(#105) Inline phpdocs tag not enclosed with curly brackets @link found
(#102) Inline phpdocs tag not enclosed with curly brackets @see found
local/moodlecheck/tests/fixtures/nophp.php
(#1) The file is empty or doesn't contain PHP code. Skipped.
local/moodlecheck/tests/fixtures/phpdoc_tags_general.php
(#69) Phpdocs for function fixturing_general::incomplete_param_annotation has incomplete parameters list
(#79) Phpdocs for function fixturing_general::missing_param_defintion has incomplete parameters list
(#86) Phpdocs for function fixturing_general::missing_param_annotation has incomplete parameters list
(#96) Phpdocs for function fixturing_general::incomplete_param_definition has incomplete parameters list
(#106) Phpdocs for function fixturing_general::incomplete_param_annotation1 has incomplete parameters list
(#115) Phpdocs for function fixturing_general::mismatch_param_types has incomplete parameters list
(#125) Phpdocs for function fixturing_general::mismatch_param_types1 has incomplete parameters list
(#135) Phpdocs for function fixturing_general::mismatch_param_types2 has incomplete parameters list
(#145) Phpdocs for function fixturing_general::mismatch_param_types3 has incomplete parameters list
(#216) Phpdocs for function fixturing_general::incomplete_return_annotation has incomplete parameters list
local/moodlecheck/tests/fixtures/phpdoc_tags_inline.php
(#71) Invalid inline phpdocs tag @param found
(#72) Invalid inline phpdocs tag @throws found
(#76) Inline phpdocs tag not enclosed with curly brackets @see found
(#73) Inline phpdocs tag {@link tags need to have a valid URL} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#74) Inline phpdocs tag {@see https://moodle.org We do not support URLs in see tags.} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#75) Inline phpdocs tag {@see $this->tagrules['url']} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
local/moodlecheck/tests/moodlecheck_rules_test.php
(#268) Phpdocs for function moodlecheck_rules_test::test_empty_nophp_files has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]