Prechecker results: error


PHP lint problems

(2 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

local/moodlecheck/tests/fixtures/unfinished.php
(#31) PHP Parse error: Unterminated comment starting line 31 in /local/moodlecheck/tests/fixtures/unfinished.php on line 31
local/moodlecheck/tests/fixtures/uses.php
(#30) PHP Parse error: syntax error, unexpected token "{" in /local/moodlecheck/tests/fixtures/uses.php on line 30

PHP coding style problems

(18 errors, 6 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/moodlecheck/tests/fixtures/error_and_warning.php
(#2) The opening <?php tag must be followed by exactly one newline.
local/moodlecheck/tests/fixtures/nophp.php
(#1) No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
local/moodlecheck/tests/fixtures/phpdoc_method_overrides.php
(#17) Expected MOODLE_INTERNAL check or config.php inclusion. Multiple artifacts detected.
(#24) Closing brace must be on a line by itself
(#29) Closing brace must be on a line by itself
(#34) Closing brace must be on a line by itself
local/moodlecheck/tests/fixtures/phpdoc_properties.php
(#17) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#23) The 'var' keyword is not permitted.Visibility must be explicitly declared with public, private or protected
(#23) Scope modifier not specified for member variable "$undocumented1"
(#24) The 'var' keyword is not permitted.Visibility must be explicitly declared with public, private or protected
(#24) Scope modifier not specified for member variable "$undocumented2"
(#35) Inline doc block comments are not allowed; use "// Comment." instead
(#38) The 'var' keyword is not permitted.Visibility must be explicitly declared with public, private or protected
(#38) Scope modifier not specified for member variable "$documented1"
(#39) Inline doc block comments are not allowed; use "// Comment." instead
(#42) The 'var' keyword is not permitted.Visibility must be explicitly declared with public, private or protected
(#42) Scope modifier not specified for member variable "$documented2"
local/moodlecheck/tests/fixtures/phpdoc_tags_general.php
(#202) Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $one is optional, while parameter $two is required.
(#202) Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $one is optional, while parameter $three is required.
local/moodlecheck/tests/fixtures/unfinished.php
(#28) Duplicate class name "dummy_class_without_tags" found; first defined in /var/lib/jenkins/git_repositories/prechecker/local/moodlecheck/tests/fixtures/classtags.php on line 28
(#31) Inline doc block comments are not allowed; use "// Comment." instead
local/moodlecheck/tests/fixtures/uses.php
(#32) Class constants must be uppercase; expected NS but found ns
(#35) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#35) A closing tag is not permitted at the end of a PHP file

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(119 errors, 9 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/moodlecheck/file.php
(#37) Variable local_moodlecheck_file::$filepath is not documented
(#38) Variable local_moodlecheck_file::$needsvalidation is not documented
(#39) Variable local_moodlecheck_file::$errors is not documented
(#40) Variable local_moodlecheck_file::$tokens is not documented
(#41) Variable local_moodlecheck_file::$tokenscount is not documented
(#42) Variable local_moodlecheck_file::$classes is not documented
(#43) Variable local_moodlecheck_file::$interfaces is not documented
(#44) Variable local_moodlecheck_file::$traits is not documented
(#45) Variable local_moodlecheck_file::$functions is not documented
(#46) Variable local_moodlecheck_file::$filephpdocs is not documented
(#47) Variable local_moodlecheck_file::$allphpdocs is not documented
(#48) Variable local_moodlecheck_file::$variables is not documented
(#49) Variable local_moodlecheck_file::$defines is not documented
(#50) Variable local_moodlecheck_file::$constants is not documented
(#35) Constant local_moodlecheck_file::MODIFIERS is not documented
(#1372) Inline phpdocs tag {@link self::$validtags} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
local/moodlecheck/locallib.php
(#43) Function local_moodlecheck_rule::__construct is not documented
(#47) Function local_moodlecheck_rule::set_callback is not documented
(#52) Function local_moodlecheck_rule::set_rulestring is not documented
(#57) Function local_moodlecheck_rule::set_errorstring is not documented
(#62) Function local_moodlecheck_rule::set_severity is not documented
(#67) Function local_moodlecheck_rule::get_name is not documented
(#77) Function local_moodlecheck_rule::get_error_message is not documented
(#98) Function local_moodlecheck_rule::validatefile is not documented
(#125) Function local_moodlecheck_registry::add_rule is not documented
(#131) Function local_moodlecheck_registry::get_registered_rules is not documented
(#135) Function local_moodlecheck_registry::enable_rule is not documented
(#149) Function local_moodlecheck_registry::get_enabled_rules is not documented
(#153) Function local_moodlecheck_registry::enable_all_rules is not documented
(#175) Function local_moodlecheck_path::__construct is not documented
(#186) Function local_moodlecheck_path::get_fullpath is not documented
(#195) Function local_moodlecheck_path::validate is not documented
(#218) Function local_moodlecheck_path::is_ignored is not documented
(#229) Function local_moodlecheck_path::is_file is not documented
(#233) Function local_moodlecheck_path::is_dir is not documented
(#237) Function local_moodlecheck_path::get_path is not documented
(#241) Function local_moodlecheck_path::get_file is not documented
(#245) Function local_moodlecheck_path::get_subpaths is not documented
(#249) Function local_moodlecheck_path::set_rootpath is not documented
(#253) Function local_moodlecheck_path::is_rootpath is not documented
(#257) Function local_moodlecheck_path::get_components is not documented
(#294) Function local_moodlecheck_form::definition is not documented
(#37) Variable local_moodlecheck_rule::$code is not documented
(#38) Variable local_moodlecheck_rule::$callback is not documented
(#39) Variable local_moodlecheck_rule::$rulestring is not documented
(#40) Variable local_moodlecheck_rule::$errorstring is not documented
(#41) Variable local_moodlecheck_rule::$severity is not documented
(#122) Variable local_moodlecheck_registry::$rules is not documented
(#123) Variable local_moodlecheck_registry::$enabledrules is not documented
(#168) Variable local_moodlecheck_path::$path is not documented
(#169) Variable local_moodlecheck_path::$ignorepaths is not documented
(#170) Variable local_moodlecheck_path::$file is not documented
(#171) Variable local_moodlecheck_path::$subpaths is not documented
(#172) Variable local_moodlecheck_path::$validated is not documented
(#173) Variable local_moodlecheck_path::$rootpath is not documented
local/moodlecheck/rules/phpdocs_basic.php
(#334) Inline phpdocs tag not enclosed with curly brackets @link found
(#331) Inline phpdocs tag not enclosed with curly brackets @see found
local/moodlecheck/tests/fixtures/anonymous/named.php
(#27) Class someclass is not documented
local/moodlecheck/tests/fixtures/error_and_warning.php
(#2) Empty line found after PHP open tag
(#11) Class someclass is not documented
(#12) Function someclass::somefunc is not documented
local/moodlecheck/tests/fixtures/nophp.php
(#1) The file is empty or doesn't contain PHP code. Skipped.
local/moodlecheck/tests/fixtures/phpdoc_file_required_no1.php
(#17) Package is not specified for class dummy_fileclass_without_tags. It is also not specified in file-level phpdocs
local/moodlecheck/tests/fixtures/phpdoc_file_required_no2.php
(#17) Package is not specified for interface dummy_fileinterface_without_tags. It is also not specified in file-level phpdocs
local/moodlecheck/tests/fixtures/phpdoc_file_required_no3.php
(#17) Package is not specified for trait dummy_filetrait_without_tags. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block does not have @copyright tag
(#17) File-level phpdocs block does not have @license tag
local/moodlecheck/tests/fixtures/phpdoc_file_required_yes1.php
(#19) Package is not specified for class dummy_fileclass1_without_tags. It is also not specified in file-level phpdocs
(#25) Package is not specified for class dummy2_fileclass2_without_tags. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block is not found
local/moodlecheck/tests/fixtures/phpdoc_file_required_yes2.php
(#19) Package is not specified for function dummy_filefunction_without_tags. It is also not specified in file-level phpdocs
(#19) File-level phpdocs block is not found
(#19) Function dummy_filefunction_without_tags is not documented
local/moodlecheck/tests/fixtures/phpdoc_file_required_yes3.php
(#19) Package is not specified for interface dummy_fileinterface1_without_tags. It is also not specified in file-level phpdocs
(#25) Package is not specified for trait dummy_filetrait1_without_tags. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block is not found
local/moodlecheck/tests/fixtures/phpdoc_method_overrides.php
(#22) Package is not specified for class dummy_implements_something. It is also not specified in file-level phpdocs
(#27) Package is not specified for class dummy_extends_something. It is also not specified in file-level phpdocs
(#32) Package is not specified for class dummy_extends_and_implements_something. It is also not specified in file-level phpdocs
(#17) Package is not specified for interface dummy_top_level. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block is not found
(#22) Class dummy_implements_something is not documented
(#27) Class dummy_extends_something is not documented
(#32) Class dummy_extends_and_implements_something is not documented
(#19) Function dummy_top_level::undocumented is not documented
(#24) Function dummy_implements_something::undocumented is not documented
(#29) Function dummy_extends_something::undocumented is not documented
(#34) Function dummy_extends_and_implements_something::undocumented is not documented
local/moodlecheck/tests/fixtures/phpdoc_properties.php
(#19) Package is not specified for class dummy_with_properties. It is also not specified in file-level phpdocs
(#23) Variable dummy_with_properties::$undocumented1 is not documented
(#24) Variable dummy_with_properties::$undocumented2 is not documented
(#25) Variable dummy_with_properties::$undocumented3 is not documented
(#26) Variable dummy_with_properties::$undocumented4 is not documented
(#27) Constant dummy_with_properties::UNDOCUMENTED_CONSTANT1 is not documented
(#28) Constant dummy_with_properties::UNDOCUMENTED_CONSTANT2 is not documented
(#31) Invalid phpdocs tag @const used
local/moodlecheck/tests/fixtures/phpdoc_tags_general.php
(#69) Phpdocs for function fixturing_general::incomplete_param_annotation has incomplete parameters list
(#79) Phpdocs for function fixturing_general::missing_param_defintion has incomplete parameters list
(#86) Phpdocs for function fixturing_general::missing_param_annotation has incomplete parameters list
(#96) Phpdocs for function fixturing_general::incomplete_param_definition has incomplete parameters list
(#106) Phpdocs for function fixturing_general::incomplete_param_annotation1 has incomplete parameters list
(#115) Phpdocs for function fixturing_general::mismatch_param_types has incomplete parameters list
(#125) Phpdocs for function fixturing_general::mismatch_param_types1 has incomplete parameters list
(#135) Phpdocs for function fixturing_general::mismatch_param_types2 has incomplete parameters list
(#145) Phpdocs for function fixturing_general::mismatch_param_types3 has incomplete parameters list
(#216) Phpdocs for function fixturing_general::incomplete_return_annotation has incomplete parameters list
(#54) Invalid phpdocs tag @codingStandardsIgnoreLine used
(#58) Invalid phpdocs tag @small used
(#59) Invalid phpdocs tag @zzzing used
(#60) Invalid phpdocs tag @inheritdoc used
(#55) Incorrect path for phpdocs tag @covers detected
(#56) Incorrect path for phpdocs tag @dataProvider detected
(#57) Incorrect path for phpdocs tag @group detected
local/moodlecheck/tests/fixtures/phpdoc_tags_inline.php
(#71) Invalid inline phpdocs tag @param found
(#72) Invalid inline phpdocs tag @throws found
(#76) Inline phpdocs tag not enclosed with curly brackets @see found
(#73) Inline phpdocs tag {@link tags need to have a valid URL} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#74) Inline phpdocs tag {@see https://moodle.org We do not support URLs in see tags.} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#75) Inline phpdocs tag {@see $this->tagrules['url']} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
local/moodlecheck/tests/fixtures/phpdoc_tags_packagespecified.php
(#28) Package is not specified for class missingclass. It is also not specified in file-level phpdocs
(#52) Package is not specified for interface missinginterface. It is also not specified in file-level phpdocs
(#40) Package is not specified for trait missingtrait. It is also not specified in file-level phpdocs
(#62) Package is not specified for function missingfunction. It is also not specified in file-level phpdocs
local/moodlecheck/tests/fixtures/phpdoc_tags_test.php
(#68) Invalid phpdocs tag @small used
(#69) Invalid phpdocs tag @zzzing used
(#70) Invalid phpdocs tag @inheritdoc used
local/moodlecheck/tests/fixtures/uses.php
(#17) File-level phpdocs block does not have @copyright tag
local/moodlecheck/tests/moodlecheck_rules_test.php
(#409) Phpdocs for function moodlecheck_rules_test::test_empty_nophp_files has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]