Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(143 errors, 42 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/mobile/check.php
(#67) Expected "} else {\n"; found "}\n else {\n"
local/mobile/db/services.php
(#158) Expected 1 space before "=>"; 0 found
(#166) Expected 1 space before "=>"; 0 found
(#182) Expected 1 space before "=>"; 0 found
local/mobile/db/upgrade.php
(#51) Empty CATCH statement detected
local/mobile/externallib.php
(#157) Expected 1 space after "="; newline found
(#336) Inline comments must start with a capital letter, digit or 3-dots sequence
(#417) Line exceeds 132 characters; contains 136 characters
(#574) Expected 1 space after "="; newline found
(#598) Expected 1 space before "?"; 0 found
(#599) Expected 1 space before "?"; 0 found
(#621) Expected 1 space before "?"; 0 found
(#622) Expected 1 space before "?"; 0 found
(#623) Expected 1 space before "?"; 0 found
(#654) Expected 1 space before "?"; 0 found
(#655) Expected 1 space before "?"; 0 found
(#680) Expected 1 space before "?"; 0 found
(#681) Expected 1 space before "?"; 0 found
(#703) Line exceeds 132 characters; contains 140 characters
(#1076) Line exceeds 132 characters; contains 139 characters
(#1078) Line exceeds 132 characters; contains 134 characters
(#1389) Expected 1 space after "="; newline found
(#1613) Expected 1 space after "="; newline found
(#2303) Expected 1 space after "="; newline found
(#2825) Line exceeds 132 characters; contains 136 characters
(#3193) Expected 9 space(s) before asterisk; 5 found
(#3194) Expected 9 space(s) before asterisk; 5 found
(#3195) Expected 9 space(s) before asterisk; 5 found
(#3196) Expected 9 space(s) before asterisk; 5 found
(#3197) Expected 9 space(s) before asterisk; 5 found
(#4653) Expected 1 space after "="; newline found
(#4922) Expected 9 space(s) before asterisk; 5 found
(#4923) Expected 9 space(s) before asterisk; 5 found
(#4924) Expected 9 space(s) before asterisk; 5 found
(#4925) Expected 9 space(s) before asterisk; 5 found
(#4926) Expected 9 space(s) before asterisk; 5 found
(#5142) Expected 9 space(s) before asterisk; 5 found
(#5143) Expected 9 space(s) before asterisk; 5 found
(#5144) Expected 9 space(s) before asterisk; 5 found
(#5145) Expected 9 space(s) before asterisk; 5 found
(#5146) Expected 9 space(s) before asterisk; 5 found
(#5217) Expected 1 space after "="; newline found
(#5861) Expected 1 space after "="; newline found
(#6033) Expected 1 space after "="; newline found
(#6360) Expected 1 space after "="; newline found
(#6811) Line exceeds 132 characters; contains 136 characters
(#6842) Line exceeds 132 characters; contains 137 characters
(#7476) Expected 1 space after "="; newline found
(#7501) Line exceeds 132 characters; contains 138 characters
(#7932) Line exceeds 132 characters; contains 137 characters
(#7966) Line exceeds 132 characters; contains 137 characters
(#8472) Empty IF statement detected
(#9198) Expected 1 space after "="; newline found
(#9919) Line exceeds 132 characters; contains 133 characters
(#10098) Line exceeds 132 characters; contains 136 characters
(#10395) Line exceeds 132 characters; contains 137 characters
(#11011) Expected 1 space after "="; newline found
(#11516) Line exceeds 132 characters; contains 139 characters
local/mobile/futurelib.php
(#410) No space found before comment text; expected "// There is no admin configuration for this tool. Use configuration in the lti instance record plus some defaults." but found "//There is no admin configuration for this tool. Use configuration in the lti instance record plus some defaults."
(#419) Inline comments must end in full-stops, exclamation marks, or question marks
(#419) No space found before comment text; expected "// Default the organizationid if not specified" but found "//Default the organizationid if not specified"
(#440) Inline comments must end in full-stops, exclamation marks, or question marks
(#440) No space found before comment text; expected "// If the current request is using SSL and a secure tool URL is specified, use it" but found "//If the current request is using SSL and a secure tool URL is specified, use it"
(#444) No space found before comment text; expected "// If SSL is forced, use the secure tool url if specified. Otherwise, make sure https is on the normal launch URL." but found "//If SSL is forced, use the secure tool url if specified. Otherwise, make sure https is on the normal launch URL."
(#486) No space found before comment text; expected "// If no key and secret, do the launch unsigned." but found "//If no key and secret, do the launch unsigned."
(#1085) Empty IF statement detected
(#1674) Line exceeds 132 characters; contains 134 characters
(#2411) Expected 1 space after "+"; newline found
(#2996) Line exceeds 132 characters; contains 139 characters
local/mobile/launch.php
(#221) Line exceeds 132 characters; contains 138 characters
(#221) Line exceeds 132 characters; contains 138 characters
(#221) Line exceeds 132 characters; contains 138 characters
(#221) Line exceeds 132 characters; contains 138 characters
local/mobile/locallib.php
(#36) Line exceeds 132 characters; contains 158 characters
(#39) Expected MOODLE_INTERNAL check or config.php inclusion
(#39) Variable "userid_or_ids" must not contain underscores.
(#46) Variable "course_item" must not contain underscores.
(#48) Variable "course_item" must not contain underscores.
(#65) Variable "grade_items" must not contain underscores.
(#66) Variable "grade_items" must not contain underscores.
(#66) Variable "grade_item" must not contain underscores.
(#69) Variable "grade_item" must not contain underscores.
(#70) Inline comments must start with a capital letter, digit or 3-dots sequence
(#70) Inline comments must end in full-stops, exclamation marks, or question marks
(#72) Variable "grade_item" must not contain underscores.
(#73) Variable "grade_item" must not contain underscores.
(#74) Variable "grade_item" must not contain underscores.
(#75) Variable "grade_item" must not contain underscores.
(#76) Variable "grade_item" must not contain underscores.
(#77) Variable "grade_item" must not contain underscores.
(#78) Variable "grade_item" must not contain underscores.
(#79) Variable "grade_item" must not contain underscores.
(#80) Variable "grade_item" must not contain underscores.
(#81) Variable "grade_item" must not contain underscores.
(#82) Variable "grade_item" must not contain underscores.
(#83) Variable "grade_item" must not contain underscores.
(#86) Variable "grade_item" must not contain underscores.
(#102) Variable "userid_or_ids" must not contain underscores.
(#105) Variable "userid_or_ids" must not contain underscores.
(#106) Variable "userid_or_ids" must not contain underscores.
(#109) Variable "userid_or_ids" must not contain underscores.
(#113) Variable "grade_grades" must not contain underscores.
(#113) Variable "grade_item" must not contain underscores.
(#115) Variable "grade_grades" must not contain underscores.
(#115) Variable "grade_item" must not contain underscores.
(#118) Variable "grade_grades" must not contain underscores.
(#119) Variable "grade_grades" must not contain underscores.
(#120) Variable "grade_grades" must not contain underscores.
(#121) Variable "grade_grades" must not contain underscores.
(#122) Variable "grade_grades" must not contain underscores.
(#123) Variable "grade_grades" must not contain underscores.
(#124) Variable "grade_grades" must not contain underscores.
(#125) Variable "grade_grades" must not contain underscores.
(#126) Variable "grade_grades" must not contain underscores.
(#128) Inline comments must start with a capital letter, digit or 3-dots sequence
(#128) Inline comments must end in full-stops, exclamation marks, or question marks
(#129) Variable "grade_item" must not contain underscores.
(#129) Variable "grade_item" must not contain underscores.
(#134) Variable "grade_item" must not contain underscores.
(#144) Variable "grade_item" must not contain underscores.
(#145) Variable "grade_item" must not contain underscores.
(#145) Variable "grade_item" must not contain underscores.
(#145) Line exceeds 132 characters; contains 138 characters
(#150) Variable "grade_item" must not contain underscores.
(#150) Variable "grade_item" must not contain underscores.
(#155) Inline comments must start with a capital letter, digit or 3-dots sequence
(#155) Inline comments must end in full-stops, exclamation marks, or question marks
(#168) Variable "grade_outcome" must not contain underscores.
(#168) Expected 1 space before "=>"; 0 found
(#168) Expected 1 space after "=>"; 0 found
(#168) Variable "grade_item" must not contain underscores.
(#173) Inline comments must start with a capital letter, digit or 3-dots sequence
(#173) Inline comments must end in full-stops, exclamation marks, or question marks
(#175) Variable "grade_item" must not contain underscores.
(#176) Variable "grade_item" must not contain underscores.
(#177) Variable "grade_item" must not contain underscores.
(#178) Variable "grade_item" must not contain underscores.
(#179) Variable "grade_item" must not contain underscores.
(#180) Variable "grade_outcome" must not contain underscores.
(#181) Variable "grade_outcome" must not contain underscores.
(#182) Variable "grade_item" must not contain underscores.
(#183) Variable "grade_item" must not contain underscores.
(#185) Variable "userid_or_ids" must not contain underscores.
(#187) Variable "userid_or_ids" must not contain underscores.
(#188) Variable "userid_or_ids" must not contain underscores.
(#190) Variable "userid_or_ids" must not contain underscores.
(#194) Variable "grade_grades" must not contain underscores.
(#194) Variable "grade_item" must not contain underscores.
(#196) Variable "grade_grades" must not contain underscores.
(#196) Variable "grade_item" must not contain underscores.
(#199) Variable "grade_grades" must not contain underscores.
(#200) Variable "grade_grades" must not contain underscores.
(#201) Variable "grade_grades" must not contain underscores.
(#202) Variable "grade_grades" must not contain underscores.
(#203) Variable "grade_grades" must not contain underscores.
(#204) Variable "grade_grades" must not contain underscores.
(#206) Inline comments must start with a capital letter, digit or 3-dots sequence
(#206) Inline comments must end in full-stops, exclamation marks, or question marks
(#207) Variable "grade_item" must not contain underscores.
(#217) Variable "grade_item" must not contain underscores.
(#218) Expected 1 space before "-"; 0 found
(#218) Expected 1 space after "-"; 0 found
(#221) Inline comments must start with a capital letter, digit or 3-dots sequence
(#221) Inline comments must end in full-stops, exclamation marks, or question marks
(#232) Variable "grade_item" must not contain underscores.
(#233) Inline comments must start with a capital letter, digit or 3-dots sequence
(#234) Variable "grade_item" must not contain underscores.
(#235) Expected "while (...) {\n"; found "while(...) {\n"
(#235) Expected 1 space before "=>"; 0 found
(#235) Expected 1 space after "=>"; 0 found
(#235) Expected 1 space before "=>"; 0 found
(#235) Expected 1 space after "=>"; 0 found
(#235) Expected 1 space before "=>"; 0 found
(#235) Expected 1 space after "=>"; 0 found
(#235) Expected 1 space before "=>"; 0 found
(#235) Expected 1 space after "=>"; 0 found
(#235) Expected 1 space before "=>"; 0 found
(#235) Expected 1 space after "=>"; 0 found
(#235) Line exceeds maximum limit of 180 characters; contains 183 characters
(#239) Variable "grade_item" must not contain underscores.
(#240) Variable "grade_item" must not contain underscores.
(#249) Inline comments must start with a capital letter, digit or 3-dots sequence
(#249) Inline comments must end in full-stops, exclamation marks, or question marks
(#277) Line indented incorrectly; expected at least 8 spaces, found 7
(#280) Line exceeds 132 characters; contains 135 characters

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by jshint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]


PHPDocs style problems

(22 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/mobile/check.php
(#17) No one-line description found in phpdocs for file
local/mobile/db/upgrade.php
(#27) Function xmldb_local_mobile_upgrade is not documented
local/mobile/externallib.php
(#35) Class local_mobile_external is not documented
(#1265) Phpdocs for function local_mobile_external::mod_forum_get_forum_discussions_paginated has incomplete parameters list
(#11724) Phpdocs for function local_mobile_external::mod_quiz_view_attempt has incomplete parameters list
(#11795) Phpdocs for function local_mobile_external::mod_quiz_view_attempt_summary has incomplete parameters list
local/mobile/futurelib.php
(#2485) Class local_mobile_quiz is not documented
(#2575) Class local_mobile_quiz_attempt is not documented
(#2943) Class local_mobile_quiz_access_manager is not documented
(#2966) Class local_mobile_question_bank is not documented
(#755) Function enrol_guest_get_enrol_info is not documented
(#2284) Function local_mobile_external_format_text is not documented
(#2874) Function local_mobile_quiz_attempt::determine_layout is not documented
(#2894) Function local_mobile_quiz_attempt::number_questions is not documented
(#2918) Function local_mobile_quiz_attempt::set_offline_modified_time is not documented
(#2987) Function local_mobile_mod_quiz_add_timemodifiedoffline is not documented
(#320) Phpdocs for function external_util::validate_courses has incomplete parameters list
(#358) Phpdocs for function external_format_string has incomplete parameters list
(#310) Package core_webservice is not valid
(#875) Package mod_glossary is not valid
local/mobile/launch.php
(#27) Function is_ios is not documented
local/mobile/server.php
(#46) Package webservice_corsrest is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]