Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(168 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

public/local/helpdesk/categories.php
(#65) Blank line found at start of control structure
(#77) Blank line found at end of control structure
(#78) Blank line found at start of control structure
(#89) Opening parenthesis of a multi-line function call must be the last content on the line
(#90) Only one argument is allowed per line in a multi-line function call
(#91) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#91) Closing parenthesis of a multi-line function call must be on a line by itself
(#95) Opening parenthesis of a multi-line function call must be the last content on the line
(#96) Only one argument is allowed per line in a multi-line function call
(#97) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#97) Closing parenthesis of a multi-line function call must be on a line by itself
(#105) Opening parenthesis of a multi-line function call must be the last content on the line
(#106) Only one argument is allowed per line in a multi-line function call
(#107) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#107) Closing parenthesis of a multi-line function call must be on a line by itself
(#113) Opening parenthesis of a multi-line function call must be the last content on the line
(#119) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#119) Closing parenthesis of a multi-line function call must be on a line by itself
(#124) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#124) Closing parenthesis of a multi-line function call must be on a line by itself
public/local/helpdesk/classes/external/geniai.php
(#44) Opening brace must not be followed by a blank line
(#119) Opening parenthesis of a multi-line function call must be the last content on the line
(#119) Only one argument is allowed per line in a multi-line function call
(#125) Multi-line function call not indented correctly; expected 24 spaces but found 28
(#125) Closing parenthesis of a multi-line function call must be on a line by itself
(#132) Opening parenthesis of a multi-line function call must be the last content on the line
(#132) Only one argument is allowed per line in a multi-line function call
(#136) Multi-line function call not indented correctly; expected 24 spaces but found 28
(#136) Closing parenthesis of a multi-line function call must be on a line by itself
(#159) Opening parenthesis of a multi-line function call must be the last content on the line
(#159) Only one argument is allowed per line in a multi-line function call
(#163) Multi-line function call not indented correctly; expected 20 spaces but found 24
(#163) Closing parenthesis of a multi-line function call must be on a line by itself
(#168) Opening parenthesis of a multi-line function call must be the last content on the line
(#168) Only one argument is allowed per line in a multi-line function call
(#172) Multi-line function call not indented correctly; expected 20 spaces but found 24
(#172) Closing parenthesis of a multi-line function call must be on a line by itself
(#179) Blank line found at start of control structure
(#260) Opening parenthesis of a multi-line function call must be the last content on the line
(#260) Only one argument is allowed per line in a multi-line function call
(#266) Multi-line function call not indented correctly; expected 20 spaces but found 24
(#266) Closing parenthesis of a multi-line function call must be on a line by itself
(#277) Blank line found at start of control structure
public/local/helpdesk/classes/external/ticket.php
(#42) Opening brace must not be followed by a blank line
(#118) Blank line found at start of control structure
public/local/helpdesk/classes/form/category_candidate_selector.php
(#67) Long list syntax is not allowed
(#80) Long list syntax is not allowed
public/local/helpdesk/classes/form/category_controller.php
(#41) Opening brace must not be followed by a blank line
(#56) Blank line found at start of control structure
(#68) Blank line found at start of control structure
(#146) Blank line found at start of control structure
(#176) Blank line found at start of control structure
(#180) Blank line found at start of control structure
public/local/helpdesk/classes/form/category_existing_selector.php
(#67) Long list syntax is not allowed
(#80) Long list syntax is not allowed
public/local/helpdesk/classes/form/category_form.php
(#39) Opening brace must not be followed by a blank line
public/local/helpdesk/classes/form/knowledgebase_controller.php
(#50) Blank line found at start of control structure
(#64) Blank line found at start of control structure
public/local/helpdesk/classes/form/response_controller.php
(#58) Blank line found at start of control structure
(#79) Opening parenthesis of a multi-line function call must be the last content on the line
(#79) Only one argument is allowed per line in a multi-line function call
(#80) Multi-line function call not indented correctly; expected 16 spaces but found 20
(#80) Only one argument is allowed per line in a multi-line function call
(#80) Only one argument is allowed per line in a multi-line function call
(#80) Only one argument is allowed per line in a multi-line function call
(#80) Closing parenthesis of a multi-line function call must be on a line by itself
public/local/helpdesk/classes/form/response_form.php
(#72) Blank line found at start of control structure
public/local/helpdesk/classes/form/ticket_controller.php
(#37) Opening brace must not be followed by a blank line
(#73) Opening parenthesis of a multi-line function call must be the last content on the line
(#73) Only one argument is allowed per line in a multi-line function call
(#74) Multi-line function call not indented correctly; expected 16 spaces but found 20
(#74) Only one argument is allowed per line in a multi-line function call
(#74) Only one argument is allowed per line in a multi-line function call
(#74) Only one argument is allowed per line in a multi-line function call
(#74) Closing parenthesis of a multi-line function call must be on a line by itself
public/local/helpdesk/classes/form/ticket_form.php
(#41) Opening brace must not be followed by a blank line
public/local/helpdesk/classes/mail/send_message.php
(#93) Blank line found at start of control structure
public/local/helpdesk/classes/mail/ticket_mail.php
(#42) Opening brace must not be followed by a blank line
(#60) Opening parenthesis of a multi-line function call must be the last content on the line
(#64) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#64) Closing parenthesis of a multi-line function call must be on a line by itself
(#66) Opening parenthesis of a multi-line function call must be the last content on the line
(#70) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#70) Closing parenthesis of a multi-line function call must be on a line by itself
(#71) Opening parenthesis of a multi-line function call must be the last content on the line
(#75) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#75) Closing parenthesis of a multi-line function call must be on a line by itself
(#77) Opening parenthesis of a multi-line function call must be the last content on the line
(#81) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#81) Closing parenthesis of a multi-line function call must be on a line by itself
(#83) Opening parenthesis of a multi-line function call must be the last content on the line
(#87) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#87) Closing parenthesis of a multi-line function call must be on a line by itself
(#127) Opening parenthesis of a multi-line function call must be the last content on the line
(#131) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#131) Closing parenthesis of a multi-line function call must be on a line by itself
(#133) Opening parenthesis of a multi-line function call must be the last content on the line
(#137) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#137) Closing parenthesis of a multi-line function call must be on a line by itself
(#138) Opening parenthesis of a multi-line function call must be the last content on the line
(#142) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#142) Closing parenthesis of a multi-line function call must be on a line by itself
(#144) Opening parenthesis of a multi-line function call must be the last content on the line
(#148) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#148) Closing parenthesis of a multi-line function call must be on a line by itself
(#150) Opening parenthesis of a multi-line function call must be the last content on the line
(#154) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#154) Closing parenthesis of a multi-line function call must be on a line by itself
public/local/helpdesk/classes/model/knowledgebase.php
(#34) Opening brace must not be followed by a blank line
public/local/helpdesk/classes/model/response.php
(#32) Opening brace must not be followed by a blank line
public/local/helpdesk/classes/model/ticket.php
(#32) Opening brace must not be followed by a blank line
public/local/helpdesk/classes/privacy/provider.php
(#44) The interface names in a "class implements" statement should be ordered alphabetically. Expected: \core_privacy\local\metadata\provider, \core_privacy\local\request\core_userlist_provider, \core_privacy\local\request\plugin\provider; Found: \core_privacy\local\request\core_userlist_provider, \core_privacy\local\metadata\provider, \core_privacy\local\request\plugin\provider
(#47) Opening brace must not be followed by a blank line
(#57) Opening parenthesis of a multi-line function call must be the last content on the line
(#63) Opening parenthesis of a multi-line function call must be the last content on the line
(#69) Opening parenthesis of a multi-line function call must be the last content on the line
public/local/helpdesk/classes/task/close_tickets.php
(#34) Opening brace must not be followed by a blank line
public/local/helpdesk/classes/task/response_tickets.php
(#32) Opening brace must not be followed by a blank line
public/local/helpdesk/classes/util/filter.php
(#28) Opening brace must not be followed by a blank line
public/local/helpdesk/db/upgrade.php
(#115) Blank line found at end of control structure
(#122) Blank line found at start of control structure
public/local/helpdesk/index.php
(#72) Opening parenthesis of a multi-line function call must be the last content on the line
(#73) Multi-line function call not indented correctly; expected 0 spaces but found 4
(#73) Closing parenthesis of a multi-line function call must be on a line by itself
(#80) Blank line found at start of control structure
(#109) Opening parenthesis of a multi-line function call must be the last content on the line
(#110) Multi-line function call not indented correctly; expected 4 spaces but found 8
(#110) Only one argument is allowed per line in a multi-line function call
(#110) Only one argument is allowed per line in a multi-line function call
(#110) Closing parenthesis of a multi-line function call must be on a line by itself
(#213) Blank line found at start of control structure
(#239) Opening parenthesis of a multi-line function call must be the last content on the line
(#240) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#240) Only one argument is allowed per line in a multi-line function call
(#240) Closing parenthesis of a multi-line function call must be on a line by itself
(#241) Opening parenthesis of a multi-line function call must be the last content on the line
(#242) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#242) Only one argument is allowed per line in a multi-line function call
(#242) Closing parenthesis of a multi-line function call must be on a line by itself
(#243) Opening parenthesis of a multi-line function call must be the last content on the line
(#244) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#244) Only one argument is allowed per line in a multi-line function call
(#244) Closing parenthesis of a multi-line function call must be on a line by itself
(#245) Opening parenthesis of a multi-line function call must be the last content on the line
(#246) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#246) Only one argument is allowed per line in a multi-line function call
(#246) Closing parenthesis of a multi-line function call must be on a line by itself
public/local/helpdesk/knowledgebase.php
(#54) Opening parenthesis of a multi-line function call must be the last content on the line
(#55) Multi-line function call not indented correctly; expected 0 spaces but found 4
(#55) Closing parenthesis of a multi-line function call must be on a line by itself
(#78) Blank line found at start of control structure
(#90) Opening parenthesis of a multi-line function call must be the last content on the line
(#91) Only one argument is allowed per line in a multi-line function call
(#92) Multi-line function call not indented correctly; expected 12 spaces but found 16
(#92) Closing parenthesis of a multi-line function call must be on a line by itself
(#98) Opening parenthesis of a multi-line function call must be the last content on the line
(#104) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#104) Closing parenthesis of a multi-line function call must be on a line by itself
(#109) Multi-line function call not indented correctly; expected 8 spaces but found 12
(#109) Closing parenthesis of a multi-line function call must be on a line by itself
public/local/helpdesk/settings.php
(#27) Blank line found at start of control structure
public/local/helpdesk/ticket.php
(#89) Opening parenthesis of a multi-line function call must be the last content on the line
(#90) Multi-line function call not indented correctly; expected 0 spaces but found 4
(#90) Closing parenthesis of a multi-line function call must be on a line by itself
(#91) Opening parenthesis of a multi-line function call must be the last content on the line
(#92) Multi-line function call not indented correctly; expected 0 spaces but found 4
(#92) Closing parenthesis of a multi-line function call must be on a line by itself
(#144) Blank line found at start of control structure

Javascript coding style problems

(10 errors, 22 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

public/local/helpdesk/amd/src/filter_course.js
(#19) @package should be empty. (jsdoc/empty-tags)
(#24) Identifier 'dataTables_init' is not in camel case. (camelcase)
(#27) Identifier 'data_course_block_select' is not in camel case. (camelcase)
(#35) Unexpected console statement. (no-console)
(#39) Identifier 'data_course_block_select' is not in camel case. (camelcase)
(#40) Identifier 'data_course_block_select' is not in camel case. (camelcase)
(#42) Expected catch,fail,always() or return (promise/catch-or-return)
(#47) Each then() should return a value or throw (promise/always-return)
(#51) Identifier 'data_course_block_select' is not in camel case. (camelcase)
(#52) Identifier 'data_course_block_select' is not in camel case. (camelcase)
(#53) Identifier 'data_course_block_select' is not in camel case. (camelcase)
(#54) Identifier 'data_course_block_select' is not in camel case. (camelcase)
(#61) Identifier 'dataTables_init' is not in camel case. (camelcase)
(#82) Identifier 'export_title' is not in camel case. (camelcase)
(#91) ["datatable_course_select"] is better written in dot notation. (dot-notation)
(#96) Identifier 'data_course_block_select' is not in camel case. (camelcase)
(#103) Missing semicolon. (@babel/semi)
public/local/helpdesk/amd/src/filter_user.js
(#19) @package should be empty. (jsdoc/empty-tags)
(#24) Identifier 'dataTables_init' is not in camel case. (camelcase)
(#33) Unexpected console statement. (no-console)
(#43) Identifier 'data_user_block_select' is not in camel case. (camelcase)
(#45) Expected catch,fail,always() or return (promise/catch-or-return)
(#50) Each then() should return a value or throw (promise/always-return)
(#54) Identifier 'data_user_block_select' is not in camel case. (camelcase)
(#64) Identifier 'dataTables_init' is not in camel case. (camelcase)
(#78) Identifier 'export_title' is not in camel case. (camelcase)
(#90) ["datatable_user_select"] is better written in dot notation. (dot-notation)
public/local/helpdesk/amd/src/index.js
(#19) @package should be empty. (jsdoc/empty-tags)
(#35) Missing semicolon. (@babel/semi)
public/local/helpdesk/amd/src/ticket.js
(#19) @package should be empty. (jsdoc/empty-tags)
(#24) 'ui' is defined but never used. (no-unused-vars)
(#67) Missing semicolon. (@babel/semi)

CSS problems

(37 errors, 1 warnings)

This section shows CSS problems detected by stylelint [More info]

public/local/helpdesk/styles.css
(#81) Expected empty line before at-rule (at-rule-empty-line-before)
(#344) Expected empty line before at-rule (at-rule-empty-line-before)
(#349) Expected empty line before at-rule (at-rule-empty-line-before)
(#112) Unexpected !important (declaration-no-important)
(#154) Unexpected !important (declaration-no-important)
(#292) Unexpected !important (declaration-no-important)
(#312) Unexpected !important (declaration-no-important)
(#317) Unexpected !important (declaration-no-important)
(#321) Unexpected !important (declaration-no-important)
(#324) Unexpected !important (declaration-no-important)
(#333) Unexpected !important (declaration-no-important)
(#342) Unexpected !important (declaration-no-important)
(#346) Unexpected !important (declaration-no-important)
(#351) Unexpected !important (declaration-no-important)
(#390) Unexpected URL scheme "data:" (function-url-scheme-disallowed-list)
(#111) Expected line length to be no more than 132 characters (max-line-length)
(#95) Expected newline after "," (selector-list-comma-newline-after)
(#111) Expected newline after "," (selector-list-comma-newline-after)
(#111) Expected newline after "," (selector-list-comma-newline-after)
public/local/helpdesk/styles.scss
(#20) Unexpected !important (declaration-no-important)
(#64) Unexpected !important (declaration-no-important)
(#205) Unexpected !important (declaration-no-important)
(#212) Unexpected !important (declaration-no-important)
(#219) Unexpected !important (declaration-no-important)
(#222) Unexpected !important (declaration-no-important)
(#226) Unexpected !important (declaration-no-important)
(#236) Unexpected !important (declaration-no-important)
(#245) Unexpected !important (declaration-no-important)
(#249) Unexpected !important (declaration-no-important)
(#252) Unexpected !important (declaration-no-important)
(#294) Unexpected URL scheme "data:" (function-url-scheme-disallowed-list)
(#228) Unexpected whitespace at end of line (no-eol-whitespace)
(#255) Unexpected whitespace at end of line (no-eol-whitespace)
(#261) Unexpected whitespace at end of line (no-eol-whitespace)
(#276) Unexpected whitespace at end of line (no-eol-whitespace)
(#301) Unexpected whitespace at end of line (no-eol-whitespace)
(#19) Expected newline after "," (selector-list-comma-newline-after)
(#19) Expected newline after "," (selector-list-comma-newline-after)

PHPDocs style problems

(3 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

public/local/helpdesk/classes/model/ticket.php
(#276) Phpdocs for function ticket::get_description has incomplete parameters list
(#607) Phpdocs for function ticket::set_answeredat has incomplete parameters list
(#616) Phpdocs for function ticket::set_closedat has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

public/local/helpdesk/templates/category-users.mustache
(#1) HTML Validation info, line 16: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ("((add))"><br/> )
public/local/helpdesk/templates/knowledgebase-form-ia.mustache
(#1) ESLint did not run
public/local/helpdesk/templates/response-form-ia.mustache
(#1) ESLint did not run

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]