Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(20 errors, 3 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/easycustmenu/classes/api/menu_item_context.php
(#68) PHP4 style constructors are not allowed; use "__construct()" instead
local/easycustmenu/classes/helper.php
(#60) Variable "user_id" must not contain underscores.
(#79) Variable "user_id" must not contain underscores.
(#79) Variable "user_id" must not contain underscores.
(#80) Variable "user_id" must not contain underscores.
(#135) Variable "user_roles" must not contain underscores.
(#135) Must use "self::" for local static member reference
(#136) Variable "user_roles" must not contain underscores.
(#136) Variable "user_role" must not contain underscores.
(#138) Variable "user_role" must not contain underscores.
(#139) Variable "user_role" must not contain underscores.
(#139) Variable "user_role" must not contain underscores.
(#140) Variable "user_role" must not contain underscores.
(#140) There should be a comma after the last array item in a multi-line array.
(#147) Whitespace found at end of line
(#158) Inline comments must start with a capital letter, digit or 3-dots sequence
(#158) This comment is 59% valid code; is this commented out code?
(#159) Expected 1 space before comment text but found 5; use block comment if you need indentation
(#160) Expected 1 space before comment text but found 9; use block comment if you need indentation
(#161) Expected 1 space before comment text but found 5; use block comment if you need indentation
(#162) Inline comments must end in full-stops, exclamation marks, or question marks
(#165) Variable "has_in_contextlevels" must not contain underscores.
(#166) Variable "has_in_contextlevels" must not contain underscores.

Javascript coding style problems

(0 errors, 144 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/easycustmenu/amd/src/easy-menu-drag.js
(#25) Unexpected space before function parentheses. (space-before-function-paren)
(#30) Identifier 'menu_drag' is not in camel case. (camelcase)
(#30) Identifier 'menu_type' is not in camel case. (camelcase)
(#32) Identifier 'menu_type' is not in camel case. (camelcase)
(#33) Unexpected space before function parentheses. (space-before-function-paren)
(#35) Identifier 'input_itemdepth' is not in camel case. (camelcase)
(#37) Identifier 'end_x' is not in camel case. (camelcase)
(#38) Identifier 'start_x' is not in camel case. (camelcase)
(#39) Identifier 'prev_element' is not in camel case. (camelcase)
(#40) Identifier 'prev_element_itemdepth' is not in camel case. (camelcase)
(#41) Identifier 'prev_element' is not in camel case. (camelcase)
(#42) Identifier 'prev_element_itemdepth' is not in camel case. (camelcase)
(#42) Identifier 'prev_element' is not in camel case. (camelcase)
(#44) Identifier 'menu_item' is not in camel case. (camelcase)
(#45) Comments should not begin with a lowercase character. (capitalized-comments)
(#46) Identifier 'end_x' is not in camel case. (camelcase)
(#46) Identifier 'start_x' is not in camel case. (camelcase)
(#46) Identifier 'end_x' is not in camel case. (camelcase)
(#46) Identifier 'start_x' is not in camel case. (camelcase)
(#47) Identifier 'new_itemdepth' is not in camel case. (camelcase)
(#48) Identifier 'new_itemdepth' is not in camel case. (camelcase)
(#48) Identifier 'prev_element_itemdepth' is not in camel case. (camelcase)
(#50) Identifier 'input_itemdepth' is not in camel case. (camelcase)
(#51) Identifier 'new_itemdepth' is not in camel case. (camelcase)
(#52) Identifier 'menu_item' is not in camel case. (camelcase)
(#58) Comments should not begin with a lowercase character. (capitalized-comments)
(#59) Identifier 'end_x' is not in camel case. (camelcase)
(#59) Identifier 'start_x' is not in camel case. (camelcase)
(#59) Identifier 'end_x' is not in camel case. (camelcase)
(#59) Identifier 'start_x' is not in camel case. (camelcase)
(#60) Identifier 'new_itemdepth' is not in camel case. (camelcase)
(#62) Identifier 'new_itemdepth' is not in camel case. (camelcase)
(#65) Identifier 'input_itemdepth' is not in camel case. (camelcase)
(#66) Identifier 'new_itemdepth' is not in camel case. (camelcase)
(#67) Identifier 'menu_item' is not in camel case. (camelcase)
(#77) Identifier 'easy_menu_drag' is not in camel case. (camelcase)
(#77) Unexpected space before function parentheses. (space-before-function-paren)
(#77) Identifier 'menu_type' is not in camel case. (camelcase)
local/easycustmenu/amd/src/ecm.js
(#31) Identifier 'target_blank_menu' is not in camel case. (camelcase)
(#31) Identifier 'target_blank_menu' is not in camel case. (camelcase)
(#32) Identifier 'target_blank_menu' is not in camel case. (camelcase)
(#33) Identifier 'target_blank_on_menu' is not in camel case. (camelcase)
(#38) Identifier 'menu_item' is not in camel case. (camelcase)
(#39) Identifier 'menu_item' is not in camel case. (camelcase)
(#53) Identifier 'admin_plugin_setting_init' is not in camel case. (camelcase)
(#53) Identifier 'plugin_header_content' is not in camel case. (camelcase)
(#54) Comments should not begin with a lowercase character. (capitalized-comments)
(#55) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#60) Identifier 'plugin_header_content' is not in camel case. (camelcase)
(#64) Identifier 'plugin_header_content' is not in camel case. (camelcase)
(#75) Identifier 'admin_core_setting_init' is not in camel case. (camelcase)
(#75) Identifier 'string_array' is not in camel case. (camelcase)
(#85) Identifier 'get_ecm_btn' is not in camel case. (camelcase)
(#85) Identifier 'css_class' is not in camel case. (camelcase)
(#87) Identifier 'css_class' is not in camel case. (camelcase)
(#93) Comments should not begin with a lowercase character. (capitalized-comments)
(#94) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#96) Identifier 'btn_ecm_custommenuitems' is not in camel case. (camelcase)
(#96) Identifier 'string_array' is not in camel case. (camelcase)
(#96) ["manage_menu_label"] is better written in dot notation. (dot-notation)
(#97) Identifier 'show_menu_label' is not in camel case. (camelcase)
(#97) Identifier 'string_array' is not in camel case. (camelcase)
(#97) ["show_menu_label"] is better written in dot notation. (dot-notation)
(#97) Expected space or tab after '//' in comment. (spaced-comment)
(#98) Identifier 'hide_menu_label' is not in camel case. (camelcase)
(#98) Identifier 'string_array' is not in camel case. (camelcase)
(#98) ["hide_menu_label"] is better written in dot notation. (dot-notation)
(#98) Expected space or tab after '//' in comment. (spaced-comment)
(#99) Identifier 'btn_hide_show_custommenuitems' is not in camel case. (camelcase)
(#107) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#108) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#108) Unexpected space before function parentheses. (space-before-function-paren)
(#111) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#112) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#113) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#114) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#114) Identifier 'hide_menu_label' is not in camel case. (camelcase)
(#119) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#120) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#121) Identifier 'element_show_hide' is not in camel case. (camelcase)
(#121) Identifier 'show_menu_label' is not in camel case. (camelcase)
(#130) Comments should not begin with a lowercase character. (capitalized-comments)
(#131) Identifier 'btn_ecm_customusermenuitems' is not in camel case. (camelcase)
(#131) Identifier 'string_array' is not in camel case. (camelcase)
(#131) ["manage_menu_label_2"] is better written in dot notation. (dot-notation)
(#132) Identifier 'show_menu_label_2' is not in camel case. (camelcase)
(#132) Identifier 'string_array' is not in camel case. (camelcase)
(#132) ["show_menu_label_2"] is better written in dot notation. (dot-notation)
(#133) Identifier 'hide_menu_label_2' is not in camel case. (camelcase)
(#133) Identifier 'string_array' is not in camel case. (camelcase)
(#133) ["hide_menu_label_2"] is better written in dot notation. (dot-notation)
(#134) Identifier 'btn_hide_show_customusermenuitems' is not in camel case. (camelcase)
(#143) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#144) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#144) Unexpected space before function parentheses. (space-before-function-paren)
(#147) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#148) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#149) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#150) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#150) Identifier 'hide_menu_label_2' is not in camel case. (camelcase)
(#155) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#156) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#157) Identifier 'element_show_hide_2' is not in camel case. (camelcase)
(#157) Identifier 'show_menu_label_2' is not in camel case. (camelcase)
local/easycustmenu/amd/src/nav-menu-setting.js
(#27) Identifier 'menu_drag' is not in camel case. (camelcase)
(#36) Identifier 'ajax_get_menu_item_context' is not in camel case. (camelcase)
(#36) Identifier 'menu_item_num' is not in camel case. (camelcase)
(#36) Identifier 'menu_type' is not in camel case. (camelcase)
(#41) Identifier 'menu_item_num' is not in camel case. (camelcase)
(#43) Identifier 'menu_type' is not in camel case. (camelcase)
(#43) Identifier 'menu_type' is not in camel case. (camelcase)
(#48) Unexpected space before function parentheses. (space-before-function-paren)
(#56) Unexpected space before function parentheses. (space-before-function-paren)
(#59) Comments should not begin with a lowercase character. (capitalized-comments)
(#65) Identifier 'menu_type' is not in camel case. (camelcase)
(#67) Identifier 'menu_drag' is not in camel case. (camelcase)
(#71) Unexpected space before function parentheses. (space-before-function-paren)
(#73) Identifier 'menu_id' is not in camel case. (camelcase)
(#74) Identifier 'menu_id' is not in camel case. (camelcase)
(#75) Identifier 'menu_id' is not in camel case. (camelcase)
(#75) Identifier 'menu_id' is not in camel case. (camelcase)
(#77) Identifier 'menu_id' is not in camel case. (camelcase)
(#79) Unexpected space before function parentheses. (space-before-function-paren)
(#81) Expected catch,fail,always() or return (promise/catch-or-return)
(#82) Each then() should return a value or throw (promise/always-return)
(#82) Unexpected space before function parentheses. (space-before-function-paren)
(#84) Identifier 'menu_drag' is not in camel case. (camelcase)
(#95) Unexpected space before function parentheses. (space-before-function-paren)
(#98) Identifier 'menu_id' is not in camel case. (camelcase)
(#99) Identifier 'menu_id' is not in camel case. (camelcase)
(#103) Comments should not begin with a lowercase character. (capitalized-comments)
(#104) Unexpected space before function parentheses. (space-before-function-paren)
(#107) Identifier 'menu_id' is not in camel case. (camelcase)
(#113) Identifier 'menu_id' is not in camel case. (camelcase)
(#120) Unexpected space before function parentheses. (space-before-function-paren)
(#121) Identifier 'menu_id' is not in camel case. (camelcase)
(#123) Identifier 'menu_id' is not in camel case. (camelcase)
(#126) Identifier 'menu_id' is not in camel case. (camelcase)
(#130) Comments should not begin with a lowercase character. (capitalized-comments)
(#131) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#133) Unexpected space before function parentheses. (space-before-function-paren)
(#135) Statement inside of curly braces should be on next line. (brace-style)
(#135) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#162) Comments should not begin with a lowercase character. (capitalized-comments)

CSS problems

(1 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

local/easycustmenu/style/nav-menu-setting.css
(#23) Expected a trailing semicolon (declaration-block-trailing-semicolon)

PHPDocs style problems

(6 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/easycustmenu/classes/helper.php
(#57) Phpdocs for function helper::check_menu_line_role has incomplete parameters list
(#111) Phpdocs for function helper::get_condition_user_roles has incomplete parameters list
(#146) Phpdocs for function helper::get_user_roles_info has incomplete parameters list
(#306) Phpdocs for function helper::menu_item_wrapper_section has incomplete parameters list
local/easycustmenu/classes/menu/navmenu.php
(#113) Phpdocs for function navmenu::get_easycustmenu_setting_section has incomplete parameters list
local/easycustmenu/classes/menu/usermenu.php
(#87) Phpdocs for function usermenu::get_usermenu_setting_section has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(1 errors, 2 warnings)

This section shows problems detected in mustache templates [More info]

local/easycustmenu/templates/menu_item_wrapper.mustache
(#1) HTML Validation error, line 3: Bad value “” for attribute “id” on element “div”: An ID must not be the empty string. (d><body><div id="" class="menu-item-wrapper" itemdepth="" > )
(#1) HTML Validation error, line 3: Attribute “itemdepth” not allowed on element “div” at this point. (d><body><div id="" class="menu-item-wrapper" itemdepth="" > )
local/easycustmenu/templates/menu_setting_collection.mustache
(#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]