Overview
(0 errors, 0 warnings)
This section shows the general problems detected when processing the code [More info]
PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(36 errors, 78 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- local/downloadcenter/classes/event/plugin_viewed.php
- (#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#21) Missing @copyright tag
- (#21) Missing @license tag
- (#23) Incorrect @package tag for class plugin_viewed. Expected local_downloadcenter, found local_downloadcenter\event.
- (#39) No one-line description found in phpdocs for docblock of function get_name
- (#46) No one-line description found in phpdocs for docblock of function get_description
- (#54) No one-line description found in phpdocs for docblock of function get_url
- (#55) Short array syntax must be used to define arrays
- local/downloadcenter/classes/event/zip_downloaded.php
- (#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#22) Missing @copyright tag
- (#22) Missing @license tag
- (#24) Incorrect @package tag for class zip_downloaded. Expected local_downloadcenter, found local_downloadcenter\event.
- (#40) No one-line description found in phpdocs for docblock of function get_name
- (#47) No one-line description found in phpdocs for docblock of function get_description
- (#56) No one-line description found in phpdocs for docblock of function get_url
- (#57) Short array syntax must be used to define arrays
- local/downloadcenter/classes/privacy/provider.php
- (#1) No one-line description found in phpdocs for docblock of file provider.php
- (#28) Missing docblock for class provider
- local/downloadcenter/db/access.php
- (#28) Short array syntax must be used to define arrays
- (#29) Short array syntax must be used to define arrays
- (#32) Short array syntax must be used to define arrays
- local/downloadcenter/download_form.php
- (#38) No one-line description found in phpdocs for docblock of function definition
- (#54) Short array syntax must be used to define arrays
- (#69) Short array syntax must be used to define arrays
- (#73) Short array syntax must be used to define arrays
- (#73) Line exceeds 132 characters; contains 161 characters
- (#83) Short array syntax must be used to define arrays
- (#83) Line exceeds 132 characters; contains 139 characters
- (#86) Short array syntax must be used to define arrays
- (#86) Line exceeds 132 characters; contains 139 characters
- (#89) Short array syntax must be used to define arrays
- local/downloadcenter/index.php
- (#37) Short array syntax must be used to define arrays
- (#45) Short array syntax must be used to define arrays
- (#67) Short array syntax must be used to define arrays
- (#77) Short array syntax must be used to define arrays
- (#80) Short array syntax must be used to define arrays
- local/downloadcenter/lang/en/local_downloadcenter.php
- (#30) The string key "downloadcenter:view" is not in the correct order, it should be before "pluginname"
- (#36) The string key "exclude_empty_topics" is not in the correct order, it should be before "settings_title"
- (#44) The string key "createzip" is not in the correct order, it should be before "infomessage_teachers"
- (#47) The string key "download" is not in the correct order, it should be before "zipready"
- (#49) The string key "eventDOWNLOADEDZIP" is not in the correct order, it should be before "zipcreating"
- (#53) The string key "privacy:null_reason" is not in the correct order, it should be before "untitled"
- (#55) The string key "no_downloadable_content" is not in the correct order, it should be before "privacy:null_reason"
- (#57) The string key "downloadoptions" is not in the correct order, it should be before "no_downloadable_content"
- (#60) The string key "downloadoptions:addnumbering" is not in the correct order, it should be before "downloadoptions:filesrealnames_help"
- local/downloadcenter/lib.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#45) No one-line description found in phpdocs for docblock of function local_downloadcenter_extend_navigation_course
- (#64) Short array syntax must be used to define arrays
- (#86) No one-line description found in phpdocs for docblock of function local_downloadcenter_extend_navigation
- (#93) No one-line description found in phpdocs for docblock of function local_downloadcenter_get_fontawesome_icon_map
- local/downloadcenter/locallib.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#28) Missing docblock for class local_downloadcenter_factory
- (#30) Content missing for @var tag in member variable comment
- (#34) Content missing for @var tag in member variable comment
- (#38) Content missing for @var tag in member variable comment
- (#42) Content missing for @var tag in member variable comment
- (#45) Missing member variable doc comment
- (#65) Content missing for @var tag in member variable comment
- (#89) No one-line description found in phpdocs for docblock of function get_resources_for_user
- (#100) Line exceeds 132 characters; contains 133 characters
- (#104) Short array syntax must be used to define arrays
- (#220) No one-line description found in phpdocs for docblock of function get_js_modnames
- (#221) Short array syntax must be used to define arrays
- (#229) No one-line description found in phpdocs for docblock of function create_zip
- (#397) Short array syntax must be used to define arrays
- (#442) Short array syntax must be used to define arrays
- (#469) Short array syntax must be used to define arrays
- (#473) Short array syntax must be used to define arrays
- (#475) Short array syntax must be used to define arrays
- (#503) Short array syntax must be used to define arrays
- (#508) Short array syntax must be used to define arrays
- (#534) Line exceeds 132 characters; contains 135 characters
- (#542) Line exceeds 132 characters; contains 141 characters
- (#591) Line exceeds 132 characters; contains 162 characters
- (#593) Line exceeds 132 characters; contains 134 characters
- (#630) Line exceeds 132 characters; contains 171 characters
- (#633) Line exceeds 132 characters; contains 138 characters
- (#665) Short array syntax must be used to define arrays
- (#667) Line exceeds 132 characters; contains 173 characters
- (#668) Short array syntax must be used to define arrays
- (#670) Line exceeds 132 characters; contains 147 characters
- (#671) Short array syntax must be used to define arrays
- (#689) Short array syntax must be used to define arrays
- (#742) Line exceeds 132 characters; contains 161 characters
- (#750) Line exceeds 132 characters; contains 143 characters
- (#751) Short array syntax must be used to define arrays
- (#760) Short array syntax must be used to define arrays
- (#768) Short array syntax must be used to define arrays
- (#807) No one-line description found in phpdocs for docblock of function add_folder_contents
- (#825) No one-line description found in phpdocs for docblock of function parse_form_data
- (#861) No one-line description found in phpdocs for docblock of function shorten_filename
- (#871) Missing docblock for function convert_content_to_html_doc
- (#887) Missing docblock for function append_etherpadlite_css
- local/downloadcenter/tests/files_visible_test.php
- (#22) Invalid @category tag value "phpunit".
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#33) Testcase local_downloadcenter_files_visible_testcase should be declared as abstract.
- (#33) PHPUnit testcase name "local_downloadcenter_files_visible_testcase" does not match file name "files_visible_test"
- (#33) PHPUnit class "local_downloadcenter_files_visible_testcase" does not have any namespace. It is recommended to add it to the "local_downloadcenter" namespace, using more levels if needed, in order to match the code being tested
- (#33) Missing docblock for class local_downloadcenter_files_visible_testcase
- (#35) Test method test_empty() is missing any coverage information, own or at class level
- (#35) Test method test_empty() is missing a return type
- (#41) Short array syntax must be used to define arrays
- (#42) Short array syntax must be used to define arrays
- (#73) Test method test_student_visibility() is missing any coverage information, own or at class level
- (#73) Test method test_student_visibility() is missing a return type
- (#79) Short array syntax must be used to define arrays
- (#80) Short array syntax must be used to define arrays
- (#107) Test method test_teacher_visibility() is missing any coverage information, own or at class level
- (#107) Test method test_teacher_visibility() is missing a return type
- (#113) Short array syntax must be used to define arrays
- (#137) Missing docblock for function helper_add_file_to_context in testcase
- (#142) Short array syntax must be used to define arrays
- (#151) Missing docblock for function helper_add_resources_to_course in testcase
- local/downloadcenter/version.php
- (#1) No one-line description found in phpdocs for docblock of file version.php
Javascript coding style problems
(0 errors, 31 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
- local/downloadcenter/amd/src/modfilter.js
- (#32) ["all"] is better written in dot notation. (dot-notation)
- (#33) ["none"] is better written in dot notation. (dot-notation)
- (#34) ["select"] is better written in dot notation. (dot-notation)
- (#35) ["showtypes"] is better written in dot notation. (dot-notation)
- (#36) ["hidetypes"] is better written in dot notation. (dot-notation)
- (#43) ["showtypes"] is better written in dot notation. (dot-notation)
- (#44) ["select"] is better written in dot notation. (dot-notation)
- (#75) Statement inside of curly braces should be on next line. (brace-style)
- (#75) Multiple spaces found before ''item_''. (no-multi-spaces)
- (#75) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
- (#76) Statement inside of curly braces should be on next line. (brace-style)
- (#76) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
- (#77) Statement inside of curly braces should be on next line. (brace-style)
- (#77) This line has 3 statements. Maximum allowed is 2. (max-statements-per-line)
- (#77) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
- (#79) Statement inside of curly braces should be on next line. (brace-style)
- (#79) This line has 3 statements. Maximum allowed is 2. (max-statements-per-line)
- (#79) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
- (#115) ["showtypes"] is better written in dot notation. (dot-notation)
- (#117) ["hidetypes"] is better written in dot notation. (dot-notation)
- (#119) There should be no space before '}'. (@babel/object-curly-spacing)
- (#127) Statement inside of curly braces should be on next line. (brace-style)
- (#127) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
- (#128) Statement inside of curly braces should be on next line. (brace-style)
- (#128) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
- (#160) Identifier 'html_generator' is not in camel case. (camelcase)
- (#161) ["all"] is better written in dot notation. (dot-notation)
- (#162) ["none"] is better written in dot notation. (dot-notation)
- (#166) Identifier 'row_generator' is not in camel case. (camelcase)
- local/downloadcenter/amd/src/search.js
- (#77) Statement inside of curly braces should be on next line. (brace-style)
- (#77) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
CSS problems
(0 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
PHPDocs style problems
(4 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- local/downloadcenter/locallib.php
- (#71) Phpdocs for function local_downloadcenter_factory::__construct has incomplete parameters list
- (#803) Phpdocs for function local_downloadcenter_factory::add_folder_contents has incomplete parameters list
- (#820) Phpdocs for function local_downloadcenter_factory::parse_form_data has incomplete parameters list
- (#857) Phpdocs for function local_downloadcenter_factory::shorten_filename has incomplete parameters list
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(3 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
- local/downloadcenter/amd/build/modfilter.min.js
- Uncommitted change detected.
- local/downloadcenter/amd/build/modfilter.min.js.map
- Uncommitted change detected.
- local/downloadcenter/amd/build/search.min.js.map
- Uncommitted change detected.
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]