Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 55 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/downloadcenter/classes/event/plugin_viewed.php
(#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#55) Short array syntax must be used to define arrays
local/downloadcenter/classes/event/zip_downloaded.php
(#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#57) Short array syntax must be used to define arrays
local/downloadcenter/db/access.php
(#28) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#32) Short array syntax must be used to define arrays
local/downloadcenter/download_form.php
(#50) Short array syntax must be used to define arrays
(#64) Short array syntax must be used to define arrays
(#72) Short array syntax must be used to define arrays
local/downloadcenter/index.php
(#37) Short array syntax must be used to define arrays
(#45) Short array syntax must be used to define arrays
(#67) Short array syntax must be used to define arrays
(#77) Short array syntax must be used to define arrays
(#80) Short array syntax must be used to define arrays
local/downloadcenter/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#64) Short array syntax must be used to define arrays
local/downloadcenter/locallib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#102) Short array syntax must be used to define arrays
(#213) Short array syntax must be used to define arrays
(#404) Short array syntax must be used to define arrays
(#476) Short array syntax must be used to define arrays
(#503) Short array syntax must be used to define arrays
(#507) Short array syntax must be used to define arrays
(#509) Short array syntax must be used to define arrays
(#537) Short array syntax must be used to define arrays
(#542) Short array syntax must be used to define arrays
(#575) Line exceeds 132 characters; contains 137 characters
(#624) Line exceeds 132 characters; contains 162 characters
(#626) Line exceeds 132 characters; contains 134 characters
(#663) Line exceeds 132 characters; contains 171 characters
(#666) Line exceeds 132 characters; contains 138 characters
(#698) Short array syntax must be used to define arrays
(#700) Line exceeds 132 characters; contains 173 characters
(#701) Short array syntax must be used to define arrays
(#703) Line exceeds 132 characters; contains 147 characters
(#704) Short array syntax must be used to define arrays
(#722) Short array syntax must be used to define arrays
(#775) Line exceeds 132 characters; contains 161 characters
(#783) Line exceeds 132 characters; contains 143 characters
(#784) Short array syntax must be used to define arrays
(#793) Short array syntax must be used to define arrays
(#801) Short array syntax must be used to define arrays
local/downloadcenter/tests/files_visible_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#33) PHPUnit testcase name "local_downloadcenter_files_visible_testcase" does not match file name "files_visible_test"
(#33) PHPUnit class "local_downloadcenter_files_visible_testcase" does not have any namespace. It is recommended to add it to the "local_downloadcenter" namespace, using more levels if needed, in order to match the code being tested
(#35) Test method test_empty() is missing any coverage information, own or at class level
(#41) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#73) Test method test_student_visibility() is missing any coverage information, own or at class level
(#79) Short array syntax must be used to define arrays
(#80) Short array syntax must be used to define arrays
(#107) Test method test_teacher_visibility() is missing any coverage information, own or at class level
(#113) Short array syntax must be used to define arrays
(#142) Short array syntax must be used to define arrays

Javascript coding style problems

(0 errors, 29 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/downloadcenter/amd/src/modfilter.js
(#32) ["all"] is better written in dot notation. (dot-notation)
(#33) ["none"] is better written in dot notation. (dot-notation)
(#34) ["select"] is better written in dot notation. (dot-notation)
(#35) ["showtypes"] is better written in dot notation. (dot-notation)
(#36) ["hidetypes"] is better written in dot notation. (dot-notation)
(#43) ["showtypes"] is better written in dot notation. (dot-notation)
(#44) ["select"] is better written in dot notation. (dot-notation)
(#75) Statement inside of curly braces should be on next line. (brace-style)
(#75) Multiple spaces found before ''item_''. (no-multi-spaces)
(#75) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#76) Statement inside of curly braces should be on next line. (brace-style)
(#76) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#77) Statement inside of curly braces should be on next line. (brace-style)
(#77) This line has 3 statements. Maximum allowed is 2. (max-statements-per-line)
(#77) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#79) Statement inside of curly braces should be on next line. (brace-style)
(#79) This line has 3 statements. Maximum allowed is 2. (max-statements-per-line)
(#79) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#115) ["showtypes"] is better written in dot notation. (dot-notation)
(#117) ["hidetypes"] is better written in dot notation. (dot-notation)
(#119) There should be no space before '}'. (@babel/object-curly-spacing)
(#127) Statement inside of curly braces should be on next line. (brace-style)
(#127) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#128) Statement inside of curly braces should be on next line. (brace-style)
(#128) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#160) Identifier 'html_generator' is not in camel case. (camelcase)
(#161) ["all"] is better written in dot notation. (dot-notation)
(#162) ["none"] is better written in dot notation. (dot-notation)
(#166) Identifier 'row_generator' is not in camel case. (camelcase)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(34 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/downloadcenter/classes/event/plugin_viewed.php
(#26) There is no description in phpdocs for function init
(#35) There is no description in phpdocs for function get_name
(#43) There is no description in phpdocs for function get_description
(#50) There is no description in phpdocs for function get_url
(#23) Package local_downloadcenter\event is not valid
local/downloadcenter/classes/event/zip_downloaded.php
(#27) There is no description in phpdocs for function init
(#36) There is no description in phpdocs for function get_name
(#44) There is no description in phpdocs for function get_description
(#52) There is no description in phpdocs for function get_url
(#24) Package local_downloadcenter\event is not valid
local/downloadcenter/classes/privacy/provider.php
(#28) Class provider is not documented
(#17) No one-line description found in phpdocs for file
local/downloadcenter/download_form.php
(#35) There is no description in phpdocs for function definition
local/downloadcenter/lib.php
(#28) There is no description in phpdocs for function local_downloadcenter_extend_settings_navigation
(#38) There is no description in phpdocs for function local_downloadcenter_extend_navigation_course
(#81) There is no description in phpdocs for function local_downloadcenter_extend_navigation
(#90) There is no description in phpdocs for function local_downloadcenter_get_fontawesome_icon_map
local/downloadcenter/locallib.php
(#28) Class local_downloadcenter_factory is not documented
(#904) Function local_downloadcenter_factory::convert_content_to_html_doc is not documented
(#920) Function local_downloadcenter_factory::append_etherpadlite_css is not documented
(#45) Variable local_downloadcenter_factory::$_downloadoptions is not documented
(#83) There is no description in phpdocs for function get_resources_for_user
(#209) There is no description in phpdocs for function get_js_modnames
(#216) There is no description in phpdocs for function create_zip
(#835) There is no description in phpdocs for function add_folder_contents
(#852) There is no description in phpdocs for function parse_form_data
(#889) There is no description in phpdocs for function shorten_filename
(#71) Phpdocs for function local_downloadcenter_factory::__construct has incomplete parameters list
(#836) Phpdocs for function local_downloadcenter_factory::add_folder_contents has incomplete parameters list
(#853) Phpdocs for function local_downloadcenter_factory::parse_form_data has incomplete parameters list
(#890) Phpdocs for function local_downloadcenter_factory::shorten_filename has incomplete parameters list
local/downloadcenter/tests/files_visible_test.php
(#33) Class local_downloadcenter_files_visible_testcase is not documented
(#137) Function local_downloadcenter_files_visible_testcase::helper_add_file_to_context is not documented
(#151) Function local_downloadcenter_files_visible_testcase::helper_add_resources_to_course is not documented
(#22) Category phpunit is not valid
local/downloadcenter/version.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(2 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

local/downloadcenter/amd/build/modfilter.min.js
Uncommitted change detected.
local/downloadcenter/amd/build/modfilter.min.js.map
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]