Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 6 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/downloadcenter/lib.php
(#75) Inline comments must end in full-stops, exclamation marks, or question marks
local/downloadcenter/locallib.php
(#518) Line exceeds 132 characters; contains 137 characters
(#567) Line exceeds 132 characters; contains 162 characters
(#569) Line exceeds 132 characters; contains 134 characters
(#606) Line exceeds 132 characters; contains 171 characters
(#609) Line exceeds 132 characters; contains 138 characters

Javascript coding style problems

(0 errors, 30 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/downloadcenter/amd/src/modfilter.js
(#13) Missing JSDoc for parameter 'modnames'. (valid-jsdoc)
(#34) ["all"] is better written in dot notation. (dot-notation)
(#35) ["none"] is better written in dot notation. (dot-notation)
(#36) ["select"] is better written in dot notation. (dot-notation)
(#37) ["showtypes"] is better written in dot notation. (dot-notation)
(#38) ["hidetypes"] is better written in dot notation. (dot-notation)
(#44) ["select"] is better written in dot notation. (dot-notation)
(#46) ["showtypes"] is better written in dot notation. (dot-notation)
(#77) Statement inside of curly braces should be on next line. (brace-style)
(#77) Multiple spaces found before ''item_''. (no-multi-spaces)
(#77) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#78) Statement inside of curly braces should be on next line. (brace-style)
(#78) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#79) Statement inside of curly braces should be on next line. (brace-style)
(#79) This line has 3 statements. Maximum allowed is 2. (max-statements-per-line)
(#79) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#81) Statement inside of curly braces should be on next line. (brace-style)
(#81) This line has 3 statements. Maximum allowed is 2. (max-statements-per-line)
(#81) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#117) ["showtypes"] is better written in dot notation. (dot-notation)
(#119) ["hidetypes"] is better written in dot notation. (dot-notation)
(#121) There should be no space before '}'. (babel/object-curly-spacing)
(#129) Statement inside of curly braces should be on next line. (brace-style)
(#129) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#130) Statement inside of curly braces should be on next line. (brace-style)
(#130) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#162) Identifier 'html_generator' is not in camel case. (camelcase)
(#163) ["all"] is better written in dot notation. (dot-notation)
(#164) ["none"] is better written in dot notation. (dot-notation)
(#168) Identifier 'row_generator' is not in camel case. (camelcase)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(38 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/downloadcenter/classes/event/plugin_viewed.php
(#23) Package local_downloadcenter\event is not valid
(#26) There is no description in phpdocs for function init
(#35) There is no description in phpdocs for function get_name
(#43) There is no description in phpdocs for function get_description
(#50) There is no description in phpdocs for function get_url
local/downloadcenter/classes/event/zip_downloaded.php
(#24) Package local_downloadcenter\event is not valid
(#27) There is no description in phpdocs for function init
(#36) There is no description in phpdocs for function get_name
(#44) There is no description in phpdocs for function get_description
(#52) There is no description in phpdocs for function get_url
local/downloadcenter/classes/privacy/provider.php
(#28) Class provider is not documented
(#17) No one-line description found in phpdocs for file
local/downloadcenter/download_form.php
(#35) There is no description in phpdocs for function definition
(#91) There is no description in phpdocs for function definition
local/downloadcenter/lib.php
(#29) There is no description in phpdocs for function local_downloadcenter_extend_settings_navigation
(#40) There is no description in phpdocs for function local_downloadcenter_extend_navigation
(#130) There is no description in phpdocs for function local_downloadcenter_get_fontawesome_icon_map
local/downloadcenter/locallib.php
(#28) Class local_downloadcenter_factory is not documented
(#736) Function local_downloadcenter_factory::convert_content_to_html_doc is not documented
(#68) There is no description in phpdocs for function get_resources_for_user
(#192) There is no description in phpdocs for function get_js_modnames
(#199) There is no description in phpdocs for function create_zip
(#641) There is no description in phpdocs for function add_file_to_session
(#659) There is no description in phpdocs for function get_file_from_session
(#675) There is no description in phpdocs for function add_folder_contents
(#692) There is no description in phpdocs for function parse_form_data
(#722) There is no description in phpdocs for function shorten_filename
(#60) Phpdocs for function local_downloadcenter_factory::__construct has incomplete parameters list
(#642) Phpdocs for function local_downloadcenter_factory::add_file_to_session has incomplete parameters list
(#660) Phpdocs for function local_downloadcenter_factory::get_file_from_session has incomplete parameters list
(#676) Phpdocs for function local_downloadcenter_factory::add_folder_contents has incomplete parameters list
(#693) Phpdocs for function local_downloadcenter_factory::parse_form_data has incomplete parameters list
(#723) Phpdocs for function local_downloadcenter_factory::shorten_filename has incomplete parameters list
local/downloadcenter/tests/files_visible_test.php
(#22) Category phpunit is not valid
(#33) Class local_downloadcenter_files_visible_testcase is not documented
(#137) Function local_downloadcenter_files_visible_testcase::helper_add_file_to_context is not documented
(#151) Function local_downloadcenter_files_visible_testcase::helper_add_resources_to_course is not documented
local/downloadcenter/version.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "gherkinlint" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(20 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

local/downloadcenter/tests/behat/pages_check.feature
(#2) Wrong indentation for "Feature", expected indentation level of 0, but got 2
(#4) Wrong indentation for "Background", expected indentation level of 2, but got 4
(#5) Wrong indentation for "given", expected indentation level of 4, but got 2
(#10) Wrong indentation for "and", expected indentation level of 4, but got 2
(#13) Wrong indentation for "and", expected indentation level of 4, but got 2
(#18) Wrong indentation for "and", expected indentation level of 4, but got 2
(#22) Wrong indentation for "scenario tag", expected indentation level of 2, but got 4
(#23) Wrong indentation for "Scenario", expected indentation level of 2, but got 4
(#24) Wrong indentation for "given", expected indentation level of 4, but got 6
(#25) Wrong indentation for "and", expected indentation level of 4, but got 6
(#26) Wrong indentation for "and", expected indentation level of 4, but got 6
(#30) Wrong indentation for "and", expected indentation level of 4, but got 6
(#31) Wrong indentation for "Step", expected indentation level of 4, but got 6
(#32) Wrong indentation for "and", expected indentation level of 4, but got 6
(#33) Wrong indentation for "and", expected indentation level of 4, but got 6
(#34) Wrong indentation for "and", expected indentation level of 4, but got 6
(#35) Wrong indentation for "and", expected indentation level of 4, but got 6
(#36) Wrong indentation for "Step", expected indentation level of 4, but got 6
(#36) Trailing spaces are not allowed
(#38) Multiple empty lines are not allowed