Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(11 errors, 51 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/csp/classes/helper.php
(#54) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
(#79) Short array syntax must be used to define arrays
(#96) There must not be a space before the colon in a return type declaration
local/csp/classes/privacy/provider.php
(#40) Method name "_get_reason" should not be prefixed with an underscore to indicate visibility
local/csp/classes/table/csp_report.php
(#55) There should be a comma after the last array item in a multi-line array.
(#69) Short array syntax must be used to define arrays
(#187) There should be a comma after the last array item in a multi-line array.
(#225) There should be a comma after the last array item in a multi-line array.
(#266) There should be a comma after the last array item in a multi-line array.
(#298) Short array syntax must be used to define arrays
local/csp/csp_report.php
(#37) Short array syntax must be used to define arrays
(#43) There should be a comma after the last array item in a multi-line array.
(#46) Short array syntax must be used to define arrays
(#54) Short array syntax must be used to define arrays
(#55) Short array syntax must be used to define arrays
(#78) Short array syntax must be used to define arrays
(#83) Short array syntax must be used to define arrays
(#83) Short array syntax must be used to define arrays
(#100) Short array syntax must be used to define arrays
(#113) Short array syntax must be used to define arrays
(#132) Short array syntax must be used to define arrays
(#140) Short array syntax must be used to define arrays
(#160) Short array syntax must be used to define arrays
local/csp/db/access.php
(#29) Short array syntax must be used to define arrays
(#30) Short array syntax must be used to define arrays
(#33) Short array syntax must be used to define arrays
(#36) There should be a comma after the last array item in a multi-line array.
(#37) There should be a comma after the last array item in a multi-line array.
(#38) There should be a comma after the last array item in a multi-line array.
local/csp/lang/en/local_csp.php
(#49) The string key "cspreports" is not in the correct order, it should be before "featurepolicydescription"
(#68) The string key "nonduplicaterecords" is not in the correct order, it should be before "norecordsfound"
(#75) The string key "privacy:metadata" is not in the correct order, it should be before "violateddirective"
(#77) Unexpected comment found. Auto-fixing will not work after this comment
(#78) The string key "notificationenforcedheader" is not in the correct order, it should be before "privacy:metadata"
(#80) The string key "notificationenforcedsources" is not in the correct order, it should be before "notificationenforcedstart"
(#83) The string key "notificationreportedsources" is not in the correct order, it should be before "notificationreportedstart"
(#85) Unexpected comment found. Auto-fixing will not work after this comment
(#91) Unexpected comment found. Auto-fixing will not work after this comment
(#92) The string key "csp:seenotifications" is not in the correct order, it should be before "notificationsenablereporteddescription"
local/csp/lib.php
(#34) There must not be a space before the colon in a return type declaration
local/csp/mixed_content_examples.php
(#47) Short array syntax must be used to define arrays
(#55) Short array syntax must be used to define arrays
(#63) Short array syntax must be used to define arrays
(#71) Short array syntax must be used to define arrays
(#77) Short array syntax must be used to define arrays
(#82) Short array syntax must be used to define arrays
(#85) There should be a comma after the last array item in a multi-line array.
local/csp/tests/helper_test.php
(#33) Unit test helper_test should be declared as final.
(#38) Test method test_merge_duplicate_records_with_no_records() is missing a return type
(#47) Test method test_merge_duplicate_records_with_one_records() is missing a return type
(#58) Test method test_merge_duplicate_records_with_two_non_matching_records() is missing a return type
(#70) Test method test_merge_duplicate_records_with_two_matching_records() is missing a return type
local/csp/tests/task/merge_duplicate_records_task_test.php
(#34) Unit test merge_duplicate_records_task_test should be declared as final.
(#39) Test method test_get_duplicate_list_sql_with_none_found() is missing any coverage information, own or at class level
(#39) Test method test_get_duplicate_list_sql_with_none_found() is missing a return type
(#59) Test method test_get_duplicate_list_sql() is missing any coverage information, own or at class level
(#59) Test method test_get_duplicate_list_sql() is missing a return type
(#83) Test method test_execute_with_no_duplicate_records() is missing any coverage information, own or at class level
(#83) Test method test_execute_with_no_duplicate_records() is missing a return type
(#98) Test method test_execute_with_duplicate_records() is missing any coverage information, own or at class level
(#98) Test method test_execute_with_duplicate_records() is missing a return type

Javascript coding style problems

(0 errors, 3 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/csp/amd/src/notifications.js
(#53) Expected an error object to be thrown. (no-throw-literal)
(#73) Expected catch,fail,always() or return (promise/catch-or-return)
(#76) Expected catch,fail,always() or return (promise/catch-or-return)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]