Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(80 errors, 130 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/courseflowtool/classes/observer.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#41) Opening brace must not be followed by a blank line
(#68) Inline comments must end in full-stops, exclamation marks, or question marks
(#74) Inline comments must end in full-stops, exclamation marks, or question marks
(#80) Line exceeds 132 characters; contains 146 characters
(#83) Function closing brace must go on the next line following the body; found 1 blank lines before brace
(#85) The closing brace for the class must go on the next line after the body
local/courseflowtool/classes/output/help_page.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#40) Opening brace must not be followed by a blank line
(#49) PHP keywords must be lowercase; expected "global" but found "GLOBAL"
local/courseflowtool/classes/output/import_tool.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/courseflowtool/classes/output/preview_import.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#58) Inline comments must end in full-stops, exclamation marks, or question marks
local/courseflowtool/classes/privacy/provider.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) Opening brace must not be followed by a blank line
local/courseflowtool/db/caches.php
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#30) Expected 1 space between the comma and "// Only store a single value per key". Found: 16 spaces
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Expected 1 space between the comma and "// Simple data types (string, int, arrays, objects)". Found: 17 spaces
(#31) Inline comments must end in full-stops, exclamation marks, or question marks
local/courseflowtool/db/events.php
(#30) Line exceeds 132 characters; contains 134 characters
local/courseflowtool/finalize_import.php
(#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#47) Line exceeds 132 characters; contains 155 characters
(#57) Blank line found at start of control structure
(#69) Inline comments must end in full-stops, exclamation marks, or question marks
(#70) Blank line found at start of control structure
(#85) Empty lines are not allowed in multi-line function calls
(#91) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) Blank line found at start of control structure
(#117) Inline comments must end in full-stops, exclamation marks, or question marks
(#121) Expected at least 1 space before "."; 0 found
(#121) Expected at least 1 space after "."; 0 found
(#121) Expected at least 1 space before "."; 0 found
(#121) Expected at least 1 space after "."; 0 found
(#121) Expected at least 1 space before "."; 0 found
(#121) Expected at least 1 space after "."; 0 found
(#121) Expected at least 1 space before "."; 0 found
(#122) Expected at least 1 space before "."; 0 found
(#122) Expected at least 1 space after "."; 0 found
(#122) Expected at least 1 space before "."; 0 found
(#122) Expected at least 1 space after "."; 0 found
(#122) Expected at least 1 space before "."; 0 found
(#122) Expected at least 1 space after "."; 0 found
(#122) Expected at least 1 space before "."; 0 found
(#123) Expected at least 1 space before "."; 0 found
(#123) Expected at least 1 space after "."; 0 found
(#123) Expected at least 1 space before "."; 0 found
(#123) Expected at least 1 space after "."; 0 found
(#123) Expected at least 1 space before "."; 0 found
(#123) Expected at least 1 space after "."; 0 found
(#123) Expected at least 1 space before "."; 0 found
(#124) Expected at least 1 space before "."; 0 found
(#124) Expected at least 1 space after "."; 0 found
(#126) Function closing brace must go on the next line following the body; found 1 blank lines before brace
(#128) Inline comments must end in full-stops, exclamation marks, or question marks
(#135) Line exceeds 132 characters; contains 164 characters
(#136) Inline comments must end in full-stops, exclamation marks, or question marks
(#149) Inline comments must end in full-stops, exclamation marks, or question marks
(#150) Line exceeds 132 characters; contains 155 characters
(#153) Inline comments must end in full-stops, exclamation marks, or question marks
local/courseflowtool/help_page.php
(#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
local/courseflowtool/import_tool.php
(#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) Inline comments must end in full-stops, exclamation marks, or question marks
(#60) Expected 1 blank line at end of file; 2 found
local/courseflowtool/lang/en/local_courseflowtool.php
(#26) The string key "courseflowtool:view" is not in the correct order, it should be before "pluginname"
(#29) Unexpected comment found. Auto-fixing will not work after this comment
(#29) Inline comments must start with a capital letter, digit or 3-dots sequence
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#35) The string key "jsoninput_button" is not in the correct order, it should be before "jsoninput_placeholder"
(#36) The string key "json_process_error" is not in the correct order, it should be before "jsoninput_button"
(#38) The string key "associateoutcomes" is not in the correct order, it should be before "usecourseflowstyle"
(#40) The string key "import_url_instructions" is not in the correct order, it should be before "url_input_label"
(#42) The string key "import_options" is not in the correct order, it should be before "urlinput_button"
(#45) Unexpected comment found. Auto-fixing will not work after this comment
(#45) Inline comments must start with a capital letter, digit or 3-dots sequence
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) The string key "json_process_invalid" is not in the correct order, it should be before "open_help_page"
(#47) The string key "json_process_decode_error" is not in the correct order, it should be before "json_process_invalid"
(#49) Unexpected comment found. Auto-fixing will not work after this comment
(#49) Inline comments must start with a capital letter, digit or 3-dots sequence
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#52) The string key "lesson" is not in the correct order, it should be before "section"
(#55) The string key "lessons" is not in the correct order, it should be before "sections"
(#57) The string key "label_overwrite" is not in the correct order, it should be before "outcomes"
(#58) The string key "confirm_import" is not in the correct order, it should be before "label_overwrite"
(#63) Unexpected comment found. Auto-fixing will not work after this comment
(#63) Inline comments must start with a capital letter, digit or 3-dots sequence
(#63) Inline comments must end in full-stops, exclamation marks, or question marks
(#65) The string key "no_data" is not in the correct order, it should be before "select_all"
(#66) The string key "error" is not in the correct order, it should be before "no_data"
(#70) Unexpected comment found. Auto-fixing will not work after this comment
(#70) Inline comments must start with a capital letter, digit or 3-dots sequence
(#70) Inline comments must end in full-stops, exclamation marks, or question marks
(#74) Unexpected comment found. Auto-fixing will not work after this comment
(#74) Inline comments must start with a capital letter, digit or 3-dots sequence
(#74) Inline comments must end in full-stops, exclamation marks, or question marks
(#75) The string key "cachedef_courseflow_import_data" is not in the correct order, it should be before "privacy:metadata"
(#77) Unexpected comment found. Auto-fixing will not work after this comment
(#77) Inline comments must start with a capital letter, digit or 3-dots sequence
(#77) Inline comments must end in full-stops, exclamation marks, or question marks
(#79) The string key "help_intro" is not in the correct order, it should be before "help_title"
(#81) The string key "help_courseflow" is not in the correct order, it should be before "help_step1_title"
(#85) The string key "help_step2-1_desc" is not in the correct order, it should be before "help_step2_title"
(#90) The string key "help_options_desc" is not in the correct order, it should be before "help_step2-2_image_alt"
(#91) The string key "help_option_styling" is not in the correct order, it should be before "help_options_desc"
(#92) The string key "help_option_outcomes" is not in the correct order, it should be before "help_option_styling"
(#96) The string key "help_step3_desc" is not in the correct order, it should be before "help_step3_title"
(#99) The string key "help_confirm_title" is not in the correct order, it should be before "help_step3_image_alt"
(#100) The string key "help_confirm_desc" is not in the correct order, it should be before "help_confirm_title"
(#100) Expected 1 blank line at end of file; 2 found
local/courseflowtool/lib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#85) Line exceeds 132 characters; contains 180 characters
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#103) Blank line found at start of control structure
(#105) Inline comments must end in full-stops, exclamation marks, or question marks
(#107) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Inline comments must end in full-stops, exclamation marks, or question marks
(#124) Incorrect spacing between argument "$lessontypedisplay" and equals sign; expected 1 but found 0
(#124) Incorrect spacing between default value and equals sign for argument "$lessontypedisplay"; expected 1 but found 0
(#128) Expected at least 1 space before "."; 0 found
(#128) Expected at least 1 space after "."; 0 found
(#128) Expected at least 1 space before "."; 0 found
(#128) Expected at least 1 space after "."; 0 found
(#141) Incorrect spacing between argument "$lessontype" and equals sign; expected 1 but found 0
(#141) Incorrect spacing between default value and equals sign for argument "$lessontype"; expected 1 but found 0
(#141) Incorrect spacing between argument "$colour" and equals sign; expected 1 but found 0
(#141) Incorrect spacing between default value and equals sign for argument "$colour"; expected 1 but found 0
(#146) Expected at least 1 space before "."; 0 found
(#146) Expected at least 1 space after "."; 0 found
(#146) Expected at least 1 space before "."; 0 found
(#146) Expected at least 1 space after "."; 0 found
(#148) Expected at least 1 space before "."; 0 found
(#149) Expected at least 1 space before "."; 0 found
(#150) Expected at least 1 space before "."; 0 found
(#151) Expected at least 1 space before "."; 0 found
(#152) Expected at least 1 space before "."; 0 found
(#153) Expected at least 1 space before "."; 0 found
(#154) Expected at least 1 space before "."; 0 found
(#189) Incorrect spacing between argument "$lessontypedisplay" and equals sign; expected 1 but found 0
(#189) Incorrect spacing between default value and equals sign for argument "$lessontypedisplay"; expected 1 but found 0
(#190) Incorrect spacing between argument "$lessontype" and equals sign; expected 1 but found 0
(#190) Incorrect spacing between default value and equals sign for argument "$lessontype"; expected 1 but found 0
(#191) Incorrect spacing between argument "$colour" and equals sign; expected 1 but found 0
(#191) Incorrect spacing between default value and equals sign for argument "$colour"; expected 1 but found 0
(#192) Incorrect spacing between argument "$usestyle" and equals sign; expected 1 but found 0
(#192) Incorrect spacing between default value and equals sign for argument "$usestyle"; expected 1 but found 0
(#200) Inline comments must end in full-stops, exclamation marks, or question marks
(#205) Inline comments must end in full-stops, exclamation marks, or question marks
(#208) Inline comments must end in full-stops, exclamation marks, or question marks
(#215) Inline comments must end in full-stops, exclamation marks, or question marks
(#222) Line exceeds 132 characters; contains 145 characters
(#232) Inline comments must end in full-stops, exclamation marks, or question marks
(#234) Inline comments must end in full-stops, exclamation marks, or question marks
(#237) Inline comments must end in full-stops, exclamation marks, or question marks
(#244) Inline comments must end in full-stops, exclamation marks, or question marks
(#245) Blank line found at start of control structure
(#247) Inline comments must end in full-stops, exclamation marks, or question marks
(#252) Inline comments must end in full-stops, exclamation marks, or question marks
(#264) Inline comments must end in full-stops, exclamation marks, or question marks
(#275) Inline comments must end in full-stops, exclamation marks, or question marks
(#277) Inline comments must end in full-stops, exclamation marks, or question marks
(#287) Inline comments must end in full-stops, exclamation marks, or question marks
(#289) Inline comments must end in full-stops, exclamation marks, or question marks
(#292) Inline comments must end in full-stops, exclamation marks, or question marks
(#300) Blank line found at end of control structure
(#302) Inline comments must end in full-stops, exclamation marks, or question marks
(#323) Inline comments must end in full-stops, exclamation marks, or question marks
(#339) Inline comments must end in full-stops, exclamation marks, or question marks
(#343) Inline comments must end in full-stops, exclamation marks, or question marks
(#345) Blank line found at start of control structure
(#368) Inline comments must end in full-stops, exclamation marks, or question marks
(#379) Inline comments must end in full-stops, exclamation marks, or question marks
(#400) Inline comments must start with a capital letter, digit or 3-dots sequence
(#400) Inline comments must end in full-stops, exclamation marks, or question marks
(#401) Inline comments must end in full-stops, exclamation marks, or question marks
(#407) Blank line found at end of control structure
(#410) Inline comments must end in full-stops, exclamation marks, or question marks
(#417) Inline comments must end in full-stops, exclamation marks, or question marks
(#445) Inline comments must end in full-stops, exclamation marks, or question marks
(#452) Inline comments must end in full-stops, exclamation marks, or question marks
(#459) Line exceeds 132 characters; contains 174 characters
(#469) Inline comments must end in full-stops, exclamation marks, or question marks
(#488) Inline comments must end in full-stops, exclamation marks, or question marks
(#489) Inline comments must end in full-stops, exclamation marks, or question marks
(#496) Inline comments must end in full-stops, exclamation marks, or question marks
(#523) Inline comments must end in full-stops, exclamation marks, or question marks
(#535) Inline comments must end in full-stops, exclamation marks, or question marks
(#545) Inline comments must end in full-stops, exclamation marks, or question marks
(#552) Inline comments must end in full-stops, exclamation marks, or question marks
(#566) Inline comments must end in full-stops, exclamation marks, or question marks
(#576) Expected 1 blank line at end of file; 2 found
(#576) Function closing brace must go on the next line following the body; found 1 blank lines before brace
local/courseflowtool/preview_import.php
(#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#43) Expected at least 1 space before "."; 0 found
(#43) Expected at least 1 space after "."; 0 found
(#43) Expected at least 1 space before "."; 0 found
(#43) Expected at least 1 space after "."; 0 found
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#76) Expected 1 blank line at end of file; 2 found
local/courseflowtool/process_json.php
(#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#44) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
(#63) Inline comments must end in full-stops, exclamation marks, or question marks
(#68) Inline comments must end in full-stops, exclamation marks, or question marks
(#70) Inline comments must end in full-stops, exclamation marks, or question marks
(#73) Inline comments must end in full-stops, exclamation marks, or question marks
(#84) Inline comments must end in full-stops, exclamation marks, or question marks
(#85) Expected at least 1 space after "."; 0 found

Javascript coding style problems

(0 errors, 30 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/courseflowtool/amd/src/ImportTool.js
(#23) Expected space or tab after '/*' in comment. (spaced-comment)
(#25) Identifier 'json_process_error' is not in camel case. (camelcase)
(#43) Unused eslint-disable directive (no problems were reported from 'no-console').
(#49) Expected space(s) after "if". (keyword-spacing)
(#49) Each then() should return a value or throw (promise/always-return)
(#49) Requires a space after '{'. (block-spacing)
(#49) Statement inside of curly braces should be on next line. (brace-style)
(#49) Missing space before opening brace. (space-before-blocks)
(#49) Requires a space before '}'. (block-spacing)
(#49) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#52) Identifier 'json_process_error' is not in camel case. (camelcase)
(#69) Missing space before value for key 'importurl'. (key-spacing)
(#73) Unused eslint-disable directive (no problems were reported from 'no-console').
(#79) Expected space(s) after "if". (keyword-spacing)
(#79) Each then() should return a value or throw (promise/always-return)
(#79) Requires a space after '{'. (block-spacing)
(#79) Statement inside of curly braces should be on next line. (brace-style)
(#79) Missing space before opening brace. (space-before-blocks)
(#79) Requires a space before '}'. (block-spacing)
(#79) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#82) Identifier 'json_process_error' is not in camel case. (camelcase)
local/courseflowtool/amd/src/PreviewImport.js
(#23) Expected space or tab after '/*' in comment. (spaced-comment)
(#24) Identifier 'error_finalize' is not in camel case. (camelcase)
(#24) A space is required after ','. (comma-spacing)
(#24) Identifier 'error_generic' is not in camel case. (camelcase)
(#33) Unused eslint-disable directive (no problems were reported from 'no-console').
(#38) Each then() should return a value or throw (promise/always-return)
(#41) Identifier 'error_generic' is not in camel case. (camelcase)
(#45) Identifier 'error_finalize' is not in camel case. (camelcase)
(#49) Expected space or tab after '//' in comment. (spaced-comment)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 6 warnings)

This section shows problems detected in mustache templates [More info]

local/courseflowtool/templates/help_page.mustache
(#1) Example context missing.
local/courseflowtool/templates/import_tool.mustache
(#1) Example context missing.
(#1) ESLint warning [camelcase]: Identifier 'json_process_error' is not in camel case. ( json_process_error: "((+json_process_error%2C+local_courseflowtool+))",
local/courseflowtool/templates/preview_import.mustache
(#1) Example context missing.
(#1) ESLint warning [camelcase]: Identifier 'error_finalize' is not in camel case. ( error_finalize: "((+error_finalize%2C+local_courseflowtool+))",
(#1) ESLint warning [camelcase]: Identifier 'error_generic' is not in camel case. ( error_generic: "((+error%2C+local_courseflowtool+))",

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]