Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(96 errors, 4 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/compatability_test/index.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#28) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
local/compatability_test/lang/en/local_compatability_test.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
local/compatability_test/lib.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#33) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#42) Inline comments must start with a capital letter, digit or 3-dots sequence
(#258) Whitespace found at end of line within string
(#259) Whitespace found at end of line within string
(#260) Whitespace found at end of line within string
(#267) Whitespace found at end of line within string
(#268) Whitespace found at end of line within string
(#269) Whitespace found at end of line within string
(#270) Whitespace found at end of line within string
(#280) Inline comments must end in full-stops, exclamation marks, or question marks
(#280) No space found before comment text; expected "// GET THE LANG FILE STRINGS" but found "//GET THE LANG FILE STRINGS"
(#280) Whitespace found at end of line
(#282) Commas (,) must be followed by white space.
(#284) Whitespace found at end of line within string
(#285) Whitespace found at end of line within string
(#286) Whitespace found at end of line within string
(#288) Spaces must be used to indent lines; tabs are not allowed
(#288) Tab found within whitespace
(#288) Whitespace found at end of line within string
(#290) Spaces must be used to indent lines; tabs are not allowed
(#290) Tab found within whitespace
(#290) Whitespace found at end of line within string
(#292) Spaces must be used to indent lines; tabs are not allowed
(#292) Tab found within whitespace
(#292) Whitespace found at end of line within string
(#294) Spaces must be used to indent lines; tabs are not allowed
(#294) Tab found within whitespace
(#294) Whitespace found at end of line within string
(#296) Spaces must be used to indent lines; tabs are not allowed
(#296) Tab found within whitespace
(#296) Whitespace found at end of line within string
(#298) Spaces must be used to indent lines; tabs are not allowed
(#298) Tab found within whitespace
(#298) Whitespace found at end of line within string
(#300) Spaces must be used to indent lines; tabs are not allowed
(#300) Tab found within whitespace
(#300) Whitespace found at end of line within string
(#302) Spaces must be used to indent lines; tabs are not allowed
(#302) Tab found within whitespace
(#302) Whitespace found at end of line within string
(#304) Spaces must be used to indent lines; tabs are not allowed
(#304) Tab found within whitespace
(#304) Whitespace found at end of line within string
(#306) Spaces must be used to indent lines; tabs are not allowed
(#306) Tab found within whitespace
(#306) Whitespace found at end of line within string
(#308) Spaces must be used to indent lines; tabs are not allowed
(#308) Tab found within whitespace
(#308) Whitespace found at end of line within string
(#310) Spaces must be used to indent lines; tabs are not allowed
(#310) Tab found within whitespace
(#310) Whitespace found at end of line within string
(#312) Spaces must be used to indent lines; tabs are not allowed
(#312) Tab found within whitespace
(#312) Whitespace found at end of line within string
(#314) Spaces must be used to indent lines; tabs are not allowed
(#314) Tab found within whitespace
(#314) Whitespace found at end of line within string
(#315) Whitespace found at end of line within string
(#316) Whitespace found at end of line within string
(#317) Whitespace found at end of line within string
(#318) Whitespace found at end of line within string
(#319) Whitespace found at end of line within string
local/compatability_test/settings.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
local/compatability_test/version.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
local/compatability_test/view.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#29) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
(#41) Spaces must be used to indent lines; tabs are not allowed
(#42) Spaces must be used to indent lines; tabs are not allowed
(#43) Spaces must be used to indent lines; tabs are not allowed
(#44) Spaces must be used to indent lines; tabs are not allowed
(#45) Spaces must be used to indent lines; tabs are not allowed
(#45) Line indented incorrectly; expected 8 spaces, found 5
(#46) Spaces must be used to indent lines; tabs are not allowed
(#47) Spaces must be used to indent lines; tabs are not allowed
(#48) Spaces must be used to indent lines; tabs are not allowed
(#48) Line indented incorrectly; expected 8 spaces, found 5
(#49) Spaces must be used to indent lines; tabs are not allowed
(#50) Spaces must be used to indent lines; tabs are not allowed
(#51) Spaces must be used to indent lines; tabs are not allowed
(#51) Line indented incorrectly; expected 8 spaces, found 5
(#52) Spaces must be used to indent lines; tabs are not allowed
(#53) Spaces must be used to indent lines; tabs are not allowed
(#54) Spaces must be used to indent lines; tabs are not allowed
(#54) Line indented incorrectly; expected 8 spaces, found 5
(#55) Spaces must be used to indent lines; tabs are not allowed
(#56) Spaces must be used to indent lines; tabs are not allowed
(#57) Spaces must be used to indent lines; tabs are not allowed
(#58) Spaces must be used to indent lines; tabs are not allowed
(#59) Spaces must be used to indent lines; tabs are not allowed
(#60) Spaces must be used to indent lines; tabs are not allowed
(#61) Spaces must be used to indent lines; tabs are not allowed
(#61) Line indented incorrectly; expected 4 spaces, found 3
(#62) Spaces must be used to indent lines; tabs are not allowed
(#63) Spaces must be used to indent lines; tabs are not allowed

Javascript coding style problems

(10 errors, 345 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

local/compatability_test/js/PluginDetect_Java_Flash.js
(#10) Line is too long.
(#14) Line is too long.
(#30) Line is too long.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) 'hasOwnProperty' is a really bad name.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '!==' and instead saw '!='.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing 'new' prefix when invoking a constructor.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '{' and instead saw 'if'.
(#30) Expected '{' and instead saw 'e'.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing 'new' prefix when invoking a constructor.
(#30) Missing 'new' prefix when invoking a constructor.
(#30) Missing 'new' prefix when invoking a constructor.
(#30) Expected '{' and instead saw 'for'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'for'.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'break'.
(#30) Missing semicolon.
(#30) 'l' used out of scope.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'c'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '===' and instead saw '=='.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'if'.
(#30) Expected '!==' and instead saw '!='.
(#30) Expected '!==' and instead saw '!='.
(#30) Expected '===' and instead saw '=='.
(#30) Expected '!==' and instead saw '!='.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing semicolon.
(#30) Missing '()' invoking a constructor.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Wrap an immediate function invocation in parens to assist the reader in understanding that the expression is the result of a function, and not the function itself.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'break'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw ';'.
(#30) Expected '{' and instead saw 'for'.
(#30) Expected '{' and instead saw 'if'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) eval can be harmful.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) 'c' is already defined.
(#30) Expected '{' and instead saw 'if'.
(#30) Missing 'new' prefix when invoking a constructor.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '{' and instead saw 'for'.
(#30) Expected '{' and instead saw 'c'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'for'.
(#30) Expected '{' and instead saw 'if'.
(#30) Expected '===' and instead saw '=='.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '!==' and instead saw '!='.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '===' and instead saw '=='.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '!==' and instead saw '!='.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '===' and instead saw '=='.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '!==' and instead saw '!='.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '!==' and instead saw '!='.
(#30) Expected '!==' and instead saw '!='.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '!==' and instead saw '!='.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'c'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'e'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'b'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'for'.
(#30) Expected '{' and instead saw 'if'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'for'.
(#30) Expected '{' and instead saw 'if'.
(#30) Missing semicolon.
(#30) Expected '===' and instead saw '=='.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'a'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '{' and instead saw ';'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'break'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '===' and instead saw '=='.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'a'.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'f'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '===' and instead saw '=='.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '{' and instead saw 'return'.
(#30) Expected '===' and instead saw '=='.
(#30) Expected '{' and instead saw 'return'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'for'.
(#30) Expected '{' and instead saw 'try'.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Missing semicolon.
(#30) Expected '{' and instead saw 'try'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected a conditional expression and instead saw an assignment.
(#30) Expected '{' and instead saw 'f'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Expected '{' and instead saw '/'.
(#30) Expected an identifier and instead saw '/'.
(#30) Expected an operator and instead saw '['.
(#30) Unexpected '\'.
(#30) Expected an operator and instead saw '^'.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) Unmatched '{'.
(#30) Unmatched '{'.
(#30) Unmatched '{'.
(#30) Unmatched '{'.
(#30) Missing semicolon.
(#30) Unmatched '{'.
(#30) Unmatched '('.
(#30) Wrapping non-IIFE function literals in parens is unnecessary.
(#30) Expected an assignment or function call and instead saw an expression.
(#30) Missing semicolon.
(#30) 'e' is defined but never used.
(#30) 'd' is defined but never used.
(#30) 'k' is defined but never used.
(#30) 'p' is defined but never used.
(#30) 'm' is defined but never used.
(#30) 'h' is defined but never used.
local/compatability_test/js/scripts.js
(#4) Expected '===' and instead saw '=='.
(#12) Unreachable 'break' after 'return'.
(#16) Unreachable 'break' after 'return'.
(#20) Unreachable 'break' after 'return'.
(#24) Unreachable 'break' after 'return'.
(#28) Unreachable 'break' after 'return'.
(#32) Unreachable 'break' after 'return'.
(#36) Unreachable 'break' after 'return'.
(#40) Unreachable 'break' after 'return'.
(#49) Unreachable 'break' after 'return'.
(#53) Unreachable 'break' after 'return'.
(#57) Unreachable 'break' after 'return'.
(#64) Unreachable 'break' after 'return'.
(#68) Unreachable 'break' after 'return'.
(#72) Unreachable 'break' after 'return'.
(#76) Unreachable 'break' after 'return'.
(#85) Unreachable 'break' after 'return'.
(#89) Unreachable 'break' after 'return'.
(#93) Unreachable 'break' after 'return'.
(#100) Unreachable 'break' after 'return'.
(#104) Unreachable 'break' after 'return'.
(#108) Unreachable 'break' after 'return'.
(#112) Unreachable 'break' after 'return'.
(#121) Unreachable 'break' after 'return'.
(#125) Unreachable 'break' after 'return'.
(#129) Unreachable 'break' after 'return'.
(#136) Unreachable 'break' after 'return'.
(#140) Unreachable 'break' after 'return'.
(#144) Unreachable 'break' after 'return'.
(#148) Unreachable 'break' after 'return'.
(#159) ['java'] is better written in dot notation.
(#162) Expected '===' and instead saw '=='.
(#163) ['failure_java_not_installed'] is better written in dot notation.
(#167) Expected '===' and instead saw '=='.
(#168) ['failure_java_mac'] is better written in dot notation.
(#171) ['java'] is better written in dot notation.
(#171) ['visit_website_java'] is better written in dot notation.
(#173) ['flash'] is better written in dot notation.
(#176) Expected '===' and instead saw '=='.
(#177) ['failure_flash_not_installed'] is better written in dot notation.
(#180) ['flash'] is better written in dot notation.
(#180) ['visit_website_flash'] is better written in dot notation.
(#182) ['quicktime'] is better written in dot notation.
(#185) Expected '===' and instead saw '=='.
(#186) ['failure_quicktime_not_installed'] is better written in dot notation.
(#189) Line is too long.
(#189) ['quicktime'] is better written in dot notation.
(#189) ['visit_website_quicktime'] is better written in dot notation.
(#191) ['silverlight'] is better written in dot notation.
(#194) Expected '===' and instead saw '=='.
(#195) ['failure_silverlight_not_installed'] is better written in dot notation.
(#198) Line is too long.
(#198) ['silverlight'] is better written in dot notation.
(#198) ['visit_website_silverlight'] is better written in dot notation.
(#200) ['browser'] is better written in dot notation.
(#202) ['chrome'] is better written in dot notation.
(#205) ['chrome'] is better written in dot notation.
(#205) ['visit_website_chrome'] is better written in dot notation.
(#208) ['gecko'] is better written in dot notation.
(#211) ['gecko'] is better written in dot notation.
(#211) ['visit_website_gecko'] is better written in dot notation.
(#214) ['opera'] is better written in dot notation.
(#217) ['opera'] is better written in dot notation.
(#217) ['visit_website_opera'] is better written in dot notation.
(#220) ['safari'] is better written in dot notation.
(#221) Unnecessary semicolon.
(#223) ['safari'] is better written in dot notation.
(#223) ['visit_website_safari'] is better written in dot notation.
(#235) 'buildRow' was used before it was defined.
(#236) Expected '===' and instead saw '=='.
(#247) Expected '===' and instead saw '=='.
(#254) 'banner' is already defined.
(#257) ['banner_success'] is better written in dot notation.
(#266) Expected '===' and instead saw '=='.
(#267) Confusing use of '!'.
(#274) Expected '===' and instead saw '=='.
(#278) Expected '===' and instead saw '=='.
(#301) 'currentVersion' is already defined.
(#303) 'i' is already defined.
(#311) 'currentVersion' is already defined.
(#313) 'i' is already defined.
(#320) 'currentVersion' is already defined.
(#322) 'i' is already defined.
(#338) ['chrome'] is better written in dot notation.
(#339) ['chrome'] is better written in dot notation.
(#342) ['gecko'] is better written in dot notation.
(#343) ['gecko'] is better written in dot notation.
(#346) ['opera'] is better written in dot notation.
(#347) ['opera'] is better written in dot notation.
(#350) ['safari'] is better written in dot notation.
(#351) ['safari'] is better written in dot notation.
(#359) ['browser'] is better written in dot notation.
(#362) ['java'] is better written in dot notation.
(#362) ['java'] is better written in dot notation.
(#365) ['flash'] is better written in dot notation.
(#365) ['flash'] is better written in dot notation.
(#368) ['quicktime'] is better written in dot notation.
(#368) ['quicktime'] is better written in dot notation.
(#371) ['silverlight'] is better written in dot notation.
(#371) ['silverlight'] is better written in dot notation.
(#376) 'upToDate' was used before it was defined.
(#155) 'updateUserView' is defined but never used.
(#265) 'forceStatusPage' is defined but never used.
(#273) 'checkDisplayBanner' is defined but never used.
(#358) 'isUpToDate' is defined but never used.

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]


PHPDocs style problems

(25 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/compatability_test/index.php
(#22) Package local is not valid
local/compatability_test/lib.php
(#33) Function local_compatability_test_check_enabled is not documented
(#87) Function local_compatability_test_enable_browser_check is not documented
(#95) Function local_compatability_test_enable_chrome_check is not documented
(#103) Function local_compatability_test_enable_gecko_check is not documented
(#111) Function local_compatability_test_enable_opera_check is not documented
(#119) Function local_compatability_test_enable_safari_check is not documented
(#127) Function local_compatability_test_enable_flash_check is not documented
(#135) Function local_compatability_test_enable_java_check is not documented
(#143) Function local_compatability_test_enable_quicktime_check is not documented
(#151) Function local_compatability_test_enable_silverlight_check is not documented
(#164) Function local_compatability_test_min_version_flash is not documented
(#172) Function local_compatability_test_min_version_java is not documented
(#180) Function local_compatability_test_min_version_quicktime is not documented
(#188) Function local_compatability_test_min_version_silverlight is not documented
(#196) Function local_compatability_test_min_version_chrome is not documented
(#204) Function local_compatability_test_min_version_gecko is not documented
(#212) Function local_compatability_test_min_version_opera is not documented
(#220) Function local_compatability_test_min_version_safari is not documented
(#232) Function local_compatability_test_force_view_page is not documented
(#244) Function local_compatability_test_admin_feedback is not documented
(#23) Package local is not valid
local/compatability_test/settings.php
(#22) Package local is not valid
local/compatability_test/version.php
(#22) Package local is not valid
local/compatability_test/view.php
(#22) Package local is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]