Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(173 errors, 58 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/cnw_smartcohort/classes/observer.php
(#35) Opening brace should be on the same line as the declaration
(#49) Opening brace should be on the same line as the declaration
(#58) Opening brace should be on the same line as the declaration
local/cnw_smartcohort/classes/privacy/provider.php
(#39) Opening brace should be on the same line as the declaration
local/cnw_smartcohort/classes/task/initialize_filter.php
(#30) "require_once" must be immediately followed by an open parenthesis
(#41) Opening brace should be on the same line as the declaration
(#49) Opening brace should be on the same line as the declaration
local/cnw_smartcohort/classes/task/process_queue.php
(#30) "require_once" must be immediately followed by an open parenthesis
(#41) Opening brace should be on the same line as the declaration
(#49) Opening brace should be on the same line as the declaration
local/cnw_smartcohort/db/upgrade.php
(#36) Opening brace should be on the same line as the declaration
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
local/cnw_smartcohort/db/upgradelib.php
(#31) Opening brace should be on the same line as the declaration
local/cnw_smartcohort/edit.php
(#78) Inline comments must end in full-stops, exclamation marks, or question marks
(#80) Line exceeds 132 characters; contains 167 characters
(#81) Line exceeds 132 characters; contains 162 characters
(#111) Variable "confirmOutput" must be all lower-case
(#112) Variable "confirmOutput" must be all lower-case
(#113) Variable "confirmOutput" must be all lower-case
(#114) Variable "confirmOutput" must be all lower-case
(#115) Variable "confirmOutput" must be all lower-case
(#120) Variable "confirmOutput" must be all lower-case
(#121) Variable "confirmOutput" must be all lower-case
(#122) Variable "confirmOutput" must be all lower-case
(#123) Variable "confirmOutput" must be all lower-case
(#124) Variable "confirmOutput" must be all lower-case
(#124) Line exceeds 132 characters; contains 161 characters
(#125) Variable "confirmOutput" must be all lower-case
(#126) Variable "confirmOutput" must be all lower-case
(#127) Variable "confirmOutput" must be all lower-case
(#128) Variable "confirmOutput" must be all lower-case
local/cnw_smartcohort/edit_form.php
(#41) Opening brace should be on the same line as the declaration
(#47) Line exceeds 132 characters; contains 135 characters
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#57) Inline comments must end in full-stops, exclamation marks, or question marks
(#73) Inline comments must end in full-stops, exclamation marks, or question marks
(#103) Line exceeds 132 characters; contains 141 characters
(#105) Line exceeds 132 characters; contains 145 characters
(#108) Line exceeds 132 characters; contains 139 characters
(#124) Inline comments must end in full-stops, exclamation marks, or question marks
(#128) Variable "operatorKey" must be all lower-case
(#129) Variable "valueKey" must be all lower-case
(#130) Variable "operatorKey" must be all lower-case
(#131) Variable "valueKey" must be all lower-case
(#139) Opening brace should be on the same line as the declaration
local/cnw_smartcohort/index.php
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#52) This comment is 50% valid code; is this commented out code?
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) Variable "profileFields" must be all lower-case
(#72) Variable "profileFields" must be all lower-case
(#76) Line exceeds 132 characters; contains 160 characters
(#82) Inline comments must end in full-stops, exclamation marks, or question marks
(#84) Line exceeds maximum limit of 180 characters; contains 211 characters
(#85) Line exceeds maximum limit of 180 characters; contains 190 characters
(#86) Line exceeds maximum limit of 180 characters; contains 193 characters
(#88) Inline control structures are not allowed
(#90) Inline comments must end in full-stops, exclamation marks, or question marks
(#92) Variable "rulesString" must be all lower-case
(#94) Variable "rulesString" must be all lower-case
(#99) Variable "rulesString" must be all lower-case
(#99) Variable "profileFields" must be all lower-case
(#101) Variable "rulesString" must be all lower-case
(#101) Variable "profileFields" must be all lower-case
(#103) Variable "rulesString" must be all lower-case
(#103) Line exceeds maximum limit of 180 characters; contains 212 characters
(#107) Variable "rulesString" must be all lower-case
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
(#110) Variable "affectedUsers" must be all lower-case
(#112) Inline comments must end in full-stops, exclamation marks, or question marks
(#118) Variable "rulesString" must be all lower-case
(#119) Line exceeds 132 characters; contains 133 characters
(#120) Variable "affectedUsers" must be all lower-case
(#120) Line exceeds maximum limit of 180 characters; contains 210 characters
(#128) Line exceeds maximum limit of 180 characters; contains 294 characters
local/cnw_smartcohort/lib.php
(#31) Variable "with_deleted" must not contain underscores.
(#32) Opening brace should be on the same line as the declaration
(#35) Variable "with_deleted" must not contain underscores.
(#43) Opening brace should be on the same line as the declaration
(#49) Variable "queryWhere" must be all lower-case
(#50) Variable "queryParams" must be all lower-case
(#65) Variable "queryWhere" must be all lower-case
(#67) Variable "queryWhere" must be all lower-case
(#69) Variable "queryParams" must be all lower-case
(#72) Line exceeds maximum limit of 180 characters; contains 196 characters
(#79) Variable "queryParams" must be all lower-case
(#81) Variable "queryWhere" must be all lower-case
(#82) Variable "queryWhere" must be all lower-case
(#85) Variable "queryParams" must be all lower-case
(#99) Opening brace should be on the same line as the declaration
(#102) Inline comments must end in full-stops, exclamation marks, or question marks
(#105) Inline comments must end in full-stops, exclamation marks, or question marks
(#111) Variable "operatorKey" must be all lower-case
(#112) Variable "operatorKey" must be all lower-case
(#113) Variable "valueKey" must be all lower-case
(#118) Variable "operatorKey" must be all lower-case
(#119) Variable "valueKey" must be all lower-case
(#141) Opening brace should be on the same line as the declaration
(#144) Inline comments must end in full-stops, exclamation marks, or question marks
(#147) Inline comments must end in full-stops, exclamation marks, or question marks
(#150) Inline comments must end in full-stops, exclamation marks, or question marks
(#150) No space found before comment text; expected "// STORE NEW RULES" but found "//STORE NEW RULES"
(#156) Variable "operatorKey" must be all lower-case
(#157) Variable "operatorKey" must be all lower-case
(#158) Variable "valueKey" must be all lower-case
(#163) Variable "operatorKey" must be all lower-case
(#164) Variable "valueKey" must be all lower-case
(#185) Opening brace should be on the same line as the declaration
(#190) Inline comments must end in full-stops, exclamation marks, or question marks
(#191) Variable "shouldRemove" must be all lower-case
(#191) Line exceeds maximum limit of 180 characters; contains 297 characters
(#194) Variable "shouldRemove" must be all lower-case
(#194) Variable "scAdd" must be all lower-case
(#195) Variable "scAdd" must be all lower-case
(#195) Variable "scAdd" must be all lower-case
(#200) Inline comments must end in full-stops, exclamation marks, or question marks
(#216) Opening brace should be on the same line as the declaration
(#219) Variable "affectedUsers" must be all lower-case
(#221) Variable "cohortUsers" must be all lower-case
(#223) Variable "cohortUsers" must be all lower-case
(#226) Variable "affectedUserIds" must be all lower-case
(#227) Variable "affectedUsers" must be all lower-case
(#227) Variable "affectedUser" must be all lower-case
(#228) Variable "affectedUserIds" must be all lower-case
(#228) Variable "affectedUser" must be all lower-case
(#230) Variable "cohortUserIds" must be all lower-case
(#231) Variable "cohortUsers" must be all lower-case
(#231) Variable "cohortUser" must be all lower-case
(#232) Variable "cohortUserIds" must be all lower-case
(#232) Variable "cohortUser" must be all lower-case
(#235) Variable "shouldBeInCohort" must be all lower-case
(#235) Variable "affectedUserIds" must be all lower-case
(#235) Variable "cohortUserIds" must be all lower-case
(#236) Variable "shouldNotBeInCohort" must be all lower-case
(#236) Variable "cohortUserIds" must be all lower-case
(#236) Variable "affectedUserIds" must be all lower-case
(#238) Inline comments must end in full-stops, exclamation marks, or question marks
(#239) Variable "shouldNotBeInCohort" must be all lower-case
(#239) Variable "userId" must be all lower-case
(#240) Variable "scAdds" must be all lower-case
(#240) Variable "userId" must be all lower-case
(#241) Variable "scAdds" must be all lower-case
(#241) Variable "scAdds" must be all lower-case
(#242) Variable "userId" must be all lower-case
(#243) Variable "userId" must be all lower-case
(#247) Inline comments must end in full-stops, exclamation marks, or question marks
(#248) Variable "shouldBeInCohort" must be all lower-case
(#248) Variable "userId" must be all lower-case
(#249) Variable "userId" must be all lower-case
(#250) Variable "userId" must be all lower-case
(#250) Line exceeds 132 characters; contains 143 characters
(#251) Variable "scAdd" must be all lower-case
(#252) Variable "scAdd" must be all lower-case
(#253) Variable "scAdd" must be all lower-case
(#253) Variable "userId" must be all lower-case
(#254) Variable "scAdd" must be all lower-case
(#255) Variable "scAdd" must be all lower-case
(#259) Inline comments must end in full-stops, exclamation marks, or question marks
(#260) Variable "affectedUserIds" must be all lower-case
(#260) Variable "cohortUserIds" must be all lower-case
(#261) Variable "userId" must be all lower-case
(#262) Variable "userId" must be all lower-case
(#262) Line exceeds 132 characters; contains 143 characters
(#263) Variable "scAdd" must be all lower-case
(#264) Variable "scAdd" must be all lower-case
(#265) Variable "scAdd" must be all lower-case
(#265) Variable "userId" must be all lower-case
(#266) Variable "scAdd" must be all lower-case
(#267) Variable "scAdd" must be all lower-case
(#278) Opening brace should be on the same line as the declaration
(#293) Opening brace should be on the same line as the declaration
local/cnw_smartcohort/tests/smartcohort_test.php
(#43) Visibility must be declared on method "arrays_are_similar"
(#44) Opening brace should be on the same line as the declaration
(#45) Inline comments must start with a capital letter, digit or 3-dots sequence
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must start with a capital letter, digit or 3-dots sequence
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#56) Inline comments must start with a capital letter, digit or 3-dots sequence
(#56) Inline comments must end in full-stops, exclamation marks, or question marks
(#67) Variable "getField" must be all lower-case
(#68) Opening brace should be on the same line as the declaration
(#85) Variable "getField" must be all lower-case
(#96) Inline comments must start with a capital letter, digit or 3-dots sequence
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
(#96) This comment is 80% valid code; is this commented out code?
(#96) No space found before comment text; expected "// var_dump($filterid);" but found "//var_dump($filterid);"
(#105) Public method name "smartcohort_test::testCohortLibHasAllFunction" must be in lower-case letters only
(#106) Opening brace should be on the same line as the declaration
(#120) Public method name "smartcohort_test::testCohortTableSchema" must be in lower-case letters only
(#121) Opening brace should be on the same line as the declaration
(#137) Opening brace should be on the same line as the declaration
(#141) Variable "lib_get" must not contain underscores.
(#143) Variable "lib_get" must not contain underscores.
(#148) Opening brace should be on the same line as the declaration
(#172) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#181) Opening brace should be on the same line as the declaration
(#194) Line exceeds 132 characters; contains 170 characters
(#202) Opening brace should be on the same line as the declaration
(#208) Variable "usertoAdd" must be all lower-case
(#209) Variable "usertoAdd" must be all lower-case
(#210) Variable "usertoAdd" must be all lower-case
(#211) Variable "usertoAdd" must be all lower-case
(#212) Variable "usertoAdd" must be all lower-case
(#214) Variable "usertoAdd" must be all lower-case
(#215) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#221) Line exceeds 132 characters; contains 144 characters
(#226) Opening brace should be on the same line as the declaration
(#234) Variable "usertoAdd" must be all lower-case
(#235) Variable "usertoAdd" must be all lower-case
(#236) Variable "usertoAdd" must be all lower-case
(#237) Variable "usertoAdd" must be all lower-case
(#238) Variable "usertoAdd" must be all lower-case
(#240) Variable "usertoAdd" must be all lower-case
(#248) Opening brace should be on the same line as the declaration
(#258) Line exceeds 132 characters; contains 148 characters
(#262) Line exceeds 132 characters; contains 149 characters
(#268) Line exceeds 132 characters; contains 148 characters
(#272) Line exceeds 132 characters; contains 149 characters
(#274) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#279) Opening brace should be on the same line as the declaration
(#289) Line exceeds 132 characters; contains 148 characters
(#293) Line exceeds 132 characters; contains 149 characters
(#299) Line exceeds 132 characters; contains 148 characters
(#303) Line exceeds 132 characters; contains 149 characters
(#305) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#310) Opening brace should be on the same line as the declaration
(#327) Line exceeds 132 characters; contains 148 characters
(#331) Line exceeds 132 characters; contains 150 characters
(#337) Opening brace should be on the same line as the declaration
(#354) Line exceeds 132 characters; contains 148 characters
(#358) Line exceeds 132 characters; contains 150 characters

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(17 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/cnw_smartcohort/classes/observer.php
(#29) Class local_cnw_smartcohort_observer is not documented
(#31) There is no description in phpdocs for function user_updated
(#45) There is no description in phpdocs for function user_deleted
(#54) There is no description in phpdocs for function cohort_deleted
local/cnw_smartcohort/classes/privacy/provider.php
(#29) Class provider is not documented
local/cnw_smartcohort/classes/task/initialize_filter.php
(#32) Class initialize_filter is not documented
local/cnw_smartcohort/classes/task/process_queue.php
(#32) Class process_queue is not documented
local/cnw_smartcohort/edit_form.php
(#31) Class filter_edit_form is not documented
(#138) Function filter_edit_form::validation is not documented
local/cnw_smartcohort/lib.php
(#31) Function smartcohort_get_filters is not documented
(#42) Function smartcohort_get_users_by_filter is not documented
(#211) Phpdocs for function smartcohort_run_filter has incomplete parameters list
local/cnw_smartcohort/tests/smartcohort_test.php
(#33) Class smartcohort_test is not documented
(#105) Function smartcohort_test::testCohortLibHasAllFunction is not documented
(#120) Function smartcohort_test::testCohortTableSchema is not documented
(#39) Phpdocs for function smartcohort_test::arrays_are_similar has incomplete parameters list
(#63) Phpdocs for function smartcohort_test::create_filter has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]