Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(102 errors, 106 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/categorybanner/classes/admin_setting_categorybanner_rules.php
(#37) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#91) Whitespace found at end of line
(#93) Whitespace found at end of line
(#94) This comment is 44% valid code; is this commented out code?
(#95) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) No space found before comment text; expected "// $return .= html_writer::tag('pre', 'Plugin Config: ' . print_r(get_config('local_categorybanner'), true));" but found "//$return .= html_writer::tag('pre', 'Plugin Config: ' . print_r(get_config('local_categorybanner'), true));"
(#96) Whitespace found at end of line
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#99) Whitespace found at end of line
(#100) This comment is 44% valid code; is this commented out code?
(#101) Inline comments must end in full-stops, exclamation marks, or question marks
(#101) No space found before comment text; expected "// $return .= html_writer::tag('pre', 'Rules Array: ' . print_r($rules, true));" but found "//$return .= html_writer::tag('pre', 'Rules Array: ' . print_r($rules, true));"
(#102) Whitespace found at end of line
(#106) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Short array syntax must be used to define arrays
(#111) There should be a comma after the last array item in a multi-line array.
(#114) Short array syntax must be used to define arrays
(#115) Whitespace found at end of line
(#117) Whitespace found at end of line
(#118) Whitespace found at end of line
(#119) Whitespace found at end of line
(#120) Whitespace found at end of line
(#123) Whitespace found at end of line
(#124) Inline comments must end in full-stops, exclamation marks, or question marks
(#125) Short array syntax must be used to define arrays
(#126) Whitespace found at end of line
(#127) Inline comments must end in full-stops, exclamation marks, or question marks
(#128) Short array syntax must be used to define arrays
(#131) There should be a comma after the last array item in a multi-line array.
(#136) Short array syntax must be used to define arrays
(#138) Whitespace found at end of line
(#139) Inline comments must end in full-stops, exclamation marks, or question marks
(#140) Short array syntax must be used to define arrays
(#144) There should be a comma after the last array item in a multi-line array.
(#149) Short array syntax must be used to define arrays
(#151) There should be a comma after the last array item in a multi-line array.
(#154) Whitespace found at end of line
(#155) Short array syntax must be used to define arrays
(#158) There should be a comma after the last array item in a multi-line array.
(#161) Whitespace found at end of line
(#164) Whitespace found at end of line
(#165) Inline comments must end in full-stops, exclamation marks, or question marks
(#166) Short array syntax must be used to define arrays
(#168) There should be a comma after the last array item in a multi-line array.
(#170) Whitespace found at end of line
(#175) Short array syntax must be used to define arrays
(#179) Whitespace found at end of line
local/categorybanner/classes/form/edit_rule.php
(#40) Whitespace found at end of line
(#42) Whitespace found at end of line
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Short array syntax must be used to define arrays
(#46) Line exceeds 132 characters; contains 157 characters
(#50) Line exceeds 132 characters; contains 133 characters
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) This comment is 43% valid code; is this commented out code?
(#51) Whitespace found at end of line
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#53) Short array syntax must be used to define arrays
(#56) Whitespace found at end of line
(#57) Inline comments must end in full-stops, exclamation marks, or question marks
(#58) Short array syntax must be used to define arrays
(#58) Short array syntax must be used to define arrays
(#58) Line exceeds 132 characters; contains 168 characters
(#61) Whitespace found at end of line
(#62) Inline comments must end in full-stops, exclamation marks, or question marks
(#69) Whitespace found at end of line within string
(#80) Whitespace found at end of line within string
(#85) Whitespace found at end of line
(#86) Inline comments must end in full-stops, exclamation marks, or question marks
(#89) Whitespace found at end of line
(#90) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) Whitespace found at end of line
(#94) Inline comments must end in full-stops, exclamation marks, or question marks
(#97) Whitespace found at end of line
(#100) Whitespace found at end of line
(#110) Whitespace found at end of line
(#114) Whitespace found at end of line
(#118) Whitespace found at end of line
local/categorybanner/classes/rule_manager.php
(#39) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#43) Whitespace found at end of line
(#45) Whitespace found at end of line
(#57) Whitespace found at end of line
(#62) Whitespace found at end of line
(#65) Whitespace found at end of line
(#68) Whitespace found at end of line
(#74) Whitespace found at end of line
(#76) Whitespace found at end of line
(#101) Short array syntax must be used to define arrays
(#103) Whitespace found at end of line
(#104) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Line exceeds 132 characters; contains 155 characters
(#109) Short array syntax must be used to define arrays
(#113) There should be a comma after the last array item in a multi-line array.
(#118) Whitespace found at end of line
(#119) Inline comments must end in full-stops, exclamation marks, or question marks
(#123) Whitespace found at end of line
(#129) Whitespace found at end of line
(#137) Whitespace found at end of line
(#138) Whitespace found at end of line
(#139) Whitespace found at end of line
(#141) Short array syntax must be used to define arrays
(#145) There should be a comma after the last array item in a multi-line array.
(#148) Whitespace found at end of line
(#161) Variable "applicable_banners" must not contain underscores.
(#161) Short array syntax must be used to define arrays
(#162) Whitespace found at end of line
(#164) Inline comments must end in full-stops, exclamation marks, or question marks
(#166) Variable "applicable_banners" must not contain underscores.
(#168) Inline comments must end in full-stops, exclamation marks, or question marks
(#169) Expected "} else if (...) {\n"; found "}\n // Check for exact category match\n else if (...) {\n"
(#170) Variable "applicable_banners" must not contain underscores.
(#172) Inline comments must end in full-stops, exclamation marks, or question marks
(#173) Expected "} else if (...) {\n"; found "}\n // Check if rule applies to subcategories (only if not already matched)\n else if (...) {\n"
(#174) Inline comments must end in full-stops, exclamation marks, or question marks
(#175) Short array syntax must be used to define arrays
(#177) Variable "path_parts" must not contain underscores.
(#178) Inline comments must end in full-stops, exclamation marks, or question marks
(#179) Variable "path_parts" must not contain underscores.
(#180) Variable "applicable_banners" must not contain underscores.
(#185) Whitespace found at end of line
(#186) Variable "applicable_banners" must not contain underscores.
(#189) Whitespace found at end of line
(#190) Inline comments must end in full-stops, exclamation marks, or question marks
(#191) Variable "applicable_banners" must not contain underscores.
(#204) Variable "max_id" must not contain underscores.
(#205) Variable "max_id" must not contain underscores.
(#217) Variable "apply_to_subcategories" must not contain underscores.
(#221) Whitespace found at end of line
(#224) Variable "apply_to_subcategories" must not contain underscores.
(#224) Line exceeds 132 characters; contains 133 characters
(#225) Whitespace found at end of line
(#226) Inline comments must end in full-stops, exclamation marks, or question marks
(#228) Whitespace found at end of line
(#243) Whitespace found at end of line
(#247) Whitespace found at end of line
(#248) Inline comments must end in full-stops, exclamation marks, or question marks
(#250) Whitespace found at end of line
local/categorybanner/db/access.php
(#27) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#29) Inline comments must start with a capital letter, digit or 3-dots sequence
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#29) No space found before comment text; expected "// this capability has a risk of XSS (Cross-Site Scripting)" but found "//this capability has a risk of XSS (Cross-Site Scripting)"
(#31) Whitespace found at end of line
(#32) Short array syntax must be used to define arrays
(#34) There should be a comma after the last array item in a multi-line array.
(#35) There should be a comma after the last array item in a multi-line array.
(#36) There should be a comma after the last array item in a multi-line array.
local/categorybanner/db/events.php
(#27) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#28) There should be a comma after the last array item in a multi-line array.
local/categorybanner/edit.php
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Short array syntax must be used to define arrays
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) Short array syntax must be used to define arrays
(#66) Short array syntax must be used to define arrays
(#70) Short array syntax must be used to define arrays
(#72) There should be a comma after the last array item in a multi-line array.
(#74) There should be a comma after the last array item in a multi-line array.
(#78) Short array syntax must be used to define arrays
(#80) There should be a comma after the last array item in a multi-line array.
(#87) Inline comments must end in full-stops, exclamation marks, or question marks
(#94) Whitespace found at end of line
local/categorybanner/lang/en/local_categorybanner.php
(#28) The string key "no_rules" is not in the correct order, it should be before "rules_desc"
(#29) The string key "add_rule" is not in the correct order, it should be before "no_rules"
(#31) The string key "delete_rule" is not in the correct order, it should be before "edit_rule"
(#32) The string key "category" is not in the correct order, it should be before "delete_rule"
(#34) The string key "apply_to_subcategories" is not in the correct order, it should be before "global_banner"
(#37) The string key "rule_saved" is not in the correct order, it should be before "unknown_category"
(#38) The string key "rule_deleted" is not in the correct order, it should be before "rule_saved"
(#39) The string key "confirm_delete" is not in the correct order, it should be before "rule_deleted"
(#40) The string key "categorybanner:managebanner" is not in the correct order, it should be before "confirm_delete"
(#42) The string key "actions" is not in the correct order, it should be before "categorybanner:managebanner"
local/categorybanner/lang/fr/local_categorybanner.php
(#19) Whitespace found at end of line
(#20) Whitespace found at end of line
(#23) Whitespace found at end of line
(#27) Whitespace found at end of line
(#42) The string key "no_rules" is not in the correct order, it should be before "rules_desc"
(#43) The string key "add_rule" is not in the correct order, it should be before "no_rules"
(#45) The string key "delete_rule" is not in the correct order, it should be before "edit_rule"
(#46) The string key "category" is not in the correct order, it should be before "delete_rule"
(#48) The string key "apply_to_subcategories" is not in the correct order, it should be before "global_banner"
(#51) The string key "rule_saved" is not in the correct order, it should be before "unknown_category"
(#52) The string key "rule_deleted" is not in the correct order, it should be before "rule_saved"
(#53) The string key "confirm_delete" is not in the correct order, it should be before "rule_deleted"
(#54) The string key "categorybanner:managebanner" is not in the correct order, it should be before "confirm_delete"
(#55) The string key "actions" is not in the correct order, it should be before "categorybanner:managebanner"
local/categorybanner/lib.php
(#19) Whitespace found at end of line
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) Whitespace found at end of line
(#53) Variable "course_layouts" must not contain underscores.
(#53) Short array syntax must be used to define arrays
(#54) Variable "course_layouts" must not contain underscores.
(#65) Whitespace found at end of line
(#66) Inline comments must end in full-stops, exclamation marks, or question marks
(#84) Inline comments must end in full-stops, exclamation marks, or question marks
(#89) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) Inline comments must end in full-stops, exclamation marks, or question marks
local/categorybanner/settings.php
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#41) Whitespace found at end of line
(#49) Short array syntax must be used to define arrays
(#53) Inline comments must end in full-stops, exclamation marks, or question marks
(#57) Inline comments must end in full-stops, exclamation marks, or question marks
(#60) Inline comments must end in full-stops, exclamation marks, or question marks
(#66) Inline comments must end in full-stops, exclamation marks, or question marks
local/categorybanner/version.php
(#27) Inline comments must end in full-stops, exclamation marks, or question marks
(#28) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(1 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

local/categorybanner/styles.css
(#2) Unexpected !important (declaration-no-important)

PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]