Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(171 errors, 106 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/autogroup/classes/domain.php: (#46) Short array syntax must be used to define arrays; (#56) @type tag is not allowed in member variable comment; (#56) Invalid docblock tag "@type".; (#57) Missing @var tag in member variable comment; (#71) No one-line description found in phpdocs for docblock of function get_id; (#79) No one-line description found in phpdocs for docblock of function __get; (#95) No one-line description found in phpdocs for docblock of function __set; (#114) No one-line description found in phpdocs for docblock of function set_id; (#131) No one-line description found in phpdocs for docblock of function exists
local/autogroup/classes/domain/autogroup_set.php: (#60) Short array syntax must be used to define arrays; (#61) There should be a comma after the last array item in a multi-line array.; (#94) Short array syntax must be used to define arrays; (#98) Short array syntax must be used to define arrays; (#106) No one-line description found in phpdocs for docblock of function __construct; (#129) No one-line description found in phpdocs for docblock of function validate_object; (#140) No one-line description found in phpdocs for docblock of function load_from_object; (#178) No one-line description found in phpdocs for docblock of function get_autogroups; (#183) Short array syntax must be used to define arrays; (#185) There should be a comma after the last array item in a multi-line array.; (#203) No one-line description found in phpdocs for docblock of function generate_group_idnumber; (#206) Short array syntax must be used to define arrays; (#209) There should be a comma after the last array item in a multi-line array.; (#219) No one-line description found in phpdocs for docblock of function retrieve_applicable_roles; (#220) Short array syntax must be used to define arrays; (#232) No one-line description found in phpdocs for docblock of function retrieve_default_roles; (#236) Short array syntax must be used to define arrays; (#252) No one-line description found in phpdocs for docblock of function delete; (#258) Short array syntax must be used to define arrays; (#259) Short array syntax must be used to define arrays; (#260) Short array syntax must be used to define arrays; (#288) No one-line description found in phpdocs for docblock of function get_eligible_roles; (#289) Short array syntax must be used to define arrays; (#345) No one-line description found in phpdocs for docblock of function get_group_count; (#352) No one-line description found in phpdocs for docblock of function get_membership_counts; (#353) Short array syntax must be used to define arrays; (#392) No one-line description found in phpdocs for docblock of function set_course; (#419) No one-line description found in phpdocs for docblock of function set_options; (#434) No one-line description found in phpdocs for docblock of function verify_user_group_membership; (#435) Short array syntax must be used to define arrays; (#444) Short array syntax must be used to define arrays; (#497) No one-line description found in phpdocs for docblock of function get_or_create_group_by_idnumber; (#520) Short array syntax must be used to define arrays; (#553) No one-line description found in phpdocs for docblock of function create; (#584) No one-line description found in phpdocs for docblock of function as_object; (#614) Short array syntax must be used to define arrays; (#618) Short array syntax must be used to define arrays
local/autogroup/classes/domain/course.php: (#50) Short array syntax must be used to define arrays; (#61) No one-line description found in phpdocs for docblock of function __construct; (#76) No one-line description found in phpdocs for docblock of function parse_course_id; (#93) No one-line description found in phpdocs for docblock of function get_autogroups; (#95) Short array syntax must be used to define arrays; (#109) No one-line description found in phpdocs for docblock of function get_membership_counts; (#110) Short array syntax must be used to define arrays; (#121) No one-line description found in phpdocs for docblock of function verify_all_group_membership; (#135) No one-line description found in phpdocs for docblock of function verify_user_group_membership
local/autogroup/classes/domain/group.php: (#57) Short array syntax must be used to define arrays; (#59) There should be a comma after the last array item in a multi-line array.; (#103) Missing member variable doc comment; (#104) Whitespace found at end of line; (#105) Missing member variable doc comment; (#112) No one-line description found in phpdocs for docblock of function __construct; (#128) No one-line description found in phpdocs for docblock of function load_from_database; (#129) Short array syntax must be used to define arrays; (#139) No one-line description found in phpdocs for docblock of function validate_object; (#158) No one-line description found in phpdocs for docblock of function load_from_object; (#159) Line indented incorrectly; expected 8 spaces, found 5; (#160) Line indented incorrectly; expected 12 spaces, found 8; (#161) Line indented incorrectly; expected at least 16 spaces, found 12; (#162) Line indented incorrectly; expected 12 spaces, found 8; (#163) Line indented incorrectly; expected 8 spaces, found 4; (#163) Closing brace indented incorrectly; expected 5 spaces, found 4; (#164) Line indented incorrectly; expected 4 spaces, found 0; (#164) Closing brace indented incorrectly; expected 4 spaces, found 0; (#169) No one-line description found in phpdocs for docblock of function get_members; (#170) Short array syntax must be used to define arrays; (#193) No one-line description found in phpdocs for docblock of function as_object; (#211) Short array syntax must be used to define arrays; (#228) No one-line description found in phpdocs for docblock of function membership_count; (#248) No one-line description found in phpdocs for docblock of function is_valid_autogroup; (#263) Short array syntax must be used to define arrays; (#272) No one-line description found in phpdocs for docblock of function is_autogroup; (#287) Missing docblock for function update
local/autogroup/classes/domain/user.php: (#68) No one-line description found in phpdocs for docblock of function __construct; (#84) No one-line description found in phpdocs for docblock of function parse_user_data; (#89) Short array syntax must be used to define arrays; (#105) No one-line description found in phpdocs for docblock of function get_group_membership; (#112) Short array syntax must be used to define arrays; (#114) There should be a comma after the last array item in a multi-line array.; (#135) Short array syntax must be used to define arrays; (#156) No one-line description found in phpdocs for docblock of function verify_user_group_membership
local/autogroup/classes/event_handler.php: (#31) Import statements must not begin with a leading backslash; (#63) No one-line description found in phpdocs for docblock of function user_enrolment_created; (#84) No one-line description found in phpdocs for docblock of function group_member_added; (#98) Short array syntax must be used to define arrays; (#99) Short array syntax must be used to define arrays; (#120) No one-line description found in phpdocs for docblock of function group_member_removed; (#132) Short array syntax must be used to define arrays; (#133) Short array syntax must be used to define arrays; (#154) No one-line description found in phpdocs for docblock of function user_updated; (#174) No one-line description found in phpdocs for docblock of function group_created; (#198) No one-line description found in phpdocs for docblock of function group_change; (#210) Short array syntax must be used to define arrays; (#218) Short array syntax must be used to define arrays; (#231) No one-line description found in phpdocs for docblock of function role_change; (#249) No one-line description found in phpdocs for docblock of function role_deleted; (#262) No one-line description found in phpdocs for docblock of function course_created; (#279) No one-line description found in phpdocs for docblock of function course_restored; (#296) No one-line description found in phpdocs for docblock of function position_updated; (#323) Whitespace found at end of line; (#343) No one-line description found in phpdocs for docblock of function process_event
local/autogroup/classes/exception.php: (#50) No one-line description found in phpdocs for docblock of function __construct
local/autogroup/classes/exception/invalid_argument.php: (#33) Missing docblock for class invalid_argument
local/autogroup/classes/exception/invalid_autogroup_set_argument.php: (#31) Missing docblock for class invalid_autogroup_set_argument; (#32) Missing docblock for function __construct
local/autogroup/classes/exception/invalid_course_argument.php: (#31) Missing docblock for class invalid_course_argument; (#32) Missing docblock for function __construct
local/autogroup/classes/exception/invalid_group_argument.php: (#31) Missing docblock for class invalid_group_argument; (#32) Missing docblock for function __construct
local/autogroup/classes/exception/invalid_user_argument.php: (#31) Missing docblock for class invalid_user_argument; (#32) Missing docblock for function __construct
local/autogroup/classes/form/autogroup_set_delete.php: (#33) Import statements must not begin with a leading backslash; (#41) @type tag is not allowed in member variable comment; (#41) Invalid docblock tag "@type".; (#42) Missing @var tag in member variable comment; (#56) Missing docblock for function add_dialogue; (#76) Short array syntax must be used to define arrays
local/autogroup/classes/form/autogroup_set_settings.php: (#40) @type tag is not allowed in member variable comment; (#40) Invalid docblock tag "@type".; (#41) Missing @var tag in member variable comment; (#48) Member variable "autogroup_set" must not contain underscores.; (#50) Missing docblock for function definition; (#65) No one-line description found in phpdocs for docblock of function add_group_by_options; (#97) No one-line description found in phpdocs for docblock of function add_role_options; (#120) Short array syntax must be used to define arrays
local/autogroup/classes/privacy/provider.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#53) There must not be a space before the colon in a return type declaration; (#73) There must not be a space before the colon in a return type declaration; (#119) Short array syntax must be used to define arrays
local/autogroup/classes/sort_module.php: (#31) Import statements must not begin with a leading backslash; (#46) Content missing for @var tag in member variable comment; (#50) Content missing for @var tag in member variable comment; (#56) Short array syntax must be used to define arrays; (#66) No one-line description found in phpdocs for docblock of function __construct; (#80) No one-line description found in phpdocs for docblock of function eligible_groups_for_user; (#94) No one-line description found in phpdocs for docblock of function __get; (#106) No one-line description found in phpdocs for docblock of function __set
local/autogroup/classes/sort_module/primary_position.php: (#51) No one-line description found in phpdocs for docblock of function __construct; (#62) No one-line description found in phpdocs for docblock of function config_is_valid; (#79) No one-line description found in phpdocs for docblock of function eligible_groups_for_user; (#87) Short array syntax must be used to define arrays; (#89) There should be a comma after the last array item in a multi-line array.; (#100) Short array syntax must be used to define arrays; (#123) No one-line description found in phpdocs for docblock of function grouping_by; (#134) No one-line description found in phpdocs for docblock of function parse_name_manager; (#143) No one-line description found in phpdocs for docblock of function parse_name_organisation; (#146) Short array syntax must be used to define arrays; (#153) No one-line description found in phpdocs for docblock of function parse_name_position; (#156) Short array syntax must be used to define arrays
local/autogroup/classes/sort_module/profile_field.php: (#48) No one-line description found in phpdocs for docblock of function __construct; (#59) No one-line description found in phpdocs for docblock of function config_is_valid; (#93) No one-line description found in phpdocs for docblock of function eligible_groups_for_user; (#104) No one-line description found in phpdocs for docblock of function grouping_by; (#111) No one-line description found in phpdocs for docblock of function grouping_by_text
local/autogroup/classes/sort_module/user_info_field.php: (#48) No one-line description found in phpdocs for docblock of function __construct; (#59) No one-line description found in phpdocs for docblock of function config_is_valid; (#94) No one-line description found in phpdocs for docblock of function eligible_groups_for_user; (#108) No one-line description found in phpdocs for docblock of function grouping_by; (#124) No one-line description found in phpdocs for docblock of function grouping_by_text
local/autogroup/classes/sort_module/user_info_field_multivalue.php: (#51) Commas (,) must be followed by white space.; (#57) No one-line description found in phpdocs for docblock of function __construct; (#69) No one-line description found in phpdocs for docblock of function config_is_valid; (#104) No one-line description found in phpdocs for docblock of function eligible_groups_for_user; (#123) No one-line description found in phpdocs for docblock of function grouping_by; (#130) No one-line description found in phpdocs for docblock of function grouping_by_text
local/autogroup/classes/task/process_event.php: (#20) Incorrect @package tag for file process_event.php. Expected local_autogroup, found local_autogroup .; (#20) Whitespace found at end of line; (#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#31) Missing docblock for class process_event; (#48) File must end with a newline character
local/autogroup/classes/usecase.php: (#52) No one-line description found in phpdocs for docblock of function invoke; (#66) No one-line description found in phpdocs for docblock of function __get; (#75) No one-line description found in phpdocs for docblock of function __set
local/autogroup/classes/usecase/add_default_to_course.php: (#66) No one-line description found in phpdocs for docblock of function __construct; (#74) Short array syntax must be used to define arrays; (#83) No one-line description found in phpdocs for docblock of function invoke; (#102) Short array syntax must be used to define arrays
local/autogroup/classes/usecase/verify_course_group_membership.php: (#57) No one-line description found in phpdocs for docblock of function __construct; (#65) No one-line description found in phpdocs for docblock of function invoke
local/autogroup/classes/usecase/verify_group_idnumber.php: (#60) No one-line description found in phpdocs for docblock of function __construct; (#73) No one-line description found in phpdocs for docblock of function invoke; (#94) Short array syntax must be used to define arrays; (#99) Missing docblock for function group_has_members; (#102) Short array syntax must be used to define arrays
local/autogroup/classes/usecase/verify_group_population.php: (#56) No one-line description found in phpdocs for docblock of function __construct; (#68) No one-line description found in phpdocs for docblock of function invoke; (#79) Short array syntax must be used to define arrays
local/autogroup/classes/usecase/verify_user_group_membership.php: (#58) No one-line description found in phpdocs for docblock of function __construct; (#66) No one-line description found in phpdocs for docblock of function invoke
local/autogroup/cli/rebuild.php: (#41) File must end with a newline character
local/autogroup/db/access.php: (#38) There should be a comma after the last array item in a multi-line array.; (#40) There should be a comma after the last array item in a multi-line array.
local/autogroup/db/events.php: (#135) There should be a comma after the last array item in a multi-line array.
local/autogroup/db/upgrade.php: (#61) Short array syntax must be used to define arrays; (#84) There should be a comma after the last array item in a multi-line array.; (#85) There should be a comma after the last array item in a multi-line array.; (#94) Line exceeds 132 characters; contains 144 characters
local/autogroup/edit.php: (#69) Short array syntax must be used to define arrays; (#96) Short array syntax must be used to define arrays; (#101) Short array syntax must be used to define arrays; (#109) Short array syntax must be used to define arrays; (#117) Short array syntax must be used to define arrays; (#166) Short array syntax must be used to define arrays
local/autogroup/lang/en/local_autogroup.php: (#31) Unexpected comment found. Auto-fixing will not work after this comment; (#32) The string key "actions" is not in the correct order, it should be before "pluginname"; (#37) The string key "autogroupdescription" is not in the correct order, it should be before "coursesettingstitle"; (#41) The string key "dontgroup" is not in the correct order, it should be before "updatesettingsintro"; (#42) The string key "cleanupold" is not in the correct order, it should be before "dontgroup"; (#45) The string key "set_groups" is not in the correct order, it should be before "set_type"; (#47) The string key "set_groupby" is not in the correct order, it should be before "set_roles"; (#48) The string key "set_delimitedby" is not in the correct order, it should be before "set_groupby"; (#50) The string key "confirmdelete" is not in the correct order, it should be before "set_delimitedby"; (#54) Unexpected comment found. Auto-fixing will not work after this comment; (#55) The string key "addtonewcourses" is not in the correct order, it should be before "create"; (#58) The string key "defaults" is not in the correct order, it should be before "preservemanual"; (#59) The string key "defaultroles" is not in the correct order, it should be before "defaults"; (#62) The string key "events" is not in the correct order, it should be before "general"; (#68) The string key "listenforuserpositionchanges" is not in the correct order, it should be before "listenforuserprofilechanges_help"; (#70) The string key "listenforgroupchanges" is not in the correct order, it should be before "listenforuserpositionchanges_help"; (#74) The string key "adhoceventhandler" is not in the correct order, it should be before "listenforgroupmembership_help"; (#76) Unexpected comment found. Auto-fixing will not work after this comment; (#79) Unexpected comment found. Auto-fixing will not work after this comment; (#80) The string key "auth" is not in the correct order, it should be before "autogroup:managecourse"; (#86) Unexpected comment found. Auto-fixing will not work after this comment; (#91) Unexpected comment found. Auto-fixing will not work after this comment; (#91) Inline comments must end in full-stops, exclamation marks, or question marks; (#92) The string key "privacy:metadata:local_autogroup" is not in the correct order, it should be before "sort_module:user_info_field_multivalue"; (#96) The string key "privacy:metadata:local_autogroup_manual:groupid" is not in the correct order, it should be before "privacy:metadata:local_autogroup_manual:userid"; (#98) Unexpected comment found. Auto-fixing will not work after this comment
local/autogroup/locallib.php: (#80) No one-line description found in phpdocs for docblock of function local_autogroup_sanitise_sort_module_name; (#99) No one-line description found in phpdocs for docblock of function local_autogroup_amend_settings_structure; (#123) Inline comments must start with a capital letter, digit or 3-dots sequence; (#123) This comment is 63% valid code; is this commented out code?; (#123) Line indented incorrectly; expected at least 16 spaces, found 14; (#123) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#130) Short array syntax must be used to define arrays
local/autogroup/manage.php: (#59) Short array syntax must be used to define arrays; (#61) Short array syntax must be used to define arrays; (#62) Short array syntax must be used to define arrays
local/autogroup/renderer.php: (#33) Missing docblock for class local_autogroup_renderer; (#34) Missing docblock for constant local_autogroup_renderer::URL_COURSE_SETTINGS; (#35) Missing docblock for constant local_autogroup_renderer::URL_COURSE_MANAGE; (#37) Missing docblock for function add_new_groupset; (#40) Short array syntax must be used to define arrays; (#52) Missing docblock for function intro_text; (#69) Missing docblock for function groupsets_table; (#74) Short array syntax must be used to define arrays; (#81) Short array syntax must be used to define arrays; (#86) There should be a comma after the last array item in a multi-line array.; (#93) Missing docblock for function groupsets_table_group; (#94) Short array syntax must be used to define arrays; (#97) Space found before square bracket; expected "$row[" but found "$row ["; (#100) Space found before square bracket; expected "$row[" but found "$row ["; (#103) Space found before square bracket; expected "$row[" but found "$row ["; (#109) Space found before square bracket; expected "$row[" but found "$row ["; (#112) Short array syntax must be used to define arrays; (#113) Short array syntax must be used to define arrays
local/autogroup/tests/local_autogroup_lib_test.php: (#16) Boilerplate comment must be followed by a single blank line or end of file; (#41) Unit test local_autogroup_lib_test should be declared as final.; (#41) PHPUnit class "local_autogroup_lib_test" does not have any namespace. It is recommended to add it to the "local_autogroup" namespace, using more levels if needed, in order to match the code being tested; (#45) The setUp() method in unit tests must always call to parent::setUp().; (#52) Test method test_autogroup_assign() is missing any coverage information, own or at class level; (#52) Test method test_autogroup_assign() is missing a return type; (#83) Test method test_autogroup_adhoc_assign() is missing any coverage information, own or at class level; (#83) Test method test_autogroup_adhoc_assign() is missing a return type; (#124) There should be a comma after the last array item in a multi-line array.; (#128) Short array syntax must be used to define arrays; (#179) File must end with a newline character

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

Overview

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems