Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(11 errors, 56 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/assignsubmission_download/classes/event/assignsubmission_download_table_downloaded.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/assignsubmission_download/classes/event/assignsubmission_download_table_viewed.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/assignsubmission_download/classes/local/filerenaming.php
(#41) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#247) Line exceeds 132 characters; contains 155 characters
(#319) Line exceeds 132 characters; contains 173 characters
(#385) Logical operator "or" is prohibited; use "||" instead
(#385) Logical operator "and" is prohibited; use "&&" instead
(#389) Logical operator "or" is prohibited; use "||" instead
(#389) Logical operator "or" is prohibited; use "||" instead
(#501) Logical operator "or" is prohibited; use "||" instead
(#634) File must end with a newline character
local/assignsubmission_download/classes/local/printpreview.php
(#41) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#153) Line exceeds 132 characters; contains 133 characters
(#255) Line exceeds 132 characters; contains 163 characters
(#284) Line exceeds 132 characters; contains 133 characters
(#317) File must end with a newline character
local/assignsubmission_download/classes/privacy/provider.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#134) File must end with a newline character
local/assignsubmission_download/db/upgrade.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
local/assignsubmission_download/filerenamingsettingsform.php
(#180) Line exceeds 132 characters; contains 136 characters
(#182) This comment is 63% valid code; is this commented out code?
(#184) Inline comments must end in full-stops, exclamation marks, or question marks
local/assignsubmission_download/groupsactivitymenu.php
(#74) Logical operator "and" is prohibited; use "&&" instead
(#101) Logical operator "or" is prohibited; use "||" instead
(#110) Logical operator "or" is prohibited; use "||" instead
(#110) Logical operator "or" is prohibited; use "||" instead
(#178) File must end with a newline character
local/assignsubmission_download/lib.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) Logical operator "or" is prohibited; use "||" instead
(#107) File must end with a newline character
local/assignsubmission_download/locallib.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Line exceeds 132 characters; contains 145 characters
(#45) Line exceeds 132 characters; contains 135 characters
(#49) Line exceeds 132 characters; contains 139 characters
(#84) Inline comments must end in full-stops, exclamation marks, or question marks
(#207) File must end with a newline character
local/assignsubmission_download/mtablepdf.php
(#28) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#126) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#175) This comment is 67% valid code; is this commented out code?
(#177) This comment is 67% valid code; is this commented out code?
(#178) This comment is 67% valid code; is this commented out code?
(#181) This comment is 67% valid code; is this commented out code?
(#185) This comment is 67% valid code; is this commented out code?
(#186) This comment is 67% valid code; is this commented out code?
(#189) This comment is 67% valid code; is this commented out code?
(#191) This comment is 67% valid code; is this commented out code?
(#202) This comment is 67% valid code; is this commented out code?
(#203) This comment is 67% valid code; is this commented out code?
(#206) This comment is 67% valid code; is this commented out code?
(#210) This comment is 67% valid code; is this commented out code?
(#212) This comment is 67% valid code; is this commented out code?
(#215) This comment is 67% valid code; is this commented out code?
(#217) This comment is 67% valid code; is this commented out code?
(#247) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#301) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#319) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#331) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#440) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#588) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#928) File must end with a newline character
local/assignsubmission_download/printpreviewsettingsform.php
(#71) Line exceeds 132 characters; contains 152 characters
(#131) File must end with a newline character
local/assignsubmission_download/ptablepdf.php
(#136) Logical operator "or" is prohibited; use "||" instead
(#201) File must end with a newline character
local/assignsubmission_download/renderer.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#90) File must end with a newline character
local/assignsubmission_download/settings.php
(#50) File must end with a newline character

Javascript coding style problems

(0 errors, 20 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/assignsubmission_download/amd/src/filerenaming_groupingtoggle.js
(#33) Unexpected empty function. (no-empty-function)
(#56) Unexpected space before function parentheses. (space-before-function-paren)
(#58) Unexpected space before function parentheses. (space-before-function-paren)
(#60) Unexpected space before function parentheses. (space-before-function-paren)
local/assignsubmission_download/amd/src/filerenaming_grouptoggle.js
(#33) Unexpected empty function. (no-empty-function)
local/assignsubmission_download/amd/src/filerenaming_tagsupport.js
(#33) Unexpected empty function. (no-empty-function)
(#36) Identifier 'add_tag' is not in camel case. (camelcase)
local/assignsubmission_download/amd/src/printpreviewer.js
(#33) Unexpected empty function. (no-empty-function)
(#36) Identifier 'change_in_perpage' is not in camel case. (camelcase)
(#42) Expected space(s) after "if". (keyword-spacing)
(#54) Identifier 'change_in_optimum' is not in camel case. (camelcase)
(#60) Expected space(s) after "if". (keyword-spacing)
(#76) Requires a space after '{'. (block-spacing)
(#76) Statement inside of curly braces should be on next line. (brace-style)
(#76) Requires a space before '}'. (block-spacing)
(#76) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#81) Multiple spaces found before '='. (no-multi-spaces)
(#82) Multiple spaces found before '='. (no-multi-spaces)
(#86) Unexpected space before function parentheses. (space-before-function-paren)
(#129) Expected space(s) after "if". (keyword-spacing)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(72 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/assignsubmission_download/classes/event/assignsubmission_download_table_downloaded.php
(#20) Package local is not valid
(#34) Package local is not valid
local/assignsubmission_download/classes/event/assignsubmission_download_table_viewed.php
(#20) Package local is not valid
(#40) Package local is not valid
local/assignsubmission_download/classes/local/filerenaming.php
(#183) Function filerenaming::get_filenrenaming_form is not documented
(#619) Function filerenaming::convert_content_to_html_doc is not documented
(#52) Variable filerenaming::$_filerenamingform is not documented
(#254) Phpdocs for function filerenaming::get_lastdownloaded_date has incomplete parameters list
(#273) Phpdocs for function filerenaming::update_lastdownloaded_date has incomplete parameters list
(#316) Phpdocs for function filerenaming::download_submissions has incomplete parameters list
(#56) Not recommended phpdocs tag @global used
(#20) Package local is not valid
(#46) Package local is not valid
local/assignsubmission_download/classes/local/printpreview.php
(#57) Not recommended phpdocs tag @global used
(#20) Package local is not valid
(#47) Package local is not valid
local/assignsubmission_download/classes/privacy/provider.php
(#48) Function provider::get_metadata is not documented
(#20) Package local is not valid
(#38) Package local is not valid
local/assignsubmission_download/db/access.php
(#42) Package local is not valid
local/assignsubmission_download/db/upgrade.php
(#28) Function xmldb_local_assignsubmission_download_upgrade is not documented
(#17) No one-line description found in phpdocs for file
(#19) Package moodle311 is not valid
local/assignsubmission_download/filerenamingsettingsform.php
(#199) Function mod_assign_filerenaming_settings_form::validation is not documented
(#20) Package local is not valid
(#36) Package local is not valid
local/assignsubmission_download/groupsactivitymenu.php
(#45) Function moodlequickform_groupsactivitymenu::__construct is not documented
(#52) Function moodlequickform_groupsactivitymenu::getvalue is not documented
(#56) Function moodlequickform_groupsactivitymenu::set_data is not documented
(#81) Function moodlequickform_groupsactivitymenu::tohtml is not documented
(#132) Function moodlequickform_groupsactivitymenu::render_single_select is not documented
(#40) Variable moodlequickform_groupsactivitymenu::$cm is not documented
(#41) Variable moodlequickform_groupsactivitymenu::$url is not documented
(#42) Variable moodlequickform_groupsactivitymenu::$aag is not documented
(#43) Variable moodlequickform_groupsactivitymenu::$groupmode is not documented
(#20) Package local is not valid
(#33) Package local is not valid
local/assignsubmission_download/lang/en/local_assignsubmission_download.php
(#20) Package local is not valid
local/assignsubmission_download/lib.php
(#20) Package local is not valid
local/assignsubmission_download/locallib.php
(#30) Constant FILERENAMING_TAGS is not documented
(#36) Phpdocs for function filerenaming_rename_file has incomplete parameters list
(#172) Phpdocs for function replace_custom has incomplete parameters list
(#20) Package local is not valid
local/assignsubmission_download/mtablepdf.php
(#20) Package mtablepdf is not valid
(#35) Package mod_checkmark is not valid
local/assignsubmission_download/printpreviewsettingsform.php
(#20) Package local is not valid
(#35) Package local is not valid
local/assignsubmission_download/printpreviewtable.php
(#17) No one-line description found in phpdocs for file
(#73) Phpdocs for function printpreview_table::__construct has incomplete parameters list
(#839) Phpdocs for function printpreview_table::export_class_instance has incomplete parameters list
(#21) Package local is not valid
(#37) Package local is not valid
local/assignsubmission_download/ptablepdf.php
(#49) Function table_pdf_export_format::start_document is not documented
(#53) Function table_pdf_export_format::start_table is not documented
(#58) Function table_pdf_export_format::output_headers is not documented
(#62) Function table_pdf_export_format::add_seperator is not documented
(#66) Function table_pdf_export_format::setup_table is not documented
(#178) Function table_pdf_export_format::add_data is not documented
(#193) Function table_pdf_export_format::finish_table is not documented
(#197) Function table_pdf_export_format::finish_document is not documented
(#43) Variable table_pdf_export_format::$pdf is not documented
(#44) Variable table_pdf_export_format::$filename is not documented
(#45) Variable table_pdf_export_format::$columns is not documented
(#46) Variable table_pdf_export_format::$widths is not documented
(#47) Variable table_pdf_export_format::$rownum is not documented
(#20) Package local is not valid
(#36) Package local is not valid
local/assignsubmission_download/renderer.php
(#42) Phpdocs for function local_assignsubmission_download_renderer::render_printpreview_table has incomplete parameters list
(#20) Package local is not valid
(#32) Package local is not valid
local/assignsubmission_download/settings.php
(#20) Package local is not valid
local/assignsubmission_download/version.php
(#20) Package local is not valid
local/assignsubmission_download/view_filerenaming.php
(#20) Package local is not valid
local/assignsubmission_download/view_printpreview.php
(#20) Package local is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]